D29229: [KPlotting] Port foreach (deprecated) to range for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R277 KPlotting BRANCH l-foreach (branched from master) REVISION DETAIL

Re: Splitting KWayland

On Mon, Apr 27, 2020 at 2:12 PM David Edmundson wrote: > > > On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > >> Hi, >> As discussed in the meeting last week, I've been looking into the split. >> >> Here's what I was thinking of, please tell me if there's something >> massively important I'm

Re: Splitting KWayland

On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea would be to start working on it after kwayland

D28882: Create protocol to manage video feeds

meven added inline comments. INLINE COMMENTS > screencasting.cpp:141 > +} > +void zkde_screencast_unstable_v1_removeSource(uint32_t sourceId) > override { > +auto it = std::find_if(m_sources.begin(), m_sources.end(), > [sourceId] (const ScreencastingSource ) { Missing blank

D29228: [KProcessRunner] Use only executable name for scope

broulik created this revision. broulik added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Slashes aren't allowed in scope names, so when a full executable path is

Splitting KWayland

Hi, As discussed in the meeting last week, I've been looking into the split. Here's what I was thinking of, please tell me if there's something massively important I'm missing. The idea would be to start working on it after kwayland and other kf5 have been tagged next week (?). Something I was

Re: KF 5 & C++14?

Am Montag, 27. April 2020, 00:45:41 CEST schrieb David Faure: > On Sunday, April 26, 2020 5:30:37 PM CEST Friedrich W. H. Kossebau wrote: > > Hi, > > > > I just saw that at least kimageformats, knewstuff & kquickcharts all set > > this: set(CMAKE_CXX_STANDARD 14) > > > >

D28882: Create protocol to manage video feeds

davidedmundson added inline comments. INLINE COMMENTS > screencast.xml:46 > + > + > + add type = "destructor" so that clients calling this release the resource REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich,

Re: Having $(framework)_global.h headers (was: Re: building KF5 projects against a different Qt5 version [...])

Am Sonntag, 26. April 2020, 16:12:31 CEST schrieb Friedrich W. H. Kossebau: > Am Sonntag, 26. April 2020, 15:46:35 CEST schrieb David Faure: > > On Sunday, April 26, 2020 3:21:34 PM CEST René J.V. Bertin wrote: > > > Talking about version test hacks (or not-so-hacks): why is it that > > >

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel,

D29223: Update Taiwanese holidays

cgiboudeaux added a reviewer: shrapnel. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin,

Re: Information regarding upcoming Gitlab Migration

In part I am mostly re-iterating what Ben already mentioned in different messages. On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > Does this mean that to clone it we'll have to go "git clone > kde:games/knetwalk" or something along the lines? Yes [Rest of message is with sysadmin

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud wrote: > > Hi, > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > > replies] > > > > > > Hello

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 12:55 PM Ben Cooksley wrote: > > On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > > replies] > > > > > > Hello Community

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 10:50 PM Piyush Aggarwal wrote: > > > > On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol, wrote: >> >> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: >> > >> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for >> > replies] >> > >> > Hello Community members,

D29223: Update Taiwanese holidays

nhiga added a comment. Notes: 1. Holidays for indigenous peoples have not been included. Some of them seem to have a fixed date, but for other festivals we know the range but not the exact dates. For example, it is known that 豐年祭(收穫祭) is celebrated between July 1 and September 30

Re: changing icon sizes no longer emits signal

(That's why confirmation prompts are pointless, one gets so used to just acknowledge them all that that I sent this mail mid-sentece :) ...so perhaps we should just change it to always emit the dbus signal manually when something changed, rather than it being nested inside exportToKDE4().

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin team wants

Re: changing icon sizes no longer emits signal

Hi, A patch like the one attached seems to help, but someone who knows the KCM better (or has time to dig) should make this conditional on the user actually changing icon sizes, and only emit for the groups that have changed. Patch makes sense, though I wonder why we do both emitChange and a

D29198: filenamesearch:/ define a title for the query

meven updated this revision to Diff 81330. meven marked an inline comment as done. meven added a comment. Rename DolphinSearchBox::getQueryTitle to DolphinSearchBox::queryTitle REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29198?vs=81246=81330 BRANCH

D29197: filenamesearch: Implement stat to display metainfo

meven added a reviewer: elvisangelaccio. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29197 To: meven, #dolphin, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for the repositories on Gitlab.

D29223: Update Taiwanese holidays

nhiga created this revision. nhiga added reviewers: winterz, cgiboudeaux. nhiga added projects: KDE PIM, Frameworks. nhiga requested review of this revision. REVISION SUMMARY This patch improves upon @shrapnel 's work on the accuracy of the Taiwanese

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added a comment. In D29170#658058 , @meven wrote: > Is it not sufficient to fix bug 415567 ? In which case replace in commit comment CCBUG by BUG No, that bug has two issues. "Program not found" and "Missing lib" -- which is

D29222: Fix update auto selection

leinir edited the summary of this revision. leinir added reviewers: Frameworks, Plasma, bugseforuns, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29222 To: leinir, #frameworks, #plasma, bugseforuns, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack,

D29222: Fix update auto selection

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The new autoselection for updating installed entries would firstly not be looking at the right amount of download

D29219: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant

This revision was automatically updated to reflect the committed changes. Closed by commit R236:5d803a237955: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D29221: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, bruns. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY As was discussed in https://phabricator.kde.org/D29138 and on IRC (with frinring and vkrause), add

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 09:25:56 + Build duration: 1 min 17 sec and counting JUnit Tests Name:

D29138: [Solid] Replace foreach (deprecated) with range/index for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:b9abef40855e: [Solid] Replace foreach (deprecated) with range/index for (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29138?vs=81131=81314

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in fakeopticaldisc.cpp:43 > Thats not a cast but a constructor, see QFlags documentation From opticaldrive.h: Q_DECLARE_FLAGS(MediumTypes, MediumType) AFAIU, MediumTypes is the QFlags, MediumType is the enum. So

D29170: Detect executables without +x permission in $PATH to improve error message

meven added a comment. Is it not sufficient to fix bug 415567 ? In which case replace in commit comment CCBUG by BUG INLINE COMMENTS > desktopexecparser.cpp:40 > #include > +#include > Not needed. REPOSITORY R241 KIO BRANCH 2020_04_findExecutable REVISION DETAIL

D29219: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-remove-redundant-displayflag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29219 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc:

D27859: [server] Expose SurfaceRole class

zzag abandoned this revision. zzag added a comment. Given our planned kwaylandserver changes, we don't need this patch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 7:26 PM Ilya Bizyaev wrote: > > Hello Bhushan! > > Thank you for you work on the Gitlab migration! > > The lists look good! Here are some ideas that I have, in case you think they > can be considered before we transition: > • The "applications" category is somewhat

D29170: Detect executables without +x permission in $PATH to improve error message

ahmadsamir accepted this revision. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kprocessrunner.cpp:65 > +const QStringList searchPaths = > QString::fromLocal8Bit(qgetenv("PATH")).split(QDir::listSeparator(), > skipEmptyParts); > +

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 6:33 PM Rolf Eike Beer wrote: > > Bhushan Shah wrote: > > > I've worked on draft "move" of the current set of the repositories in > > their respective subgroups at the repo-metadata project's branch [1]. > > You can browse the directory structure to get idea of how final

Re: Information regarding upcoming Gitlab Migration

Bhushan Shah wrote: I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. No objection, just a request for

<    1   2