D18883: Add PDF thumbnailer

2020-05-08 Thread Méven Car
meven added a comment. ping Is it still standing ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: meven, bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 18 - Fixed!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/18/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 00:59:41 + Build duration: 3 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 00:59:41 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » prison » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 00:12:02 + Build duration: 6 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 26 - Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/26/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 00:00:08 + Build duration: 12 min and counting JUnit Tests Name:

D29370: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R289:d256eaf8d8ed: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R289 KNotifications

D29369: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:1d8d223745eb: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R294 KBookmarks CHANGES

D29368: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R284:5b08593fc0c4: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R284 KCompletion CHANGES

D29367: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R276:df9e5d3bb765: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R276 KItemViews CHANGES

D29363: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:5904c475cb37: Use UI marker context in more tr() calls (authored by kossebau). CHANGED PRIOR TO COMMIT

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

2020-05-08 Thread David Faure
dfaure created this revision. dfaure added reviewers: ahmadsamir, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY [Next up, KRun::displayOpenWithDialog] REPOSITORY R241 KIO BRANCH

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping? If no-one objects would push upcoming Monday, May 11th. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29414 To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Andres Betts
abetts added a comment. +1 from me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham added a comment. In D29534#666554 , @ndavis wrote: > I don't like the look of those +/- buttons. I think this makes it harder to know that you can drag the panel height up and down. That would be a comment for D29535

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Noah Davis
ndavis added a comment. I don't like the look of those +/- buttons. I think this makes it harder to know that you can drag the height up and down. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: ndavis,

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham retitled this revision from "Implement wheel/touchpad scrolling for SpinBox control" to "Implement scroll and drag adjustment of values for SpinBox control". ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham added a task: T9460: Consider a more user-friendly SpinBox control. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82311. ngraham added a comment. Implement click-and-drag (along both the X and Y axes) to modify the value REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82276=82311 BRANCH

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-05-08 Thread Gustavo Carneiro
araujoluis marked 7 inline comments as done. araujoluis added inline comments. INLINE COMMENTS > tcanabrava wrote in kcolorcombo.cpp:244 > namedColors.reserve(colors.size()); Done! > tcanabrava wrote in kcolorcombo.cpp:245 > for(auto color : colors) Done! > tcanabrava wrote in

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R294:50c5c2fd7e5c: KBookmarkMenuTest: extend unittest to cover undeprecated API (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29541?vs=82300=82308#toc REPOSITORY R294

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

2020-05-08 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH extendunittestfornudeprecated REVISION DETAIL https://phabricator.kde.org/D29541 To: kossebau, #frameworks, nicolasfella, dfaure, ahmadsamir Cc: kde-frameworks-devel,

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Sorry, I have one last comment about a comment :) INLINE COMMENTS > copyjob.cpp:477 > +// Check available free space for remote urls > +// TODO: find a

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 585 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/585/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 May 2020 19:13:05 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 88 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/88/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 08 May 2020 19:04:08 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 95 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/95/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 08 May 2020 18:53:33 + Build duration: 23 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 584 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/584/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 May 2020 18:43:50 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 182 - Fixed!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/182/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 08 May 2020 18:53:33 + Build duration: 11 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 87 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/87/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 08 May 2020 18:44:55 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 86 - Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/86/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 08 May 2020 18:25:53 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 583 - Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/583/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 May 2020 18:25:53 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 94 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/94/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 08 May 2020 18:33:05 + Build duration: 6 min 27 sec and counting JUnit Tests Name:

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82305. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. "existingDest" is a better name for the var relating to m_asMethod REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29485?vs=82285=82305

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:430 > This is the same as "actualDest" too, so its definition could be moved > further up and shared with this too. > > (Not that the name is perfect --- when copying

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 93 - Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/93/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 08 May 2020 18:25:53 + Build duration: 7 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 181 - Still Failing!

2020-05-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/181/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 08 May 2020 18:30:19 + Build duration: 2 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 180 - Still Failing!

2020-05-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/180/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 08 May 2020 18:25:53 + Build duration: 4 min 20 sec and counting CONSOLE OUTPUT

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1b9b239eb262: [OpenUrlJob] Improve comments/docs (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29528?vs=82286=82304 REVISION DETAIL

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

2020-05-08 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:cb89bab36a5a: [CopyJob] Get rid of an old TODO and use QFile::rename() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29537?vs=82288=82303

D28882: Create protocol to manage video feeds

2020-05-08 Thread Aleix Pol Gonzalez
apol added a comment. Moving to kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

2020-05-08 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, nicolasfella, dfaure, ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R294 KBookmarks BRANCH

D29540: plasmawindowmodel: Expose the internal id to the model

2020-05-08 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It allows to use this class together with the screencast protocol. It's public API on the window anyway so it should

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

2020-05-08 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R241 KIO BRANCH l-qfile-rename (branched from master) REVISION DETAIL https://phabricator.kde.org/D29537 To: ahmadsamir, #frameworks, dfaure Cc:

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-late (branched from master) REVISION DETAIL https://phabricator.kde.org/D29528 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > copyjob.cpp:430 > +if (!m_privilegeExecutionEnabled && !isWritable) { > +const QUrl dest = m_asMethod ? > m_dest.adjusted(QUrl::RemoveFilename) : m_dest; > +q->setError(ERR_WRITE_ACCESS_DENIED); This is

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven added a comment. In D29397#666153 , @kossebau wrote: > In D29397#666134 , @meven wrote: > > > In D29397#666132 , @kossebau wrote: > > > > > For

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in thumbcreator.h:215 > docu? I wonder about moving qreal devicePixelRatio before img parameter REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks Cc: kossebau,

D29539: Port to ThumbnailCreatorV3 to support devicePixelRatio

2020-05-08 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, ngraham, broulik, elvisangelaccio. meven requested review of this revision. REVISION SUMMARY Generate a thumbnail depending of devicePixelRatio. Depends on kio D29397 And kio-extras

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven updated this revision to Diff 82292. meven marked an inline comment as done. meven added a comment. Code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82290=82292 BRANCH preview-dpr REVISION DETAIL https://phabricator.kde.org/D29397

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven updated this revision to Diff 82290. meven marked 2 inline comments as done. meven added a comment. Improve documentation, code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82255=82290 BRANCH preview-dpr REVISION DETAIL

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

2020-05-08 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN Renaming a dir A to a on a FAT32 partition still works REPOSITORY R241 KIO BRANCH l-qfile-rename (branched from

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82286. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29528?vs=82260=82286 BRANCH l-late (branched from master) REVISION

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in openurljob.cpp:590 > That one was on purpose. I find this version less readable, mixing a test and > an actual action (with error handling). Fair point. REPOSITORY R241 KIO

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82285. ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29485?vs=82113=82285 BRANCH l-freespace-remote-2 (branched from master)

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:430 > Here you kept a comment that said "we want to check", but the check already > happened. > I'd say just remove the two lines of comments. > The code is clearer

D29536: Adds a missing LibreOffice icon shortcut

2020-05-08 Thread Manuel Jesús de la Fuente
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b94a72842766: Adds a missing LibreOffice icon shortcut (authored by manueljlin). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29536?vs=82281=82284 REVISION

D29536: Adds a missing LibreOffice icon shortcut

2020-05-08 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fixlo16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29536 To: manueljlin, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29536: Adds a missing LibreOffice icon shortcut

2020-05-08 Thread Manuel Jesús de la Fuente
manueljlin edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29536 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29536: Adds a missing LibreOffice icon shortcut

2020-05-08 Thread Manuel Jesús de la Fuente
manueljlin created this revision. manueljlin added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. manueljlin requested review of this revision. REVISION SUMMARY Makes the 16px icon actually show up REPOSITORY R266 Breeze Icons BRANCH

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29527: Add MapProxySource

2020-05-08 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R1049:fa334cf9e809: Add MapProxySource (authored by ahiemstra). REPOSITORY R1049 KQuickCharts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29527?vs=82256=82278 REVISION DETAIL

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82276. ngraham marked 4 inline comments as done. ngraham added a comment. More control, less parseInt REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82274=82276 BRANCH

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > SpinBox.qml:49 > +if (wheel.angleDelta.y > 0 && control.value <= control.to) { > +control.value = parseInt(control.value, 10) + > control.stepSize > +valueModified() `control.value` is

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82274. ngraham added a comment. Mark the value has having been modified after adjusting by scrolling REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82273=82274 BRANCH

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Currently adjusting the value by scrolling is not implemented. This patch

D29527: Add MapProxySource

2020-05-08 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. works perfectly :) REPOSITORY R1049 KQuickCharts BRANCH mapproxysource REVISION DETAIL https://phabricator.kde.org/D29527 To: ahiemstra, mart Cc: mart, kde-frameworks-devel, LeGast00n,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > previewjob.cpp:173 > + > +void PreviewJob::setDefaultDevicePixelRatio(qreal defaultDevicePixelRatio) { > +s_defaultDevicePixelRatio =

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 92 - Fixed!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/92/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 08 May 2020 12:24:54 + Build duration: 9 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 179 - Still Failing!

2020-05-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/179/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 08 May 2020 12:24:54 + Build duration: 2 min 4 sec and counting CONSOLE OUTPUT

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29397#666134 , @meven wrote: > In D29397#666132 , @kossebau wrote: > > > For another stupid question (the first one was already asked by someone else and answered :)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 91 - Still Unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/91/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 08 May 2020 11:58:25 + Build duration: 8 min 16 sec and counting JUnit Tests Name:

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread David Faure
dfaure added a comment. Thanks! INLINE COMMENTS > openurljob.cpp:393 > +if (mime.isValid() && mimeName != m_mimeTypeName) { > +m_mimeTypeName =mimeName; > } missing space after '=' > openurljob.cpp:590 > +const QMimeType mimeType =

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 178 - Failure!

2020-05-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/178/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 08 May 2020 11:58:25 + Build duration: 3 min 36 sec and counting CONSOLE OUTPUT

D19080: Make file overwrite a bit safer

2020-05-08 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > dfaure wrote in jobtest.cpp:1759 > The other problems were fixed, but this test still fails randomly. > > In fact, why are we checking that the dest file already started to be created > when totalSize is emitted? > Surely copying involves looking

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R241 KIO BRANCH l-late (branched from master) REVISION DETAIL https://phabricator.kde.org/D29528 AFFECTED FILES

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven added a comment. In D29397#666132 , @kossebau wrote: > For another stupid question (the first one was already asked by someone else and answered :) ): > Given some generated thumbnails are cached, does the thumbnail cache specification

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. For another stupid question (the first one was already asked by someone else and answered :) ): Given some generated thumbnails are cached, does the thumbnail cache specification support logical resolution? How would cached thumbnails work cross-screen?

D29525: Make Previews devicePixelRatio aware

2020-05-08 Thread Méven Car
meven added a reviewer: elvisangelaccio. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29525 To: meven, #dolphin, #frameworks, dfaure, ngraham, elvisangelaccio Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde,

D29525: Make Previews devicePixelRatio aware

2020-05-08 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29525 To: meven, #dolphin, #frameworks, dfaure, ngraham Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela,

D29525: Make Previews devicePixelRatio aware

2020-05-08 Thread Méven Car
meven updated this revision to Diff 82257. meven added a comment. Fix REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29525?vs=82253=82257 BRANCH arcpatch-D29525 REVISION DETAIL https://phabricator.kde.org/D29525 AFFECTED FILES src/main.cpp To:

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-08 Thread Ahmad Samir
ahmadsamir added a comment. In D29385#664552 , @dfaure wrote: > -void KIO::OpenUrlJob::setRunFlags(KIO::ApplicationLauncherJob::RunFlags runFlags) > +void KIO::OpenUrlJob::setDeleteTemporaryFile(bool b) > > The more I think about it, the

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

2020-05-08 Thread David Faure
dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29524 To: dfaure, cgiboudeaux, vatra, kfunk, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29527: Add MapProxySource

2020-05-08 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY A source that provides values from a map based on keys from a different source. TEST PLAN The auto test

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

2020-05-08 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. tested successfully with the openSUSE package which uses absolute paths REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven updated this revision to Diff 82255. meven marked an inline comment as done. meven added a comment. Improve naming of a variable, fix scaling of the resulting preview REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82079=82255 BRANCH

D19080: Make file overwrite a bit safer

2020-05-08 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > jobtest.cpp:1759 > +Q_UNUSED(totalSize); > +QCOMPARE(destFileExists, QFile::exists(destPartFile)); > +}); The other problems were fixed, but this test still fails randomly. In fact, why are we checking that the dest file

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-05-08 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, dfaure, broulik, sitter, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Thumbnail ioslave can now receive a

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven added a dependent revision: D29526: Thumbnails: make thumbnail generation dpr-aware. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Méven Car
meven added a dependent revision: D29525: Make Previews devicePixelRatio aware. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29525: Make Previews devicePixelRatio aware

2020-05-08 Thread Méven Car
meven created this revision. meven added reviewers: Dolphin, Frameworks, dfaure, ngraham. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. meven requested review of this revision. REVISION SUMMARY Depends on D29397 And kio-extras

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-08 Thread Méven Car
meven updated this revision to Diff 82252. meven added a comment. Oops REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29381?vs=82251=82252 BRANCH D29381 REVISION DETAIL https://phabricator.kde.org/D29381 AFFECTED FILES CMakeLists.txt

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-08 Thread Méven Car
meven updated this revision to Diff 82251. meven added a comment. Make Thumbnail ioslave devicePixelRatio capable REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29381?vs=81786=82251 BRANCH thumbnail-dpr REVISION DETAIL

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

2020-05-08 Thread David Faure
dfaure created this revision. dfaure added reviewers: cgiboudeaux, vatra, kfunk, apol, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN works as before for the case

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 83 - Fixed!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/83/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 08 May 2020 09:41:59 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 90 - Still unstable!

2020-05-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/90/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 08 May 2020 09:42:01 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 580 - Fixed!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/580/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 May 2020 09:41:59 + Build duration: 7 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 177 - Fixed!

2020-05-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/177/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 08 May 2020 09:41:58 + Build duration: 5 min 35 sec and counting

  1   2   >