KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 592 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/592/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 May 2020 00:03:50 +
 Build duration:
5 min 38 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34495/62874)39%
(17491/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4295/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8478/14369)51%
(4404/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/94/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 23:56:13 +
 Build duration:
8 min 1 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34490/62875)39%
(17495/44542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4299/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8471/14369)51%
(4404/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 102 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/102/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 23:56:13 +
 Build duration:
7 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  In D28745#667225 , @thiago wrote:
  
  > Use Solid and ask it if the device is on an encrypted device. If Solid does 
not have such an API, add it.
  
  
  I fully second that.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 591 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/591/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 23:56:13 +
 Build duration:
5 min 49 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_favicontestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34490/62875)39%
(17485/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9187/10585)42%
(4296/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8478/14369)51%
(4408/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)76%
(618/809)60%
(370/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1798/4288)36%
(1303/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 188 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/188/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 23:56:13 +
 Build duration:
2 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 683 lines...][2020-05-09T23:58:45.617Z] ][2020-05-09T23:58:45.617Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T23:58:45.617Z] with[2020-05-09T23:58:45.617Z] [[2020-05-09T23:58:45.617Z] T=KFileItem[2020-05-09T23:58:45.617Z] ][2020-05-09T23:58:45.617Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T23:58:45.617Z] [80/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\metadata.cpp.obj[2020-05-09T23:58:45.880Z] [81/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\statjob.cpp.obj[2020-05-09T23:58:45.880Z] [82/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolinfo.cpp.obj[2020-05-09T23:58:45.880Z] [83/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolinfofactory.cpp.obj[2020-05-09T23:58:46.141Z] [84/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kurlauthorized.cpp.obj[2020-05-09T23:58:46.141Z] [85/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\hostinfo.cpp.obj[2020-05-09T23:58:46.719Z] [86/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kpasswdserverclient.cpp.obj[2020-05-09T23:58:46.719Z] [87/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\desktopexecparser.cpp.obj[2020-05-09T23:58:46.719Z] [88/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\directorysizejob.cpp.obj[2020-05-09T23:58:46.719Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T23:58:46.719Z] with[2020-05-09T23:58:46.719Z] [[2020-05-09T23:58:46.719Z] T=KFileItem[2020-05-09T23:58:46.719Z] ][2020-05-09T23:58:46.719Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T23:58:46.719Z] with[2020-05-09T23:58:46.719Z] [[2020-05-09T23:58:46.719Z] T=KFileItem[2020-05-09T23:58:46.719Z] ][2020-05-09T23:58:46.719Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T23:58:46.719Z] with[2020-05-09T23:58:46.719Z] [[2020-05-09T23:58:46.719Z] T=KFileItem[2020-05-09T23:58:46.719Z] ][2020-05-09T23:58:46.719Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T23:58:46.719Z] [89/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\faviconscache.cpp.obj[2020-05-09T23:58:47.301Z] [90/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kfileitemlistproperties.cpp.obj[2020-05-09T23:58:47.301Z] [91/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksambasharedata.cpp.obj[2020-05-09T23:58:47.301Z] [92/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\simplejob.cpp.obj[2020-05-09T23:58:47.301Z] [93/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kdirnotify.cpp.obj[2020-05-09T23:58:47.565Z] [94/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kacl.cpp.obj[2020-05-09T23:58:47.836Z] [95/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\dataprotocol.cpp.obj[2020-05-09T23:58:47.836Z] [96/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\jobuidelegateextension.cpp.obj[2020-05-09T23:58:48.103Z] [97/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\job.cpp.obj[2020-05-09T23:58:48.381Z] [98/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\copyjob.cpp.obj[2020-05-09T23:58:48.381Z] FAILED: src/core/CMakeFiles/KF5KIOCore.dir/copyjob.cpp.obj [2020-05-09T23:58:48.382Z] C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\cl.exe  /nologo /TP -DKCOMPLETION_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054100 -DKCOREADDONS_LIB -DKF5KIOCore_EXPORTS -DKF_DEPRECATED_WARNINGS_SINCE=0x06 -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054600 -DKIOCORE_DEPRECATED_WARNINGS_SINCE=0x0 -DKIOCORE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x0 -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x06 -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00 -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_USE_QSTRINGBUILDER -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"kio5\" -DUNICODE 

D28745: Skip caching thumbnails on encrypted filesystems

[Thiago Macieira]

thiago added a comment.


  Use Solid and ask it if the device is on an encrypted device. If Solid does 
not have such an API, add it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:c8c10b76931a: Build with 
EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT (authored by kossebau).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29572?vs=82392=82403

REVISION DETAIL
  https://phabricator.kde.org/D29572

AFFECTED FILES
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/services/kmimetypetrader.cpp
  src/services/kservicefactory.cpp
  src/services/kserviceoffer.cpp
  src/services/kserviceoffer.h
  src/services/kservicetypeprofile.cpp
  src/services/kservicetypeprofile.h
  src/services/kservicetypetrader.cpp
  src/sycoca/kbuildservicefactory.cpp
  src/sycoca/kmimeassociations.cpp

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29577: Stop using deprecated methods

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29577

To: aacid, dfaure
Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, 
mikesomov

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/20/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 22:45:49 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.71.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9126)43%
(10802/24859)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6197/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/18/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 22:45:49 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 191 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/191/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 22:45:49 +
 Build duration:
9 min 48 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.71.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9127)43%
(10807/24865)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6201/12738)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 22:39:50 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 22:39:39 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D29577: Stop using deprecated methods

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29577

To: aacid, dfaure
Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, 
mikesomov

D29577: Stop using deprecated methods

[Albert Astals Cid]

aacid added a subscriber: kossebau.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29577

To: aacid
Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, 
mikesomov

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 22:38:36 +
 Build duration:
5 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/14/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 22:38:23 +
 Build duration:
5 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D29577: Stop using deprecated methods

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  They are no-ops

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29577

AFFECTED FILES
  fish/fish.cpp

To: aacid
Cc: kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.14/19/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 22:37:57 +
 Build duration:
3 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R285:58afbdf29a83: KCrash: remove debug output which breaks 
unittests from using ~/.qttest/config… (authored by dfaure).

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29361?vs=81740=82400

REVISION DETAIL
  https://phabricator.kde.org/D29361

AFFECTED FILES
  src/kcrash.cpp

To: dfaure, kossebau, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz updated this revision to Diff 82398.
winterz added a comment.


  don't try to provide translatable string for unknown subdivisions

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29575?vs=82396=82398

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  src/holidayregion.cpp

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Luigi Toscano]

ltoscano added a comment.


  In D29575#667175 , @winterz wrote:
  
  > I'm guessing it's ok to depend on K5I18N ?
  
  
  KHolidays is a Tier 1 framework, so it can't depend on KI18n. Just use 
QCoreApplication::translate as used already in src/holidayregion.cpp.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz added a comment.


  I'm guessing it's ok to depend on K5I18N ?

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz created this revision.
winterz added a reviewer: vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
winterz requested review of this revision.

REVISION SUMMARY
  The German holiday files now all have a proper country and name
  since commits 4bdc6f618e77348eeafa5e802154b95febc27eab 

  and 8b3f65ed1f40975aa559881fc3116029b7e7677e 

  
  this patch allows those names to be translated.
  
  also we can see the subdivision code in the regionName
  in the case we have a subdivision but no name.
  i.e say we have country "XX-YY" but name field is empty
  then we have regionName = countyCode(XX)(yy)

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/holidayregion.cpp

To: winterz, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  usebelated

REVISION DETAIL
  https://phabricator.kde.org/D29574

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D29574: Use 
KSERVICE_DEPRECATED_VERSION_BELATED.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addbelated

REVISION DETAIL
  https://phabricator.kde.org/D29573

To: kossebau, #frameworks, #build_system, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

[Friedrich W. H. Kossebau]

kossebau added a dependency: D29573: ECMGenerateExportHeader: add generation of 
*_DEPRECATED_VERSION_BELATED().

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29574

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R309 KService

BRANCH
  usebelated

REVISION DETAIL
  https://phabricator.kde.org/D29574

AFFECTED FILES
  src/services/kserviceaction.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  So many things to take care of :-)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addbelated

REVISION DETAIL
  https://phabricator.kde.org/D29573

To: kossebau, #frameworks, #build_system, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R309 KService

BRANCH
  buildwithoutdeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29572

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, Build System, dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Now and then tagging some API as deprecated for the compiler is forgotten.
  Doing this retractivitly in newer versions but using the official version
  might break build setups configured to only show warnings up to a certain
  version and otherwise fail a build, using -Werror=deprecated-declarations.
  
  To allow retroactive tagging of API for compiler warnings, and showing the
  official version in the warniung message, while reacting only to warning
  controls for the current version where the tag is added, avoids any such
  annoying experiences, without wrong version info at the same time.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addbelated

REVISION DETAIL
  https://phabricator.kde.org/D29573

AFFECTED FILES
  modules/ECMGenerateExportHeader.cmake

To: kossebau, #frameworks, #build_system, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  To also support EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.69.0 properly some
  more if-elif would have been needed, making the code more hard to read.
  Based on dicussion on #kde-devel with dfaure that has been left out,
  for some future non-version-based *_BUILD_DEPRECATED.
  So the focus already is on building without any own deprecated API,
  no-one is expected to use EXCLUDE_DEPRECATED_BEFORE_AND_AT with a
  certain version != CURREENT or 0.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0 (default) or CURRENT,
  all unit tests pass.

REPOSITORY
  R309 KService

BRANCH
  buildwithoutdeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29572

AFFECTED FILES
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/services/kmimetypetrader.cpp
  src/services/kservicefactory.cpp
  src/services/kserviceoffer.cpp
  src/services/kserviceoffer.h
  src/services/kservicetypeprofile.cpp
  src/services/kservicetypeprofile.h
  src/services/kservicetypetrader.cpp
  src/sycoca/kbuildservicefactory.cpp
  src/sycoca/kmimeassociations.cpp

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/13/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 18:52:50 +
 Build duration:
8 min 17 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/12/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 18:52:50 +
 Build duration:
6 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.71.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33047/49193)49%
(14834/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4797/5131)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1678/1892)74%
(1083/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1938/3176)48%
(1426/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)79%
(962/1224)68%
(621/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(716/1038)56%
(226/403)src.search100%
 

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

[Victor Dodon]

printesoi added a comment.


  I would like to add some more details about my setup: I have a laptop with a 
4K display and I use a second 4K external monitor. I have enabled the 200%  
scalling and `xrandr -q | grep -E '\bconnected' `gives
  
DP-0 connected 3840x2160+0+0 (normal left inverted right x axis y axis) 
609mm x 349mm
DP-2 connected primary 3840x2160+0+2160 (normal left inverted right x axis 
y axis) 344mm x 193mm
  
  ie: the external monitor is set at 0,0 (on top) and the laptop monitor is set 
at 0,2160 (on bottom)
  
  I created a minimal project that shows the problem in this setup 
https://github.com/printesoi/kwindowsystem-workarea-test and without the patch 
the results I get from the code above is (I have a 32px panel on the bottom of 
the primary (laptop) screen):
  
QRect KWindowSystemPrivateX11::workArea(int desktop): QRect(0,0 1920x2128)
QRect KWindowSystemPrivateX11::workArea(const QList , int 
desktop): QRect(0,0 960x1588)

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29569

To: printesoi, davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

[Anthony Fieroni]

anthonyfieroni added a reviewer: zzag.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29569

To: printesoi, davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

[Victor Dodon]

printesoi added reviewers: davidedmundson, KWin.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29569

To: printesoi, davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

[Victor Dodon]

printesoi created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
printesoi requested review of this revision.

REVISION SUMMARY
  KWindowSystem::workArea() and KWindowSystem::workArea(QList()) should 
return the same value, but the second call returned an incorrect value on 
multi-monitor HiDPI setups. The cause is that the former uses 
NETRootInfo::workArea() whereas the second one uses displayGeometr() to compuse 
base work area. displayGeometry() on X11 platform did not take into account the 
device pixel ratio.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29569

AFFECTED FILES
  src/platforms/xcb/kwindowsystem.cpp

To: printesoi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25339: update lineHeight if boundingRect indicates a larger value.

[Dominik Haumann]

dhaumann added a comment.


  In D25339#666832 , @cullmann wrote:
  
  > Looking at the code, might it make more sense to just move away from the 
fixed height we have?
  
  
  Yes please. Instead of hacks and options, which will make the code and the UI 
harder to use, the correct fix is to switch to variable line heights.
  
  Of course you need to touch many places, but this approach is so much better 
than hacks. Please give it a try! :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

D25339: update lineHeight if boundingRect indicates a larger value.

[René J . V . Bertin]

rjvbb added a comment.


  >   I assume the lineHeight usages in the renderer are easy to replace with 
the proper "height()" of the individual lines of the layout.
  
  This is what I think could be tricky. One wouldn't want fluctuating line 
heights when only a single font is used (at least not when using a 
fixed-width/"mono" font). That concern is of course moot is lineheight is 
calculated from a font property that doesn't depend on the actual text being 
rendered.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

D25339: update lineHeight if boundingRect indicates a larger value.

[Christoph Cullmann]

cullmann added a comment.


  F8304597: lineheight.patch 
  
  see e.g. here for a start of using the right heights inside the renderer.
  
  for a dynamically wrapped line, the lines before the last one get now the 
right height for me.
  
  But there are a lot more places to handle.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 590 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/590/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 14:13:25 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34477/62858)39%
(17482/44530)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4298/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8475/14369)51%
(4403/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8341)43%
(2078/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:429c80c96142: Add missing compiler deprecation tag for 
5-args KServiceAction constructor (authored by kossebau).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29561?vs=82369=82370

REVISION DETAIL
  https://phabricator.kde.org/D29561

AFFECTED FILES
  src/CMakeLists.txt
  src/services/kserviceaction.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/93/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 14:13:24 +
 Build duration:
6 min 7 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34469/62858)39%
(17481/44526)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4297/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8471/14369)51%
(4405/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/101/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 14:13:25 +
 Build duration:
4 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25339: update lineHeight if boundingRect indicates a larger value.

[Christoph Cullmann]

cullmann added a comment.


  In D25339#666877 , @rjvbb wrote:
  
  > >   Looking at the code, might it make more sense to just move away from 
the fixed height we have?
  > >   It isn't used that often and in most cases one could just query the 
height of the current line.
  >
  > I'd be all for that, provided it doesn't introduce any regressions in the 
rendered result nor in rendering time.
  >
  > It could be trickier to implement than you think though?
  
  
  It is a non-trivial change.
  But I think any other change, like this, will lead to issues, too, and is 
just a "hack".
  
  I have taken a closer look.
  I assume the lineHeight usages in the renderer are easy to replace with the 
proper "height()" of the individual lines of the layout.
  
  Harder to replace is the use of the lineHeight outside of the renderer.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 187 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/187/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 14:13:24 +
 Build duration:
1 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 704 lines...][2020-05-09T14:14:54.269Z] [76/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\dataprotocol.cpp.obj[2020-05-09T14:14:55.333Z] [77/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\metadata.cpp.obj[2020-05-09T14:14:55.333Z] [78/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\storedtransferjob.cpp.obj[2020-05-09T14:14:55.333Z] [79/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolinfo.cpp.obj[2020-05-09T14:14:55.333Z] [80/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\jobtracker.cpp.obj[2020-05-09T14:14:55.980Z] [81/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\jobuidelegateextension.cpp.obj[2020-05-09T14:14:55.980Z] [82/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\jobuidelegatefactory.cpp.obj[2020-05-09T14:14:56.274Z] [83/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\job.cpp.obj[2020-05-09T14:14:56.274Z] [84/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\mkdirjob.cpp.obj[2020-05-09T14:14:56.953Z] [85/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kmountpoint.cpp.obj[2020-05-09T14:14:57.589Z] [86/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\emptytrashjob.cpp.obj[2020-05-09T14:14:57.899Z] [87/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\untrustedprogramhandlerinterface.cpp.obj[2020-05-09T14:14:58.192Z] [88/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\faviconscache.cpp.obj[2020-05-09T14:14:58.192Z] [89/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kpasswdserverloop.cpp.obj[2020-05-09T14:14:58.845Z] [90/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\slave.cpp.obj[2020-05-09T14:14:59.500Z] [91/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kcoredirlister.cpp.obj[2020-05-09T14:14:59.500Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T14:14:59.500Z] with[2020-05-09T14:14:59.500Z] [[2020-05-09T14:14:59.500Z] T=KFileItem[2020-05-09T14:14:59.500Z] ][2020-05-09T14:14:59.500Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T14:14:59.500Z] with[2020-05-09T14:14:59.500Z] [[2020-05-09T14:14:59.500Z] T=KFileItem[2020-05-09T14:14:59.500Z] ][2020-05-09T14:14:59.500Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T14:14:59.500Z] with[2020-05-09T14:14:59.500Z] [[2020-05-09T14:14:59.500Z] T=KFileItem[2020-05-09T14:14:59.500Z] ][2020-05-09T14:14:59.500Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T14:14:59.813Z] [92/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolinfofactory.cpp.obj[2020-05-09T14:14:59.813Z] [93/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksambasharedata.cpp.obj[2020-05-09T14:15:00.130Z] [94/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksslerroruidata.cpp.obj[2020-05-09T14:15:00.130Z] [95/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksslcertificatemanager.cpp.obj[2020-05-09T14:15:00.130Z] [96/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\restorejob.cpp.obj[2020-05-09T14:15:00.401Z] [97/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ktcpsocket.cpp.obj[2020-05-09T14:15:01.416Z] [98/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\directorysizejob.cpp.obj[2020-05-09T14:15:01.416Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T14:15:01.416Z] with[2020-05-09T14:15:01.416Z] [[2020-05-09T14:15:01.416Z] T=KFileItem[2020-05-09T14:15:01.416Z] ][2020-05-09T14:15:01.416Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T14:15:01.416Z] with[2020-05-09T14:15:01.416Z] [[2020-05-09T14:15:01.416Z] T=KFileItem[2020-05-09T14:15:01.416Z] ][2020-05-09T14:15:01.416Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T14:15:01.416Z] with[2020-05-09T14:15:01.416Z] [[2020-05-09T14:15:01.416Z] 

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  addmissingdeprecationtag

REVISION DETAIL
  https://phabricator.kde.org/D29561

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R309 KService

BRANCH
  addmissingdeprecationtag

REVISION DETAIL
  https://phabricator.kde.org/D29561

AFFECTED FILES
  src/CMakeLists.txt
  src/services/kserviceaction.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/92/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 13:53:13 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34481/62857)39%
(17481/44524)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4299/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8479/14369)51%
(4402/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8343)43%
(2076/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 589 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/589/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 13:53:13 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34461/62855)39%
(17474/44528)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4293/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8471/14369)51%
(4403/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8341)43%
(2078/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4287)36%
(1311/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 100 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/100/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 13:53:13 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 186 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/186/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 13:53:13 +
 Build duration:
5 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 748 lines...][2020-05-09T13:57:56.904Z] ][2020-05-09T13:57:56.904Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T13:57:56.904Z] with[2020-05-09T13:57:56.904Z] [[2020-05-09T13:57:56.904Z] T=KFileItem[2020-05-09T13:57:56.904Z] ][2020-05-09T13:57:56.904Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T13:57:56.904Z] with[2020-05-09T13:57:56.904Z] [[2020-05-09T13:57:56.904Z] T=KFileItem[2020-05-09T13:57:56.904Z] ][2020-05-09T13:57:56.904Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T13:57:57.531Z] [112/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\faviconscache.cpp.obj[2020-05-09T13:57:58.946Z] [113/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kpasswdserverloop.cpp.obj[2020-05-09T13:57:58.946Z] [114/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kdiskfreespaceinfo.cpp.obj[2020-05-09T13:58:04.449Z] [115/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\deletejob.cpp.obj[2020-05-09T13:58:04.449Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T13:58:04.449Z] with[2020-05-09T13:58:04.449Z] [[2020-05-09T13:58:04.449Z] T=KFileItem[2020-05-09T13:58:04.449Z] ][2020-05-09T13:58:04.449Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T13:58:04.449Z] with[2020-05-09T13:58:04.449Z] [[2020-05-09T13:58:04.449Z] T=KFileItem[2020-05-09T13:58:04.449Z] ][2020-05-09T13:58:04.449Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T13:58:04.449Z] with[2020-05-09T13:58:04.449Z] [[2020-05-09T13:58:04.449Z] T=KFileItem[2020-05-09T13:58:04.449Z] ][2020-05-09T13:58:04.449Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T13:58:04.847Z] [116/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kpasswdserverclient.cpp.obj[2020-05-09T13:58:05.115Z] [117/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\untrustedprogramhandlerinterface.cpp.obj[2020-05-09T13:58:05.382Z] [118/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\global.cpp.obj[2020-05-09T13:58:05.382Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T13:58:05.382Z] with[2020-05-09T13:58:05.382Z] [[2020-05-09T13:58:05.382Z] T=KFileItem[2020-05-09T13:58:05.382Z] ][2020-05-09T13:58:05.382Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T13:58:05.382Z] with[2020-05-09T13:58:05.382Z] [[2020-05-09T13:58:05.382Z] T=KFileItem[2020-05-09T13:58:05.382Z] ][2020-05-09T13:58:05.382Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T13:58:05.382Z] with[2020-05-09T13:58:05.382Z] [[2020-05-09T13:58:05.382Z] T=KFileItem[2020-05-09T13:58:05.382Z] ][2020-05-09T13:58:05.382Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T13:58:05.382Z] [119/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksambashare.cpp.obj[2020-05-09T13:58:05.970Z] [120/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\slave.cpp.obj[2020-05-09T13:58:07.452Z] [121/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\mkdirjob.cpp.obj[2020-05-09T13:58:07.452Z] [122/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\simplejob.cpp.obj[2020-05-09T13:58:07.715Z] [123/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\multigetjob.cpp.obj[2020-05-09T13:58:07.988Z] [124/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kfileitemlistproperties.cpp.obj[2020-05-09T13:58:07.988Z] [125/732] Building CXX object 

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  I think the patch as is has some structural problems. I think it would be 
significantly cleaner when:
  
  - the "cacheAllowed" checking code is moved into a separate function
  - the global `allowCache` variable is removed, and the value is passed into 
`createSubThumbnail(...)`/`drawSubThumbnail(...)` as parameter
  
  You can then call the check function once on the directory, at the same place 
the `QDirIterator` is instantiated (line 538).
  
  And can you please use `arc` for uploading the patch, it is really hard to do 
a review without context.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/17/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:34:41 +
 Build duration:
1 hr 3 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/11/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 11:32:14 +
 Build duration:
1 hr 2 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.71.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33011/49191)49%
(14806/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4791/5129)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1937/3176)48%
(1419/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)68%
(706/1038)54%

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 185 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/185/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 11:29:35 +
 Build duration:
1 hr 2 min and counting
   CONSOLE OUTPUT
  [...truncated 661 lines...][2020-05-09T12:32:07.879Z] [59/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\mkdirjob.cpp.obj[2020-05-09T12:32:07.879Z] [60/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\desktopexecparser.cpp.obj[2020-05-09T12:32:08.138Z] [61/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksslerroruidata.cpp.obj[2020-05-09T12:32:08.138Z] [62/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kpasswdserverloop.cpp.obj[2020-05-09T12:32:08.429Z] [63/732] Building CXX object src\ioslaves\http\kcookiejar\CMakeFiles\kcookiejar5.dir\main.cpp.obj[2020-05-09T12:32:10.450Z] [64/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\chmodjob.cpp.obj[2020-05-09T12:32:10.450Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T12:32:10.450Z] with[2020-05-09T12:32:10.450Z] [[2020-05-09T12:32:10.450Z] T=KFileItem[2020-05-09T12:32:10.450Z] ][2020-05-09T12:32:10.450Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T12:32:10.450Z] with[2020-05-09T12:32:10.450Z] [[2020-05-09T12:32:10.450Z] T=KFileItem[2020-05-09T12:32:10.450Z] ][2020-05-09T12:32:10.450Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T12:32:10.450Z] with[2020-05-09T12:32:10.450Z] [[2020-05-09T12:32:10.450Z] T=KFileItem[2020-05-09T12:32:10.450Z] ][2020-05-09T12:32:10.450Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T12:32:10.450Z] [65/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kurlauthorized.cpp.obj[2020-05-09T12:32:12.456Z] [66/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kdiskfreespaceinfo.cpp.obj[2020-05-09T12:32:12.741Z] [67/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\restorejob.cpp.obj[2020-05-09T12:32:12.741Z] [68/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\slaveinterface.cpp.obj[2020-05-09T12:32:12.741Z] [69/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksambasharedata.cpp.obj[2020-05-09T12:32:13.755Z] [70/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolmanager.cpp.obj[2020-05-09T12:32:13.755Z] ..\src\core\kprotocolmanager.cpp(959): warning C4996: 'GetVersionExW': was declared deprecated[2020-05-09T12:32:13.755Z] C:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\um\sysinfoapi.h(396): note: see declaration of 'GetVersionExW'[2020-05-09T12:32:13.755Z] ..\src\core\kprotocolmanager.cpp(962): warning C4996: 'GetVersionExW': was declared deprecated[2020-05-09T12:32:13.755Z] C:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\um\sysinfoapi.h(396): note: see declaration of 'GetVersionExW'[2020-05-09T12:32:14.021Z] [71/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\metadata.cpp.obj[2020-05-09T12:32:14.021Z] [72/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\slaveconfig.cpp.obj[2020-05-09T12:32:14.662Z] [73/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kfileitemlistproperties.cpp.obj[2020-05-09T12:32:16.097Z] [74/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolinfo.cpp.obj[2020-05-09T12:32:16.389Z] [75/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\filejob.cpp.obj[2020-05-09T12:32:17.019Z] [76/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksambashare.cpp.obj[2020-05-09T12:32:17.658Z] [77/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\emptytrashjob.cpp.obj[2020-05-09T12:32:17.937Z] [78/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\jobtracker.cpp.obj[2020-05-09T12:32:19.386Z] [79/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\deletejob.cpp.obj[2020-05-09T12:32:19.386Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T12:32:19.386Z] with[2020-05-09T12:32:19.386Z] [[2020-05-09T12:32:19.386Z] T=KFileItem[2020-05-09T12:32:19.386Z] ][2020-05-09T12:32:19.386Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T12:32:19.386Z] with[2020-05-09T12:32:19.386Z] [[2020-05-09T12:32:19.386Z] T=KFileItem[2020-05-09T12:32:19.386Z] ][2020-05-09T12:32:19.386Z] 

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/17/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:32:52 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/91/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 11:29:35 +
 Build duration:
55 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34467/62856)39%
(17484/44524)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4297/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8471/14369)51%
(4410/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/12/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:32:14 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 588 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/588/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 11:29:35 +
 Build duration:
43 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34475/62855)39%
(17482/44528)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4302/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8479/14369)51%
(4404/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8341)43%
(2079/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 19 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/19/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 11:26:40 +
 Build duration:
46 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.71.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9126)43%
(10805/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6200/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:31:31 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/24/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 11:25:45 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 491 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:30:56 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D25339: update lineHeight if boundingRect indicates a larger value.

[René J . V . Bertin]

rjvbb added a comment.


  >   Looking at the code, might it make more sense to just move away from the 
fixed height we have?
  >   It isn't used that often and in most cases one could just query the 
height of the current line.
  
  I'd be all for that, provided it doesn't introduce any regressions in the 
rendered result nor in rendering time.
  
  It could be trickier to implement than you think though?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:25:44 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 487 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.RecursOn_ConnectDaily2.icsFailed: projectroot.autotests.RecursOn_ConnectDaily3.icsFailed: projectroot.autotests.RecursOn_ConnectDaily6.icsFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/99/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:29:35 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.14 - Build # 18 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.14/18/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 11:24:48 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.frameworkintegration_kstyle_unittest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:27:29 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/11/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:27:14 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/27/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 11:25:38 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 190 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/190/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 11:26:40 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.71.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9127)43%
(10807/24863)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6201/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/13/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:27:00 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/17/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 11:26:40 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D29354: Bash: fix comments after escapes

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1e8466029c82: Bash: fix comments after escapes (authored 
by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29354?vs=81718=82360

REVISION DETAIL
  https://phabricator.kde.org/D29354

AFFECTED FILES
  autotests/folding/highlight.sh.fold
  autotests/html/highlight.sh.html
  autotests/input/highlight.sh
  autotests/reference/highlight.sh.ref
  autotests/reference/test.bb.ref
  data/syntax/bash.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29354: Bash: fix comments after escapes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Same here ;=) Thanks a lot for the work on all this issues!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-comments-bash

REVISION DETAIL
  https://phabricator.kde.org/D29354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-folding-latex

REVISION DETAIL
  https://phabricator.kde.org/D29521

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in 
regions markers BEGIN-END (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29521?vs=82244=82359

REVISION DETAIL
  https://phabricator.kde.org/D29521

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/90/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 10:55:21 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34474/62856)39%
(17482/44524)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4297/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8478/14369)51%
(4407/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

[Christoph Cullmann]

cullmann added a comment.


  Looks fine for me, thanks for improvement!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29521

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:444
> I'm a bit confused. My explanation here points to kio_desktop and kio_remote 
> (and was apparently clear), and the API docs for UDS_LOCAL_PATH say
> 
>   /// A local file path if the ioslave display files sitting
>   /// on the local filesystem (but in another hierarchy, e.g. settings:/ or 
> remote:/)
> 
> which is basically the same information? What is unclear?

> to map URLs from kioslaves-that-wrap-the-local-file-system back to local 
> paths.

That made much more sense to me, reading the docs again now, I know what it 
meant, but I did not before.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/98/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 10:55:21 +
 Build duration:
8 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in copyjob.cpp:444
> Excellent points; I was scratching my head trying to figure out what use 
> UDS_LOCAL_PATH is when, while testing with qDebug(), it was _always_ empty, 
> the only time it wasn't empty was in testtrash unit test, some code there set 
> it, used it or something. So I resorted to grep'ing the code and I found the 
> KCoreDirLister::cachedItemForUrl instance (which answers your next comment). 
> So someone who knows all the use-cases of UDS_LOCAL_PATH (you in this case) 
> should/must update the UDS_LOCAL_PATH docs :D

I'm a bit confused. My explanation here points to kio_desktop and kio_remote 
(and was apparently clear), and the API docs for UDS_LOCAL_PATH say

  /// A local file path if the ioslave display files sitting
  /// on the local filesystem (but in another hierarchy, e.g. settings:/ or 
remote:/)

which is basically the same information? What is unclear?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[David Faure]

dfaure created this revision.
dfaure added reviewers: ahmadsamir, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This will not look up the preferred app or run scripts/executables, it always 
shows an open-with dialog.
  Bonus feature compared to KRun::displayOpenWithDialog or KOpenWithDialog: it 
will first determine the mimetype
  (even for remote URLs), which allows to "remember this app for this mimetype".
  
  On the other hand, this loses the support for multiple URLs; OpenUrlJob is 
about a single URL.
  I guess for multiple URLs the best solution is to use KOpenWithDialog 
directly.

TEST PLAN
  New unittest

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

AFFECTED FILES
  autotests/openurljobtest.cpp
  autotests/openurljobtest.h
  src/gui/openurljob.cpp
  src/gui/openurljob.h

To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 587 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/587/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 10:55:21 +
 Build duration:
5 min 46 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)66%
(275/414)66%
(275/414)54%
(33841/62836)38%
(17054/44528)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)86%
(9062/10585)41%
(4235/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)58%
(8303/14359)50%
(4315/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui63%
(5/8)63%
(5/8)65%
(522/804)53%
(325/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)36%
(1557/4282)30%
(1079/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[David Faure]

dfaure added a dependent revision: D29557: Add 
KIO::OpenUrlJob::setShowOpenWithDialog as replacement for 
KRun::displayOpenWithDialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29547

To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 184 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/184/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 09 May 2020 10:55:21 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 698 lines...][2020-05-09T10:56:43.264Z] [80/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\restorejob.cpp.obj[2020-05-09T10:56:43.834Z] [81/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\multigetjob.cpp.obj[2020-05-09T10:56:43.834Z] [82/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kacl.cpp.obj[2020-05-09T10:56:43.834Z] [83/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\specialjob.cpp.obj[2020-05-09T10:56:43.834Z] [84/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\chmodjob.cpp.obj[2020-05-09T10:56:43.834Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T10:56:43.834Z] with[2020-05-09T10:56:43.834Z] [[2020-05-09T10:56:43.834Z] T=KFileItem[2020-05-09T10:56:43.834Z] ][2020-05-09T10:56:43.834Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T10:56:43.834Z] with[2020-05-09T10:56:43.834Z] [[2020-05-09T10:56:43.834Z] T=KFileItem[2020-05-09T10:56:43.834Z] ][2020-05-09T10:56:43.834Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T10:56:43.834Z] with[2020-05-09T10:56:43.834Z] [[2020-05-09T10:56:43.834Z] T=KFileItem[2020-05-09T10:56:43.834Z] ][2020-05-09T10:56:43.834Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T10:56:44.404Z] [85/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kfileitem.cpp.obj[2020-05-09T10:56:44.404Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T10:56:44.404Z] with[2020-05-09T10:56:44.404Z] [[2020-05-09T10:56:44.404Z] T=KFileItem[2020-05-09T10:56:44.404Z] ][2020-05-09T10:56:44.404Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T10:56:44.404Z] with[2020-05-09T10:56:44.404Z] [[2020-05-09T10:56:44.404Z] T=KFileItem[2020-05-09T10:56:44.404Z] ][2020-05-09T10:56:44.404Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-09T10:56:44.404Z] with[2020-05-09T10:56:44.404Z] [[2020-05-09T10:56:44.404Z] T=KFileItem[2020-05-09T10:56:44.404Z] ][2020-05-09T10:56:44.404Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-09T10:56:44.404Z] [86/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\filecopyjob.cpp.obj[2020-05-09T10:56:44.404Z] [87/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\jobuidelegateextension.cpp.obj[2020-05-09T10:56:44.404Z] [88/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kprotocolinfo.cpp.obj[2020-05-09T10:56:44.404Z] [89/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kurlauthorized.cpp.obj[2020-05-09T10:56:44.404Z] [90/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\job_error.cpp.obj[2020-05-09T10:56:44.665Z] [91/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ktcpsocket.cpp.obj[2020-05-09T10:56:44.665Z] [92/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\forwardingslavebase.cpp.obj[2020-05-09T10:56:44.927Z] [93/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\ksambasharedata.cpp.obj[2020-05-09T10:56:45.187Z] [94/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\knfsshare.cpp.obj[2020-05-09T10:56:45.187Z] [95/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\directorysizejob.cpp.obj[2020-05-09T10:56:45.187Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-09T10:56:45.187Z] with[2020-05-09T10:56:45.187Z] [[2020-05-09T10:56:45.187Z] T=KFileItem[2020-05-09T10:56:45.187Z] ][2020-05-09T10:56:45.187Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-09T10:56:45.187Z] with[2020-05-09T10:56:45.187Z] [[2020-05-09T10:56:45.187Z] T=KFileItem[2020-05-09T10:56:45.187Z] ][2020-05-09T10:56:45.187Z] 

D25339: update lineHeight if boundingRect indicates a larger value.

[Christoph Cullmann]

cullmann added a comment.


  Looking at the code, might it make more sense to just move away from the 
fixed height we have?
  It isn't used that often and in most cases one could just query the height of 
the current line.
  That would solve this issue without needing any hacks for the rendering I 
think.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1cac602d9966: [CopyJob] Check free space for remote urls 
before copying and other improvements (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29485?vs=82334=82356

REVISION DETAIL
  https://phabricator.kde.org/D29485

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir added a comment.


  @dfaure please don't forget to flesh out the UDS_LOCAL_PATH docs 
https://phabricator.kde.org/D29485#inline-169199

REPOSITORY
  R241 KIO

BRANCH
  l-freespace-remote-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:477
> I'm assuming the TODO was about "What if I'm using a NFS mount and the 
> connection breaks at the time of KDiskFreeSpaceInfo, i.e. what should we do 
> about error handling".
> 
> But I think the current code -- which ignores errors and moves on, both for 
> local and now for remote files, actually makes most sense. This is after all 
> just a preliminary check. The worst that will happen is that there will 
> indeed not be enough room and the copy will fail. But that's better than not 
> trying at all, possibly due to a bug in one of those two classes, or possibly 
> because of intermittent network failures.

That makes sense :)

REPOSITORY
  R241 KIO

BRANCH
  l-freespace-remote-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu marked an inline comment as done.
marcingu added inline comments.

INLINE COMMENTS

> meven wrote in thumbnail.cpp:738
> There is an error with the previous line, one of the two should be 
> allowDirCached I think.
> Here you always ignore result of `sharesFilesystemWithThumbRoot`

Could you elaborate? I don't see it.

> thiago wrote in thumbnail.cpp:743
> How about encrypted block storage, which is superior to those encrypted fs 
> and the recommended solution?

Any pointers how to do that?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/97/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 10:39:57 +
 Build duration:
4 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_favicontestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/96/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 09 May 2020 10:05:03 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 89 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/89/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 09 May 2020 10:05:04 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34404/62844)39%
(17467/44518)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4301/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8442/14358)51%
(4398/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kcolorcombo.cpp:89
> +int unused, v;
> +innercolor.getHsv(, , );
> +textColor = v > 128 ? Qt::black : Qt::white;

Please don't use "value" component to calculate the brightness of a color. 
#81 is much darker than #808080. To decide, use qGray(). The threshold also 
needs to be higher than 128; I use 170, but this mostly depends on correctness 
of monitor gamma settings.

See  
https://stackoverflow.com/questions/3942878/how-to-decide-font-color-in-white-or-black-depending-on-background-color

> kcolorcombo.cpp:277
> +list.reserve(d->colorList.size());
> +for (auto iColor : d->colorList) {
> +list.append({iColor.second});

Variables declared in 'for' are local, so just use 'color'.

> kcolorcombo.h:61
>  
> +/** Struct used in named colors list */
> +using ColorList = QList>;

The comment still says "struct". Maybe clarify that this list is actually used 
as a map.

(I guess since mapping would happen in both directions, using a QMap isn't 
useful?)

> kcolorcombo.h:91
> + * standard list.
> + * @param colors map os named colors. If empty, the selction list
> + *  reverts to the standard list.

typos: of; selection

> kcolorcombo.h:97
> +/**
> + * Inserts a named color at a specific position in the standard list
> + * @param index position in the list

Sentence misses a full stop.

> kcolorcombo.h:110
> +/**
> + * Return the list of named colors available for selecion.
> + * If no named color, return namedColor is empty.

typo: selection

> kcolorcombo.h:111
> + * Return the list of named colors available for selecion.
> + * If no named color, return namedColor is empty.
> + * @return list of named colors

This sentence is confusing. I guess you wanted to write "if there are no named 
colors, the returned list is empty." (to clarify that it won't return the 
standard list).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 586 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/586/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 May 2020 10:05:04 +
 Build duration:
9 min 0 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34404/62844)39%
(17464/44522)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4299/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(102/116)88%
(102/116)59%
(8452/14359)51%
(4406/8708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4287)36%
(1300/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%