D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 2 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked an inline comment as done.
araujoluis added inline comments.

INLINE COMMENTS

> cblack wrote in kcolorcombo.h:52
> Is a simple tuple list really the best way to represent colours? Knowing what 
> most designers like, a better data structure would encapsulate named groups 
> of optionally named colours.

I believe that yes, each color has its own representation, and the way it was 
proposed, if the color is not available, the name used is the hex value of the 
color.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked an inline comment as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> kcolorcombo.h:52
>  Q_PROPERTY(QList colors READ colors WRITE setColors)
> +Q_PROPERTY(QList> namedColors READ namedColors 
> WRITE setNamedColors)
>  

Is a simple tuple list really the best way to represent colours? Knowing what 
most designers like, a better data structure would encapsulate named groups of 
optionally named colours.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis added inline comments.

INLINE COMMENTS

> cfeck wrote in kcolorcombo.h:61
> The comment still says "struct". Maybe clarify that this list is actually 
> used as a map.
> 
> (I guess since mapping would happen in both directions, using a QMap isn't 
> useful?)

Using QMap would cause me a problem, consider the following code block:

  for (int i = 0; i  setCurrentIndex (i + 1);

I need variable i for iteration with the call q-> setCurrentIndex (i + 1) and 
this method would not be available with QMap.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> kcolorcombo.cpp:90
> +innerColor.getHsv(&unused, &unused, &v);
> +textColor = v > 128 ? Qt::black : Qt::white;
> +}

I would probably do what Kirigami does for `ColorUtils::brightnessForColor` 
here: `((0.299 * color.red() + 0.587 * color.green() + 0.114 * color.blue()) / 
255) > 0.5 ? Qt::black : Qt::white`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82484.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: fix comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82483&id=82484

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82483.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: fix comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82482&id=82483

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked an inline comment as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked an inline comment as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 3 inline comments as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked 14 inline comments as done.
araujoluis added inline comments.

INLINE COMMENTS

> patrickelectric wrote in kcolorcombo.h:52
> This is just a suggestion and not something that's necessary to do, but maybe 
> it could help to create a simple class to replace QPair:
> 
>   class KComboColor {
>   Q_PROPERTY(QColor color MEMBER color)
>   Q_PROPERTY(QString name MEMBER name)
>   public:
>   QColor color;
>   QString name;
>   }

Good suggestion, I will be thinking how to do it as this would alter the use of 
lists within the code.

> cfeck wrote in kcolorcombo.h:61
> The comment still says "struct". Maybe clarify that this list is actually 
> used as a map.
> 
> (I guess since mapping would happen in both directions, using a QMap isn't 
> useful?)

Done!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis marked an inline comment as done.
araujoluis added inline comments.

INLINE COMMENTS

> patrickelectric wrote in kcolorcombo.cpp:74
> Missing const, also the name should be `innerColor` with a capital C if we 
> are following the code style from this file.

Done!

> patrickelectric wrote in kcolorcombo.cpp:83
> missing reference for innercolor ?

Yes, reference not found for innercolor or innerColor

> patrickelectric wrote in kcolorcombo.cpp:107
> It's missing const

Done!

> patrickelectric wrote in kcolorcombo.cpp:107
> Maybe changing the logic to make it more simpler:
> 
>   QRect colorRect = tv.toString().isEmpty() ? innerrect : 
> QRect(innerrect.x(), innerrect.y() + innerrect.height() / 2, 
> innerrect.width(), innerrect.height() / 2);

Done!

> patrickelectric wrote in kcolorcombo.cpp:107
> Maybe changing the logic to make it more simpler:
> 
>   QRect colorRect = tv.toString().isEmpty() ? innerrect : 
> QRect(innerrect.x(), innerrect.y() + innerrect.height() / 2, 
> innerrect.width(), innerrect.height() / 2);

Done!

> patrickelectric wrote in kcolorcombo.cpp:107
> It's missing const

Done!

> cfeck wrote in kcolorcombo.cpp:277
> Variables declared in 'for' are local, so just use 'color'.

Done!

> cfeck wrote in kcolorcombo.h:91
> typos: of; selection

Done!

> cfeck wrote in kcolorcombo.h:110
> typo: selection

Done!

> cfeck wrote in kcolorcombo.h:111
> This sentence is confusing. I guess you wanted to write "if there are no 
> named colors, the returned list is empty." (to clarify that it won't return 
> the standard list).

Done!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82482.
araujoluis marked an inline comment as done.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: rename variable

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82481&id=82482

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82481.
araujoluis marked an inline comment as done.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: fix comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82480&id=82481

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82480.
araujoluis marked an inline comment as done.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: fix comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82479&id=82480

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82479.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: fix comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82478&id=82479

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82478.
araujoluis marked an inline comment as done.
araujoluis added a comment.


  - kwidgetsaddons: update comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82477&id=82478

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82477.
araujoluis marked an inline comment as done.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: rename innerrect to innerRect

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82476&id=82477

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82476.
araujoluis marked 2 inline comments as done.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: set QRect colorRect as constant

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82475&id=82476

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis updated this revision to Diff 82475.
araujoluis added a comment.


  - kwidgetsaddons: kcolorcombo: rename a set constant for innerColor

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29502?vs=82219&id=82475

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

AFFECTED FILES
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  tests/kcolorcombotest.cpp

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[patrick j pereira]

patrickelectric added a comment.


  Just some small tips.

INLINE COMMENTS

> kcolorcombo.cpp:74
>  bool paletteBrush = (k_colorcombodelegate_brush(index, 
> Qt::BackgroundRole).style() == Qt::NoBrush);
> -if (isSelected) {
> -innercolor = option.palette.color(QPalette::Highlight);
> -} else {
> -innercolor = option.palette.color(QPalette::Base);
> -}
> +QColor innercolor = option.palette.color( isSelected ? 
> QPalette::Highlight : QPalette::Base);
> +

Missing const, also the name should be `innerColor` with a capital C if we are 
following the code style from this file.

> kcolorcombo.cpp:83
> +
> +auto textColorLambda = [&paletteBrush, &isSelected, &option, 
> innercolor]() -> QColor {
> +QColor textColor;

missing reference for innercolor ?

> kcolorcombo.cpp:107
>  painter->setRenderHint(QPainter::Antialiasing);
> -painter->drawRoundedRect(innerrect, 2, 2);
> +QRect colorRect = !tv.toString().isEmpty() ? 
> QRect(innerrect.x(), innerrect.y() + innerrect.height() / 2, 
> innerrect.width(), innerrect.height() / 2) : innerrect;
> +painter->drawRoundedRect(colorRect, 2, 2);

Maybe changing the logic to make it more simpler:

  QRect colorRect = tv.toString().isEmpty() ? innerrect : QRect(innerrect.x(), 
innerrect.y() + innerrect.height() / 2, innerrect.width(), innerrect.height() / 
2);

> kcolorcombo.cpp:107
>  painter->setRenderHint(QPainter::Antialiasing);
> -painter->drawRoundedRect(innerrect, 2, 2);
> +QRect colorRect = !tv.toString().isEmpty() ? 
> QRect(innerrect.x(), innerrect.y() + innerrect.height() / 2, 
> innerrect.width(), innerrect.height() / 2) : innerrect;
> +painter->drawRoundedRect(colorRect, 2, 2);

It's missing const

> kcolorcombo.h:52
>  Q_PROPERTY(QList colors READ colors WRITE setColors)
> +Q_PROPERTY(QList> namedColors READ namedColors 
> WRITE setNamedColors)
>  

This is just a suggestion and not something that's necessary to do, but maybe 
it could help to create a simple class to replace QPair:

  class KComboColor {
  Q_PROPERTY(QColor color MEMBER color)
  Q_PROPERTY(QString name MEMBER name)
  public:
  QColor color;
  QString name;
  }

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Re: Fwd: KDE CI: Administration » Dependency Build Calligra stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Still Failing!

[David Faure]

On Sunday, May 10, 2020 11:53:31 AM CEST Ben Cooksley wrote:
> Can someone investigate the below please?

Fixed by Ahmad today in https://phabricator.kde.org/D29599

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D29610: [CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK for now, to fix the unittests. The *real* fix however is to use 
QFile::rename in kio_file so that this failure to rename doesn't even happen in 
the first place.
  
  In this commit can you at least leave a TODO to that effect?

INLINE COMMENTS

> copyjob.cpp:1965
> +if (_src != _dest
> +&& srcParentDir == destParentDir
> +&& QString::compare(_src, _dest, Qt::CaseInsensitive) == 0) {

Why this check? The next line compares absolute paths -- including the parent 
dir.

Hmm OK one could manufacture a special case with /dir/file and /DIR/FILE where 
the compare() passes but the parent dirs differ. The orig code had that bug... 
OK :)

REPOSITORY
  R241 KIO

BRANCH
  l-qfile-rename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29610

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29610: [CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  The code now uses QFile::rename() only if direct renaming fails and we're
  moving a file/dir e.g. 'A' to 'a' on a case-insensitive filesystem such
  as FAT3. This matches the behaviour from before commit cb89bab36a5aa4e78c 
,
  and also fixes the jobtest moveFileDestAlreadyExists unit test.

TEST PLAN
  jobtest unit test passes again
  Moving a dir 'A' to 'a' on a FAT32 partition still works

REPOSITORY
  R241 KIO

BRANCH
  l-qfile-rename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29610

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> svuorela wrote in dialog.cpp:317
> I think I read once that whenever you used a ordered map over an unordered 
> map, you need to justify it by talking to your manager about it. But that's 
> also a bit from the bucket of nitpickery unless we are in a hot codepath.

Interesting. This makes it sound like "ordering" is a feature that costs extra.
But my understanding is that the bookkeeping required for a hash table, is what 
costs extra -- for small quantities of data, as is the case here.
Instanciating nodes and making a few '<' comparisons are less work than 
creating buckets, and hashing (entire) strings.

Anyhow, for 5-10 items nothing makes a difference.

> svuorela wrote in dialog.cpp:326
> nitpickery. but range based for and qAsConst on container?

For a QMap? I think this iterates over pairs, so it only looks nice with C++17 
structured bindings.
(or if it doesn't, then that's an incompatibility with std::map, awful).

REPOSITORY
  R295 KCMUtils

BRANCH
  fix_duplicates

REVISION DETAIL
  https://phabricator.kde.org/D28760

To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

[David Faure]

dfaure closed this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28760

To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Tobias Fella]

tfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause, tfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29597: file extractor: fix linking

[Peter Eszlari]

eszlari added a comment.


  Strange. It worked with gmake locally, but failed on the Flathub buildbot 
again (https://flathub.org/builds/#/builders/32/builds/19809, only  x86_64 
failed, not arm or aarch64).
  
  What really fixed it at the end, was switching to an out of source build.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29597

To: eszlari, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

[Sune Vuorela]

svuorela accepted this revision.
svuorela added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dialog.cpp:317
>  const QStringList dirs = 
> QStandardPaths::locateAll(QStandardPaths::DataLocation, 
> QStringLiteral("ksettingsdialog"),  QStandardPaths::LocateDirectory);
> +QMap fileMap;
>  for (const QString &dir : dirs) {

I think I read once that whenever you used a ordered map over an unordered map, 
you need to justify it by talking to your manager about it. But that's also a 
bit from the bucket of nitpickery unless we are in a hot codepath.

> dialog.cpp:326
>  }
> +for (auto it = fileMap.constBegin(); it != fileMap.constEnd(); ++it) {
> +parseGroupFile(it.value());

nitpickery. but range based for and qAsConst on container?

REPOSITORY
  R295 KCMUtils

BRANCH
  fix_duplicates

REVISION DETAIL
  https://phabricator.kde.org/D28760

To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Méven Car]

meven added a comment.


  Great consistency work !
  
  CC @niccolove

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: meven, dfaure, mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D29597: file extractor: fix linking

[Peter Eszlari]

eszlari abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29597

To: eszlari, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D29597: file extractor: fix linking

[Peter Eszlari]

eszlari added a comment.


  Indeed. It failed with cmake 3.15.2 + ninja 1.9.0 and worked with make 
(4.2.1).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29597

To: eszlari, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 595 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/595/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 May 2020 18:02:48 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34483/62873)39%
(17493/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4303/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8471/14369)51%
(4403/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/105/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 10 May 2020 18:02:48 +
 Build duration:
8 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/97/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 10 May 2020 18:02:48 +
 Build duration:
5 min 11 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34475/62874)39%
(17490/44542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4299/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8461/14368)50%
(4398/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4287)36%
(1311/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29547

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  Yeah, This should be a new component, or at most enabled by an off-by-default 
property. The default behavior should not change.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson, ngraham
Cc: ngraham, apol, davidedmundson, ognarb, cblack, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[Ahmad Samir]

ahmadsamir accepted this revision.
ahmadsamir added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in krun.h:216
> I did, but Friedrich had a less confusing suggestion:
> 
> @deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise 
> runApplication instead.

Yeah, makes sense; the point is keeping the users of the class informed/aware 
anyway.

REPOSITORY
  R241 KIO

BRANCH
  2020_05_deprecate_KRun_run_methods

REVISION DETAIL
  https://phabricator.kde.org/D29547

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29511: Label: Add ping-pong logic

[Aleix Pol Gonzalez]

apol added a comment.


  I feel like this could break Labels unknowingly. Maybe it would make sense to 
have an extra scrollToFit (?) property or even another separate component to do 
that.
  
  Seeing things bouncing without the author intending could be worse than 
having the text cut off.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson
Cc: apol, davidedmundson, ognarb, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kcmoduleinfo.h:131
> It's complicated.
> 
> 1. If you use the QString constructor, you know service() is usable. That's 
> the case for all users of KCModuleInfo except KCModuleLoader. [Not that there 
> are many]
> 
> 2. Even KCModuleLoader calls service(), to test for noDisplay().
> 
> The whole concept of NoDisplay only makes sense for desktop files, unless we 
> want to have that in JSON metadata as well. I suppose we do, but this 
> currently seems to be completely missing (e.g. from KPluginMetaData, if we 
> want this in all plugins, not just KCMs). We'd have to duplicate the logic 
> currently in KService::noDisplay().
> 
> Any volunteers to look into this? :-)

As I just ran into this code, a short reminder: it would be a regression not to 
have a noDisplay check in the case of pure JSON metadata, as the current code 
of KService::;noDisplay() also asks KAuth whether the page should be shown 
(`KAuthorized::authorizeControlModule(storageId())`), which some KIOSK systems 
or admins might rely on, but also `showInCurrentDesktop()` & 
`showOnCurrentPlatform()`, which also still make sense, for what I can tell.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: kossebau, svuorela, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

Re: RFC: relative executables in desktop files

[Aleix Pol]

On Sun, Apr 26, 2020 at 1:36 PM David Faure  wrote:
>
> During the review of https://phabricator.kde.org/D29170 the following 
> question surfaced again: should it be possible for a desktop file to refer to 
> an executable that is in the "current directory", for some definition of that 
> term. At least, outside of $PATH.
>
> In my opinion, in a GUI program started graphically, the notion of "current 
> dir" (QDir::currentPath()) has no meaning. The user can't see it and can't 
> change it. When starting the program from the command line it does serve a 
> purpose for command line arguments, but IMHO not after that (e.g. if you 
> navigate to another dir in dolphin, QDir::currentPath() still points to the 
> directory you started dolphin from).
>
> There is however another "current directory" that might make more sense when 
> starting a desktop file: the directory of the desktop file itself.
>
> There are actual use cases for that, see this very old request on the XDG 
> mailing-list:
> https://lists.freedesktop.org/archives/xdg/2011-April/011883.html
>
> AFAICS this discussion has 3 possible outcomes:
>
> * We do not support starting executables that are not in $PATH, end of story.
> That was actually what I had in mind when writing the code initially, any use 
> of API that also looked in the current directory (like QFileInfo::exists) was 
> accidental. Unless I'm mistaken, this is how it's been until now. It's also 
> what the XDG spec [1] says.
>
> * We support launching executables relative to the desktop file, 
> transparently. In the same directory, put a copy of dolphin called dolphin2, 
> and a copy of org.kde.dolphin.desktop modified to say Exec=dolphin2, and 
> clicking on the desktop file starts dolphin2. That's what my current revision 
> of D29170 does.
> I'm wondering if this is the right thing to do though.
> After all, on the command line "foo" doesn't start a local executable called 
> foo, only ./foo does that. Except for people who add "." to $PATH, but that's 
> generally not recommended (security, accidental use of wrong binary).
>
> * We could also adopt the above proposal from the xdg list, which is that 
> Exec=foo only looks in $PATH, while Exec=./foo only looks in the directory of 
> the desktop file.
>
> (I'm purposefully excluding the 4th option, resolving relative to 
> QDir::currentPath() which as explained at the top, would be nonsense IMHO)
>
> Thoughts?

One thing to note, which is probably easy to support: at the moment in
kwin we're relying on certain apps to be defined in absolute paths for
some security measures.

Just supporting $PATH makes most sense to me, there's increasingly
other ways to distribute software that abstract XDG out (e.g. snap,
appimage and flatpak). Weird custom uses should become increasingly
more rare over time.

Aleix

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[David Faure]

dfaure updated this revision to Diff 82453.
dfaure marked 2 inline comments as done.
dfaure added a comment.


  take review into account

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29547?vs=82325&id=82453

BRANCH
  2020_05_deprecate_KRun_run_methods

REVISION DETAIL
  https://phabricator.kde.org/D29547

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/krun.h

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[David Faure]

dfaure marked 2 inline comments as done.
dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in krun.h:216
> I don't think you want both @deprecated?

I did, but Friedrich had a less confusing suggestion:

@deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise 
runApplication instead.

> ahmadsamir wrote in krun.h:229
> You meant "5, 71"

No, we want this method to be deprecated since 5.6.

> ahmadsamir wrote in krun.h:369
> But OpenUrlJob is in 5.71 not 5.31? people will be reading that on 
> api.kde.org not only in 5.71 header files, right?
> maybe:
> @deprecated since 5.31
> Since 5.71, use OpenUrlJob instead.

Right, same A->B->C problem here.

I'll use the same solution.

> ahmadsamir wrote in krun.h:380
> The same issue 5.31 vs 5.71.

Same thing. Whatever the text is, the important bit is that this warns when 
asking for deprecation warnings ">= 5.31"

> ahmadsamir wrote in krun.h:452
> Missing @deprecated.

Well spotted.

> ahmadsamir wrote in krun.h:599
> So, you're keeping the name slotTimout? I guess after 5-10 years, no point 
> changing it :)

I'm going to deprecate the whole KRun class, so this TODO is irrelevant.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29547

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> krun.h:216
> + * @deprecated since 5.6, use runApplication instead.
> + * @deprecated since 5.71, use ApplicationLauncherJob instead.
> + * @code

I don't think you want both @deprecated?

> krun.h:229
>   */
> -KIOWIDGETS_DEPRECATED_VERSION(5, 6, "Use KRun::runApplication(const 
> KService &, const QList &, QWidget *, RunFlags, const QString &, const 
> QByteArray &")
> +KIOWIDGETS_DEPRECATED_VERSION(5, 6, "Use KIO::ApplicationLauncherJob, 
> see API docs for a code sample")
>  static bool run(const KService &service, const QList &urls, 
> QWidget *window,

You meant "5, 71"

> krun.h:369
>   * @return @c true on success, @c false on error
> - * @deprecated since 5.31, use runUrl() with RunFlags instead.
> + * @deprecated since 5.31, use OpenUrlJob instead.
> + * @code

But OpenUrlJob is in 5.71 not 5.31? people will be reading that on api.kde.org 
not only in 5.71 header files, right?
maybe:
@deprecated since 5.31
Since 5.71, use OpenUrlJob instead.

> krun.h:380
>   */
> -KIOWIDGETS_DEPRECATED_VERSION(5, 31, "Use KRun::const QUrl &, const 
> QString &, QWidget *, RunFlags, const QString &, const QByteArray &")
> +KIOWIDGETS_DEPRECATED_VERSION(5, 31, "Use KIO::OpenUrlJob, see API docs 
> for a code sample")
>  static bool runUrl(const QUrl &url, const QString &mimetype, QWidget 
> *window,

The same issue 5.31 vs 5.71.

> krun.h:452
>   * @param asn Application startup notification id, if any (otherwise "").
>   * @return @c true on success, @c false on error
> + * @code

Missing @deprecated.

> krun.h:599
>   */
> -void slotTimeout(); // KDE5: rename to slotNextStep() or something like 
> that
> +void slotTimeout();
>  

So, you're keeping the name slotTimout? I guess after 5-10 years, no point 
changing it :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29547

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29597: file extractor: fix linking

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Your build system seems to be broken. The "missing" methods are statically 
linked, see 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29597

To: eszlari, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D24367: Some sanity verification

[Martin Tobias Holmedahl Sandsmark]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:8562ce18f1ab: Add some sanity and bounds checking 
(authored by sandsmark).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24367?vs=79917&id=82450#toc

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24367?vs=79917&id=82450

REVISION DETAIL
  https://phabricator.kde.org/D24367

AFFECTED FILES
  src/imageformats/exr.cpp
  src/imageformats/pcx.cpp
  src/imageformats/pic.cpp
  src/imageformats/psd.cpp
  src/imageformats/rgb.cpp
  src/imageformats/tga.cpp

To: sandsmark, aacid, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

dfaure added a subscriber: chinmoyr.
dfaure added a comment.


  In D23875#532045 , @dhaumann wrote:
  
  > @dfaure: D21197  can be closed / 
abandoned?
  
  
  Yes, but @chinmoyr has disappeared, it seems?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: dfaure, #frameworks, ahmadsamir
Cc: chinmoyr, dhaumann, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

[David Faure]

dfaure added a comment.


  ping?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28760

To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

[David Faure]

dfaure added a reviewer: svuorela.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29547

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[David Faure]

dfaure added a reviewer: svuorela.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29558

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 594 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/594/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 May 2020 15:18:47 +
 Build duration:
8 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34483/62873)39%
(17486/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4300/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8471/14369)50%
(4398/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/96/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 10 May 2020 15:18:48 +
 Build duration:
8 min 33 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34498/62874)39%
(17487/44542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4308/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8495/14369)51%
(4404/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(703/1289)40%
(411/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/104/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 10 May 2020 15:18:48 +
 Build duration:
7 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 190 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/190/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sun, 10 May 2020 15:18:48 +
 Build duration:
3 min 2 sec and counting

D29599: [CopyJob] Try to fix windows build

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d026227574b8: [CopyJob] Try to fix windows build 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29599?vs=82444&id=82447

REVISION DETAIL
  https://phabricator.kde.org/D29599

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29599: [CopyJob] Try to fix windows build

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Bonus points for keeping an eye on CI, I wish everyone did that ;-)

REPOSITORY
  R241 KIO

BRANCH
  l-fix-win-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29599

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Building all of KF with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT set, so 
dropping any deprecated API from the build, serves as a small sanity check to 
see if the future (like KF6) is well prepared and there is no hidden 
undeprecated functional dependency on deprecated API. Only backward-compatibel 
functionality should still rely on any deprecated API. Or otherwise the 
deprecation should be undone possibly.
  
  No oversight over Plasma these days, so cannot tell what parts are still 
depending on metadata fetched from desktop files via KService. But given such 
API has been deprecated since KF 5.0 it might be time to complete any missing 
adaption. 
  So any changes done here are solely based on "it builds without deprecated 
API used" :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29600

To: kossebau, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  NO_CHANGELOG

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixbuildwithoutdeprecated

REVISION DETAIL
  https://phabricator.kde.org/D29600

AFFECTED FILES
  src/plasma/pluginloader.cpp
  src/plasma/private/containmentactions_p.h

To: kossebau, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 593 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/593/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 May 2020 14:18:01 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34490/62873)39%
(17486/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10585)42%
(4299/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8478/14369)50%
(4399/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

D29599: [CopyJob] Try to fix windows build

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  The windows build is failing on the CI because of S_IWUSR; include
  kioglobal_p.h to try and fix that.

REPOSITORY
  R241 KIO

BRANCH
  l-fix-win-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29599

AFFECTED FILES
  src/core/copyjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/103/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 10 May 2020 14:18:01 +
 Build duration:
9 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/95/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 10 May 2020 14:18:01 +
 Build duration:
6 min 0 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(277/414)67%
(277/414)55%
(34479/62874)39%
(17493/44542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(58/59)98%
(58/59)87%
(9188/10584)42%
(4301/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8460/14368)50%
(4400/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 189 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/189/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sun, 10 May 2020 14:18:01 +
 Build duration:
1 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 761 lines...][2020-05-10T14:19:55.951Z] [128/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\deletejob.cpp.obj[2020-05-10T14:19:55.951Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-10T14:19:55.951Z] with[2020-05-10T14:19:55.951Z] [[2020-05-10T14:19:55.951Z] T=KFileItem[2020-05-10T14:19:55.951Z] ][2020-05-10T14:19:55.951Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-10T14:19:55.951Z] with[2020-05-10T14:19:55.951Z] [[2020-05-10T14:19:55.951Z] T=KFileItem[2020-05-10T14:19:55.951Z] ][2020-05-10T14:19:55.951Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-10T14:19:55.951Z] with[2020-05-10T14:19:55.951Z] [[2020-05-10T14:19:55.951Z] T=KFileItem[2020-05-10T14:19:55.951Z] ][2020-05-10T14:19:55.951Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-10T14:19:55.951Z] [129/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kdiskfreespaceinfo.cpp.obj[2020-05-10T14:19:55.951Z] [130/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kpasswdserverclient.cpp.obj[2020-05-10T14:19:55.951Z] [131/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\chmodjob.cpp.obj[2020-05-10T14:19:55.951Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-10T14:19:55.951Z] with[2020-05-10T14:19:55.951Z] [[2020-05-10T14:19:55.951Z] T=KFileItem[2020-05-10T14:19:55.951Z] ][2020-05-10T14:19:55.951Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251): note: see declaration of 'QSet::toList'[2020-05-10T14:19:55.951Z] with[2020-05-10T14:19:55.951Z] [[2020-05-10T14:19:55.951Z] T=KFileItem[2020-05-10T14:19:55.951Z] ][2020-05-10T14:19:55.951Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-10T14:19:55.951Z] with[2020-05-10T14:19:55.951Z] [[2020-05-10T14:19:55.951Z] T=KFileItem[2020-05-10T14:19:55.951Z] ][2020-05-10T14:19:55.951Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-10T14:19:55.951Z] [132/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\slave.cpp.obj[2020-05-10T14:19:56.215Z] [133/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\kfileitem.cpp.obj[2020-05-10T14:19:56.215Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-10T14:19:56.215Z] with[2020-05-10T14:19:56.215Z] [[2020-05-10T14:19:56.215Z] T=KFileItem[2020-05-10T14:19:56.215Z] ][2020-05-10T14:19:56.215Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251): note: see declaration of 'QSet::toList'[2020-05-10T14:19:56.215Z] with[2020-05-10T14:19:56.215Z] [[2020-05-10T14:19:56.215Z] T=KFileItem[2020-05-10T14:19:56.215Z] ][2020-05-10T14:19:56.215Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405): note: while compiling class template member function 'QList QList::fromSet(const QSet &)'[2020-05-10T14:19:56.215Z] with[2020-05-10T14:19:56.215Z] [[2020-05-10T14:19:56.215Z] T=KFileItem[2020-05-10T14:19:56.215Z] ][2020-05-10T14:19:56.215Z] C:\CI\Job Build\src\core\kfileitem.h(600): note: see reference to class template instantiation 'QList' being compiled[2020-05-10T14:19:56.496Z] [134/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\forwardingslavebase.cpp.obj[2020-05-10T14:19:56.759Z] [135/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\filejob.cpp.obj[2020-05-10T14:19:57.020Z] [136/732] Building CXX object src\core\CMakeFiles\KF5KIOCore.dir\directorysizejob.cpp.obj[2020-05-10T14:19:57.020Z] C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406): warning C4996: 'QSet::toList': Use values() instead.[2020-05-10T14:19:57.020Z] with[2020-05-10T14:19:57.020Z] [[2020-05-10T14:19:57.020Z] T=KFileItem[2020-05-1

D29223: Update Taiwanese holidays

[Allen Winter]

winterz added a comment.


  all opposed to this patch please speak up soon

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz updated this revision to Diff 82442.
winterz added a comment.


  QLatin1-ify

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29575?vs=82398&id=82442

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  src/holidayregion.cpp

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29597: file extractor: fix linking

[Peter Eszlari]

eszlari created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
eszlari requested review of this revision.

REVISION SUMMARY
[291/397] Linking CXX executable bin/baloo_file_extractor
FAILED: bin/baloo_file_extractor 
: && /usr/bin/c++  -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong 
-grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection 
-fcf-protection -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align 
-Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef 
-Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time 
-Wsuggest-override -Wlogical-op -fdiagnostics-color=always -pedantic 
-Wzero-as-null-pointer-constant  -Wl,--enable-new-dtags -L/app/lib 
-Wl,-z,relro,-z,now -Wl,--as-needed 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloo_file_extractor_autogen/mocs_compilation.cpp.o
 src/file/extractor/CMakeFiles/baloo_file_extractor.dir/main.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/app.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/result.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/idlestatemonitor.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/priority.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/basicindexingjob.cpp.o
 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o
 src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o
 src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/propertydata.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloodebug.cpp.o 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o  -o 
bin/baloo_file_extractor  -Wl,-rpath,/run/build/baloo/bin: 
/app/lib/libKF5FileMetaData.so.5.69.0 
/usr/lib/x86_64-linux-gnu/libKF5ConfigCore.so.5.69.0 
/usr/lib/x86_64-linux-gnu/libKF5Solid.so.5.69.0 bin/libKF5BalooEngine.so.5.69.0 
/usr/lib/x86_64-linux-gnu/libKF5Crash.so.5.69.0 
/usr/lib/x86_64-linux-gnu/libKF5IdleTime.so.5.69.0 
/usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.14.2 
/usr/lib/x86_64-linux-gnu/libKF5I18n.so.5.69.0 -llmdb 
/usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so.5.69.0 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.14.2 
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.14.2 
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5.14.2 && :

/usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld:
 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o:
 in function `BalooSettings::setDbVersion(int)':
/run/build/baloo/src/file/baloosettings.h:105: undefined reference to 
`BalooSettings::dbVersionChanged()'

/usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld:
 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o:
 in function `BalooSettings::setExcludedFilters(QStringList const&)':
/run/build/baloo/src/file/baloosettings.h:327: undefined reference to 
`BalooSettings::excludedFiltersChanged()'

/usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld:
 
src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o:
 in function `BalooSettings::setExcludedFiltersVersion(int)':
/run/build/baloo/src/file/baloosettings.h:364: undefined reference to 
`BalooSettings::excludedFiltersVersionChanged()'
collect2: error: ld returned 1 exit status
  
  https://flathub.org/builds/#/builders/32/builds/18929

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29597

AFFECTED FILES
  src/file/extractor/CMakeLists.txt

To: eszlari
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Fwd: KDE CI: Administration » Dependency Build Calligra stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Still Failing!

[Ben Cooksley]

Can someone investigate the below please?

Thanks,
Ben

-- Forwarded message -
From: CI System 
Date: Sun, May 10, 2020 at 8:01 PM
Subject: KDE CI: Administration » Dependency Build Calligra stable-kf5-qt5
WindowsMSVCQt5.14 - Build # 24 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Calligra%20stable-kf5-qt5%20WindowsMSVCQt5.14/24/
Project: Dependency Build Calligra stable-kf5-qt5 WindowsMSVCQt5.14
Date of build: Sun, 10 May 2020 07:19:29 +
Build duration: 42 min and counting
* CONSOLE OUTPUT *
[...truncated 43646 lines...]
[2020-05-10T08:00:56.741Z] ]
[2020-05-10T08:00:56.741Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(251):
note: see declaration of 'QSet::toList'
[2020-05-10T08:00:56.741Z] with
[2020-05-10T08:00:56.741Z] [
[2020-05-10T08:00:56.741Z] T=KFileItem
[2020-05-10T08:00:56.741Z] ]
[2020-05-10T08:00:56.741Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore\qset.h(405):
note: while compiling class template member function 'QList
QList::fromSet(const QSet &)'
[2020-05-10T08:00:56.741Z] with
[2020-05-10T08:00:56.741Z] [
[2020-05-10T08:00:56.742Z] T=KFileItem
[2020-05-10T08:00:56.742Z] ]
[2020-05-10T08:00:56.742Z] C:\CI\DepBuild\kio\src\core\kfileitem.h(600):
note: see reference to class template instantiation 'QList'
being compiled
[2020-05-10T08:00:56.742Z] [129/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\kfileitemlistproperties.cpp.obj
[2020-05-10T08:00:57.003Z] [130/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\mkpathjob.cpp.obj
[2020-05-10T08:00:57.003Z] [131/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\mkdirjob.cpp.obj
[2020-05-10T08:00:57.003Z] [132/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\tcpslavebase.cpp.obj
[2020-05-10T08:00:57.270Z] [133/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\usernotificationhandler.cpp.obj
[2020-05-10T08:00:57.270Z] [134/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\kfileitem.cpp.obj
[2020-05-10T08:00:57.270Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406):
warning C4996: 'QSet::toList': Use values() instead.
[2020-05-10T08:00:57.270Z] with
[2020-05-10T08:00:57.270Z] [
[2020-05-10T08:00:57.270Z] T=KFileItem
[2020-05-10T08:00:57.270Z] ]
[2020-05-10T08:00:57.270Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251):
note: see declaration of 'QSet::toList'
[2020-05-10T08:00:57.270Z] with
[2020-05-10T08:00:57.270Z] [
[2020-05-10T08:00:57.270Z] T=KFileItem
[2020-05-10T08:00:57.270Z] ]
[2020-05-10T08:00:57.270Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405):
note: while compiling class template member function 'QList
QList::fromSet(const QSet &)'
[2020-05-10T08:00:57.270Z] with
[2020-05-10T08:00:57.270Z] [
[2020-05-10T08:00:57.270Z] T=KFileItem
[2020-05-10T08:00:57.270Z] ]
[2020-05-10T08:00:57.270Z] C:\CI\DepBuild\kio\src\core\kfileitem.h(600):
note: see reference to class template instantiation 'QList'
being compiled
[2020-05-10T08:00:57.880Z] [135/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\kremoteencoding.cpp.obj
[2020-05-10T08:00:58.146Z] [136/731] Linking CXX executable
bin\httpheaderdispositiontest.exe
[2020-05-10T08:00:58.416Z] [137/731] Linking CXX shared module
bin\kf5\kded\kcookiejar.dll
[2020-05-10T08:00:58.416Z] Creating library lib\kcookiejar.lib and object
lib\kcookiejar.exp
[2020-05-10T08:00:58.416Z] Creating library lib\kcookiejar.lib and object
lib\kcookiejar.exp
[2020-05-10T08:00:58.416Z] [138/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\knfsshare.cpp.obj
[2020-05-10T08:00:58.416Z] [139/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\davjob.cpp.obj
[2020-05-10T08:00:58.416Z] [140/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\filejob.cpp.obj
[2020-05-10T08:00:58.678Z] [141/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\kdiskfreespaceinfo.cpp.obj
[2020-05-10T08:00:58.678Z] [142/731] Building CXX object
src\core\CMakeFiles\KF5KIOCore.dir\directorysizejob.cpp.obj
[2020-05-10T08:00:58.678Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(406):
warning C4996: 'QSet::toList': Use values() instead.
[2020-05-10T08:00:58.678Z] with
[2020-05-10T08:00:58.678Z] [
[2020-05-10T08:00:58.678Z] T=KFileItem
[2020-05-10T08:00:58.678Z] ]
[2020-05-10T08:00:58.678Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(251):
note: see declaration of 'QSet::toList'
[2020-05-10T08:00:58.678Z] with
[2020-05-10T08:00:58.678Z] [
[2020-05-10T08:00:58.678Z] T=KFileItem
[2020-05-10T08:00:58.678Z] ]
[2020-05-10T08:00:58.678Z]
C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qset.h(405):
note: while compiling class template member function 'QList
QList::fromSet(const QSet &)'
[2020-05-10T08:00:58.678Z] with
[2020-05-10T08:00:58.678Z] [
[2020-05-

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Ping :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28379

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg
Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns