D29223: Update Taiwanese holidays

nhiga set the repository for this revision to R175 KHolidays. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham,

Re: kcoreaddons_add_plugin executable/plugin directory conflict

On lundi 11 mai 2020 14:07:28 CEST Friedrich W. H. Kossebau wrote: > Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil: > > Hi all, > > > > I'm moving some plugins in kaddressbook and I ran into a problem with > > > kcoreaddons_add_plugin: > Problem found because you require ECM >=

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:a5692448a750: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string) (authored by kossebau).

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 82612. bport added a comment. Simplify the patch and adapt unittest I expected revertToDefault to revert either to cpp defined default or default from global file, but concept behind is to revert only for cpp based default. REPOSITORY R237 KConfig

D27203: Don't try to open files we can't figure out where they are

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:226 > +//passing non-local files as the working directory is not supported. > +//See

D26066: [KProcessInfo] Add parent PID

dfaure added a comment. Yep, seems fine to me. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26066 To: broulik, #frameworks, davidedmundson Cc: meven, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

dfaure added a comment. What are the values of Context and Type? "Legacy" and "UI" ? I can't see anything in index.theme https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/ REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To:

D29668: Do not reject icon theme dir with invalid context/type.

davidedmundson added a comment. Seems sensible, given it's valid to have an empty context. I don't know enough about icons to know all possible ill effects. If there's no other comments in a few days consider this a "ship it!" REPOSITORY R302 KIconThemes REVISION DETAIL

D29667: Export metalist to json file

cblack updated this revision to Diff 82608. cblack added a comment. Dump output information as well REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29667?vs=82603=82608 BRANCH cblack/metadata (branched from master) REVISION DETAIL

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng added reviewers: dfaure, apol. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng created this revision. xuetianweng added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. xuetianweng requested review of this revision. REVISION SUMMARY For example, gnome's default theme adwaita has their own context type

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 11 May 2020 18:38:33 + Build duration: 1 min 42 sec and counting JUnit Tests Name:

D29292: Port KKeySequenceItem to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c730edc8dce4: Port KKeySequenceItem to QQC2 (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29292?vs=81557=82604 REVISION DETAIL

D29123: Do not mark entry as uninstalled if uninstallation script failed

This revision was automatically updated to reflect the committed changes. Closed by commit R304:a2ecdd333c49: Do not mark entry as uninstalled if uninstallation script failed (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29667: Export metalist to json file

cblack created this revision. cblack added a reviewer: ochurlaud. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This will allow tooling to better introspect the

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex marked 4 inline comments as done. REPOSITORY R304 KNewStuff BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella updated this revision to Diff 82600. nicolasfella added a comment. - Use array REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29390?vs=81821=82600 BRANCH fallback REVISION DETAIL https://phabricator.kde.org/D29390 AFFECTED FILES

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > I just realized that function is private, not really easy to use :/ > > anyhow do you think we should remove svgz? > > Also i think using > > const QStringList extensions = { QStringLiteral(".png"), >

D29631: [android] Allow specifying APK install location

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a70e9a0162f7: [android] Allow specifying APK install location (authored by nicolasfella). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29357: Display rich text notification messages on Android

vkrause retitled this revision from "Display rich text notification messages on Android (API level 24+)" to "Display rich text notification messages on Android". REPOSITORY R289 KNotifications BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause, tfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

vkrause updated this revision to Diff 82566. vkrause added a comment. Support API level < 24 as well. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29357?vs=81729=82566 BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357

D29634: sftp: break large writes into multiple requests

feverfew added a comment. Seems like something similar should also occur in `FileJob::write`? INLINE COMMENTS > kio_sftp.cpp:1831-1832 > +while (offset < buffer.size()) { > +const auto length = qMin(MAX_XFER_BUF_SIZE, > buffer.size()); > +ssize_t

D29631: [android] Allow specifying APK install location

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH androinstall REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem,

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixbuildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D29634: sftp: break large writes into multiple requests

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY servers have arbitrary limits that we should stay below. to ensure

D29631: [android] Allow specifying APK install location

nicolasfella updated this revision to Diff 82531. nicolasfella added a comment. - Rename variable REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29631?vs=82527=82531 BRANCH androinstall REVISION DETAIL https://phabricator.kde.org/D29631

D29631: [android] Allow specifying APK install location

nicolasfella marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D27203: Don't try to open files we can't figure out where they are

meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:226 > +//passing non-local files as the working directory is not supported. > +//See QFileDialogPrivate::initialSelections > +

D29631: [android] Allow specifying APK install location

apol added a comment. +1 overall, good idea. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

apol added inline comments. INLINE COMMENTS > Android.cmake:93 > # > -# The APK would then be found in ``myapp_build_apk/bin`` in the build > directory. > +# You can specify the APK output directory by setting > ANDROID_APK_INSTALL_DIR. > +# Otherwise the APK can be found in

D18883: Add PDF thumbnailer

meven added a comment. In D18883#424888 , @aacid wrote: > Also do we have a way to limit thumbnailers to run say for X seconds? There's some files in which poppler will run "forever" kio-extras thumbnail is a an ioslave so I guess we can

D29631: [android] Allow specifying APK install location

nicolasfella added a comment. This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel,

D27203: Don't try to open files we can't figure out where they are

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=408174? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir Cc: ngraham, plasma-devel, Orage,

D27203: Don't try to open files we can't figure out where they are

ngraham added reviewers: meven, ahmadsamir. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27203: Don't try to open files we can't figure out where they are

ngraham added a reviewer: dfaure. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29631: [android] Allow specifying APK install location

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, Android, apol, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This allows

D29575: holidayregion.cpp - provide translatable strings for the German regions.

This revision was automatically updated to reflect the committed changes. Closed by commit R175:7f7533260efc: holidayregion.cpp - provide translatable strings for the German regions. (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D18883: Add PDF thumbnailer

ngraham added a comment. Yeah, seems like this got bikeshedded to death but I think it would still be quite worthwhile to have. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: meven, bruns, dhaumann, ngraham, pino,

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82520. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: set a constant variables. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82517=82520 BRANCH named_color_support REVISION DETAIL

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n,

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 82519. davidre added a comment. - fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=82492=82519 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D28208 AFFECTED

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrickelectric accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik,

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrickelectric added inline comments. INLINE COMMENTS > kcolorcombo.cpp:67 > // inner color > +QVariant tv = index.data(Qt::DisplayRole); > QVariant cv = index.data(ColorRole); Missing const. > kcolorcombo.cpp:69 > QVariant cv = index.data(ColorRole); > +QColor

D26066: [KProcessInfo] Add parent PID

meven added subscribers: dfaure, meven. meven added a comment. In D26066#598036 , @broulik wrote: > Am now using ksysguard.. I think this would makes sense, and is a nice addition to `KProcessInfo`. @dfaure an opinion ? REPOSITORY

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 2 inline comments as done. araujoluis added inline comments. INLINE COMMENTS > cblack wrote in kcolorcombo.cpp:90 > I would probably do what Kirigami does for `ColorUtils::brightnessForColor` > here: `((0.299 * color.red() + 0.587 * color.green() + 0.114 * color.blue()) > /

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82517. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix paint font colors and simplify painting REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82484=82517 BRANCH named_color_support

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Re: kcoreaddons_add_plugin executable/plugin directory conflict

Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil: > Hi all, > > I'm moving some plugins in kaddressbook and I ran into a problem with > kcoreaddons_add_plugin: Problem found because you require ECM >= 5.38, triggering the use of the CMAKE_BUILD_DIR/bin as executable artifact

D28460: Add KCModuleData as base class for plugin

meven added inline comments. INLINE COMMENTS > kcmoduledata.h:35 > + * > + * @since 5.70 > + */ @since 5.71 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28460: Add KCModuleData as base class for plugin

meven added inline comments. INLINE COMMENTS > kcmoduleloader.h:113 > + * > + * @since 5.69 > + */ @since 5.71 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29575: holidayregion.cpp - provide translatable strings for the German regions.

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

ahiemstra added inline comments. INLINE COMMENTS > SpinBox.qml:54 > +// Because we're stomping the Text Input's own mouse handling > +textField.forceActiveFocus() > +} You can do `mouse.accepted = false` instead of forceActiveFocus to allow the mouse

D29357: Display rich text notification messages on Android (API level 24+)

z3ntu added a comment. I don't see a reason why rich text should be limited to API24+? Yes, the `fromHtml(String source, int flags)` method is API 24+ but for APIs lower than that you can use `fromHtml(String source)` as for example wrapped in `androidx.core.text.HtmlCompat`: /**

kcoreaddons_add_plugin executable/plugin directory conflict

Hi all, I'm moving some plugins in kaddressbook and I ran into a problem with kcoreaddons_add_plugin: I have this in the plugin CMakeLists.txt: kaddressbook_add_plugin( kaddressbook_importexportvcardplugin JSON kaddressbook_importexportvcardplugin.json SOURCES

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 82492. davidre added a comment. - Rebase without test REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78982=82492 BRANCH sni (branched from master) REVISION DETAIL