D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-26 Thread Méven Car 
meven updated this revision to Diff 83162.
meven added a comment.


  Update to new Solid::Device::DisplayName

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26113?vs=79277=83162

BRANCH
  arcpatch-D26113

REVISION DETAIL
  https://phabricator.kde.org/D26113

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Méven Car 
meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D29461

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29814: Fix segfault on no restart args

2020-05-26 Thread Jiří Paleček 
jpalecek added a reviewer: dfaure.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29814

To: jpalecek, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

2020-05-26 Thread Jiří Paleček 
jpalecek added a reviewer: dfaure.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks, dfaure
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

D29809: Don't invoke qstring localized stuff in critical section

2020-05-26 Thread Jiří Paleček 
jpalecek added a reviewer: dfaure.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29809

To: jpalecek, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

2020-05-26 Thread Jiří Paleček 
jpalecek added inline comments.

INLINE COMMENTS

> bruns wrote in kcrash.cpp:698
> `std::copy_if`, instead of a separate `remove_if` pass.

Thanks for that suggestion, updated accordingly. I admit I'm still more 
accustomed to the old ways of `remove_if`.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

D29810: Don't use the setenv function after fork

2020-05-26 Thread Jiří Paleček 
jpalecek updated this revision to Diff 83160.
jpalecek marked an inline comment as done.
jpalecek added a comment.


  Change remove_if and copy to copy_if, per suggestion

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29810?vs=83137=83160

BRANCH
  for-upstream

REVISION DETAIL
  https://phabricator.kde.org/D29810

AFFECTED FILES
  src/kcrash.cpp

To: jpalecek, #frameworks
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

D29668: Do not reject icon theme dir with invalid context/type.

2020-05-26 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kicontheme.cpp:761
>  } else if (tmp.isEmpty()) {
>  // do nothing. key not required
>  } else {

(OK, if this key is not required then surely unknown values are fine too..)

> kicontheme.cpp:774
>  qWarning() << "Invalid Type=" << tmp << "line for icon theme: " << 
> constructFileName(QString());
> -return;
> +mType = KIconLoader::Threshold;
>  }

So, if index.theme says `Type=Fixed`, why did you change this line? It should 
work without this second change, only the first one seems useful.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal 
brute4s99 added a comment.


  updated libssh to use version 0.9.4 by default in Craft. We can merge this 
and get  for kio-extras builds. \o/

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal 
brute4s99 marked an inline comment as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Still Unstable!

2020-05-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/19/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 26 May 2020 19:31:35 +
 Build duration:
51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal 
brute4s99 marked 3 inline comments as done.
brute4s99 added inline comments.

INLINE COMMENTS

> vonreth wrote in CMakeLists.txt:26
> yes pls update libssh

Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 
release as parent revision to this revision, please take a look. ^_^

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal 
brute4s99 added a dependency: D29835: Add libssh 0.9.4 to fix kio-extras on 
windows.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29461

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal 
brute4s99 updated this revision to Diff 83159.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29461?vs=82069=83159

BRANCH
  arcpatch-D29461

REVISION DETAIL
  https://phabricator.kde.org/D29461

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, vonreth, meven
Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

2020-05-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/96/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 26 May 2020 15:48:39 +
 Build duration:
4 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.71.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)47%
(740/1558)33%
(264/804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)78%
(131/167)53%
(52/98)src90%
(9/10)90%
(9/10)50%
(609/1214)35%
(212/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/133)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Still Unstable!

2020-05-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/20/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 26 May 2020 15:48:38 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-05-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/19/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 26 May 2020 15:48:38 +
 Build duration:
2 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.71.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)48%
(742/1559)33%
(265/804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)78%
(131/167)53%
(52/98)src90%
(9/10)90%
(9/10)50%
(611/1214)35%
(213/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/134)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

D29668: Do not reject icon theme dir with invalid context/type.

2020-05-26 Thread Xuetian Weng 
xuetianweng added a comment.


  In D29668#669069 , @dfaure wrote:
  
  > What are the values of Context and Type?
  >
  > "Legacy" and "UI" ?
  >
  > I can't see anything in index.theme 
https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/
  
  
  Yes, legacy and ui.
  
  [8x8/legacy]
  Context=Legacy
  Size=8
  Type=Fixed

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29668: Do not reject icon theme dir with invalid context/type.

2020-05-26 Thread Xuetian Weng 
xuetianweng added a comment.


  You can try to install one from your distro to check the actual content. 
index.theme is generated during the "configure & make".

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-26 Thread Volker Krause 
vkrause added a comment.


  PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 
missing I think.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D29747

To: kossebau, #frameworks, svuorela, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 28 - Still Unstable!

2020-05-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/28/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 26 May 2020 12:13:26 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

Re: Recent breakage in kwallet

2020-05-26 Thread Harald Sitter 
here's my understanding of the problem:

firstly, this is likely only a problem on debian-derived systems. and
also only with blowfish

debian has this patch [1] which on *actual* little endian systems
(x86,arm64...) would run the conditional branches. the thing to note
is that not only QBO is defined but also the ifs get changed. so, on
LE systems that original patch was behaving the same as the QBO==QBE
check (with both undefined) in kwallet proper. on BE systems however
the conditional aren't run and so the output is different between us
(kf5) and them (debian-derived system).
so far so messy.

what I think was the trouble Marco mentioned is that the original
debian patch was badly merged with the change David made. specifically
because of the changed conditionals, QBO must not be hardcoded with
that patch as that'd make QBO!=QLE and fail the conditionals below
thus change behavior.

in short: I don't think David's commit broke anything. I've also made
a potential fix for the actual bug in neon just now.

also about [2] I'm sure that's not quite right because it breaks
things the other way around (i.e. for it to work it'd also have to
change the conditionals from QBO==QBE to QBO==QLE, same as the debian
patch). and that would technically break wallets on big endian
architectures (not that I'm sure we have many users on those). the way
I see it kwallet can never be properly endian aware as it'd break
legacy compatibility. equally debian can never not have the patch
because it'd then no longer be properly endian aware and break its
legacy compatibility well, of course either could decide that big
endian isn't important enough and either become endian aware, or
endian unaware ;)

[1] 
https://packaging.neon.kde.org/kde/kwallet.git/commit/debian/patches/blowfish_endianess.diff?id=188ca124c69902e4fba01d2af6b419e1aac71177
[2] https://invent.kde.org/frameworks/kwallet/-/merge_requests/1

Re: Recent breakage in kwallet

2020-05-26 Thread David Faure 
Thanks for the pointer.

Pretty sure it's wrong, but I'll reply there.

On mardi 26 mai 2020 09:31:26 CEST Marco Martin wrote:
> would the recent patch
> https://invent.kde.org/frameworks/kwallet/-/merge_requests/1
> fix anything?
> 
> On Sat, May 16, 2020 at 10:40 AM David Faure  wrote:
> > On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote:
> > > Hi all,
> > > Recently, the package of KWallet framework for neon (devel unstable,
> > > package built out of current master state) seems to be broken: kwallet
> > > now can't open anymore wallets previously created (it works if the
> > > local kwallet data is deleted and recreated)
> > > the weird thing is that it seems that with a manual build it works
> > > instead.
> > > The only kinda suspicious commit is
> > > 850219f83e7d746 fix compilation with -Werror=undef
> > > which seems to fix.. big endian for everyone?
> > 
> > It was supposed to only fix compiler warnings without changing behaviour
> > at
> > all.
> > 
> > #if Q_BYTE_ORDER == Q_BIG_ENDIAN
> > when neither is defined, evaluates to #if 0 == 0  (and warns)
> > 
> > I defined both to 1, for the same result, but so that -Wundef doesn't
> > warn.
> > 
> > > still no idea why is broken only the distro-built package
> > 
> > Any neon-specific patches to kwallet?
> > 
> > --
> > David Faure, fa...@kde.org, http://www.davidfaure.fr
> > Working on KDE Frameworks 5


-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Recent breakage in kwallet

2020-05-26 Thread Marco Martin 
would the recent patch
https://invent.kde.org/frameworks/kwallet/-/merge_requests/1
fix anything?

On Sat, May 16, 2020 at 10:40 AM David Faure  wrote:
>
> On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote:
> > Hi all,
> > Recently, the package of KWallet framework for neon (devel unstable,
> > package built out of current master state) seems to be broken: kwallet
> > now can't open anymore wallets previously created (it works if the
> > local kwallet data is deleted and recreated)
> > the weird thing is that it seems that with a manual build it works instead.
> > The only kinda suspicious commit is
> > 850219f83e7d746 fix compilation with -Werror=undef
> > which seems to fix.. big endian for everyone?
>
> It was supposed to only fix compiler warnings without changing behaviour at
> all.
>
> #if Q_BYTE_ORDER == Q_BIG_ENDIAN
> when neither is defined, evaluates to #if 0 == 0  (and warns)
>
> I defined both to 1, for the same result, but so that -Wundef doesn't warn.
>
> > still no idea why is broken only the distro-built package
>
> Any neon-specific patches to kwallet?
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

D29832: Fix Endianness issue during wallet decryption

2020-05-26 Thread Chris Coetzee 
chriscz added a comment.


  Hi @ngraham Thanks for letting me know! I've opened the PR over on gitlab: 
https://invent.kde.org/frameworks/kwallet/-/merge_requests/1. It must be quite 
a mission getting everyone over to new platforms  

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure, aacid
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-05-26 Thread Tobias Junghans 
junghans added a comment.


  Thank you for committing! Although I recently gained push rights, I did not 
have time yet to dig into the details of how to create/push commit respecting 
the KDE standards etc. Next time, I'll try on my own :)

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D29003

To: junghans, kossebau, dfaure, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns