D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. please target `release/20.04` for this fix, thanks INLINE COMMENTS > djvucreator.cpp:52-54 > + if (QStandardPaths::findExecutable(QStringLiteral("ddjvu")).isEmpty()) { > + return false; > + } extra brackets REPOSITORY R320 KIO Extras REVISION DETAIL

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. > FIXED-IN: 20.08 still for 20.08... REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio,

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH arcpatch-D26113 REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham, dfaure Cc: dfaure, feverfew, bruns, broulik,

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

meven closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham, dfaure Cc: dfaure, feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D3835: [Calendar] Populate overview models on-demand

meven accepted this revision as: meven. meven added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. @broulik is it still on the table ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3835 To:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 144 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/144/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 11:21:58 + Build duration: 7 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 643 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/643/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 11:21:57 + Build duration: 7 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 642 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/642/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 10:23:29 + Build duration: 5 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/143/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 10:23:46 + Build duration: 5 min 55 sec and counting BUILD ARTIFACTS

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in djvucreator.cpp:52-54 > extra brackets I'd like to use instead the Framework coding style to improve homogenizing coding styles.

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven updated this revision to Diff 83177. meven marked an inline comment as done. meven added a comment. Remove brackets REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83018=83177 BRANCH arcpatch-D29805 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/145/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 11:21:57 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added inline comments. INLINE COMMENTS > meven wrote in djvucreator.cpp:52-54 > I'd like to use instead the Framework coding style to improve homogenizing > coding styles. > https://community.kde.org/Policies/Frameworks_Coding_Style#Braces this code does not follow that style, so please

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 144 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/144/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 10:15:57 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. In D29805#674205 , @meven wrote: > In D29805#674204 , @pino wrote: > > > > FIXED-IN: 20.08 > > > > still for 20.08... > > > Yes kio-extra is released with KDE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/142/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 10:15:57 + Build duration: 7 min 46 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 641 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/641/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 10:15:57 + Build duration: 7 min 29 sec and counting BUILD ARTIFACTS

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. In D29805#674204 , @pino wrote: > > FIXED-IN: 20.08 > > still for 20.08... Yes kio-extra is released with KDE Applications REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/146/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 14:12:08 + Build duration: 6 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 645 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/645/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 14:11:59 + Build duration: 5 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/148/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 15:02:23 + Build duration: 11 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/149/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 15:28:33 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D10856: [WIP] Make tests compile, except one

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned, no movement in over two years. @michaelh did you still want to introduce docId instead of quint64? This diff was supposed to supplant D10851 but seems to have

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. In D29805#674225 , @pino wrote: > In D29805#674218 , @meven wrote: > > > In D29805#674206 , @pino wrote: > > > > > In

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/145/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 14:04:33 + Build duration: 7 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 644 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/644/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 14:04:33 + Build duration: 7 min 25 sec and counting BUILD ARTIFACTS

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. In D29805#674218 , @meven wrote: > In D29805#674206 , @pino wrote: > > > In D29805#674205 , @meven wrote: > > > > > In

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 13:59:18 + Build duration: 5 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/18/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 13:59:18 + Build duration: 6 min 5 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 647 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/647/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 15:28:33 + Build duration: 7 min 33 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/148/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 15:28:33 + Build duration: 7 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/150/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 16:26:23 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D10851: autotests: Introduce alias DocId

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned, no movement in over two years. @michaelh do you want to explicitly abandon this one, so we have a clean slate for invent? None of the docId type changes seem to have made it to master (see also

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/149/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 16:26:23 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 648 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/648/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 16:26:23 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/146/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 14:04:33 + Build duration: 9 min 48 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/147/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 30 May 2020 14:14:25 + Build duration: 8 min 59 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 646 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/646/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 May 2020 15:02:23 + Build duration: 4 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/147/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 30 May 2020 15:02:23 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. In D29805#674206 , @pino wrote: > In D29805#674205 , @meven wrote: > > > In D29805#674204 , @pino wrote: > > > > > > FIXED-IN:

D10825: [WIP] Introduce aliases DocId, DeviceId and Inode

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10825 To: michaelh, adridg, #baloo, #frameworks Cc:

D10826: [WIP] Introduce DocumentId class

adridg added a comment. Herald added a subscriber: kde-frameworks-devel. This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10826 To: michaelh, adridg, #baloo, #frameworks Cc: