D28745: Skip caching thumbnails on encrypted filesystems
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> marcingu wrote in thumbnail.cpp:776
> No. The m_thumbnailDirDeviceId is set to 0 and only changed if lstat executes
> properly. Then it takes value of st_dev. I don't know if st_dev can be 0
> though and I couldn't find this information in manual either. If it can, we
> should change it.
I don't see how stat would succeed and st_dev would be 0, but I could be wrong.
Maybe assert that it's not 0, at least?
> thumbnail.cpp:779
> +if (lstat(QFile::encodeName(m_thumbBasePath).data(), &baseStat) ==
> -1) {
> +qCWarning(KIO_THUMBNAIL_LOG) << "Cannot read information about
> filesystem";
> +return false;
print out the path in the warning (same on line 786)
> thumbnail.cpp:785
> +struct stat fileStat;
> +if(lstat(QFile::encodeName(path).data(), &fileStat) == -1) {
> +qCWarning(KIO_THUMBNAIL_LOG) << "Cannot read information about
> filesystem";
missing space after `if`
s/data/constData/
> thumbnail.h:93
> qint64 m_maxFileSize;
> +dev_t m_thumbnailDirDeviceId = 0;
> };
This will break compilation on Windows, I assume?
On Unix, is the corresponding include present in this file? The lack of context
makes reviewing difficult indeed. Any chance to move this to gitlab? (see
invent.kde.org)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel,
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun,
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
Syntax-Highlighter questions
Hi, a while back I needed syntax-highlighting in a QML based application. Since I could not find some QML support for syntax-highlighter, I wrote a wrapper library [1]. That worked perfectly fine but now that I wrote an example (screenshot in [1]) unexpected behaviour pops up. The example is different because it can set highlighter's definition and theme during runtime which were set once statically in the initial application. Now my issue/question: Highlight definition: Although SyntaxHighlighter::setDefinition calls rehighlight(), the content of the text field remains unchanged. By changing the size of the window, the new highlighting is drawn. Do you have any suggestions what can be done to fix that? Hoping for cure :) and thanks in advance, Andreas [1] https://github.com/schnitzeltony/ksyntax-highlighting-wrapper
Re: KIO on Android Failure
On mardi 18 août 2020 13:52:50 CEST Ben Cooksley wrote: > Hi all, > > At some point recently functionality was added to KIO which broke the > build on Android. Is there any reason why Android doesn't appear at https://build.kde.org/job/Frameworks/job/kio/ ? This is the reason why I didn't notice this problem. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 119 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/119/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 19 Aug 2020 11:14:59 + Build duration: 10 min and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.applicationlauncherjob_forkingtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
Re: KIO on Android Failure
On Wed, Aug 19, 2020 at 3:01 AM Ahmad Samir wrote: > > On 18/08/2020 13:52, Ben Cooksley wrote: > > Hi all, > > > > At some point recently functionality was added to KIO which broke the > > build on Android. > > > > I'm not sure why we're building KIO on Android, but it appears that > > some applications may be using it - and this in turn causes the > > Dependency Build jobs to fail. > > > > Could someone take a look please? > > https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.14%20KF5-SDK/lastFailedBuild/console > > > > Thanks, > > Ben > > > > It looks like it's caused by systemd integration in kprocessrunner; also it > seems Q_OS_UNIX includes > Android systems, so we need to guard it with !defind(Q_OS_ANDROID). Should > hopefully be fixed by > https://invent.kde.org/frameworks/kio/-/merge_requests/107 . > Many thanks for quickly addressing this Ahmad, it's appreciated. Cheers, Ben > -- > Ahmad Samir
