marcingu marked 2 inline comments as done.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel,
waitquietly, azyx,
marcingu updated this revision to Diff 83351.
marcingu added a comment.
Adding path to error logs
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28745?vs=83350=83351
REVISION DETAIL
https://phabricator.kde.org/D28745
AFFECTED FILES
marcingu added inline comments.
INLINE COMMENTS
> meven wrote in thumbnail.cpp:781
> error check here for `!lstat(QFile::encodeName(path).data(), )` is
> important, file might have moved for instance.
Please elaborate, I don't see what the problem is.
REPOSITORY
R320 KIO Extras
REVISION
marcingu marked 2 inline comments as done.
marcingu added inline comments.
INLINE COMMENTS
> dfaure wrote in thumbnail.h:93
> This will break compilation on Windows, I assume?
>
> On Unix, is the corresponding include present in this file? The lack of
> context makes reviewing difficult
marcingu added inline comments.
INLINE COMMENTS
> dfaure wrote in thumbnail.cpp:776
> I don't see how stat would succeed and st_dev would be 0, but I could be
> wrong. Maybe assert that it's not 0, at least?
If st_dev cannot be 0 on successful call of lstat, I don't think there's need
to
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/382/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 20 Aug 2020 18:46:40 +
Build duration:
5 min 43 sec and counting
BUILD ARTIFACTS
Hi,
On torsdag 20 augusti 2020 kl. 01:02:36 EEST Andreas Müller wrote:
> Hi,
>
> a while back I needed syntax-highlighting in a QML based application.
> Since I could not find some QML support for syntax-highlighter, I
> wrote a wrapper library [1]. That worked perfectly fine but now that I
>
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/32/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 20 Aug 2020 18:39:45 +
Build duration:
4 min 22 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/381/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 20 Aug 2020 18:39:45 +
Build duration:
6 min 54 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/34/
Project:
kf5-qt5 SUSEQt5.15
Date of build:
Thu, 20 Aug 2020 19:03:15 +
Build duration:
8 min 38 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/35/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 20 Aug 2020 19:06:18 +
Build duration:
4 min 15 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/33/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 20 Aug 2020 18:44:10 +
Build duration:
4 min 20 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/33/
Project:
kf5-qt5 SUSEQt5.15
Date of build:
Thu, 20 Aug 2020 18:39:45 +
Build duration:
23 min and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/34/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 20 Aug 2020 19:01:55 +
Build duration:
4 min 21 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/384/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 20 Aug 2020 19:08:51 +
Build duration:
5 min 33 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/383/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 20 Aug 2020 19:01:55 +
Build duration:
6 min 55 sec and counting
BUILD ARTIFACTS
On Thu, Aug 20, 2020 at 8:21 PM Kåre Särs wrote:
>
> So the thing is that the text document does not get notified that it needs a
> redraw... how is just adding a 'onDefinitionNameChanged: textArea.append("")'
>
> I tried it and it works, but is that too ugly?
>
Hi Kåre,
thanks for your
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.15/11/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Fri, 21 Aug 2020 00:38:46 +
Build duration:
1 min 37 sec and counting
JUnit Tests
Name:
On Thu, Aug 20, 2020 at 8:00 AM David Faure wrote:
>
> On mardi 18 août 2020 13:52:50 CEST Ben Cooksley wrote:
> > Hi all,
> >
> > At some point recently functionality was added to KIO which broke the
> > build on Android.
>
> Is there any reason why Android doesn't appear at
>
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/120/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 20 Aug 2020 13:07:42 +
Build duration:
4 min 47 sec and counting
JUnit Tests
Name:
20 matches
Mail list logo
