D28745: Skip caching thumbnails on encrypted filesystems
marcingu marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
D28745: Skip caching thumbnails on encrypted filesystems
marcingu updated this revision to Diff 83351. marcingu added a comment. Adding path to error logs REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=83350=83351 REVISION DETAIL https://phabricator.kde.org/D28745 AFFECTED FILES thumbnail/thumbnail.cpp thumbnail/thumbnail.h To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
D28745: Skip caching thumbnails on encrypted filesystems
marcingu added inline comments. INLINE COMMENTS > meven wrote in thumbnail.cpp:781 > error check here for `!lstat(QFile::encodeName(path).data(), )` is > important, file might have moved for instance. Please elaborate, I don't see what the problem is. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
D28745: Skip caching thumbnails on encrypted filesystems
marcingu marked 2 inline comments as done. marcingu added inline comments. INLINE COMMENTS > dfaure wrote in thumbnail.h:93 > This will break compilation on Windows, I assume? > > On Unix, is the corresponding include present in this file? The lack of > context makes reviewing difficult indeed. Any chance to move this to gitlab? > (see invent.kde.org) On Windows this check is assumed false. So in case encrypted file shares filesystem with thumbnails directory, it can take longer as those won't be cached, but it will work. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
D28745: Skip caching thumbnails on encrypted filesystems
marcingu added inline comments. INLINE COMMENTS > dfaure wrote in thumbnail.cpp:776 > I don't see how stat would succeed and st_dev would be 0, but I could be > wrong. Maybe assert that it's not 0, at least? If st_dev cannot be 0 on successful call of lstat, I don't think there's need to change anything. m_thumbnailDirDeviceId will remain zero only if lstat returns error and as long it's zero sharesFilesystemWithThumbRoot will return false. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 382 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/382/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 20 Aug 2020 18:46:40 + Build duration: 5 min 43 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5TextEditor-5.74.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.74.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report79% (22/28)86% (263/305)86% (263/305)68% (33506/49327)50% (15100/30147)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (38/38)100% (38/38)94% (4873/5171)49% (1824/3690)autotests.src.vimode100% (9/9)100% (9/9)99% (5543/5585)58% (984/1708)src.buffer88% (15/17)88% (15/17)90% (1701/1893)75% (1099/1464)src.completion100% (11/11)100% (11/11)57% (1788/3136)42% (1009/2425)src.completion.expandingtree100% (3/3)100% (3/3)40% (182/457)21% (73/340)src.dialogs0% (0/4)0% (0/4)0% (0/868)0% (0/184)src.document100% (4/4)100% (4/4)61% (1948/3182)48% (1422/2947)src.export0% (0/4)0% (0/4)0% (0/121)0% (0/156)src.include.ktexteditor78% (14/18)78% (14/18)90% (205/227)65% (146/226)src.inputmode100% (8/8)100% (8/8)63% (192/304)51% (39/77)src.mode88% (7/8)88% (7/8)36% (378/1051)16% (146/891)src.part0% (0/1)0% (0/1)0% (0/7)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/862)0% (0/278)src.render100% (8/8)100% (8/8)77% (950/1227)67% (610/914)src.schema22% (2/9)22% (2/9)1% (19/1472)1% (6/625)src.script94% (16/17)94% (16/17)69% (717/1040)56% (227/409)src.search100%
Re: Syntax-Highlighter questions
Hi,
On torsdag 20 augusti 2020 kl. 01:02:36 EEST Andreas Müller wrote:
> Hi,
>
> a while back I needed syntax-highlighting in a QML based application.
> Since I could not find some QML support for syntax-highlighter, I
> wrote a wrapper library [1]. That worked perfectly fine but now that I
> wrote an example (screenshot in [1]) unexpected behaviour pops up. The
> example is different because it can set highlighter's definition and
> theme during runtime which were set once statically in the initial
> application.
>
> Now my issue/question:
> Highlight definition: Although SyntaxHighlighter::setDefinition calls
> rehighlight(), the content of the text field remains unchanged. By
> changing the size of the window, the new highlighting is drawn. Do you
> have any suggestions what can be done to fix that?
>
> Hoping for cure :) and thanks in advance,
So the thing is that the text document does not get notified that it needs a
redraw... how is
just adding a 'onDefinitionNameChanged: textArea.append("")'
I tried it and it works, but is that too ugly?
Nice wrapper tho... :)
/Kåre
>
> Andreas
>
>
> [1] https://github.com/schnitzeltony/ksyntax-highlighting-wrapper
KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 32 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/32/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 20 Aug 2020 18:39:45 + Build duration: 4 min 22 sec and counting JUnit Tests Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 381 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/381/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 20 Aug 2020 18:39:45 + Build duration: 6 min 54 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5TextEditor-5.74.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.74.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report79% (22/28)86% (263/305)86% (263/305)68% (33506/49327)50% (15100/30147)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (38/38)100% (38/38)94% (4873/5171)49% (1824/3690)autotests.src.vimode100% (9/9)100% (9/9)99% (5543/5585)58% (984/1708)src.buffer88% (15/17)88% (15/17)90% (1701/1893)75% (1099/1464)src.completion100% (11/11)100% (11/11)57% (1788/3136)42% (1009/2425)src.completion.expandingtree100% (3/3)100% (3/3)40% (182/457)21% (73/340)src.dialogs0% (0/4)0% (0/4)0% (0/868)0% (0/184)src.document100% (4/4)100% (4/4)61% (1948/3182)48% (1423/2947)src.export0% (0/4)0% (0/4)0% (0/121)0% (0/156)src.include.ktexteditor78% (14/18)78% (14/18)90% (205/227)65% (146/226)src.inputmode100% (8/8)100% (8/8)63% (192/304)51% (39/77)src.mode88% (7/8)88% (7/8)36% (378/1051)16% (146/891)src.part0% (0/1)0% (0/1)0% (0/7)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/862)0% (0/278)src.render100% (8/8)100% (8/8)77% (950/1227)67% (610/914)src.schema22% (2/9)22% (2/9)1% (19/1472)1% (6/625)src.script94% (16/17)94% (16/17)69% (717/1040)56% (227/409)src.search100%
KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 34 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/34/ Project: kf5-qt5 SUSEQt5.15 Date of build: Thu, 20 Aug 2020 19:03:15 + Build duration: 8 min 38 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5TextEditor-5.74.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.74.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report79% (22/28)85% (260/305)85% (260/305)67% (33120/49304)49% (14868/30143)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src97% (37/38)97% (37/38)93% (4828/5166)49% (1817/3690)autotests.src.vimode100% (9/9)100% (9/9)99% (5543/5585)58% (984/1708)src.buffer88% (15/17)88% (15/17)89% (1678/1893)74% (1078/1464)src.completion100% (11/11)100% (11/11)57% (1788/3136)42% (1009/2425)src.completion.expandingtree100% (3/3)100% (3/3)40% (182/457)21% (73/340)src.dialogs0% (0/4)0% (0/4)0% (0/868)0% (0/184)src.document100% (4/4)100% (4/4)61% (1942/3182)48% (1411/2947)src.export0% (0/4)0% (0/4)0% (0/121)0% (0/156)src.include.ktexteditor78% (14/18)78% (14/18)83% (189/227)55% (125/226)src.inputmode100% (8/8)100% (8/8)63% (192/304)51% (39/77)src.mode88% (7/8)88% (7/8)36% (378/1051)16% (146/891)src.part0% (0/1)0% (0/1)0% (0/7)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/862)0% (0/278)src.render100% (8/8)100% (8/8)77% (950/1227)67% (610/914)src.schema22% (2/9)22% (2/9)1% (19/1472)1% (6/625)src.script94% (16/17)94% (16/17)68%
KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 35 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/35/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 20 Aug 2020 19:06:18 + Build duration: 4 min 15 sec and counting JUnit Tests Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 33 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/33/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 20 Aug 2020 18:44:10 + Build duration: 4 min 20 sec and counting JUnit Tests Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 33 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/33/ Project: kf5-qt5 SUSEQt5.15 Date of build: Thu, 20 Aug 2020 18:39:45 + Build duration: 23 min and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5TextEditor-5.74.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.74.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalFailed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report79% (22/28)85% (260/305)85% (260/305)67% (33120/49304)49% (14868/30143)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src97% (37/38)97% (37/38)93% (4828/5166)49% (1817/3690)autotests.src.vimode100% (9/9)100% (9/9)99% (5543/5585)58% (984/1708)src.buffer88% (15/17)88% (15/17)89% (1678/1893)74% (1078/1464)src.completion100% (11/11)100% (11/11)57% (1788/3136)42% (1009/2425)src.completion.expandingtree100% (3/3)100% (3/3)40% (182/457)21% (73/340)src.dialogs0% (0/4)0% (0/4)0% (0/868)0% (0/184)src.document100% (4/4)100% (4/4)61% (1942/3182)48% (1411/2947)src.export0% (0/4)0% (0/4)0% (0/121)0% (0/156)src.include.ktexteditor78% (14/18)78% (14/18)83% (189/227)55% (125/226)src.inputmode100% (8/8)100% (8/8)63% (192/304)51% (39/77)src.mode88% (7/8)88% (7/8)36% (378/1051)16% (146/891)src.part0% (0/1)0% (0/1)0% (0/7)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/862)0% (0/278)src.render100% (8/8)100% (8/8)77% (950/1227)67% (610/914)src.schema22% (2/9)22% (2/9)1% (19/1472)1% (6/625)src.script94% (16/17)94% (16/17)68%
KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 34 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/34/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 20 Aug 2020 19:01:55 + Build duration: 4 min 21 sec and counting JUnit Tests Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 384 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/384/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 20 Aug 2020 19:08:51 + Build duration: 5 min 33 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5TextEditor-5.74.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.74.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report79% (22/28)86% (263/305)86% (263/305)68% (33506/49327)50% (15100/30147)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (38/38)100% (38/38)94% (4873/5171)49% (1824/3690)autotests.src.vimode100% (9/9)100% (9/9)99% (5543/5585)58% (984/1708)src.buffer88% (15/17)88% (15/17)90% (1701/1893)75% (1099/1464)src.completion100% (11/11)100% (11/11)57% (1788/3136)42% (1009/2425)src.completion.expandingtree100% (3/3)100% (3/3)40% (182/457)21% (73/340)src.dialogs0% (0/4)0% (0/4)0% (0/868)0% (0/184)src.document100% (4/4)100% (4/4)61% (1948/3182)48% (1423/2947)src.export0% (0/4)0% (0/4)0% (0/121)0% (0/156)src.include.ktexteditor78% (14/18)78% (14/18)90% (205/227)65% (146/226)src.inputmode100% (8/8)100% (8/8)63% (192/304)51% (39/77)src.mode88% (7/8)88% (7/8)36% (378/1051)16% (146/891)src.part0% (0/1)0% (0/1)0% (0/7)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/862)0% (0/278)src.render100% (8/8)100% (8/8)77% (950/1227)67% (610/914)src.schema22% (2/9)22% (2/9)1% (19/1472)1% (6/625)src.script94% (16/17)94% (16/17)69% (717/1040)56% (227/409)src.search100%
KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 383 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/383/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 20 Aug 2020 19:01:55 + Build duration: 6 min 55 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5TextEditor-5.74.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.74.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.kateindenttest_testRubyName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report79% (22/28)86% (263/305)86% (263/305)68% (33506/49327)50% (15101/30147)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (38/38)100% (38/38)94% (4873/5171)49% (1824/3690)autotests.src.vimode100% (9/9)100% (9/9)99% (5543/5585)58% (984/1708)src.buffer88% (15/17)88% (15/17)90% (1701/1893)75% (1099/1464)src.completion100% (11/11)100% (11/11)57% (1788/3136)42% (1009/2425)src.completion.expandingtree100% (3/3)100% (3/3)40% (182/457)21% (73/340)src.dialogs0% (0/4)0% (0/4)0% (0/868)0% (0/184)src.document100% (4/4)100% (4/4)61% (1948/3182)48% (1423/2947)src.export0% (0/4)0% (0/4)0% (0/121)0% (0/156)src.include.ktexteditor78% (14/18)78% (14/18)90% (205/227)65% (146/226)src.inputmode100% (8/8)100% (8/8)63% (192/304)51% (39/77)src.mode88% (7/8)88% (7/8)36% (378/1051)16% (146/891)src.part0% (0/1)0% (0/1)0% (0/7)100% (0/0)src.printing0% (0/4)0% (0/4)0% (0/862)0% (0/278)src.render100% (8/8)100% (8/8)77% (950/1227)67% (610/914)src.schema22% (2/9)22% (2/9)1% (19/1472)1% (6/625)src.script94% (16/17)94% (16/17)69% (717/1040)56% (227/409)src.search100%
Re: Syntax-Highlighter questions
On Thu, Aug 20, 2020 at 8:21 PM Kåre Särs wrote:
>
> So the thing is that the text document does not get notified that it needs a
> redraw... how is just adding a 'onDefinitionNameChanged: textArea.append("")'
>
> I tried it and it works, but is that too ugly?
>
Hi Kåre,
thanks for your response. It was an inspiring suggestion:
OK I was looking for something that the library does for all
consumers. So I looked into QTextDocument but I found nothing that
looked suitable for a forced redraw.
So I remembered: My code does nothing with the document but passing it
to SyntaxHighlighter on creation. That lead me to the (brute force)
solution: Every time a new definition or theme is set, the highlighter
is destroyed and a new one is created [1]. Maybe ugly from performance
point of view but works fine.
[1]
https://github.com/schnitzeltony/ksyntax-highlighting-wrapper/commit/d556eece45dc65aada51d7c7925a13866188ba22
Thanks again,
Andreas
KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.15 - Build # 11 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.15/11/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Fri, 21 Aug 2020 00:38:46 + Build duration: 1 min 37 sec and counting JUnit Tests Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
Re: KIO on Android Failure
On Thu, Aug 20, 2020 at 8:00 AM David Faure wrote: > > On mardi 18 août 2020 13:52:50 CEST Ben Cooksley wrote: > > Hi all, > > > > At some point recently functionality was added to KIO which broke the > > build on Android. > > Is there any reason why Android doesn't appear at > https://build.kde.org/job/Frameworks/job/kio/ > ? > > This is the reason why I didn't notice this problem. Because a job hasn't been requested for KIO on Android. I'm not sure why it is being included in the Dependency Builds / Docker image builds, as from my understanding Android builds were all using a cut down list of dependencies. We can certainly enable Android CI jobs for KIO though, that is easy enough to do. Cheers, Ben > > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Working on KDE Frameworks 5 > > >
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 120 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/120/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 20 Aug 2020 13:07:42 + Build duration: 4 min 47 sec and counting JUnit Tests Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
