KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 426 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/426/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Mar 2022 13:23:43 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.15 - Build # 444 - Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.15/444/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Tue, 08 Mar 2022 15:09:32 +
 Build duration:
7 min 57 sec and counting
   BUILD ARTIFACTS
  acc/KF5NewStuff-5.92.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.core.knewstuff_installationtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report41%
(7/17)26%
(22/84)26%
(22/84)20%
(1677/8323)11%
(1412/13150)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(58/58)53%
(33/62)autotests.core67%
(2/3)67%
(2/3)41%
(73/180)25%
(37/146)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(225/307)47%
(109/234)src20%
(2/10)20%
(2/10)4%
(22/550)0%
(0/153)src.attica0%
(0/2)0%
(0/2)0%
(0/418)0%
(0/1349)src.core48%
(12/25)48%
(12/25)26%
(733/2858)12%
(870/7263)src.core.jobs0%
(0/7)0%
(0/7)0%
(0/301)0%
(0/647)src.kmoretools60%
(3/5)60%
(3/5)48%
(433/902)33%
(156/472)src.opds0%
(0/1)0%
(0/1)0%
(0/336)0%
(0/1120)src.qtquick0%
(0/12)0%
(0/12)0%
(0/924)0%
(0/468)src.staticxml100%
(1/1)100%
(1/1)67%
(133/199)33%
(207/636)src.tools.knewstuff-dialog0%
(0/2)0%
(0/2)0%
(0/84)0%
(0/35)src.ui0%
(0/8)0%
(0/8)0%
(0/781)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/124)0%
(0/154)src.widgets0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/18)tests0%
(0/1)0%
(0/1)0%
(0/98)0%
(0/48)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/142)0%
(0/28)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 427 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/427/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Mar 2022 14:16:10 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.15 - Build # 700 - Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.15/700/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 16:23:39 +
 Build duration:
4 min 3 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectrootC_.CI.Job_Build.autotests.pagepool/tst_layers.qml

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 798 - Fixed!

2022-03-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/798/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Mar 2022 16:23:39 +
 Build duration:
1 hr 11 min and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)

[sysadmin/ci-tooling] local-metadata: Block frameworks/kded on Windows too.

2022-03-08 Thread Ben Cooksley
Git commit 712ed90054285fa02a67c1a6fb92b66fc440146f by Ben Cooksley.
Committed on 08/03/2022 at 17:48.
Pushed by bcooksley into branch 'master'.

Block frameworks/kded on Windows too.

CCMAIL: kde-frameworks-devel@kde.org

M  +1-0local-metadata/project-ignore-rules.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/712ed90054285fa02a67c1a6fb92b66fc440146f

diff --git a/local-metadata/project-ignore-rules.yaml 
b/local-metadata/project-ignore-rules.yaml
index 2f93f05..1430b83 100644
--- a/local-metadata/project-ignore-rules.yaml
+++ b/local-metadata/project-ignore-rules.yaml
@@ -14,6 +14,7 @@
 - 'frameworks/kactivities-stats'
 - 'frameworks/baloo'
 - 'frameworks/kglobalaccel'
+- 'frameworks/kded'
 - 'kde/applications/baloo-widgets'
 - 'kde/workspace/libksysguard'
 - 'kde/kdenetwork/kaccounts-integration'


KF6 meeting notes 2022-03-08

2022-03-08 Thread Volker Krause
Short meeting due to the Plasma 6 spring covering a lot already during the 
weekend.

https://invent.kde.org/frameworks/kwayland/-/merge_requests/52
- blocks kwayland-server/plasma-workspace
- should we maybe as a first step just add the extra folder level and leave 
the upper/lower case split as-is?

KQuickCharts shader tools port:
- Qt6 API to hand data to shaders is extremely basic which complicates the 
porting
- see also Plasma 6 Sprint notes

signature.asc
Description: This is a digitally signed message part.


KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.15 - Build # 702 - Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.15/702/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 20:10:48 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectrootC_.CI.Job_Build.autotests.pagepool/tst_layers.qml

Re: CI Repairs

2022-03-08 Thread Ben Cooksley
On Tue, Mar 8, 2022 at 11:20 PM Volker Krause  wrote:

> On Dienstag, 8. März 2022 08:54:38 CET Ben Cooksley wrote:
> > This evening i've repaired several issues that were causing builds to
> fail
> > on the main Jenkins CI system. This includes a broken Windows builder
> > (causing Windows builds to periodically fail) and a hung FreeBSD builder
> > (which was consuming half a CPU and preventing KWin CI jobs from
> completing)
>
> Thank you! Would that also explain the problems we are seeing with the
> FreeBSD
> seed job?
>

Unfortunately no.

Most of the issues i've seen with the seed jobs on FreeBSD/Windows have
been due to CMake erroring out as a consequence of the platform not being
supported.
I've been fixing those as we hit them (by disabling the build of that
project on that platform)

Looks like FreeBSD passes now.


>
> > Replacement runs have been initiated for all projects.
> >
> > So far all appears well, however a number of projects appear to have CI
> > regressions on one or more platforms due to:
> > - Use of exceptions (KMail)
>
> For this I'm not finding an explanation, it started after a completely
> unrelated merge commit and the exception using code is in an Akonadi
> header
> that is used all over the place.
>
> > - Use of an ECM version that does not exist (print-manager)
>
> Fixed.
>
> > - Use of C++ functionality that is not enabled (okular on Windows)
>
> https://invent.kde.org/graphics/okular/-/merge_requests/582
>
> > - Something to do with qobject_cast (akonadiconsole)
>
> We had similar issues in other modules over the past two weeks or so due
> to
> the include install layout changes not being propagated fully yet. That's
> what
> made me initially look at the FreeBSD seed job.
>
> Regards,
> Volker


Thanks,
Ben


KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 FreeBSDQt5.15 - Build # 333 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20FreeBSDQt5.15/333/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Mar 2022 22:10:23 +
 Build duration:
5 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.tests.KDEFetchTranslationsName: projectroot.tests Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 FreeBSDQt5.15 - Build # 334 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20FreeBSDQt5.15/334/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 08 Mar 2022 22:16:31 +
 Build duration:
3 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.tests.KDEFetchTranslationsName: projectroot.tests Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.15 - Build # 380 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.15/380/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Tue, 08 Mar 2022 22:10:23 +
 Build duration:
4 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.tests.KDEFetchTranslationsName: projectroot.home.jenkins.workspace.Frameworks.extra-cmake-modules Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 76 test(s), Skipped: 0 test(s), Total: 76 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.15 - Build # 701 - Fixed!

2022-03-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.15/701/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 16:27:51 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)

[sysadmin/ci-tooling] local-metadata: Block KGlobalAccel on Windows too.

2022-03-08 Thread Ben Cooksley
Git commit 8d376b50b67f572dab60519a9ce7b3ba3a9f744c by Ben Cooksley.
Committed on 08/03/2022 at 17:13.
Pushed by bcooksley into branch 'master'.

Block KGlobalAccel on Windows too.

CCMAIL: kde-frameworks-devel@kde.org

M  +1-0local-metadata/project-ignore-rules.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/8d376b50b67f572dab60519a9ce7b3ba3a9f744c

diff --git a/local-metadata/project-ignore-rules.yaml 
b/local-metadata/project-ignore-rules.yaml
index f970914..2f93f05 100644
--- a/local-metadata/project-ignore-rules.yaml
+++ b/local-metadata/project-ignore-rules.yaml
@@ -13,6 +13,7 @@
 - 'frameworks/kwayland'
 - 'frameworks/kactivities-stats'
 - 'frameworks/baloo'
+- 'frameworks/kglobalaccel'
 - 'kde/applications/baloo-widgets'
 - 'kde/workspace/libksysguard'
 - 'kde/kdenetwork/kaccounts-integration'


KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.15 - Build # 381 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.15/381/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Tue, 08 Mar 2022 22:14:55 +
 Build duration:
4 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.tests.KDEFetchTranslationsName: projectroot.home.jenkins.workspace.Frameworks.extra-cmake-modules Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 76 test(s), Skipped: 0 test(s), Total: 76 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 1447 - Still Unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/1447/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Wed, 09 Mar 2022 01:44:58 +
 Build duration:
9 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: projectroot.autotests.kiocore_ktcpsockettestFailed: projectroot.autotests.kiogui_openurljobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: CI Repairs

2022-03-08 Thread Volker Krause
On Dienstag, 8. März 2022 08:54:38 CET Ben Cooksley wrote:
> This evening i've repaired several issues that were causing builds to fail
> on the main Jenkins CI system. This includes a broken Windows builder
> (causing Windows builds to periodically fail) and a hung FreeBSD builder
> (which was consuming half a CPU and preventing KWin CI jobs from completing)

Thank you! Would that also explain the problems we are seeing with the FreeBSD 
seed job?

> Replacement runs have been initiated for all projects.
> 
> So far all appears well, however a number of projects appear to have CI
> regressions on one or more platforms due to:
> - Use of exceptions (KMail)

For this I'm not finding an explanation, it started after a completely 
unrelated merge commit and the exception using code is in an Akonadi header 
that is used all over the place.

> - Use of an ECM version that does not exist (print-manager)

Fixed.

> - Use of C++ functionality that is not enabled (okular on Windows)

https://invent.kde.org/graphics/okular/-/merge_requests/582

> - Something to do with qobject_cast (akonadiconsole)

We had similar issues in other modules over the past two weeks or so due to 
the include install layout changes not being propagated fully yet. That's what 
made me initially look at the FreeBSD seed job.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.


KStars on Windows

2022-03-08 Thread Ben Cooksley
Hi Jasem,

Recently some changes were introduced to Frameworks which means that they
now enforce more rigorously the platforms on which they build.

This means that KAuth is no longer available on Windows - unfortunately
though it looks like KStars has a mandatory dependency on KAuth.

Are you able to make this optional or should we disable Windows CI builds
for KStars?

Cheers,
Ben


[sysadmin/ci-tooling] local-metadata: kdelibs4support has a hard dependency on kglobalaccel (not sure why) which is no longer available on Windows.

2022-03-08 Thread Ben Cooksley
Git commit 8e43c6c798e16e45e5cc0ad8f148c0c8df6d5fd9 by Ben Cooksley.
Committed on 09/03/2022 at 07:27.
Pushed by bcooksley into branch 'master'.

kdelibs4support has a hard dependency on kglobalaccel (not sure why) which is 
no longer available on Windows.
Therefore blacklist it on Windows.

CCMAIL: kde-frameworks-devel@kde.org

M  +1-0local-metadata/project-ignore-rules.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/8e43c6c798e16e45e5cc0ad8f148c0c8df6d5fd9

diff --git a/local-metadata/project-ignore-rules.yaml 
b/local-metadata/project-ignore-rules.yaml
index 8f7bf1b..33dd1e3 100644
--- a/local-metadata/project-ignore-rules.yaml
+++ b/local-metadata/project-ignore-rules.yaml
@@ -15,6 +15,7 @@
 - 'frameworks/baloo'
 - 'frameworks/kglobalaccel'
 - 'frameworks/kded'
+- 'frameworks/kdelibs4support'
 - 'kde/applications/baloo-widgets'
 - 'kde/workspace/libksysguard'
 - 'kde/kdenetwork/kaccounts-integration'


[sysadmin/repo-management] hooks: Implement two additional checks as part of our hooks:

2022-03-08 Thread Ben Cooksley
Git commit 919f7163102835d46c81593251fd0689fea71640 by Ben Cooksley.
Committed on 08/03/2022 at 08:13.
Pushed by bcooksley into branch 'master'.

Implement two additional checks as part of our hooks:

1) Require that all *.knsrc file changes be reviewed by a Sysadmin if landing 
in a non-work branch
2) Alert Sysadmin if anyone mentions download.kde.org or files.kde.org in the 
text of their code.

CCMAIL: kde-frameworks-devel@kde.org
CCMAIL: plasma-de...@kde.org

M  +14   -0hooks/hooklib.py
M  +16   -2hooks/invent.pre-receive

https://invent.kde.org/sysadmin/repo-management/commit/919f7163102835d46c81593251fd0689fea71640

diff --git a/hooks/hooklib.py b/hooks/hooklib.py
index 062b0e3..df04d96 100644
--- a/hooks/hooklib.py
+++ b/hooks/hooklib.py
@@ -706,6 +706,10 @@ class CommitEmailNotifier:
 if self.checker and (self.checker.license_problem or 
self.checker.commit_problem):
 cc_addresses.append( self.commit.committer_email )
 
+# Add Sysadmin if infrastructure problems have been found
+if self.checker and self.checker.infra_problem):
+cc_addresses.append( 'sysad...@kde.org' )
+
 if self.keywords['email_gui']:
 cc_addresses.append( 'kde-doc-engl...@kde.org' )
 
@@ -1002,6 +1006,10 @@ class CommitChecker:
 def commit_problem(self):
 return self._commit_problem
 
+@property
+def infra_problem(self):
+return self._infra_problem
+
 @property
 def commit_notes(self):
 return self._commit_notes
@@ -1219,6 +1227,7 @@ class CommitChecker:
 
 # Initialise
 self._license_problem = False
+self._infra_problem = False
 self._commit_problem = False
 self._commit_notes = defaultdict(list)
 
@@ -1261,6 +1270,11 @@ class CommitChecker:
 self._commit_notes[filename].append(note)
 self._commit_problem = True
 
+# Check for references to KDE.org infrastructure which are being 
added without permission
+if re.search(".*(download|files)\.kde\.org.*", line) and 
line.startswith("+"):
+self._commit_notes[filename].append( "[INFRASTRUCTURE]" )
+self._infra_problem = True
+
 # Store the diff
 filediff.append(line)
 
diff --git a/hooks/invent.pre-receive b/hooks/invent.pre-receive
index 75dda6a..537d104 100755
--- a/hooks/invent.pre-receive
+++ b/hooks/invent.pre-receive
@@ -99,6 +99,9 @@ translation_file_rules = [
 '^poqm/.*'
 ]
 
+# These users are authorised to review changes to *.knsrc files
+knsrc_reviewers = ['bcooksley', 'bshah', 'nalvarez']
+
 # For these users we always skip notifications
 notification_user_exceptions = ["scripty"]
 
@@ -355,8 +358,8 @@ for changeset in repository.changesets.values():
 if not os.path.exists(repository_config + "/skip-author-email-checks"):
 auditor.audit_emails_in_metadata( changeset, email_domains_blocked )
 
-   # Depending on who we are, we may also need to check to see whether we are 
changing translations that have been mirrored into the repository
-   # Only specific users are allowed to change these as they are maintained by 
scripty
+# Depending on who we are, we may also need to check to see whether we are 
changing translations that have been mirrored into the repository
+# Only specific users are allowed to change these as they are maintained 
by scripty
 if not os.path.exists(repository_config + "/skip-translation-protections") 
and push_user not in translation_mirror_maintainers:
 # Review each commit for changes to files...
 for commit in changeset.commits.values():
@@ -368,6 +371,17 @@ for changeset in repository.changesets.values():
 if re.match(restriction, filename):
 auditor.log_failure(commit.sha1, "Translations 
maintained separately: " + filename)
 
+# Depending on who we are, we may also need to check to see whether we are 
impacting on a KNSRC file
+# Only specific users are allowed to change these as they can have 
substantial infrastructure implications
+if not os.path.exists(repository_config + "/skip-knsrc-protections") and 
push_user not in knsrc_reviewers and changeset.ref_type is not 
RefType.WorkBranch:
+# Review each commit for changes to files...
+for commit in changeset.commits.values():
+# Now check each file that was changed in that commit...
+for filename in commit.files_changed:
+# Did we change a KNSRC file?
+if re.match(".*knsrc.*", filename):
+auditor.log_failure(commit.sha1, "KNewStuff configuration 
must be Sysadmin reviewed: " + filename)
+
 # Did we have any commit audit failures?
 if auditor.audit_failed:
 print("Push declined - commits failed audit")


KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.15 - Build # 697 - Still unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.15/697/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:40 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.coronatestFailed: projectroot.autotests.plasma_dialogstatetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_themetest

Re: Critical Denial of Service bugs in Discover

2022-03-08 Thread Ben Cooksley
On Mon, Mar 7, 2022 at 1:16 PM Aleix Pol  wrote:

>
> On Sat, Mar 5, 2022 at 8:36 AM Ben Cooksley  wrote:
>
>> On Fri, Mar 4, 2022 at 12:49 AM Aleix Pol  wrote:
>>
>>> I'd say wireshark is too low level for what the problem is here. We are
>>> talking about having too many HTTP requests for specific URLs.
>>>
>>
>> Correct, I guess the difference in our approaches comes from a "before
>> release" to a "monitor after release" angle to things.
>> I'd like to see increased scrutiny during the development process as well
>> to make sure that we release code that operates properly from Day 1.
>>
>
> A way to do this could be using commit hooks that do not allow to reach
> certain services. (which we discussed in private chat).
> We could also analyse at cmake time the knsrc files we install, but this
> has a very limited and specific scope.
>

I've now applied two checks as part of the hooks which will hopefully catch
anything new being introduced.
We still need to ensure that anything pre-existing is sorted out of course.


>
>
>> I can think two main measures:
>>> - Trigger an alarm (an e-mail notification?) if there's a specific
>>> UserAgent that has a specific portion of the queries we have in a specific
>>> day in the services we care about.
>>> - Offer plots to see how queries by UserAgent evolve over the last
>>> couple of months (or couple of years).
>>>
>>
>> At the moment our ability to analyse our logs is somewhat limited by our
>> Privacy Policy - https://kde.org/privacypolicy/
>> Currently we don't have any provision for long term storage of
>> this information even on an aggregated basis - so we would need to update
>> this first.
>>
>
> Hopefully the NDA should help here and it doesn't seem all that far away.
> I know Neofytos and Ade have been working on it lately.
>

The privacy policy will still need to be updated, but that can form part of
the puzzle yes.


>
> The second issue there is that we are transitioning users to contact a CDN
>> based endpoint (which is substantially more scalable).
>> This does mean we lose visibility on data such as User Agents and the
>> URLs being impacted though as we only get aggregated data unless we ask for
>> raw logs - which makes implementing something like what you've described
>> much harder.
>>
>
> That does seem like a stopper. Still, it seems like it's not that big of a
> problem when there is a CDN, so we better worry about the other cases.
>

We should still be reasonable to the CDN of course, but it makes it much
more managable yes.


>
> Aleix
>

Cheers,
Ben


KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.15 - Build # 699 - Fixed!

2022-03-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.15/699/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:44 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)

[sysadmin/ci-tooling] local-metadata: Ensure we do not use frameworks/bluez-qt on FreeBSD

2022-03-08 Thread Ben Cooksley
Git commit fc4c56fed4466c1adf26b570b000edb1791e5e43 by Ben Cooksley.
Committed on 08/03/2022 at 08:59.
Pushed by bcooksley into branch 'master'.

Ensure we do not use frameworks/bluez-qt on FreeBSD

CCMAIL: kde-frameworks-devel@kde.org

M  +1-0local-metadata/project-ignore-rules.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/fc4c56fed4466c1adf26b570b000edb1791e5e43

diff --git a/local-metadata/project-ignore-rules.yaml 
b/local-metadata/project-ignore-rules.yaml
index aa3ac42..36b34c4 100644
--- a/local-metadata/project-ignore-rules.yaml
+++ b/local-metadata/project-ignore-rules.yaml
@@ -22,6 +22,7 @@
 - 'kdesupport/polkit-qt-1'
 - 'frameworks/networkmanager-qt'
 - 'frameworks/modemmanager-qt'
+- 'frameworks/bluez-qt'
 - 'kde/workspace/plymouth-kcm'
 - 'kde/workspace/plasma-nm'
 - 'kde/workspace/plasma-vault'


KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.15 - Build # 191 - Fixed!

2022-03-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.15/191/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:51 +
 Build duration:
1 hr 17 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 495 test(s), Skipped: 0 test(s), Total: 495 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.15 - Build # 607 - Still unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.15/607/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:42 +
 Build duration:
41 min and counting
   JUnit Tests
  Name: projectroot Failed: 10 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 69 test(s)Failed: projectroot.autotests.indentdetect_testFailed: projectroot.autotests.inlinenote_testFailed: projectroot.autotests.katedocument_testFailed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleFailed: projectroot.autotests.kateindenttest_testRubyFailed: projectroot.autotests.katetextbuffertestFailed: projectroot.autotests.kateview_testFailed: projectroot.autotests.messagetestFailed: projectroot.autotests.movingrange_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.15 - Build # 329 - Still unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.15/329/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:43 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.core.knewstuff_installationtest

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.15 - Build # 1261 - Fixed!

2022-03-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.15/1261/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:45 +
 Build duration:
46 min and counting

KDE CI: Frameworks » kdelibs4support » kf5-qt5 WindowsMSVCQt5.15 - Build # 134 - Still unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20WindowsMSVCQt5.15/134/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:48 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot Failed: 11 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kdatetimetestFailed: projectroot.autotests.kdebug_unittestFailed: projectroot.autotests.kdelibs4support_klocaletestFailed: projectroot.autotests.kglobalsettingstestFailed: projectroot.autotests.kglobaltestFailed: projectroot.autotests.klibloadertestFailed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstestFailed: projectroot.autotests.ktimezonestestFailed: projectroot.autotests.kuniqueapptestFailed: projectroot.autotests.kurltest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.15 - Build # 381 - Still unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.15/381/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:49 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kdelibs4configmigratortestFailed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kfileutilstestFailed: projectroot.autotests.knetworkmountstestcanonical

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.15 - Build # 214 - Still unstable!

2022-03-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.15/214/
 Project:
kf5-qt5 WindowsMSVCQt5.15
 Date of build:
Tue, 08 Mar 2022 07:43:50 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.klanguagenametestFailed: projectroot.autotests.kstandardactiontest

[sysadmin/ci-tooling] local-metadata: Block KAuth on Windows.

2022-03-08 Thread Ben Cooksley
Git commit 1322a5f4ae7335bf31a288189a455dff4c34c83c by Ben Cooksley.
Committed on 08/03/2022 at 09:36.
Pushed by bcooksley into branch 'master'.

Block KAuth on Windows.

CCMAIL: kde-frameworks-devel@kde.org

M  +1-0local-metadata/project-ignore-rules.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/1322a5f4ae7335bf31a288189a455dff4c34c83c

diff --git a/local-metadata/project-ignore-rules.yaml 
b/local-metadata/project-ignore-rules.yaml
index 36b34c4..f970914 100644
--- a/local-metadata/project-ignore-rules.yaml
+++ b/local-metadata/project-ignore-rules.yaml
@@ -7,6 +7,7 @@
 - 'frameworks/networkmanager-qt'
 - 'frameworks/modemmanager-qt'
 - 'frameworks/bluez-qt'
+- 'frameworks/kauth'
 - 'frameworks/kdesu'
 - 'frameworks/kpty'
 - 'frameworks/kwayland'