Re: More work available

2012-08-04 Thread Kevin Ottens 
On Saturday 04 August 2012 00:52:16 David Faure wrote:
 On Friday 03 August 2012 13:57:54 Jeremy Whiting wrote:
  Hey David,
 
  I started taking a stab at the KApplication - QApplication
  fix/conversions, then pulled and can't build currently.  I can't tell
  from the last few commits what broke it either.

 I just compiled kdelibs with Qt4 and with Qt5, no errors.

 OK, not a clean build with rm -rf of the install prefix, I'll do this now.

  The error I'm getting
  is about KDE_DEPRECATED in kdecore/config/kconfig.h included from
  ksharedconfig.h

 This typically happens when a KDE4 header is being found instead of a
 kdelibs- framework header.

 Do you have KDE4 headers in /usr/include maybe?
 Is -I/usr/include in the compilation line?  (make VERBOSE=1 to see it). In
 theory this should never happen, but the difference between theory and
 practice is that sometimes things break in practice :-)

Maybe worth putting as a hint on the building page?

Regards.
--
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: libinqt5 - Windows fixes

2012-08-04 Thread Andrius da Costa Ribas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105867/
---

Review request for KDE Frameworks and kdewin.


Description
---

General fixes for Windows build. Replaced some references to Qt5 libraries into 
the Qt4 equivalent ones.


Diffs
-

  libinqt5/src/CMakeLists.txt 99f75e5 
  libinqt5/src/qstandardpaths.cpp f97a861 
  libinqt5/src/qstandardpaths_win.cpp 478e614 
  libinqt5/src/qtemporarydir.cpp 6121a83 

Diff: http://git.reviewboard.kde.org/r/105867/diff/


Testing
---

Build OK with MSVC. No further tests because of other issues with other parts 
of KF5 build.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel