Re: Review Request: KF5 - Q_OS_* not defined
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:25 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Updated patch to fix other occurrences. Description --- Q_OS_WIN Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. Diffs (updated) - kde3support/KDE3SupportMacros.cmake a4f44e2 kdecore/CMakeLists.txt e5cbd19 kded/CMakeLists.txt fb204e8 kdeui/CMakeLists.txt 7849b52 kdeui/KDEUIMacros.cmake d5c20d9 kinit/CMakeLists.txt 3c283a6 tier1/kidletime/src/CMakeLists.txt 973d623 tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd Diff: http://git.reviewboard.kde.org/r/105868/diff/ Testing --- Got undefined references before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request: KF5 - Q_OS_* not defined
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/ --- (Updated Aug. 5, 2012, 10:28 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Oops ... last one had something wrong. Description --- Q_OS_WIN Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. Diffs (updated) - kde3support/KDE3SupportMacros.cmake a4f44e2 kdecore/CMakeLists.txt e5cbd19 kded/CMakeLists.txt fb204e8 kdeui/CMakeLists.txt 7849b52 kdeui/KDEUIMacros.cmake d5c20d9 kinit/CMakeLists.txt 3c283a6 tier1/kidletime/src/CMakeLists.txt 973d623 tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd Diff: http://git.reviewboard.kde.org/r/105868/diff/ Testing --- Got undefined references before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Unit test results
On Sunday 29 July 2012 14:53:47 David Faure wrote: 71 - kdeui-kstartupinfo_unittest (Failed) // hangs. KXMessages::x11Event needs porting to XCB Fixed. 76 - kdeui-ktoolbar_unittest (Failed) // something about the keyboard modifiers in triggered(Qt::MouseButtons,Qt::KeyboardModifiers). Not a real bug, but a testlib issue. In Qt5, QTest::mouseClick doesn't set QApplication::keyboardModifiers anymore. Mail sent to the Qt development list last Monday (and happily ignored by everyone there since then). kuniqueapptest fails too, with recent Qt5, due to QPA processing events too early; reported to the Qt development list too. I'll look at klibloadertest next, and into plugins in general. 102 - kfile-kfileplacesmodeltest (Failed) // again :-( Benjamin, didn't you fix this one once already? (**) 108 - httpheaderdispositiontest (Failed) // 3 failures, utf8 related, needs investigation 116 - kutils-kemoticontest2 (Failed) // Lots of XPASS and one FAIL, needs investigation Any volunteers? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Reviewboard
I tried adding frameworks group to the last review I posted for the cleanup task I just finished, but rb said there's no such group... Jeremy On Fri, Jul 20, 2012 at 10:04 AM, David Faure fa...@kde.org wrote: There is now a frameworks group on reviewboard, which you can use so that reviews are sent to this list. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/ --- (Updated Aug. 6, 2012, 6:53 p.m.) Review request for KDE Frameworks and David Faure. Description --- Port from KApplication KCmdLineArgs to QApplication in unit tests. Diffs - interfaces/terminal/example/main.cc 40c1f01c001a04e1d9ad538a52e4be93a827535d kde3support/tests/itemcontainertest.cpp 3fa45262cf43958118caf6d2c13e3cbe7052adce kde3support/tests/k3listviewtest.cpp fade590e4bb40a8d90555adf930e16dac1c3a2f8 kde3support/tests/k3wizardtest.cpp 39dbd5717c6860af82b19f236b8e951194e875c5 kde3support/tests/kaboutdialogtest.cpp 631144986b33497382ad46d260ae43aca100efbf kde3support/tests/kactivelabeltest.cpp 4653a94cad4276ea44f6436a2baf46e296138136 kde3support/tests/kdocktest.cpp 7a0bd770377e0123e80d1ffb5c633751a96e9e71 kde3support/tests/kdockwidgetdemo.cpp cba54ba922ba259f28c3d6b95379c539a70fed03 kde3support/tests/kdockwidgettest.cpp 8247e21e783506d0f31b13cc739c770a580e2f92 kdeui/tests/kanimatedbuttontest.cpp 9f9d77071e788b8289fd84620aa515bcd40cd621 kdeui/tests/kassistantdialogtest.cpp 9d90824027acc57dd68ad1ab6c946d3ffac67098 kdeui/tests/kbugreporttest.cpp 6b6cd4c6c839e4f462803fd9666042c65a982602 kdeui/tests/kcategorizedviewtest.cpp 5c78e77a0884a02857f8fd898e70efc080e7d708 kdeui/tests/kcharselecttest.cpp b519c542149d2244977d0478a0e2f0edd1edd9b0 kdeui/tests/kcodecactiontest.cpp 6d7004340ffbeef24659a7d654baf13c996ba3d8 kdeui/tests/kcolorcollectiontest.cpp 8262213c94c9318955fc90b4ac4fc69b709cce99 kdeui/tests/kcolordlgtest.cpp 28d52c558a2161209d8fbed70d3bd78d81659bbf kdeui/tests/kcolorutilsdemo.cpp a6bb914b81f7f9b529164bc8faa133580c3c51e4 kdeui/tests/kcomboboxtest.cpp ec453987cd204bc65924ad5bd2c8e58a5ecec390 kdeui/tests/kcompletionuitest.cpp 6ab5444294cfab76b52bbfc4dd53c7e01f7296cf kdeui/tests/kdatepicktest.cpp 620ff7adc0fa815bcd8ca8fdfbc5d16ee964e63b kdeui/tests/kdatetabletest.cpp 43e31d76e260e0a1e63118311874c7cb97f36deb kdeui/tests/kdatetimewidgettest.cpp 39e05c0c6d514ba61c4dd4279a4fd3b31cb0638e kdeui/tests/kdatewidgettest.cpp 2f8b568ffd336fcd5d6d714d606db0ee8db0bc5b kdeui/tests/keditlistboxtest.cpp d0713e06c7e292dbd88a551d5aa845c303502c39 kdeui/tests/kfontdialogtest.cpp 01cf2dae03ec0eb4b795b77ecf90a4915b649e0e kdeui/tests/kjobtrackerstest.cpp 3168cb84199c5a2798ddefb967855e89ad2172f3 kdeui/tests/kmainwindowrestoretest.cpp 926613e003f0ac562126b6c3ab5f073ef3560768 kdeui/tests/kmainwindowtest.cpp 10b8db582ccdbf521084e3b35624ff6c728bfc3e kdeui/tests/kmanagerselectiontest.cpp e447ae267bdf328577fa767a2f18cf1b769a9039 kdeui/tests/kmessagetest.cpp f6f1b869894d6fea7721a636d817b9dd33ad7b56 kdeui/tests/kmodifierkeyinfotest.cpp 1a5beeba45d4166497c85ab17ad2d6b90b89593d kdeui/tests/knewpassworddialogtest.cpp 1ecb81a7d6a2da150cb1cc811c930679c73c5dfe kdeui/tests/knuminputtest.cpp a8c6a2c6c226dabb8c726685419f5cc4b962b734 kdeui/tests/kpagedialogtest.cpp 65f90f9586eead6fd626230522d53fed7def4b4d kdeui/tests/kpagewidgettest.cpp d8c4983eb4c2b1309770601c2a8d2a2334afc888 kdeui/tests/kpassivepopuptest.cpp b0192251a4dd2f121d9c1a37a30da6db4c099742 kdeui/tests/kpassworddialogtest.cpp 11862b04475a9398d24df47489e8d210453c74ba kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp 04d2b3358d1262a4275e8264bd3555ce670b66d9 kdeui/tests/kpopuptest.cpp a85f1bc387acda46a5ac4570a7c942b485a08523 kdeui/tests/kprogressdialogtest.cpp 8be3beff144c44e3774f6dbdc7412122071e30d7 kdeui/tests/kreplacetest.cpp 294a0cf46c4931d931a5dab68b5e2c7717060312 kdeui/tests/krichtexteditor/main.cpp 92fa2577eb31f2f99377c8bf7f427a857b98d11c kdeui/tests/krulertest.cpp 9a22b0f3926af85329c6aaac6db19c85d13a593a kdeui/tests/kselectactiontest.cpp d72abe51e6a9232eb5dcc13fa3094ea7f184f071 kdeui/tests/ksqueezedtextlabeltest.cpp 2f25aaab6c00f71dec6a68a4f3488ebc9526061f kdeui/tests/kstatusbartest.cpp 59e9ef10a49b1f215e26aa6ba3baf128ff2e87e3 kdeui/tests/ksystemtraytest.cpp 5248bdc0532837f1f0c6a131d93bd8f336260796 kdeui/tests/ktabwidgettest.cpp 477ac7b6a71f501a8518c632f0d5c6d48256f716 kdeui/tests/ktextbrowsertest.cpp 4d15ea2affa6194cfbf30151999aa9cac6a04efe kdeui/tests/ktextedittest.cpp d605bfc46584828aa1391d68c58bc80a58428ac8 kdeui/tests/ktitlewidgettest.cpp c22d68f7ad4d53dbca745850d12c14825ebacacf kdeui/tests/ktoolbarlabelactiontest.cpp fa6e7ba31b6af2a3639ba77665171388e7c2653f kdeui/tests/ktoolbartest.cpp b1159dea61c2e9c88182c912d829bb4090bc5660 kdeui/tests/ktreewidgetsearchlinetest.cpp e2047c3446858d2d8629cb0f3fb6083cce0a5c15 kdeui/tests/kwidgetitemdelegatetest.cpp 03ec36adb47e1b386806a1b3ccb43ac210167daf kdeui/tests/kwindowtest.cpp e435b0ca66a631bcb9dc8dd3c085aea0d82846ac kdeui/tests/kxmlguitest.cpp 6bd9c8973d34a8491e587d1521dba9655584a7db
Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/#review16996 --- Thanks, a good start. BTW did you try running the tests afterwards, to see if this breaks anything? (see the list for current expected results). Otherwise I will. interfaces/terminal/example/main.cc http://git.reviewboard.kde.org/r/105897/#comment13349 The KAboutData instance is unnecessary now, and can be removed. kde3support/tests/kactivelabeltest.cpp http://git.reviewboard.kde.org/r/105897/#comment13350 Same here, and in most others. I would just do setApplicationName(KActiveLabelTest), the KAboutData isn't useful (it's not even registered anywhere anymore, as kcmdlineargs used to do). - David Faure On Aug. 6, 2012, 6:53 p.m., Jeremy Paul Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/ --- (Updated Aug. 6, 2012, 6:53 p.m.) Review request for KDE Frameworks and David Faure. Description --- Port from KApplication KCmdLineArgs to QApplication in unit tests. Diffs - interfaces/terminal/example/main.cc 40c1f01c001a04e1d9ad538a52e4be93a827535d kde3support/tests/itemcontainertest.cpp 3fa45262cf43958118caf6d2c13e3cbe7052adce kde3support/tests/k3listviewtest.cpp fade590e4bb40a8d90555adf930e16dac1c3a2f8 kde3support/tests/k3wizardtest.cpp 39dbd5717c6860af82b19f236b8e951194e875c5 kde3support/tests/kaboutdialogtest.cpp 631144986b33497382ad46d260ae43aca100efbf kde3support/tests/kactivelabeltest.cpp 4653a94cad4276ea44f6436a2baf46e296138136 kde3support/tests/kdocktest.cpp 7a0bd770377e0123e80d1ffb5c633751a96e9e71 kde3support/tests/kdockwidgetdemo.cpp cba54ba922ba259f28c3d6b95379c539a70fed03 kde3support/tests/kdockwidgettest.cpp 8247e21e783506d0f31b13cc739c770a580e2f92 kdeui/tests/kanimatedbuttontest.cpp 9f9d77071e788b8289fd84620aa515bcd40cd621 kdeui/tests/kassistantdialogtest.cpp 9d90824027acc57dd68ad1ab6c946d3ffac67098 kdeui/tests/kbugreporttest.cpp 6b6cd4c6c839e4f462803fd9666042c65a982602 kdeui/tests/kcategorizedviewtest.cpp 5c78e77a0884a02857f8fd898e70efc080e7d708 kdeui/tests/kcharselecttest.cpp b519c542149d2244977d0478a0e2f0edd1edd9b0 kdeui/tests/kcodecactiontest.cpp 6d7004340ffbeef24659a7d654baf13c996ba3d8 kdeui/tests/kcolorcollectiontest.cpp 8262213c94c9318955fc90b4ac4fc69b709cce99 kdeui/tests/kcolordlgtest.cpp 28d52c558a2161209d8fbed70d3bd78d81659bbf kdeui/tests/kcolorutilsdemo.cpp a6bb914b81f7f9b529164bc8faa133580c3c51e4 kdeui/tests/kcomboboxtest.cpp ec453987cd204bc65924ad5bd2c8e58a5ecec390 kdeui/tests/kcompletionuitest.cpp 6ab5444294cfab76b52bbfc4dd53c7e01f7296cf kdeui/tests/kdatepicktest.cpp 620ff7adc0fa815bcd8ca8fdfbc5d16ee964e63b kdeui/tests/kdatetabletest.cpp 43e31d76e260e0a1e63118311874c7cb97f36deb kdeui/tests/kdatetimewidgettest.cpp 39e05c0c6d514ba61c4dd4279a4fd3b31cb0638e kdeui/tests/kdatewidgettest.cpp 2f8b568ffd336fcd5d6d714d606db0ee8db0bc5b kdeui/tests/keditlistboxtest.cpp d0713e06c7e292dbd88a551d5aa845c303502c39 kdeui/tests/kfontdialogtest.cpp 01cf2dae03ec0eb4b795b77ecf90a4915b649e0e kdeui/tests/kjobtrackerstest.cpp 3168cb84199c5a2798ddefb967855e89ad2172f3 kdeui/tests/kmainwindowrestoretest.cpp 926613e003f0ac562126b6c3ab5f073ef3560768 kdeui/tests/kmainwindowtest.cpp 10b8db582ccdbf521084e3b35624ff6c728bfc3e kdeui/tests/kmanagerselectiontest.cpp e447ae267bdf328577fa767a2f18cf1b769a9039 kdeui/tests/kmessagetest.cpp f6f1b869894d6fea7721a636d817b9dd33ad7b56 kdeui/tests/kmodifierkeyinfotest.cpp 1a5beeba45d4166497c85ab17ad2d6b90b89593d kdeui/tests/knewpassworddialogtest.cpp 1ecb81a7d6a2da150cb1cc811c930679c73c5dfe kdeui/tests/knuminputtest.cpp a8c6a2c6c226dabb8c726685419f5cc4b962b734 kdeui/tests/kpagedialogtest.cpp 65f90f9586eead6fd626230522d53fed7def4b4d kdeui/tests/kpagewidgettest.cpp d8c4983eb4c2b1309770601c2a8d2a2334afc888 kdeui/tests/kpassivepopuptest.cpp b0192251a4dd2f121d9c1a37a30da6db4c099742 kdeui/tests/kpassworddialogtest.cpp 11862b04475a9398d24df47489e8d210453c74ba kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp 04d2b3358d1262a4275e8264bd3555ce670b66d9 kdeui/tests/kpopuptest.cpp a85f1bc387acda46a5ac4570a7c942b485a08523 kdeui/tests/kprogressdialogtest.cpp 8be3beff144c44e3774f6dbdc7412122071e30d7 kdeui/tests/kreplacetest.cpp 294a0cf46c4931d931a5dab68b5e2c7717060312 kdeui/tests/krichtexteditor/main.cpp 92fa2577eb31f2f99377c8bf7f427a857b98d11c kdeui/tests/krulertest.cpp 9a22b0f3926af85329c6aaac6db19c85d13a593a kdeui/tests/kselectactiontest.cpp d72abe51e6a9232eb5dcc13fa3094ea7f184f071
Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.
I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? I also found one KApplication usage in an io slave that's part of the patch, is that ok to port to QApplication? or is there something that KApplication brings that it needs (does kquitapp blah work on QApplications for example)? Jeremy On Mon, Aug 6, 2012 at 1:47 PM, David Faure fa...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105897/ Thanks, a good start. BTW did you try running the tests afterwards, to see if this breaks anything? (see the list for current expected results). Otherwise I will. interfaces/terminal/example/main.cchttp://git.reviewboard.kde.org/r/105897/diff/1/?file=76335#file76335line32 (Diff revision 1) int main( int argc, char** argv ) 32 KAboutData* about = new KAboutData( tetest, 0, ki18n(TETest), 0.1 ); 31 KAboutData* about = new KAboutData( tetest, 0, ki18n(TETest), 0.1 ); The KAboutData instance is unnecessary now, and can be removed. kde3support/tests/kactivelabeltest.cpphttp://git.reviewboard.kde.org/r/105897/diff/1/?file=76340#file76340line48 (Diff revision 1) KActiveLabelTest::KActiveLabelTest(QWidget *parent) 47 KCmdLineArgs::init(argc, argv, about); 46 QApplication::setApplicationName(about.appName()); Same here, and in most others. I would just do setApplicationName(KActiveLabelTest), the KAboutData isn't useful (it's not even registered anywhere anymore, as kcmdlineargs used to do). - David On August 6th, 2012, 6:53 p.m., Jeremy Paul Whiting wrote: Review request for KDE Frameworks and David Faure. By Jeremy Paul Whiting. *Updated Aug. 6, 2012, 6:53 p.m.* Description Port from KApplication KCmdLineArgs to QApplication in unit tests. Diffs - interfaces/terminal/example/main.cc (40c1f01c001a04e1d9ad538a52e4be93a827535d) - kde3support/tests/itemcontainertest.cpp (3fa45262cf43958118caf6d2c13e3cbe7052adce) - kde3support/tests/k3listviewtest.cpp (fade590e4bb40a8d90555adf930e16dac1c3a2f8) - kde3support/tests/k3wizardtest.cpp (39dbd5717c6860af82b19f236b8e951194e875c5) - kde3support/tests/kaboutdialogtest.cpp (631144986b33497382ad46d260ae43aca100efbf) - kde3support/tests/kactivelabeltest.cpp (4653a94cad4276ea44f6436a2baf46e296138136) - kde3support/tests/kdocktest.cpp (7a0bd770377e0123e80d1ffb5c633751a96e9e71) - kde3support/tests/kdockwidgetdemo.cpp (cba54ba922ba259f28c3d6b95379c539a70fed03) - kde3support/tests/kdockwidgettest.cpp (8247e21e783506d0f31b13cc739c770a580e2f92) - kdeui/tests/kanimatedbuttontest.cpp (9f9d77071e788b8289fd84620aa515bcd40cd621) - kdeui/tests/kassistantdialogtest.cpp (9d90824027acc57dd68ad1ab6c946d3ffac67098) - kdeui/tests/kbugreporttest.cpp (6b6cd4c6c839e4f462803fd9666042c65a982602) - kdeui/tests/kcategorizedviewtest.cpp (5c78e77a0884a02857f8fd898e70efc080e7d708) - kdeui/tests/kcharselecttest.cpp (b519c542149d2244977d0478a0e2f0edd1edd9b0) - kdeui/tests/kcodecactiontest.cpp (6d7004340ffbeef24659a7d654baf13c996ba3d8) - kdeui/tests/kcolorcollectiontest.cpp (8262213c94c9318955fc90b4ac4fc69b709cce99) - kdeui/tests/kcolordlgtest.cpp (28d52c558a2161209d8fbed70d3bd78d81659bbf) - kdeui/tests/kcolorutilsdemo.cpp (a6bb914b81f7f9b529164bc8faa133580c3c51e4) - kdeui/tests/kcomboboxtest.cpp (ec453987cd204bc65924ad5bd2c8e58a5ecec390) - kdeui/tests/kcompletionuitest.cpp (6ab5444294cfab76b52bbfc4dd53c7e01f7296cf) - kdeui/tests/kdatepicktest.cpp (620ff7adc0fa815bcd8ca8fdfbc5d16ee964e63b) - kdeui/tests/kdatetabletest.cpp (43e31d76e260e0a1e63118311874c7cb97f36deb) - kdeui/tests/kdatetimewidgettest.cpp (39e05c0c6d514ba61c4dd4279a4fd3b31cb0638e) - kdeui/tests/kdatewidgettest.cpp (2f8b568ffd336fcd5d6d714d606db0ee8db0bc5b) - kdeui/tests/keditlistboxtest.cpp (d0713e06c7e292dbd88a551d5aa845c303502c39) - kdeui/tests/kfontdialogtest.cpp (01cf2dae03ec0eb4b795b77ecf90a4915b649e0e) - kdeui/tests/kjobtrackerstest.cpp (3168cb84199c5a2798ddefb967855e89ad2172f3) - kdeui/tests/kmainwindowrestoretest.cpp (926613e003f0ac562126b6c3ab5f073ef3560768) - kdeui/tests/kmainwindowtest.cpp (10b8db582ccdbf521084e3b35624ff6c728bfc3e) - kdeui/tests/kmanagerselectiontest.cpp (e447ae267bdf328577fa767a2f18cf1b769a9039) - kdeui/tests/kmessagetest.cpp (f6f1b869894d6fea7721a636d817b9dd33ad7b56) - kdeui/tests/kmodifierkeyinfotest.cpp (1a5beeba45d4166497c85ab17ad2d6b90b89593d) - kdeui/tests/knewpassworddialogtest.cpp (1ecb81a7d6a2da150cb1cc811c930679c73c5dfe) - kdeui/tests/knuminputtest.cpp (a8c6a2c6c226dabb8c726685419f5cc4b962b734) - kdeui/tests/kpagedialogtest.cpp
Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.
On Monday 06 August 2012 13:53:08 Jeremy Whiting wrote: I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? Don't nuke those that have an actual list of authors. But most of them are just a fake kaboutdata just because there needed to be one. I also found one KApplication usage in an io slave that's part of the patch, is that ok to port to QApplication? or is there something that KApplication brings that it needs (does kquitapp blah work on QApplications for example)? KApplication brought dbus registration, indeed. As documented in KDE5PORTING.html, you have to add a call to KDBusService in order to get that with QApplication. Most (if not all) unittests don't need that, though. KIOSlaves themselves don't register to DBus, though. The KApplication usage in ioslaves was for an event loop, right? Ah it's old kio_metainfo. I'm pretty sure a QCoreApplication is enough there. Thanks, -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Fwd: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again.
-- Forwarded Message -- Subject: [kdelibs/frameworks] kdecore/util: This makes K_EXPORT_PLUGIN work with Qt5 again. Date: Monday 06 August 2012, 17:59:21 From: David Faure fa...@kde.org To: kde-comm...@kde.org CC: kde-framewo...@kde.org, thi...@kde.org Git commit dfdb6762045bc47becf2d9abb2ac70e5463bd0a7 by David Faure. Committed on 06/08/2012 at 17:58. Pushed by dfaure into branch 'frameworks'. This makes K_EXPORT_PLUGIN work with Qt5 again. In other words, we provide more backwards compatibility than Qt5 does itself (where Q_EXPORT_PLUGIN just breaks compilation)... I'm not actually sure why Qt5 does that, it's easy to support to old macro for compatibility, as proven here (the unittests pass, i.e. the loading actually works). This doesn't prevent porting our plugins (and loader, for incremental migration) to pure qt5 plugins though, of course. CCMAIL: thi...@kde.org, kde-framewo...@kde.org M +12 -2kdecore/util/kexportplugin.h http://commits.kde.org/kdelibs/dfdb6762045bc47becf2d9abb2ac70e5463bd0a7 diff --git a/kdecore/util/kexportplugin.h b/kdecore/util/kexportplugin.h index fe328ef..316d8fe 100644 --- a/kdecore/util/kexportplugin.h +++ b/kdecore/util/kexportplugin.h @@ -75,8 +75,18 @@ K_PLUGIN_VERIFICATION_DATA #else -#pragma message(Plugins are broken. Need to port to new plugin system.) -#define K_EXPORT_PLUGIN(factory) +#pragma message(K_EXPORT_PLUGIN is defined as a hack here, for compat. Port to new plugin system (QT_PLUGIN_METADATA) instead.) + +#if defined (Q_OS_WIN32) defined(Q_CC_BOR) +#define Q_STANDARD_CALL __stdcall +#else +#define Q_STANDARD_CALL +#endif + +#define K_EXPORT_PLUGIN(factory) \ +Q_EXTERN_C Q_DECL_EXPORT QT_PREPEND_NAMESPACE(QObject) * Q_STANDARD_CALL qt_plugin_instance() \ +Q_PLUGIN_INSTANCE(factory) \ +K_PLUGIN_VERIFICATION_DATA #endif - -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
