Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread David Faure
On Thursday 25 October 2012 22:47:00 Jon Severinsson wrote: > torsdagen den 25 oktober 2012 19:25:29 skrev du: > > On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > > > I triggered this in Qt5 too, and I figured out the underlying reason for > > > it to happen. If, when KSystemTimeZone

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread Jon Severinsson
torsdagen den 25 oktober 2012 19:25:29 skrev du: > On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > > I triggered this in Qt5 too, and I figured out the underlying reason for > > it to happen. If, when KSystemTimeZonesPrivate::setLocalZone() tries to > > figure out what time zone to u

Re: Review Request: Fix KDateTimeTest::cleanupTestCase() on frameworks branch

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107037/#review20916 --- This review has been submitted with commit 44ada438b0bf64114d3

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

2012-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107038/#review20896 --- Ah ok, setting UTC is probably better than making the whole thi

Re: Review Request: Fix KDateTimeTest::cleanupTestCase() on frameworks branch

2012-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107037/#review20894 --- Ship it! Ship It! - David Faure On Oct. 25, 2012, 2:46 p.m.

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread David Faure
On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > I triggered this in Qt5 too, and I figured out the underlying reason for it > to happen. If, when KSystemTimeZonesPrivate::setLocalZone() tries to > figure out what time zone to use for KSystemTimeZones::local(), the kconfig > "ktimezon

Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

2012-10-25 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107038/ --- Review request for KDE Frameworks. Description --- If the time zone f

Review Request: Fix KDateTimeTest::cleanupTestCase() on frameworks branch

2012-10-25 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107037/ --- Review request for KDE Frameworks. Description --- KDateTime left kti

Re: Review Request: new signal void KMessageWidget::linkActivated()

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107036/#review20888 --- This review has been submitted with commit f2bbe83d5bd84882fa1

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread Jon Severinsson
fredagen den 19 oktober 2012 20:50:16 skrev David Faure: > diff --git a/kdecore/date/kdatetime.cpp b/kdecore/date/kdatetime.cpp > index 910e1cf..74e82ca 100644 > --- a/kdecore/date/kdatetime.cpp > +++ b/kdecore/date/kdatetime.cpp > @@ -1773,6 +1773,8 @@ QString KDateTime::toString(TimeFormat forma

Review Request: new signal void KMessageWidget::linkActivated()

2012-10-25 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107036/ --- Review request for KDE Frameworks and Aurélien Gâteau. Description ---