Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-22 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/ --- (Updated Feb. 22, 2013, 10:59 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-22 Thread Valentin Rusu
> On Feb. 21, 2013, 6:23 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kglobalaccel.h, line 267 > > > > > > Hm... I'm wondering, should this signal have a twin (both emitted at > > the same time) where we indicat

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread David Faure
On Friday 22 February 2013 19:29:48 Alexander Neundorf wrote: > On Friday 22 February 2013, David Faure wrote: > > How about we make it > > CMAKE_INSTALL_PREFIX "/" LIB_INSTALL_DIR "/libexec/kioslave"? > > Then on Windows, we can just request that PATH contains that (unique) > > libexec directory,

Re: Finding kf5 libs (Re: Move kde-config to kde4support.)

2013-02-22 Thread Ben Cooksley
On Sat, Feb 23, 2013 at 10:39 AM, David Faure wrote: > On Friday 22 February 2013 18:54:45 Alexander Neundorf wrote: >> On Friday 22 February 2013, David Faure wrote: >> > [This is no longer about kde*-config, retitling] >> > >> > On Friday 22 February 2013 18:38:39 Alexander Neundorf wrote: >> >

Re: Finding kf5 libs (Re: Move kde-config to kde4support.)

2013-02-22 Thread David Faure
On Friday 22 February 2013 18:54:45 Alexander Neundorf wrote: > On Friday 22 February 2013, David Faure wrote: > > [This is no longer about kde*-config, retitling] > > > > On Friday 22 February 2013 18:38:39 Alexander Neundorf wrote: > > > If you do > > > find_package(KF5 COMPONENTS kidletime kaut

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread David Faure
On Friday 22 February 2013 18:45:45 Alexander Neundorf wrote: > On Friday 22 February 2013, David Faure wrote: > > On Thursday 21 February 2013 22:01:30 Alexander Neundorf wrote: > > > Why not have a KF5DIRS variable ? > > > > You keep thinking "KDE4, renamed" :-) > > > > Think of KF5 as standalo

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, David Faure wrote: > On Thursday 21 February 2013 19:20:56 Alexander Neundorf wrote: ... > > Is there a way to find out where a library itself is located ? > > Not that I know. Found something :-) Under Windows it's GetModuleHandleEx(), with glibc dladdr() (see attache

Re: New "official" way how to use an installed kdelibs from the frameworks branch

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, Kevin Ottens wrote: > On Friday 22 February 2013 18:48:53 Alexander Neundorf wrote: > > This is either > > find_package(KConfig NO_MODULE) > > or > > find_package(KF5 COMPONENT KConfig) > > Hm, you mean that in the end both lines will be valid and do the "right" > thing

Re: New "official" way how to use an installed kdelibs from the frameworks branch

2013-02-22 Thread Kevin Ottens
On Friday 22 February 2013 18:48:53 Alexander Neundorf wrote: > This is either > find_package(KConfig NO_MODULE) > or > find_package(KF5 COMPONENT KConfig) Hm, you mean that in the end both lines will be valid and do the "right" thing? (I thought we had to pick one of those two possibilities and o

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, David Faure wrote: > On Thursday 21 February 2013 19:20:56 Alexander Neundorf wrote: > > On Thursday 21 February 2013, David Faure wrote: > > > On Thursday 21 February 2013 18:38:46 Alexander Neundorf wrote: > > > > On Thursday 21 February 2013, David Faure wrote: > > >

Re: CamelCasing our libraries ?

2013-02-22 Thread Alexander Neundorf
On Friday 15 February 2013, Alexander Neundorf wrote: > Hi, > > any opinions abouut changing our library names to CamelCase, like > libKCoreAddons.so, together with the package named KCoreAddons ? > Right now it is libkcoreaddons, and the cmake variables for it are > kcoreaddons_FOUND, kcoreaddons

Re: Finding kf5 libs (Re: Move kde-config to kde4support.)

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, David Faure wrote: > [This is no longer about kde*-config, retitling] > > On Friday 22 February 2013 18:38:39 Alexander Neundorf wrote: > > If you do > > find_package(KF5 COMPONENTS kidletime kauth kconfig) > > it will search the kidletime library, and once it has found

Finding kf5 libs (Re: Move kde-config to kde4support.)

2013-02-22 Thread David Faure
[This is no longer about kde*-config, retitling] On Friday 22 February 2013 18:38:39 Alexander Neundorf wrote: > If you do > find_package(KF5 COMPONENTS kidletime kauth kconfig) > it will search the kidletime library, and once it has found it, it will > search kauth and kconfig only in the same pr

Re: New "official" way how to use an installed kdelibs from the frameworks branch

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, Stephen Kelly wrote: > Kevin Ottens wrote: > > On Friday 08 February 2013 22:36:22 Alexander Neundorf wrote: > >> Is it only me who would prefer CamelCase to alllowercase names ? > >> find_package(KConfig NO_MODULE) > > > > Probably makes sense yes, AFAIK the Qt5 module

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, David Faure wrote: > On Thursday 21 February 2013 22:01:30 Alexander Neundorf wrote: > > Why not have a KF5DIRS variable ? > > You keep thinking "KDE4, renamed" :-) > > Think of KF5 as standalone libs on top of Qt. Do you currently have to set > a QCADIRS to use QCA, a

Re: Move kde-config to kde4support.

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, David Faure wrote: > On Thursday 21 February 2013 11:55:37 Alex Merry wrote: > > On 21/02/13 11:24, David Faure wrote: > > > For others on the list: I agree that a pure-Qt tool will be useful too, > > > but it won't give us "--prefix, the prefix where KF5 was installed",

Re: New "official" way how to use an installed kdelibs from the frameworks branch

2013-02-22 Thread Alexander Neundorf
On Friday 22 February 2013, Kevin Ottens wrote: > On Friday 08 February 2013 22:36:22 Alexander Neundorf wrote: > > Is it only me who would prefer CamelCase to alllowercase names ? > > find_package(KConfig NO_MODULE) > > Probably makes sense yes, AFAIK the Qt5 modules are camel cased too, right? >

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread David Faure
On Thursday 21 February 2013 22:01:30 Alexander Neundorf wrote: > Why not have a KF5DIRS variable ? You keep thinking "KDE4, renamed" :-) Think of KF5 as standalone libs on top of Qt. Do you currently have to set a QCADIRS to use QCA, and a ATTICADIRS to use attica, and a SOPRANODIRS to use sop

Re: libexec (Re: "kde5" or "kf5" ?)

2013-02-22 Thread David Faure
On Thursday 21 February 2013 19:20:56 Alexander Neundorf wrote: > On Thursday 21 February 2013, David Faure wrote: > > On Thursday 21 February 2013 18:38:46 Alexander Neundorf wrote: > > > On Thursday 21 February 2013, David Faure wrote: > > > > On Wednesday 20 February 2013 22:47:15 Alexander Neun

Re: Move kde-config to kde4support.

2013-02-22 Thread David Faure
On Thursday 21 February 2013 11:55:37 Alex Merry wrote: > On 21/02/13 11:24, David Faure wrote: > > For others on the list: I agree that a pure-Qt tool will be useful too, > > but it won't give us "--prefix, the prefix where KF5 was installed", for > > instance. And kf5-config is useful for compati

Build failed in Jenkins: kdelibs_frameworks_qt5 #432

2013-02-22 Thread KDE CI System
See Changes: [jigneshhk1992] Move kde-config to kde4support and rename binary kde5-config to kf5-config -- [...truncated 18272 lines...] -- Installing:

Re: Move kde-config to kde4support.

2013-02-22 Thread Alex Merry
On 21/02/13 11:24, David Faure wrote: For others on the list: I agree that a pure-Qt tool will be useful too, but it won't give us "--prefix, the prefix where KF5 was installed", for instance. And kf5-config is useful for compatibility (easier porting from scripts that use kde4-config). So let's