Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109531/ --- Review request for KDE Frameworks and kdelibs. Description --- Port t

Re: Review Request 107791: move Sonnet out of KDEUI, port away from KDE classes.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791/ --- (Updated March 16, 2013, 11:13 p.m.) Status -- This change has been m

Jenkins build is back to normal : kdelibs_frameworks_qt5 #509

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #508

See Changes: [martin.sandsmark] fix sonnet include in ktextedit -- [...truncated 10780 lines...] [ 76%] Built target kio_metainfo [ 76%] Building CXX object kfile/CMakeFiles/kfile.dir/kurlnavig

Build failed in Jenkins: kdelibs_frameworks_qt5 #507

See Changes: [martin.sandsmark] fix include for backgroundengine_p.h -- [...truncated 5424 lines...] In file included from

Build failed in Jenkins: kdelibs_frameworks_qt5 #506

See Changes: [martin.sandsmark] Move sonnet out of KDEUI, port away from kconfig. -- [...truncated 3579 lines...] [ 23%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ba

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29336 --- kdecore/io/kdebug.cpp

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- (Updated March 16, 2013, 7:43 p.m.) Status -- This change has been ma

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/#review29335 --- This review has been submitted with commit 462e41668880a1928f3

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/#review29334 --- Ship it! Ship It! - David Faure On March 16, 2013, 7:30 p.m

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- (Updated March 16, 2013, 7:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- (Updated March 16, 2013, 7:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review29333 --- tier1/itemmodels/src/kselectionproxymodel.cpp

Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109527/ --- Review request for KDE Frameworks. Description --- Port to the incomi

Re: Review Request 109515: Move KMainWindow and KToolBar to xmlgui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109515/ --- (Updated March 16, 2013, 6:56 p.m.) Status -- This change has been ma

Re: Review Request 109515: Move KMainWindow and KToolBar to xmlgui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109515/#review29332 --- This review has been submitted with commit d4ba47decf032d09696

Re: Review Request 109526: Implement SH_Widget_Animate in KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109526/ --- (Updated March 16, 2013, 6:41 p.m.) Review request for KDE Frameworks. D

Review Request 109526: Implement SH_Widget_Animate in KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109526/ --- Review request for KDE Frameworks. Description --- Implement SH_Widge

Re: Review Request 109524: Remove some compile warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- (Updated March 16, 2013, 6:16 p.m.) Review request for KDE Frameworks and

Review Request 109524: Remove some complie warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/#review29330 --- kfile/kdiroperator.cpp

Re: Review Request 109517: Port away from KListWidget to QListWidget

> On March 16, 2013, 3:39 p.m., Albert Astals Cid wrote: > > What about all the features KListWidget has and QListWidget hasn't? Are we > > ok with that? Or are we porting all the KListWidgets features to > > QListWidget? > > Kevin Ottens wrote: > Can you point to a feature which would be

Re: Review Request 109517: Port away from KListWidget to QListWidget

> On March 16, 2013, 3:39 p.m., Albert Astals Cid wrote: > > What about all the features KListWidget has and QListWidget hasn't? Are we > > ok with that? Or are we porting all the KListWidgets features to > > QListWidget? > > Kevin Ottens wrote: > Can you point to a feature which would be

Re: Review Request 109517: Port away from KListWidget to QListWidget

> On March 16, 2013, 5:46 p.m., Albert Astals Cid wrote: > > we are using the executed signal in some of the classes that is gone when > > you move to qlistwidget executed() is called itemActivated() in Qt. The point of that signal is that it's emitted on single click, in single-click mode, an

Re: Review Request 109517: Port away from KListWidget to QListWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29326 --- we are using the executed signal in some of the classes that is

Re: Review Request 109517: Port away from KListWidget to QListWidget

> On March 16, 2013, 3:39 p.m., Albert Astals Cid wrote: > > What about all the features KListWidget has and QListWidget hasn't? Are we > > ok with that? Or are we porting all the KListWidgets features to > > QListWidget? > > Kevin Ottens wrote: > Can you point to a feature which would be

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- (Updated March 16, 2013, 4:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/#review29323 --- Ship it! Ship It! - David Faure On March 16, 2013, 4:05 p.m

Re: About tier4/consistency

On Saturday 16 March 2013 10:55:07 Aleix Pol wrote: > We've seen that there are some tasks involving something called > tier4/consistency. We couldn't find it, what should we do about it? This one still has a blurry definition... So far it is staging/frameworkintegration. There's no public API par

Jenkins build is back to stable : kdelibs_frameworks_qt5 #500

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- (Updated March 16, 2013, 4:05 p.m.) Review request for KDE Frameworks and

Re: Review Request 109518: Remove apparently unused KCrash::setup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109518/#review29322 --- This review has been submitted with commit b46942ef9ec121ee72b

Re: Review Request 109518: Remove apparently unused KCrash::setup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109518/ --- (Updated March 16, 2013, 4:01 p.m.) Status -- This change has been ma

Re: Review Request 109517: Port away from KListWidget to QListWidget

> On March 16, 2013, 3:39 p.m., Albert Astals Cid wrote: > > What about all the features KListWidget has and QListWidget hasn't? Are we > > ok with that? Or are we porting all the KListWidgets features to > > QListWidget? Can you point to a feature which would be lost or is that rhethorical?

Re: Review Request 109519: Use QUrl::errorString() instead of QUrl::toString() in QMessageBox; adds qWarning as well

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109519/#review29320 --- One issue, rest looks good. kio/kio/kdirlister.cpp

Re: Review Request 109515: Move KMainWindow and KToolBar to xmlgui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109515/#review29319 --- Ship it! Ship It! - Kevin Ottens On March 16, 2013, 10:56 a

Re: Review Request 109517: Port away from KListWidget to QListWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29318 --- Hm, I only see one end of the move the files deleted not the fi

Re: Review Request 109517: Port away from KListWidget to QListWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29317 --- What about all the features KListWidget has and QListWidget has

Build failed in Jenkins: kdelibs_frameworks_qt5 #488

See Changes: [steveire] Remove forks of Qt4 related cmake files. -- [...truncated 14064 lines...] -- Installing:

Review Request 109515: Move KMainWindow and KToolBar to xmlgui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109515/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description

About tier4/consistency

Hi, We've seen that there are some tasks involving something called tier4/consistency. We couldn't find it, what should we do about it? Thanks! Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/#review29316 --- kio/kio/netaccess.h

Build failed in Jenkins: kdelibs_frameworks_qt5 #497

See Changes: [steveire] Add missing link to kdecore -- [...truncated 7065 lines...] [ 73%] Built target ksslkeygentest [ 73%] Building CXX object kio/tests/CMakeFiles/kurlcompletiontest.dir/kur

Re: Review Request 109518: Remove apparently unused KCrash::setup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109518/#review29315 --- Ship it! Ship It! - Kevin Ottens On March 16, 2013, 12:54 p

Build failed in Jenkins: kdelibs_frameworks_qt5 #496

See Changes: [steveire] Add missing link to kconfigcore. -- [...truncated 4379 lines...] [ 39%] Building CXX object tier2/kconfig/autotests/kconfig_compiler/CMakeFiles/test11.dir/test11main.cpp

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/#review29314 --- Probably makes sense to deprecate more indeed. Would need to be

Build failed in Jenkins: kdelibs_frameworks_qt5 #495

See Changes: [steveire] Don't link explicitly to QTMAIN. [steveire] Remove the PIC setting. [steveire] Remove use of the QTestWidgets include. [steveire] Don't use the QT_DEFINITIONS explicitly. [steveire] Use the CMake convenience

Review Request 109518: Remove apparently unused KCrash::setup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109518/ --- Review request for KDE Frameworks. Description --- Checking how KCras

Re: Review Request 109503: Compile with current qt dev branch

Ben Cooksley wrote: > I tried the command invocation: > git submodule foreach 'git fetch; git reset --hard origin/dev || git > reset --hard origin/master || true' > > Which does do the job. However, as feared Jenkins is far too clever > and overwrites that completely, checking out the directories

Re: Review Request 109503: Compile with current qt dev branch

On Sun, Mar 17, 2013 at 12:29 AM, Stephen Kelly wrote: > Ben Cooksley wrote: > >> On Sun, Mar 17, 2013 at 12:23 AM, Stephen Kelly >> wrote: >>> Stephen Kelly wrote: >>> Ben Cooksley wrote: > In theory, however Jenkins itself does Git handling for part of the > process and that may ve

Re: Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- (Updated March 16, 2013, 11:29 a.m.) Review request for KDE Frameworks and

Re: Review Request 109503: Compile with current qt dev branch

Ben Cooksley wrote: > On Sun, Mar 17, 2013 at 12:23 AM, Stephen Kelly > wrote: >> Stephen Kelly wrote: >> >>> Ben Cooksley wrote: In theory, however Jenkins itself does Git handling for part of the process and that may very well override our invocation of that. In any case, gi

Re: Review Request 109503: Compile with current qt dev branch

On Sun, Mar 17, 2013 at 12:23 AM, Stephen Kelly wrote: > Stephen Kelly wrote: > >> Ben Cooksley wrote: >>> In theory, however Jenkins itself does Git handling for part of the >>> process and that may very well override our invocation of that. >>> >>> In any case, git spits out the following if I r

Re: Review Request 109503: Compile with current qt dev branch

Stephen Kelly wrote: > Ben Cooksley wrote: >> In theory, however Jenkins itself does Git handling for part of the >> process and that may very well override our invocation of that. >> >> In any case, git spits out the following if I run that for each >> submodule: >> >> You are not currently on

Re: Review Request 109503: Compile with current qt dev branch

Ben Cooksley wrote: > In theory, however Jenkins itself does Git handling for part of the > process and that may very well override our invocation of that. > > In any case, git spits out the following if I run that for each submodule: > > You are not currently on a branch, so I cannot use any > '

Re: Review Request 109503: Compile with current qt dev branch

> On March 15, 2013, 5:07 p.m., Stephen Kelly wrote: > > The problem is that build.kde.org uses qt5.git, which does not yet have > > that commit. Actually qt5.git hasn't been updated in 6 weeks: > > https://codereview.qt-project.org/#change,46445 > > > > If b.k.o can be updated to use the dev

[kdelibs/frameworks] /: Require CMake 2.8.11 RC1

Git commit a72b57eacd05f70057147010245f3474963c9918 by Stephen Kelly. Committed on 16/03/2013 at 12:02. Pushed by skelly into branch 'frameworks'. Require CMake 2.8.11 RC1 The version I've changed the requirement to is not actually the RC1, but the version build.kde.org happens to have at the mom

Review Request 109516: Deprecate NetAccess::dircopy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109516/ --- Review request for KDE Frameworks and David Faure. Description --- Pa

Re: Review Request 109503: Compile with current qt dev branch

> On March 15, 2013, 5:07 p.m., Stephen Kelly wrote: > > The problem is that build.kde.org uses qt5.git, which does not yet have > > that commit. Actually qt5.git hasn't been updated in 6 weeks: > > https://codereview.qt-project.org/#change,46445 > > > > If b.k.o can be updated to use the dev