On Wednesday, June 12, 2013 16:08:27 Benjamin Port wrote:
On Wednesday, June 12, 2013 03:52:32 PM David Faure wrote:
Le mercredi 12 juin 2013 14:55:07 Benjamin Port a écrit :
some files in staging, tier1 and tier2 have no licence perhaps we can
fix
it. and then don't move a file if
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/
---
Review request for KDE Frameworks.
Description
---
Ports away
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review34280
---
Good work, not an easy task.
In addition to the issues I
On June 12, 2013, 6:51 a.m., Kevin Ottens wrote:
khtml/misc/loader.h, line 422
http://git.reviewboard.kde.org/r/110876/diff/2/?file=149646#file149646line422
qint64 instead of int? probably better since that's what addSecs uses.
Ok to change it, but the docs say addSecs uses int:
On June 12, 2013, 6:51 a.m., Kevin Ottens wrote:
khtml/misc/loader.h, line 422
http://git.reviewboard.kde.org/r/110876/diff/2/?file=149646#file149646line422
qint64 instead of int? probably better since that's what addSecs uses.
David Gil Oliva wrote:
Ok to change it, but the
On Tue, Jun 4, 2013 at 12:47 AM, David Faure fa...@kde.org wrote:
On Wednesday 29 May 2013 16:13:23 Harald Sitter wrote:
As you may be aware phonon supports building the phonon4 API against Qt5
by
building the phonon4qt5 branch.
Due to consolidation efforts at the Phonon sprint last
On June 13, 2013, 11:06 a.m., David Faure wrote:
Good work, not an easy task.
In addition to the issues I found, could you ensure that the unittests
still pass? In particular jobtest in kio, looks appropriate. Plus the one
that calls chmod().
Will do.
On June 13, 2013, 11:06
On June 13, 2013, 11:06 a.m., David Faure wrote:
kioslave/file/file.cpp, line 453
http://git.reviewboard.kde.org/r/110988/diff/1/?file=149805#file149805line453
Bug in the original code? Should be ..._FOR_WRITING if mode
QIODevice::WriteOnly?
Martin Klapetek wrote:
Would
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110995/
---
Review request for KDE Frameworks, David Faure and Kevin Ottens.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110997/
---
Review request for KDE Frameworks.
Description
---
Moved KPage*
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111002/
---
Review request for KDE Frameworks, David Faure and Kevin Ottens.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110997/#review34320
---
Using the reviewboard diff viewer, I can only see that you
See http://build.kde.org/job/plasma-framework_master_qt5/476/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110995/
---
(Updated June 13, 2013, 10:29 p.m.)
Review request for KDE Frameworks,
On June 13, 2013, 8:49 p.m., Christoph Feck wrote:
Using the reviewboard diff viewer, I can only see that you moved files, but
it is impossible to see if there are any changes to them. Is there a way to
view those changes, if any?
You can apply the files locally and use git. There you
15 matches
Mail list logo
