Re: KGlobalSettings move to kde4support
Hello, On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. Ah good, it was in my hit list for the coming days too. But if you can handle it that's fine by me. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. - Font methods: They are used in many places in and out of kdelibs, I'm unsure what's the plan for it. Should we create a new class for that? Or add it to QStyle? Or maybe we can just standarize some font names. See kdisplaySetFont() The idea here would be to handle that using our platformtheme plugin when it comes to forcing user set fonts on widgets. I've found the font API to be used outside of kdelibs widgets only seldomly and it was always for fixedFont(), so although not ideal we currently use a dynamic property names _k_fixedFont on the application object to store it (maybe QGuiApplication could be extended to have that as a regular method). The mechanisms I describe above are implemented in staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp Needs review as it might miss some calls to QApplication::setFont Most of the aspects of KGlobalSettings to ensure consistency should likely follow the same path. - isMultiHead: Reads a env variable that tells if KDE has to work on multi head mode. It's only used by plasma and KWin, so we can probably find a better place for the check. Is it even still needed? Nowadays relying on an env variable for that sounds strange... But I might miss something. In any case the code is trivial enough that it could be duplicated in kwin and plasma-framework if need be. - wheelMouseZooms: It's only used by KTextEditor, so I'd say it should be moved there and deprecate it. This one I already checked. No action is required, it's read at only one place and there's no one writing the setting... So effectively users can't change it, only the default is used. - naturalSorting: it's used by KDirOperator and Dolphin. Unsure what it does. It does what Alex Merry said. It's in fact a setting driven by dolphin itself only. It's used only there and in a couple of widgets used in a similar context. I would say it should be fully handled in dolphin itself then. On the kdelibs side the only thing needed is then for the widgets currently reading from that setting to instead provide a setter/getter pair so that dolphin will be able to change their behavior when it sees fit. - graphicEffectsLevel/graphicEffectsLevelDefault: That's being dealt by Alex Fiestas, no? Yep, there's tasks in the wiki around that already. - opaqueResize: I see there's already a task created about it, to move it to Qt. It's about using QSplitter. I guess we can assume this goes to kde4support and it's fine. Yep, the task is there already. - buttonLayout: I really can't tell who uses it, it's impossible to look it up in lxr. Nobody is using it in kdelibs. It's completely unused so we can ignore it. - createApplicationPalette/createNewApplicationPalette: These seems to me that they're only used because of some limitation in the Qt we had in maemo, to force applications to use the oxygen style. For some reason. I'd say the code for this should go to KQGuiPlatformPlugin and just deprecate these interfaces. It's like the fonts, it's handled at least in part in staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp So same treatment: needs to review the corresponding code in our platform theme plugin. - emitChange: it mostly depends on what we do with each exposed property, like we already did for the icon themes. That one it's basically the task on making sure our QPA plugin reacts to setting changes. - activate/activate(options): They only make sense within a KGlobalSettings scope. Agreed. So would it make sense to create separate tasks for each of those elements that don't have an item so that we can work them together? Having a task saying KGlobalSettings move to kde4support is unrealistic to accomplish at the moment. What should be clarified in the wiki is that the moving task in the cleanup page for that one has to come last. It indeed just says move without hinting that we already have other tasks... We probably should have a few more and clarify a few existing ones as you found out above. I can do that if you're fine with the extra information I brought in this email. Regards. -- Kévin Ottens, http://ervin.ipsquad.net
Re: Re: KGlobalSettings move to kde4support
On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: Hello, On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. Ah good, it was in my hit list for the coming days too. But if you can handle it that's fine by me. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. CC Matthew, since he knows a lot about KColorScheme. Maybe he can be of help here. Greetings, Dominik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111081: KIO::Job: more core/gui splitup.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- Review request for KDE Frameworks. Description --- KIO::Job: more core/gui splitup. job-ui() no longer returns a KIO-specific class which was holding QWidget* window and usertimestamp. It now returns the core-only base class, like in KJob. The widget-specific information is stored as a dynamic property into the job, using KJobWidgets API. Split up delegate (for error handling) and interaction interface InteractionInterface is used for the rename and skip dialog, shown by copyjob and movejob. Diffs - KDE5PORTING.html 9cac0c69861b999d968c7af5bdeb113b17086b86 kio/kio/copyjob.cpp e403735f05d644463122728af3a0694454d31367 kio/kio/job.cpp 365752866ef44d79b42c41af38b446c9fd407c7b kio/kio/job_p.h e1dd97995825a372d81a8098e0da38bb821b7a20 kio/kio/jobclasses.h 27a0f12788d35b95934ac714b58df99478e36c31 kio/kio/jobuidelegate.h 87d9d2777f8bd28e417f54900bf85826fef7fa9b kio/kio/jobuidelegate.cpp 9f7e1b2093bb22fff5105bdc958ef519bbee8fcb kio/kio/renamedialog.h 2b9efe21bb5266ced199d2be9b2f8e45df2be4d3 kio/kio/skipdialog.h 93dd30958377fb997a9f10fa2c3cba7702b14350 kio/kio/skipdialog.cpp 98251e058704ef7b8f7fc9b349d8da95c121d2ae kio/tests/jobtest.cpp 7a50857eee19faee995ebbe30e5ba0f954cc858d kio/tests/kdirmodeltest.cpp 6d9f89070d8579bccb494cbeca080498627e2b1e kio/tests/kiotesthelper.h 6ecf13409d0117148cc52c774aa5fced37a28e1d staging/kjobwidgets/src/kdialogjobuidelegate.h f33d34911db53f6e1a90589e70bc9396f049ffc4 staging/kjobwidgets/src/kdialogjobuidelegate.cpp a79eda86f8df34c6996a2f7285ba05466c6f8097 Diff: http://git.reviewboard.kde.org/r/111081/diff/ Testing --- make test Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs_frameworks_qt5 #732
See http://build.kde.org/job/kdelibs_frameworks_qt5/732/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111086: Move KXErrorHandler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111086/ --- Review request for KDE Frameworks. Description --- Finish to moving KXErrorHandler Export and rename kxerrorhandler_p.h Move kexerrorhandler test Diffs - kdeui/CMakeLists.txt c05adbd kdeui/tests/CMakeLists.txt dfe6292 kdeui/tests/kxerrorhandlertest.cpp 8b624f2 kdeui/util/kxerrorhandler.h be5cb76 kdeui/util/kxerrorhandler.cpp 48d8abe tier1/kwindowsystem/CMakeLists.txt 3032ac7 tier1/kwindowsystem/src/CMakeLists.txt b191830 tier1/kwindowsystem/src/kwindowinfo_x11.cpp f382e9c tier1/kwindowsystem/src/kwindowsystem_x11.cpp cc2c5a0 tier1/kwindowsystem/src/kxerrorhandler.h PRE-CREATION tier1/kwindowsystem/src/kxerrorhandler.cpp 67062de tier1/kwindowsystem/src/kxerrorhandler_p.h 53237a3 tier1/kwindowsystem/src/kxutils.cpp 33bd678 tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/tests/kxerrorhandlertest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111086/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111090/ --- Review request for KDE Frameworks and kdelibs. Description --- Since, according to lxr, both these classes aren't used by anyone, I just marked them as deprecated and moved them to kde4support. Diffs - kdeui/CMakeLists.txt cb30283 kdeui/widgets/kstringvalidator.h 01dbec6 kdeui/widgets/kstringvalidator.cpp c4fcc21 kio/CMakeLists.txt 9254283 kio/kfile/kfilemetainfowidget.h eaebcc8 kio/kfile/kfilemetainfowidget.cpp d0f74df staging/kde4support/src/CMakeLists.txt f89e845 staging/kde4support/src/kdeui/kstringvalidator.h PRE-CREATION staging/kde4support/src/kdeui/kstringvalidator.cpp PRE-CREATION staging/kde4support/src/kio/kfilemetainfowidget.h PRE-CREATION staging/kde4support/src/kio/kfilemetainfowidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111090/diff/ Testing --- kdelibs compiles after the move. There weren't any tests for them anywhere and I didn't bother to write any, since they're being deprecated -- I assume that's OK. Thanks, Romário Rios ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111028: Move kkeyserver* to KWindowsSystem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/#review34572 --- Ship it! Ship It! - Kevin Ottens On June 17, 2013, 10:34 a.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/ --- (Updated June 17, 2013, 10:34 a.m.) Review request for KDE Frameworks. Description --- Move kkeyserver* to KWindowsSystem Diffs - kdeui/CMakeLists.txt 05401a7 kdeui/util/kkeyserver.h 4676eae kdeui/util/kkeyserver.cpp a7853eb kdeui/util/kkeyserver_mac.h 2910f88 kdeui/util/kkeyserver_mac.cpp 2f3a496 kdeui/util/kkeyserver_win.h d1457eb kdeui/util/kkeyserver_win.cpp a02c5b9 kdeui/util/kkeyserver_x11.h da48d6d kdeui/util/kkeyserver_x11.cpp 4f74821 tier1/kwindowsystem/src/CMakeLists.txt b191830 Diff: http://git.reviewboard.kde.org/r/111028/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111028: Move kkeyserver* to KWindowsSystem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/ --- (Updated June 18, 2013, 2:31 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Move kkeyserver* to KWindowsSystem Diffs - kdeui/CMakeLists.txt 05401a7 kdeui/util/kkeyserver.h 4676eae kdeui/util/kkeyserver.cpp a7853eb kdeui/util/kkeyserver_mac.h 2910f88 kdeui/util/kkeyserver_mac.cpp 2f3a496 kdeui/util/kkeyserver_win.h d1457eb kdeui/util/kkeyserver_win.cpp a02c5b9 kdeui/util/kkeyserver_x11.h da48d6d kdeui/util/kkeyserver_x11.cpp 4f74821 tier1/kwindowsystem/src/CMakeLists.txt b191830 Diff: http://git.reviewboard.kde.org/r/111028/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KGlobalSettings move to kde4support
On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? What are these used for? They sound like WM colors? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. Perhaps, but KColorScheme already has quite some colors and they are (fairly) well organized at the moment. I would like to understand first what these other colors are used for and if maybe existing colors should be used instead, or at least how to best fit them into the existing framework. Thanks, (Please keep me CC'd.) -- Matthew ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KGlobalSettings move to kde4support
On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke mwoehlke.fl...@gmail.comwrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? What are these used for? They sound like WM colors? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. Perhaps, but KColorScheme already has quite some colors and they are (fairly) well organized at the moment. I would like to understand first what these other colors are used for and if maybe existing colors should be used instead, or at least how to best fit them into the existing framework. Thanks, (Please keep me CC'd.) -- Matthew __**_ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/**listinfo/kde-frameworks-develhttps://mail.kde.org/mailman/listinfo/kde-frameworks-devel Hi, Here you can see where and how it's used: http://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=inactiveTitleColorhttp://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=activeCaptionColorhttp://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=inactiveCaptionColor Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111081: KIO::Job: more core/gui splitup.
On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/kio/job.cpp, line 209 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164098#file164098line209 Interesting... So not having the uiDelegate() but the interactionInterface() qualify as interactive... Not sure if that could be a problem. Maybe better to let it go and let client code test what they need (delegate or extra interface) Well spotted. I removed the method now, added a note in the porting file, and used interactionInterface() in CopyJob. On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/tests/jobtest.cpp, line 264 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164106#file164106line264 Do we agree that the goal is that both uiDelegate() and interactionInterface() will return 0 if you link only kiocore? In such case those lines will become useless in automated tests? At that point it's probably even better if in the tests initTestCase() methods you register mock interfaces which allow to check what the job calls in the interfaces. Yes, however if you suddenly link another lib and it breaks your tests, that would count as rather unexpected, wouldn't it? In any case, at this point, the splitup is not done, so I'm exactly in that situation: the widget-based interaction interface is getting registered, so I need the explicit setting-to-0. About your last question, there are three cases, really: 1) in some cases we just expect the job to work, and if there's a bug, we want an error code rather than a widget popping up. That's the case at the line where you added the comment, see the QVERIFY(ok) two lines down. 2) I use mock interfaces in some places, see PredefinedAnswerJobUiDelegate used in kdirmodeltest.cpp:job-setInteractionInterface(delegate); [ok, the naming is a bit historical] 3) indeed there are also cases where we expect the job to fail, like the two lines with no skip dialog, thanks as comment. The point of the test wasn't to test the user interaction though. Could be added, of course, there's always room for more testing... - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34581 --- On June 18, 2013, 7:39 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 18, 2013, 7:39 a.m.) Review request for KDE Frameworks. Description --- KIO::Job: more core/gui splitup. job-ui() no longer returns a KIO-specific class which was holding QWidget* window and usertimestamp. It now returns the core-only base class, like in KJob. The widget-specific information is stored as a dynamic property into the job, using KJobWidgets API. Split up delegate (for error handling) and interaction interface InteractionInterface is used for the rename and skip dialog, shown by copyjob and movejob. Diffs - KDE5PORTING.html 9cac0c69861b999d968c7af5bdeb113b17086b86 kio/kio/copyjob.cpp e403735f05d644463122728af3a0694454d31367 kio/kio/job.cpp 365752866ef44d79b42c41af38b446c9fd407c7b kio/kio/job_p.h e1dd97995825a372d81a8098e0da38bb821b7a20 kio/kio/jobclasses.h 27a0f12788d35b95934ac714b58df99478e36c31 kio/kio/jobuidelegate.h 87d9d2777f8bd28e417f54900bf85826fef7fa9b kio/kio/jobuidelegate.cpp 9f7e1b2093bb22fff5105bdc958ef519bbee8fcb kio/kio/renamedialog.h 2b9efe21bb5266ced199d2be9b2f8e45df2be4d3 kio/kio/skipdialog.h 93dd30958377fb997a9f10fa2c3cba7702b14350 kio/kio/skipdialog.cpp 98251e058704ef7b8f7fc9b349d8da95c121d2ae kio/tests/jobtest.cpp 7a50857eee19faee995ebbe30e5ba0f954cc858d kio/tests/kdirmodeltest.cpp 6d9f89070d8579bccb494cbeca080498627e2b1e kio/tests/kiotesthelper.h 6ecf13409d0117148cc52c774aa5fced37a28e1d staging/kjobwidgets/src/kdialogjobuidelegate.h f33d34911db53f6e1a90589e70bc9396f049ffc4 staging/kjobwidgets/src/kdialogjobuidelegate.cpp a79eda86f8df34c6996a2f7285ba05466c6f8097 Diff: http://git.reviewboard.kde.org/r/111081/diff/ Testing --- make test Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111103: KPage* belongs to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- Review request for KDE Frameworks. Description --- When I moved KPage*, I moved it to KWidgets because I thought we needed the KGlobalSettings dependency, but then we did some magic so that it wasn't needed. This patch moves it where it belongs. Diffs - staging/kwidgets/src/CMakeLists.txt c019756 staging/kwidgets/src/paged/kpagedialog.h 382e70d staging/kwidgets/src/paged/kpagedialog.cpp 542d6a2 staging/kwidgets/src/paged/kpagedialog_p.h 7eff46b staging/kwidgets/src/paged/kpagemodel.h 6b10b78 staging/kwidgets/src/paged/kpagemodel.cpp 5e5cfa7 staging/kwidgets/src/paged/kpagemodel_p.h 6466f64 staging/kwidgets/src/paged/kpageview.h db624db staging/kwidgets/src/paged/kpageview.cpp d250f32 staging/kwidgets/src/paged/kpageview_p.h 1058579 staging/kwidgets/src/paged/kpageview_p.cpp 180d3bc staging/kwidgets/src/paged/kpagewidget.h a782468 staging/kwidgets/src/paged/kpagewidget.cpp e81ab57 staging/kwidgets/src/paged/kpagewidget_p.h 6eeaeccb staging/kwidgets/src/paged/kpagewidgetmodel.h a53de9a staging/kwidgets/src/paged/kpagewidgetmodel.cpp 0c38059 staging/kwidgets/src/paged/kpagewidgetmodel_p.h 8ab48e6 staging/kwidgets/tests/CMakeLists.txt 564d653 staging/kwidgets/tests/kpagedialogtest.h a5e9be5 staging/kwidgets/tests/kpagedialogtest.cpp b0e8efd staging/kwidgets/tests/kpagewidgettest.h 206255b staging/kwidgets/tests/kpagewidgettest.cpp a767401 tier1/kwidgetsaddons/src/CMakeLists.txt 7a58c0e tier1/kwidgetsaddons/src/kpagedialog.h PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel_p.h PRE-CREATION tier1/kwidgetsaddons/tests/CMakeLists.txt 53c21fc tier1/kwidgetsaddons/tests/kpagedialogtest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagedialogtest.cpp PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/03/diff/ Testing --- builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KGlobalSettings move to kde4support
On Tue, Jun 18, 2013 at 8:14 AM, Kevin Ottens ervin+bluesyst...@kde.orgwrote: Hello, On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. Ah good, it was in my hit list for the coming days too. But if you can handle it that's fine by me. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. - Font methods: They are used in many places in and out of kdelibs, I'm unsure what's the plan for it. Should we create a new class for that? Or add it to QStyle? Or maybe we can just standarize some font names. See kdisplaySetFont() The idea here would be to handle that using our platformtheme plugin when it comes to forcing user set fonts on widgets. I've found the font API to be used outside of kdelibs widgets only seldomly and it was always for fixedFont(), so although not ideal we currently use a dynamic property names _k_fixedFont on the application object to store it (maybe QGuiApplication could be extended to have that as a regular method). The mechanisms I describe above are implemented in staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp Needs review as it might miss some calls to QApplication::setFont Most of the aspects of KGlobalSettings to ensure consistency should likely follow the same path. - isMultiHead: Reads a env variable that tells if KDE has to work on multi head mode. It's only used by plasma and KWin, so we can probably find a better place for the check. Is it even still needed? Nowadays relying on an env variable for that sounds strange... But I might miss something. In any case the code is trivial enough that it could be duplicated in kwin and plasma-framework if need be. - wheelMouseZooms: It's only used by KTextEditor, so I'd say it should be moved there and deprecate it. This one I already checked. No action is required, it's read at only one place and there's no one writing the setting... So effectively users can't change it, only the default is used. - naturalSorting: it's used by KDirOperator and Dolphin. Unsure what it does. It does what Alex Merry said. It's in fact a setting driven by dolphin itself only. It's used only there and in a couple of widgets used in a similar context. I would say it should be fully handled in dolphin itself then. On the kdelibs side the only thing needed is then for the widgets currently reading from that setting to instead provide a setter/getter pair so that dolphin will be able to change their behavior when it sees fit. - graphicEffectsLevel/graphicEffectsLevelDefault: That's being dealt by Alex Fiestas, no? Yep, there's tasks in the wiki around that already. - opaqueResize: I see there's already a task created about it, to move it to Qt. It's about using QSplitter. I guess we can assume this goes to kde4support and it's fine. Yep, the task is there already. - buttonLayout: I really can't tell who uses it, it's impossible to look it up in lxr. Nobody is using it in kdelibs. It's completely unused so we can ignore it. - createApplicationPalette/createNewApplicationPalette: These seems to me that they're only used because of some limitation in the Qt we had in maemo, to force applications to use the oxygen style. For some reason. I'd say the code for this should go to KQGuiPlatformPlugin and just deprecate these interfaces. It's like the fonts, it's handled at least in part in staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp So same treatment: needs to review the corresponding code in our platform theme plugin. - emitChange: it mostly depends on what we do with each exposed property, like we already did for the icon themes. That one it's basically the task on making sure our QPA plugin reacts to setting changes. - activate/activate(options): They only make sense within a KGlobalSettings scope. Agreed. So would it make sense to create separate tasks for each of those elements that don't have an item so that we can work them together? Having a task saying KGlobalSettings move to kde4support is unrealistic to accomplish at the moment. What should be clarified in the wiki is that the moving task in the cleanup page for that one has to come last. It indeed just says move without hinting that we already have other tasks... We probably should have a few more and clarify a few existing ones as you
Re: KF5 Update Meeting Minutes 2013-w25
Hi, I won't be able to redo my patch for https://git.reviewboard.kde.org/r/110907/ because my laptop has a power supply problem and I won't be able to accede to my KF5 build for some time. So it's free for someone to pick it up. Sorry about that, best regards, Anne-Marie - Mail original - De: Kevin Ottens ervin+bluesyst...@kde.org À: kde-frameworks-devel@kde.org Cc: kde-core-de...@kde.org Envoyé: Mardi 18 Juin 2013 17:23:15 Objet: KF5 Update Meeting Minutes 2013-w25 Hello everyone, This is the minutes of the Week 25 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; * On June 22nd, a KF5 mini-sprint will be held in the Blue Systems Barcelona office; * sebas computed progress data number: * Qt contributions 67% done; * KDEUI Crumble 50% done; * kdelibs splitting around 40% done (on hold and will grow though); * kdelibs cleanup 73% done; * cmake 81% done; Were present: dgilo, dfaure, sebas, apol, ben2367, steveire, wojtask9, R_Rios scarpino, afiestas, and myself. Topics discussed: * dfaure is making progresses on the KIO split; * sebas is resuming the work on KPluginFactory; * conditional QML imports is scheduled as post KF 5.0 as a contribution to Qt; * cmake cleanup in plasma-framework is almost done; * apol will spearhead the efforts around KGlobalSettings; * ben2367 is working on kassistantdialog and kcrash; * ben2367 is trying to fix some of the missing copyrights; * steveire is working on cmake features we might use like the easier creation of interface properties on installation so that some of the features we got used to works nicely out of build too; * wojtask9 is working on KWallet and plans to pick KCompletion after that; * R_Rios just joined (welcome!) and will pick more tasks; * scarpino is almost done with the ECM_SourceIncompatibleChanges, ready to pick crumble tasks; * afiestas is working on the animation flag for Qt, and will pick up some tasks related to our QPA plugin; * dgilo is still working on removing our time_t uses; * QFileDialog changes are almost ready to get in Qt; * ervin is trying to get rid of the kdecore left overs; * Priority for the coming week is still the KDEUI Crumble. Action items still open: * [sandsmark] Finish the work on KPtyProcess * [steveire] Write a CMake for frameworks guideline in the wiki * [sebas] Look at cleaning up the CMake files in plasma-framework (almost there) * [steveire] investigate why kde4support isn't usable from outside kdelibs (issue with the cmake file) If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/ --- (Updated June 18, 2013, 9:35 p.m.) Review request for KDE Frameworks. Changes --- Fix suggestions made by Kévin Ottens and David Faure. Description --- Port time_t to QDateTime in HTTP (KIOSLAVE) --Fix some warnings about parentheses in conditionals. --Delete some includes that apparently weren't used. TODO: --Port QRegExp to QRegularExpression --Port QLatin1String to QStringLiteral where needed Diffs (updated) - kioslave/http/http.h b16254ec815106c63f4b73ea4a13a9bc4a393a71 kioslave/http/http.cpp c5a9bb9332ad5a3610faf0193c65fd9cd015faf4 Diff: http://git.reviewboard.kde.org/r/110945/diff/ Testing --- It builds. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111106: Fix export marco in kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/ --- Review request for KDE Frameworks. Description --- Lot of files still use kdecore, kdeui or kparts macro or not deprecated kde4support_export Diffs - staging/kde4support/src/kdecore/kascii.h ff3496e staging/kde4support/src/kdecore/kcmdlineargs.h 91adb2e staging/kde4support/src/kdecore/kgenericfactory.h c4fc666 staging/kde4support/src/kdecore/kglobal.h 743c010 staging/kde4support/src/kdecore/klibloader.cpp a05f7f3 staging/kde4support/src/kdecore/kstandarddirs.h ac36107 staging/kde4support/src/kdeui/k3icon_p.h 0ebc339 staging/kde4support/src/kdeui/kaction.h 875b35f staging/kde4support/src/kdeui/kapplication.h 246abd1 staging/kde4support/src/kdeui/kapplication.cpp efcb6ee staging/kde4support/src/kdeui/kbuttongroup.h 06f2aa2 staging/kde4support/src/kdeui/kcolordialog.h fb42d22 staging/kde4support/src/kdeui/kcolorvalueselector.h a1bea96 staging/kde4support/src/kdeui/kdialog.h 811f423 staging/kde4support/src/kdeui/kdialogbuttonbox.h b7d2e15 staging/kde4support/src/kdeui/keditlistbox.h a38ad1a staging/kde4support/src/kdeui/kfadewidgeteffect.h 99d8d1e staging/kde4support/src/kdeui/kfontdialog.h 717314a staging/kde4support/src/kdeui/khuesaturationselect.h d733728 staging/kde4support/src/kdeui/kmenu.h ae819d5 staging/kde4support/src/kdeui/kmenubar.h 58556db staging/kde4support/src/kdeui/kmessagebox_queued.h d9a0fa0 staging/kde4support/src/kdeui/kmessageboxmessagehandler.h e48a057 staging/kde4support/src/kdeui/knuminput.h 83d7eb1 staging/kde4support/src/kdeui/kpixmapcache.h 691132f staging/kde4support/src/kdeui/kprogressdialog.h 592317e staging/kde4support/src/kdeui/kpushbutton.h 7d349f9 staging/kde4support/src/kdeui/krestrictedline.h 5791dc8 staging/kde4support/src/kdeui/ksessionmanager.h ed2a662 staging/kde4support/src/kdeui/kshortcut.h 9f103fc staging/kde4support/src/kdeui/ksplashscreen.h fa7b37d staging/kde4support/src/kdeui/kstatusbar.h e1a2441 staging/kde4support/src/kdeui/ktabbar.h a5d2cd8 staging/kde4support/src/kdeui/ktabwidget.h df82043 staging/kde4support/src/kdeui/ktextbrowser.h 330e100 staging/kde4support/src/kdeui/kundostack.h 2e9fcc9 staging/kde4support/src/kdeui/kuniqueapplication.h de69715 staging/kde4support/src/kparts/componentfactory.h b52d578 staging/kde4support/src/kparts/factory.h 62fa696 staging/kde4support/src/kparts/genericfactory.h c4373e5 Diff: http://git.reviewboard.kde.org/r/06/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111105: Create KWallet framework and move kwallet.h and others
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Description --- Create KWallet framework and move kwallet.h and others. Notes: Port aways from kdebug remove unused includes Diffs - kdeui/CMakeLists.txt 0f2a0a9 kdeui/tests/CMakeLists.txt 482581c kdeui/tests/kwallettest.h 2cc469d kdeui/tests/kwallettest.cpp 7a91a29 kdeui/util/config-kwallet.h.cmake 00a95dc kdeui/util/kwallet.h eb46a89 kdeui/util/kwallet.cpp 7016b51 kdeui/util/kwallet_mac.cpp ce09f93 kdeui/util/org.kde.KWallet.xml 548c2f8 kdewebkit/CMakeLists.txt 93a44e9 khtml/CMakeLists.txt 010eb95 kio/CMakeLists.txt a29905e staging/CMakeLists.txt 4e4132b staging/kwallet/CMakeLists.txt PRE-CREATION staging/kwallet/KWalletConfig.cmake.in PRE-CREATION staging/kwallet/autotests/CMakeLists.txt PRE-CREATION staging/kwallet/src/CMakeLists.txt PRE-CREATION staging/kwallet/src/config-kwallet.h.cmake PRE-CREATION staging/kwallet/src/kwallet.h PRE-CREATION staging/kwallet/src/kwallet.cpp PRE-CREATION staging/kwallet/src/kwallet_mac.cpp PRE-CREATION staging/kwallet/src/org.kde.KWallet.xml PRE-CREATION staging/kwallet/tests/CMakeLists.txt PRE-CREATION staging/kwallet/tests/kwallettest.h PRE-CREATION staging/kwallet/tests/kwallettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111106: Fix export marco in kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/#review34625 --- Ship it! Cleaning up! ^^ good stuff - Aleix Pol Gonzalez On June 18, 2013, 9:38 p.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/ --- (Updated June 18, 2013, 9:38 p.m.) Review request for KDE Frameworks. Description --- Lot of files still use kdecore, kdeui or kparts macro or not deprecated kde4support_export Diffs - staging/kde4support/src/kdecore/kascii.h ff3496e staging/kde4support/src/kdecore/kcmdlineargs.h 91adb2e staging/kde4support/src/kdecore/kgenericfactory.h c4fc666 staging/kde4support/src/kdecore/kglobal.h 743c010 staging/kde4support/src/kdecore/klibloader.cpp a05f7f3 staging/kde4support/src/kdecore/kstandarddirs.h ac36107 staging/kde4support/src/kdeui/k3icon_p.h 0ebc339 staging/kde4support/src/kdeui/kaction.h 875b35f staging/kde4support/src/kdeui/kapplication.h 246abd1 staging/kde4support/src/kdeui/kapplication.cpp efcb6ee staging/kde4support/src/kdeui/kbuttongroup.h 06f2aa2 staging/kde4support/src/kdeui/kcolordialog.h fb42d22 staging/kde4support/src/kdeui/kcolorvalueselector.h a1bea96 staging/kde4support/src/kdeui/kdialog.h 811f423 staging/kde4support/src/kdeui/kdialogbuttonbox.h b7d2e15 staging/kde4support/src/kdeui/keditlistbox.h a38ad1a staging/kde4support/src/kdeui/kfadewidgeteffect.h 99d8d1e staging/kde4support/src/kdeui/kfontdialog.h 717314a staging/kde4support/src/kdeui/khuesaturationselect.h d733728 staging/kde4support/src/kdeui/kmenu.h ae819d5 staging/kde4support/src/kdeui/kmenubar.h 58556db staging/kde4support/src/kdeui/kmessagebox_queued.h d9a0fa0 staging/kde4support/src/kdeui/kmessageboxmessagehandler.h e48a057 staging/kde4support/src/kdeui/knuminput.h 83d7eb1 staging/kde4support/src/kdeui/kpixmapcache.h 691132f staging/kde4support/src/kdeui/kprogressdialog.h 592317e staging/kde4support/src/kdeui/kpushbutton.h 7d349f9 staging/kde4support/src/kdeui/krestrictedline.h 5791dc8 staging/kde4support/src/kdeui/ksessionmanager.h ed2a662 staging/kde4support/src/kdeui/kshortcut.h 9f103fc staging/kde4support/src/kdeui/ksplashscreen.h fa7b37d staging/kde4support/src/kdeui/kstatusbar.h e1a2441 staging/kde4support/src/kdeui/ktabbar.h a5d2cd8 staging/kde4support/src/kdeui/ktabwidget.h df82043 staging/kde4support/src/kdeui/ktextbrowser.h 330e100 staging/kde4support/src/kdeui/kundostack.h 2e9fcc9 staging/kde4support/src/kdeui/kuniqueapplication.h de69715 staging/kde4support/src/kparts/componentfactory.h b52d578 staging/kde4support/src/kparts/factory.h 62fa696 staging/kde4support/src/kparts/genericfactory.h c4373e5 Diff: http://git.reviewboard.kde.org/r/06/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111105: Create KWallet framework and move kwallet.h and others
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 18, 2013, 10:38 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Changes --- git diff HEAD~1 -M80% as apol suggested Description --- Create KWallet framework and move kwallet.h and others. Notes: Port aways from kdebug remove unused includes Diffs (updated) - kdeui/CMakeLists.txt 0f2a0a9 kdeui/tests/CMakeLists.txt 482581c kdeui/tests/kwallettest.h kdeui/tests/kwallettest.cpp 7a91a29 kdeui/util/config-kwallet.h.cmake kdeui/util/kwallet.h eb46a89 kdeui/util/kwallet.cpp 7016b51 kdeui/util/kwallet_mac.cpp ce09f93 kdeui/util/org.kde.KWallet.xml kdewebkit/CMakeLists.txt 93a44e9 khtml/CMakeLists.txt 010eb95 kio/CMakeLists.txt a29905e staging/CMakeLists.txt 4e4132b staging/kwallet/CMakeLists.txt PRE-CREATION staging/kwallet/KWalletConfig.cmake.in PRE-CREATION staging/kwallet/autotests/CMakeLists.txt PRE-CREATION staging/kwallet/src/CMakeLists.txt PRE-CREATION staging/kwallet/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/#review34631 --- Ship it! Ship It! - David Faure On June 18, 2013, 9:35 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/ --- (Updated June 18, 2013, 9:35 p.m.) Review request for KDE Frameworks. Description --- Port time_t to QDateTime in HTTP (KIOSLAVE) --Fix some warnings about parentheses in conditionals. --Delete some includes that apparently weren't used. TODO: --Port QRegExp to QRegularExpression --Port QLatin1String to QStringLiteral where needed Diffs - kioslave/http/http.h b16254ec815106c63f4b73ea4a13a9bc4a393a71 kioslave/http/http.cpp c5a9bb9332ad5a3610faf0193c65fd9cd015faf4 Diff: http://git.reviewboard.kde.org/r/110945/diff/ Testing --- It builds. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/ --- (Updated June 18, 2013, 11:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Port time_t to QDateTime in HTTP (KIOSLAVE) --Fix some warnings about parentheses in conditionals. --Delete some includes that apparently weren't used. TODO: --Port QRegExp to QRegularExpression --Port QLatin1String to QStringLiteral where needed Diffs - kioslave/http/http.h b16254ec815106c63f4b73ea4a13a9bc4a393a71 kioslave/http/http.cpp c5a9bb9332ad5a3610faf0193c65fd9cd015faf4 Diff: http://git.reviewboard.kde.org/r/110945/diff/ Testing --- It builds. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #737
See http://build.kde.org/job/kdelibs_frameworks_qt5/737/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111105: Create KWallet framework and move kwallet.h and others
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/#review34636 --- hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui). Not sure what to do because kwallettest requires kwalletd - Wojciech Kapuscinski On June 18, 2013, 10:38 p.m., Wojciech Kapuscinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 18, 2013, 10:38 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Description --- Create KWallet framework and move kwallet.h and others. Notes: Port aways from kdebug remove unused includes Diffs - kdeui/CMakeLists.txt 0f2a0a9 kdeui/tests/CMakeLists.txt 482581c kdeui/tests/kwallettest.h kdeui/tests/kwallettest.cpp 7a91a29 kdeui/util/config-kwallet.h.cmake kdeui/util/kwallet.h eb46a89 kdeui/util/kwallet.cpp 7016b51 kdeui/util/kwallet_mac.cpp ce09f93 kdeui/util/org.kde.KWallet.xml kdewebkit/CMakeLists.txt 93a44e9 khtml/CMakeLists.txt 010eb95 kio/CMakeLists.txt a29905e staging/CMakeLists.txt 4e4132b staging/kwallet/CMakeLists.txt PRE-CREATION staging/kwallet/KWalletConfig.cmake.in PRE-CREATION staging/kwallet/autotests/CMakeLists.txt PRE-CREATION staging/kwallet/src/CMakeLists.txt PRE-CREATION staging/kwallet/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w25
On Tuesday 18 June 2013 20:34:31 Anne-Marie Mahfouf wrote: I won't be able to redo my patch for https://git.reviewboard.kde.org/r/110907/ because my laptop has a power supply problem and I won't be able to accede to my KF5 build for some time. So it's free for someone to pick it up. Sorry about that, best regards, OK, we'll try to get it in for you today. Hope your laptop will get better soon, we miss you. ;-) Cheers! -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
