Re: KGlobalSettings move to kde4support

2013-06-19 Thread Kevin Ottens
Hello, On Tuesday 18 June 2013 20:00:40 Aleix Pol wrote: I added theme here [1]. Can you take a look and see if it's what you expected? :) Mostly good, I adjusted just a bit. I also removed the tasks which were deprecate only. The whole class will get deprecated when moving in kde4support,

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-19 Thread Kevin Ottens
On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/tests/jobtest.cpp, line 264 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164106#file164106line264 Do we agree that the goal is that both uiDelegate() and interactionInterface() will return 0 if you link only kiocore?

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34643 --- Ship it! Ship It! - Kevin Ottens On June 18, 2013, 5:32

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-19 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 19, 2013, 9:49 a.m.) Review request for KDE Frameworks,

Re: Review Request 110988: Port kio-file to QFile

2013-06-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated June 19, 2013, 1:04 p.m.) Review request for KDE Frameworks.

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-19 Thread Kevin Ottens
Hello, On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; Due to git.kde.org being unreachable most of today, we're extending the

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- (Updated June 19, 2013, 2:47 p.m.) Status -- This change has been

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34679 --- This review has been submitted with commit

Re: KGlobalSettings move to kde4support

2013-06-19 Thread Aleix Pol
On Tue, Jun 18, 2013 at 5:54 PM, Aleix Pol aleix...@kde.org wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke mwoehlke.fl...@gmail.com wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-19 Thread Valentin Rusu
On June 19, 2013, 1:26 a.m., Wojciech Kapuscinski wrote: hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui). Not sure what to do because kwallettest requires kwalletd Perhaps we could use this kdeui splitting opportunity to bring here kwalletd from

Re: KGlobalSettings move to kde4support

2013-06-19 Thread Matthew Woehlke
On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we

Re: Re: KGlobalSettings move to kde4support

2013-06-19 Thread Martin Gräßlin
On Wednesday 19 June 2013 15:04:57 Matthew Woehlke wrote: On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix