Re: KGlobalSettings move to kde4support
Hello, On Tuesday 18 June 2013 20:00:40 Aleix Pol wrote: I added theme here [1]. Can you take a look and see if it's what you expected? :) Mostly good, I adjusted just a bit. I also removed the tasks which were deprecate only. The whole class will get deprecated when moving in kde4support, so no action is required apart from the dependency cuts incurred by the move (part of the move task IMO). Regards. [1] http://community.kde.org/Frameworks/Epics/kdelibs_cleanups -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111081: KIO::Job: more core/gui splitup.
On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: kio/tests/jobtest.cpp, line 264 http://git.reviewboard.kde.org/r/111081/diff/1/?file=164106#file164106line264 Do we agree that the goal is that both uiDelegate() and interactionInterface() will return 0 if you link only kiocore? In such case those lines will become useless in automated tests? At that point it's probably even better if in the tests initTestCase() methods you register mock interfaces which allow to check what the job calls in the interfaces. David Faure wrote: Yes, however if you suddenly link another lib and it breaks your tests, that would count as rather unexpected, wouldn't it? In any case, at this point, the splitup is not done, so I'm exactly in that situation: the widget-based interaction interface is getting registered, so I need the explicit setting-to-0. About your last question, there are three cases, really: 1) in some cases we just expect the job to work, and if there's a bug, we want an error code rather than a widget popping up. That's the case at the line where you added the comment, see the QVERIFY(ok) two lines down. 2) I use mock interfaces in some places, see PredefinedAnswerJobUiDelegate used in kdirmodeltest.cpp: job-setInteractionInterface(delegate); [ok, the naming is a bit historical] 3) indeed there are also cases where we expect the job to fail, like the two lines with no skip dialog, thanks as comment. The point of the test wasn't to test the user interaction though. Could be added, of course, there's always room for more testing... Yes, I wasn't arguing about removing those lines *now*. They're still necessary. I was just checking we were in agreement on where it's going. :-) I apparently opened an issue by mistake (forgot to uncheck the option apparently). - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/#review34581 --- On June 18, 2013, 7:39 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- (Updated June 18, 2013, 7:39 a.m.) Review request for KDE Frameworks. Description --- KIO::Job: more core/gui splitup. job-ui() no longer returns a KIO-specific class which was holding QWidget* window and usertimestamp. It now returns the core-only base class, like in KJob. The widget-specific information is stored as a dynamic property into the job, using KJobWidgets API. Split up delegate (for error handling) and interaction interface InteractionInterface is used for the rename and skip dialog, shown by copyjob and movejob. Diffs - KDE5PORTING.html 9cac0c69861b999d968c7af5bdeb113b17086b86 kio/kio/copyjob.cpp e403735f05d644463122728af3a0694454d31367 kio/kio/job.cpp 365752866ef44d79b42c41af38b446c9fd407c7b kio/kio/job_p.h e1dd97995825a372d81a8098e0da38bb821b7a20 kio/kio/jobclasses.h 27a0f12788d35b95934ac714b58df99478e36c31 kio/kio/jobuidelegate.h 87d9d2777f8bd28e417f54900bf85826fef7fa9b kio/kio/jobuidelegate.cpp 9f7e1b2093bb22fff5105bdc958ef519bbee8fcb kio/kio/renamedialog.h 2b9efe21bb5266ced199d2be9b2f8e45df2be4d3 kio/kio/skipdialog.h 93dd30958377fb997a9f10fa2c3cba7702b14350 kio/kio/skipdialog.cpp 98251e058704ef7b8f7fc9b349d8da95c121d2ae kio/tests/jobtest.cpp 7a50857eee19faee995ebbe30e5ba0f954cc858d kio/tests/kdirmodeltest.cpp 6d9f89070d8579bccb494cbeca080498627e2b1e kio/tests/kiotesthelper.h 6ecf13409d0117148cc52c774aa5fced37a28e1d staging/kjobwidgets/src/kdialogjobuidelegate.h f33d34911db53f6e1a90589e70bc9396f049ffc4 staging/kjobwidgets/src/kdialogjobuidelegate.cpp a79eda86f8df34c6996a2f7285ba05466c6f8097 Diff: http://git.reviewboard.kde.org/r/111081/diff/ Testing --- make test Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111103: KPage* belongs to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34643 --- Ship it! Ship It! - Kevin Ottens On June 18, 2013, 5:32 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- (Updated June 18, 2013, 5:32 p.m.) Review request for KDE Frameworks. Description --- When I moved KPage*, I moved it to KWidgets because I thought we needed the KGlobalSettings dependency, but then we did some magic so that it wasn't needed. This patch moves it where it belongs. Diffs - staging/kwidgets/src/CMakeLists.txt c019756 staging/kwidgets/src/paged/kpagedialog.h 382e70d staging/kwidgets/src/paged/kpagedialog.cpp 542d6a2 staging/kwidgets/src/paged/kpagedialog_p.h 7eff46b staging/kwidgets/src/paged/kpagemodel.h 6b10b78 staging/kwidgets/src/paged/kpagemodel.cpp 5e5cfa7 staging/kwidgets/src/paged/kpagemodel_p.h 6466f64 staging/kwidgets/src/paged/kpageview.h db624db staging/kwidgets/src/paged/kpageview.cpp d250f32 staging/kwidgets/src/paged/kpageview_p.h 1058579 staging/kwidgets/src/paged/kpageview_p.cpp 180d3bc staging/kwidgets/src/paged/kpagewidget.h a782468 staging/kwidgets/src/paged/kpagewidget.cpp e81ab57 staging/kwidgets/src/paged/kpagewidget_p.h 6eeaeccb staging/kwidgets/src/paged/kpagewidgetmodel.h a53de9a staging/kwidgets/src/paged/kpagewidgetmodel.cpp 0c38059 staging/kwidgets/src/paged/kpagewidgetmodel_p.h 8ab48e6 staging/kwidgets/tests/CMakeLists.txt 564d653 staging/kwidgets/tests/kpagedialogtest.h a5e9be5 staging/kwidgets/tests/kpagedialogtest.cpp b0e8efd staging/kwidgets/tests/kpagewidgettest.h 206255b staging/kwidgets/tests/kpagewidgettest.cpp a767401 tier1/kwidgetsaddons/src/CMakeLists.txt 7a58c0e tier1/kwidgetsaddons/src/kpagedialog.h PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel_p.h PRE-CREATION tier1/kwidgetsaddons/tests/CMakeLists.txt 53c21fc tier1/kwidgetsaddons/tests/kpagedialogtest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagedialogtest.cpp PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/03/diff/ Testing --- builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111105: Create KWallet framework and move kwallet.h and others
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 19, 2013, 9:49 a.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Description --- Create KWallet framework and move kwallet.h and others. Notes: Port aways from kdebug remove unused includes Diffs (updated) - kdeui/CMakeLists.txt 0f2a0a9 kdeui/tests/CMakeLists.txt 482581c kdeui/tests/kwallettest.h kdeui/tests/kwallettest.cpp 7a91a29 kdeui/util/config-kwallet.h.cmake kdeui/util/kwallet.h eb46a89 kdeui/util/kwallet.cpp 7016b51 kdeui/util/kwallet_mac.cpp ce09f93 kdeui/util/org.kde.KWallet.xml kdewebkit/CMakeLists.txt 93a44e9 khtml/CMakeLists.txt 010eb95 kio/CMakeLists.txt a29905e staging/CMakeLists.txt 4e4132b staging/kwallet/CMakeLists.txt PRE-CREATION staging/kwallet/KWalletConfig.cmake.in PRE-CREATION staging/kwallet/autotests/CMakeLists.txt PRE-CREATION staging/kwallet/src/CMakeLists.txt PRE-CREATION staging/kwallet/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 110988: Port kio-file to QFile
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated June 19, 2013, 1:04 p.m.) Review request for KDE Frameworks. Changes --- Updated as per comments Description --- Ports away kioslave/file from unix/kde specific calls to QFile calls Diffs (updated) - kioslave/file/file.h 93aeef4 kioslave/file/file.cpp d57517b kioslave/file/file_unix.cpp 8b92e06 Diff: http://git.reviewboard.kde.org/r/110988/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w25
Hello, On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; Due to git.kde.org being unreachable most of today, we're extending the window a bit. So please don't start new patches tomorrow too, and let's try to integrate as many as we can tomorrow. dfaure will do his merge on friday morning. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111103: KPage* belongs to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- (Updated June 19, 2013, 2:47 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- When I moved KPage*, I moved it to KWidgets because I thought we needed the KGlobalSettings dependency, but then we did some magic so that it wasn't needed. This patch moves it where it belongs. Diffs - staging/kwidgets/src/CMakeLists.txt c019756 staging/kwidgets/src/paged/kpagedialog.h 382e70d staging/kwidgets/src/paged/kpagedialog.cpp 542d6a2 staging/kwidgets/src/paged/kpagedialog_p.h 7eff46b staging/kwidgets/src/paged/kpagemodel.h 6b10b78 staging/kwidgets/src/paged/kpagemodel.cpp 5e5cfa7 staging/kwidgets/src/paged/kpagemodel_p.h 6466f64 staging/kwidgets/src/paged/kpageview.h db624db staging/kwidgets/src/paged/kpageview.cpp d250f32 staging/kwidgets/src/paged/kpageview_p.h 1058579 staging/kwidgets/src/paged/kpageview_p.cpp 180d3bc staging/kwidgets/src/paged/kpagewidget.h a782468 staging/kwidgets/src/paged/kpagewidget.cpp e81ab57 staging/kwidgets/src/paged/kpagewidget_p.h 6eeaeccb staging/kwidgets/src/paged/kpagewidgetmodel.h a53de9a staging/kwidgets/src/paged/kpagewidgetmodel.cpp 0c38059 staging/kwidgets/src/paged/kpagewidgetmodel_p.h 8ab48e6 staging/kwidgets/tests/CMakeLists.txt 564d653 staging/kwidgets/tests/kpagedialogtest.h a5e9be5 staging/kwidgets/tests/kpagedialogtest.cpp b0e8efd staging/kwidgets/tests/kpagewidgettest.h 206255b staging/kwidgets/tests/kpagewidgettest.cpp a767401 tier1/kwidgetsaddons/src/CMakeLists.txt 7a58c0e tier1/kwidgetsaddons/src/kpagedialog.h PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel_p.h PRE-CREATION tier1/kwidgetsaddons/tests/CMakeLists.txt 53c21fc tier1/kwidgetsaddons/tests/kpagedialogtest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagedialogtest.cpp PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/03/diff/ Testing --- builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111103: KPage* belongs to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34679 --- This review has been submitted with commit 3deb3f51251c1eeb55b544cc4d9f1e2fa2a4269f by Aleix Pol to branch frameworks. - Commit Hook On June 18, 2013, 5:32 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- (Updated June 18, 2013, 5:32 p.m.) Review request for KDE Frameworks. Description --- When I moved KPage*, I moved it to KWidgets because I thought we needed the KGlobalSettings dependency, but then we did some magic so that it wasn't needed. This patch moves it where it belongs. Diffs - staging/kwidgets/src/CMakeLists.txt c019756 staging/kwidgets/src/paged/kpagedialog.h 382e70d staging/kwidgets/src/paged/kpagedialog.cpp 542d6a2 staging/kwidgets/src/paged/kpagedialog_p.h 7eff46b staging/kwidgets/src/paged/kpagemodel.h 6b10b78 staging/kwidgets/src/paged/kpagemodel.cpp 5e5cfa7 staging/kwidgets/src/paged/kpagemodel_p.h 6466f64 staging/kwidgets/src/paged/kpageview.h db624db staging/kwidgets/src/paged/kpageview.cpp d250f32 staging/kwidgets/src/paged/kpageview_p.h 1058579 staging/kwidgets/src/paged/kpageview_p.cpp 180d3bc staging/kwidgets/src/paged/kpagewidget.h a782468 staging/kwidgets/src/paged/kpagewidget.cpp e81ab57 staging/kwidgets/src/paged/kpagewidget_p.h 6eeaeccb staging/kwidgets/src/paged/kpagewidgetmodel.h a53de9a staging/kwidgets/src/paged/kpagewidgetmodel.cpp 0c38059 staging/kwidgets/src/paged/kpagewidgetmodel_p.h 8ab48e6 staging/kwidgets/tests/CMakeLists.txt 564d653 staging/kwidgets/tests/kpagedialogtest.h a5e9be5 staging/kwidgets/tests/kpagedialogtest.cpp b0e8efd staging/kwidgets/tests/kpagewidgettest.h 206255b staging/kwidgets/tests/kpagewidgettest.cpp a767401 tier1/kwidgetsaddons/src/CMakeLists.txt 7a58c0e tier1/kwidgetsaddons/src/kpagedialog.h PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagedialog_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagemodel_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpageview_p.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidget_p.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.h PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel.cpp PRE-CREATION tier1/kwidgetsaddons/src/kpagewidgetmodel_p.h PRE-CREATION tier1/kwidgetsaddons/tests/CMakeLists.txt 53c21fc tier1/kwidgetsaddons/tests/kpagedialogtest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagedialogtest.cpp PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.h PRE-CREATION tier1/kwidgetsaddons/tests/kpagewidgettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/03/diff/ Testing --- builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KGlobalSettings move to kde4support
On Tue, Jun 18, 2013 at 5:54 PM, Aleix Pol aleix...@kde.org wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke mwoehlke.fl...@gmail.com wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? What are these used for? They sound like WM colors? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. Perhaps, but KColorScheme already has quite some colors and they are (fairly) well organized at the moment. I would like to understand first what these other colors are used for and if maybe existing colors should be used instead, or at least how to best fit them into the existing framework. Thanks, (Please keep me CC'd.) -- Matthew __**_ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/**listinfo/kde-frameworks-develhttps://mail.kde.org/mailman/listinfo/kde-frameworks-devel Hi, Here you can see where and how it's used: http://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=inactiveTitleColorhttp://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=activeCaptionColorhttp://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=inactiveCaptionColor Aleix Hi Matthew, Can we have your insight in this? I'd appreciate it very much. Aleix PS: it wasn't Caption, it was Text http://lxr.kde.org/ident?i=activeTextColor http://lxr.kde.org/ident?i=inactiveTextColor ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111105: Create KWallet framework and move kwallet.h and others
On June 19, 2013, 1:26 a.m., Wojciech Kapuscinski wrote: hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui). Not sure what to do because kwallettest requires kwalletd Perhaps we could use this kdeui splitting opportunity to bring here kwalletd from kdeutils. We could end-up with a standalone framework, in respect to KF5 aim, IMHO. - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/#review34636 --- On June 19, 2013, 9:49 a.m., Wojciech Kapuscinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 19, 2013, 9:49 a.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Description --- Create KWallet framework and move kwallet.h and others. Notes: Port aways from kdebug remove unused includes Diffs - kdeui/CMakeLists.txt 0f2a0a9 kdeui/tests/CMakeLists.txt 482581c kdeui/tests/kwallettest.h kdeui/tests/kwallettest.cpp 7a91a29 kdeui/util/config-kwallet.h.cmake kdeui/util/kwallet.h eb46a89 kdeui/util/kwallet.cpp 7016b51 kdeui/util/kwallet_mac.cpp ce09f93 kdeui/util/org.kde.KWallet.xml kdewebkit/CMakeLists.txt 93a44e9 khtml/CMakeLists.txt 010eb95 kio/CMakeLists.txt a29905e staging/CMakeLists.txt 4e4132b staging/kwallet/CMakeLists.txt PRE-CREATION staging/kwallet/KWalletConfig.cmake.in PRE-CREATION staging/kwallet/autotests/CMakeLists.txt PRE-CREATION staging/kwallet/src/CMakeLists.txt PRE-CREATION staging/kwallet/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KGlobalSettings move to kde4support
On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? What are these used for? They sound like WM colors? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. Perhaps, but KColorScheme already has quite some colors and they are (fairly) well organized at the moment. I would like to understand first what these other colors are used for and if maybe existing colors should be used instead, or at least how to best fit them into the existing framework. Here you can see where and how it's used: http://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=inactiveTitleColor http://lxr.kde.org/ident?i=activeCaptionColor http://lxr.kde.org/ident?i=inactiveCaptionColor Yes, those appear to be the WM colors. Two possibilities come to mind. One is to continue to treat WM colors as totally independent. I think this would be best done by creating a new class similar to KColorScheme but not the same class, maybe KWmColorScheme. This is the simplest and most similar to the current state of things. The best way I have come up with to extend KColorScheme to support WM's is to add a new color set, maybe TitleBar or Caption, and to add a new decoration role BorderColor (defaulting to normal background). The new color set would need to load both border color, and all colors for the Inactive state, separately from settings so that users have the same degree of control as before. (Actually maybe not border color; I don't think the KCM allows setting that independently at the moment. Maybe we could even omit border color entirely, at least for now.) The advantages of the second method are that WM's would also newly get all the additional color role goodness (window title bar with PositiveBackground, anyone?) and users can again configure the secondary (blend) title bar background color (as this should switch over to the AlternateBackground role). However it makes KColorScheme's life harder due to the special case code for loading colors for the new set, and requires more changes to the KCM. -- Matthew ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: KGlobalSettings move to kde4support
On Wednesday 19 June 2013 15:04:57 Matthew Woehlke wrote: On 2013-06-18 11:54, Aleix Pol wrote: On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within kdelibs) and I don't know if they're configurable. I guess they should be using KColorScheme, although I don't see caption properties there. Ideas? What are these used for? They sound like WM colors? It's used a bit outside of kdelibs, but not much indeed. Still as you said it likely makes most sense in KColorScheme. So I'd say extend KColorScheme accordingly and then deprecate. Perhaps, but KColorScheme already has quite some colors and they are (fairly) well organized at the moment. I would like to understand first what these other colors are used for and if maybe existing colors should be used instead, or at least how to best fit them into the existing framework. Here you can see where and how it's used: http://lxr.kde.org/ident?i=activeTitleColor http://lxr.kde.org/ident?i=inactiveTitleColor http://lxr.kde.org/ident?i=activeCaptionColor http://lxr.kde.org/ident?i=inactiveCaptionColor Yes, those appear to be the WM colors. I just had a look at the usage of KGlobalSettings inside KWin: none of these colors are used - neither in KWin core nor in the window decorations shipped with KWin. KWin reads color values with these names from a config group called WM without using KGlobalSettings (see kde- workspace/kwin/libkdecorations/kdecoration_p.cpp line 60ff). But tracing back the argument passed into this method: it always reads the values from kwinrc, never from kdeglobals. In case that had once been supported: it's at least broken since 4.0. So from my side there is no need to keep any special handling. If we want to make this work again we just need to modify the KCM to change kwin's config file for these colors. Cheers Martin Gräßlin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
