Re: Revising changing configurations with KConfig

2013-08-01 Thread Frank Reininghaus
Hi, 2013/8/1 Kevin Ottens: On Thursday 01 August 2013 00:57:05 Aleix Pol wrote: Well, that setting is used in KDirSortFilterProxyModel as well... Should we just always sort naturally by default there then? Would make sense to add an accessor pair to KDirSortFilterProxyModel, and have the

Re: Revising changing configurations with KConfig

2013-08-01 Thread Kevin Ottens
Hello, On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: Well, KDirSortFilterProxyModel is being used indirectly by every application which has a File Open/Save dialog, and by apps like Kate which use a KDirOperator to display the contents of a directory somewhere else. Hm...

Build failed in Jenkins: plasma-framework_master_qt5 #531

2013-08-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/531/changes Changes: [sebas] Fix qDebug/kDebug port -- [...truncated 522 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:984:36: warning: ‘KUrl’ is

Re: Ki18n mostly ready

2013-08-01 Thread Chusslove Illich
[: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc file) whether to generate tr or i18n calls. So another option to specify

Build failed in Jenkins: plasma-framework_master_qt5 #532

2013-08-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/532/changes Changes: [sebas] Fix fallout from qDebug - kDebug porting -- [...truncated 804 lines...] Building CXX object

Jenkins build is back to stable : plasma-framework_master_qt5 #534

2013-08-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/534/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111833/ --- Review request for KDE Frameworks. Summary (updated) -

Re: Ki18n mostly ready

2013-08-01 Thread Kevin Ottens
Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: [: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc

Re: Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111833/ --- (Updated Aug. 1, 2013, 11:03 a.m.) Review request for KDE Frameworks.

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36906 --- Some more nitpicks from my side - sorry Sebas I hope you don't

Review Request 111834: Move KHelpClient into xmlgui

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111834/ --- Review request for KDE Frameworks. Description --- The class still

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote: Some more nitpicks from my side - sorry Sebas I hope you don't think I'm too pedantic :) But I hope others read this as well and start following the new best-practices for Qt5 codebases. No problem at all, in fact I much appreciate the

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 4:32 p.m.) Review request for KDE Frameworks and

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36923 --- staging/kservice/tools/desktoptojson/kconfigtojson.h

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57 Do we want the output/errors to be translated? It's really a helper tool for the build

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 5:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 5:49 p.m.) Review request for KDE Frameworks and

Review Request 111841: Prefer job-exec() to synchronousRun

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- Review request for KDE Frameworks. Description --- Ports all uses of

Re: Review Request 111841: Prefer job-exec() to synchronousRun

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 1, 2013, 5:52 p.m.) Review request for KDE Frameworks.

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Kevin Krammer
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57 Do we want the output/errors to be translated? Sebastian Kügler wrote: It's really a

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36933 --- nearly there! :)

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Nicolás Alvarez
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60 just do return convert(...); No, that would give the opposite return value. To have the same

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:59 p.m.) Review request for KDE Frameworks and

Problem compiling

2013-08-01 Thread David Gil Oliva
Hi, I'm having problems compiling KF5. The configuration gives me this: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at

Re: Revising changing configurations with KConfig

2013-08-01 Thread Albert Astals Cid
El Dijous, 1 d'agost de 2013, a les 08:28:13, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: Well, KDirSortFilterProxyModel is being used indirectly by every application which has a File Open/Save dialog, and by apps like Kate which use a

Re: Ki18n mostly ready

2013-08-01 Thread Albert Astals Cid
El Dijous, 1 d'agost de 2013, a les 12:54:07, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: [: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig isn't supposed to depend on ki18n at all. It does generate

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60 just do return convert(...); Nicolás Alvarez wrote: No, that would give the opposite

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36947 --- Ship it! awesome, I like it now :) - Milian Wolff On Aug.

Re: Revising changing configurations with KConfig

2013-08-01 Thread Kevin Ottens
On Thursday 01 August 2013 22:02:15 Albert Astals Cid wrote: El Dijous, 1 d'agost de 2013, a les 08:28:13, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: Well, KDirSortFilterProxyModel is being used indirectly by every application which

Re: Ki18n mostly ready

2013-08-01 Thread Kevin Ottens
On Thursday 01 August 2013 22:03:36 Albert Astals Cid wrote: El Dijous, 1 d'agost de 2013, a les 12:54:07, Kevin Ottens va escriure: Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: [: Kevin Ottens :] What's needed for kconfig_compiler? Because currently kconfig