Review Request 112096: Port KWindowEffects to XCB
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/ --- Review request for KDE Frameworks and Marco Martin. Description --- Basically a rewrite of the X11 implementation of KWindowEffects to XCB. To ensure that it doesn't break I added unit tests for everything except isEffectAvailable (that can hardly be tested as it requires a running KWin). Please note: this patch is on top of review #112052 Diffs - tier1/kwindowsystem/autotests/CMakeLists.txt 5e05c6d tier1/kwindowsystem/autotests/kwindoweffectstest.cpp PRE-CREATION tier1/kwindowsystem/src/kwindoweffects.h bf77e7c tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112096/diff/ Testing --- See new unit tests and test application in kde:scratch/graesslin/kwindoweffectsplugin.git Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112079: Add utility function to paint icon overlays
On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote: staging/kguiaddons/src/util/qiconoverlay.h, line 29 http://git.reviewboard.kde.org/r/112079/diff/1/?file=179563#file179563line29 Since the methods are in a KIconUtils namespace, maybe their name can be simplified to addOverlay()? Yup, good point, will change. On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote: staging/kguiaddons/src/util/qiconoverlay.cpp, line 26 http://git.reviewboard.kde.org/r/112079/diff/1/?file=179564#file179564line26 Qt doc says you should inherit from QIconEngineV2 instead That's Qt4, Qt5 does not have V2 anymore (see http://doc-snapshot.qt-project.org/qt5-dev/qtgui/qiconengine.html) - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review37765 --- On Aug. 14, 2013, 10:49 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 14, 2013, 10:49 a.m.) Review request for KDE Frameworks. Description --- As this was rejected from QIcon, I decided to implement it in frameworks. The idea is new private icon engine (KOverlayIconEngine), which paints the overlays itself, and then an utility function in KIconUtils:: namespace, which takes the base icon and the overlay icons as parameters and constructs new QIcon using KOverlayIconEngine. As QPixmapIconEngine (QIcon default) is private in Qt and couldn't be simply extended, the KOverlayIconEngine simply forwards the calls to QIcon, which then forwards those calls internally to QPixmapIconEngine (QIcon is really mostly just a wrapper around an engine). There are two functions QIcon KIconUtils::kIconAddOverlay(const QIcon icon, const QIcon overlay, Qt::Corner position); and QIcon KIconUtils::kIconAddOverlay(const QIcon icon, QHashQt::Corner, QIcon overlays); The first one serves for single overlay icon, the second one is then for multiple overlays, requires the QHash to be built up before passing though. Diffs - staging/kguiaddons/src/CMakeLists.txt fc8941a staging/kguiaddons/src/util/qiconoverlay.h PRE-CREATION staging/kguiaddons/src/util/qiconoverlay.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112079/diff/ Testing --- I have a small testing app with 3 QLabels, testing both ::paint() and ::pixmap() methods, all works \o/ I'm thinking about bundling the app with kguiaddons and/or additionally creating a unittest for it (I have one for Qt already), but I'll do that later as I'm off to vacation and I'd like to get comments for the code. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112079: Add utility function to paint icon overlays
On Aug. 14, 2013, 3:40 p.m., Aurélien Gâteau wrote: Forgot one thing: file names should be renamed to not start with q. Maybe kiconoverlay.*? Yeah I wasn't really sure about the name, but I didn't want to name it kiconoverlay as there is no kicon (and it puts overlay over qicon). Well, kiconutils.* ? - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review37774 --- On Aug. 14, 2013, 10:49 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 14, 2013, 10:49 a.m.) Review request for KDE Frameworks. Description --- As this was rejected from QIcon, I decided to implement it in frameworks. The idea is new private icon engine (KOverlayIconEngine), which paints the overlays itself, and then an utility function in KIconUtils:: namespace, which takes the base icon and the overlay icons as parameters and constructs new QIcon using KOverlayIconEngine. As QPixmapIconEngine (QIcon default) is private in Qt and couldn't be simply extended, the KOverlayIconEngine simply forwards the calls to QIcon, which then forwards those calls internally to QPixmapIconEngine (QIcon is really mostly just a wrapper around an engine). There are two functions QIcon KIconUtils::kIconAddOverlay(const QIcon icon, const QIcon overlay, Qt::Corner position); and QIcon KIconUtils::kIconAddOverlay(const QIcon icon, QHashQt::Corner, QIcon overlays); The first one serves for single overlay icon, the second one is then for multiple overlays, requires the QHash to be built up before passing though. Diffs - staging/kguiaddons/src/CMakeLists.txt fc8941a staging/kguiaddons/src/util/qiconoverlay.h PRE-CREATION staging/kguiaddons/src/util/qiconoverlay.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112079/diff/ Testing --- I have a small testing app with 3 QLabels, testing both ::paint() and ::pixmap() methods, all works \o/ I'm thinking about bundling the app with kguiaddons and/or additionally creating a unittest for it (I have one for Qt already), but I'll do that later as I'm off to vacation and I'd like to get comments for the code. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/#review37846 --- This review has been submitted with commit aac36d00532afac245d501ba73eb586e48b34008 by David Gil to branch frameworks. - Commit Hook On Aug. 14, 2013, 9:43 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/ --- (Updated Aug. 14, 2013, 9:43 p.m.) Review request for KDE Frameworks. Description --- Port away from kde_file in KRecentDocument (KIO) Clean up header REVIEW: 111675 Diffs - kio/kfile/krecentdocument.cpp 20dc02943287becee98de6993c161100f8cf3661 Diff: http://git.reviewboard.kde.org/r/111675/diff/ Testing --- It builds. I have also verified that the new code works, setting the file last access and modification time to the current time. That way, the porting is equivalent to the former code. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/ --- (Updated Aug. 15, 2013, 2:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Port away from kde_file in KRecentDocument (KIO) Clean up header REVIEW: 111675 Diffs - kio/kfile/krecentdocument.cpp 20dc02943287becee98de6993c161100f8cf3661 Diff: http://git.reviewboard.kde.org/r/111675/diff/ Testing --- It builds. I have also verified that the new code works, setting the file last access and modification time to the current time. That way, the porting is equivalent to the former code. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs (updated) - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: kfile/kdirselectdialog.cpp, line 408 http://git.reviewboard.kde.org/r/112037/diff/1/?file=178338#file178338line408 Hmmm it makes me realize, couldn't KEncodingFileDialog be made to depend on the file module only? That would remove the dependency on KFileDialog (the file module is planned to stay). I've investigated a bit, and we could try to make KEncodingFileDialog static-only. The majority of KEncodingFileDialog uses are static, however in a few instances kdepim/messagecomposer uses KEncodingFileDialog with instantiation and some customization (e.g. http://lxr.kde.org/source/kde/kdepim/messagecomposer/attachment/attachmentcontrollerbase.cpp#770). Maybe we can factor this into a separate kdelibs cleanups dashboard task that would involve staticifying KEncodingFileDialog while making sure kdepim can get what it needs. - Teo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37641 --- On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: Small question: by replacing KFileDialog by QFileDialog do we still provide the settings to choose whether to use Native or KDE dialog on Windows? I use the KDE one here because of the places panel where I have lots of SFTP/FTP/SMB places defined. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37641 --- On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Requiring qtbase from a few days ago
On Thu, Aug 15, 2013 at 11:21 AM, Kevin Ottens ervin+bluesyst...@kde.org wrote: On Wednesday 14 August 2013 22:51:18 Albert Astals Cid wrote: El Dimecres, 14 d'agost de 2013, a les 05:54:36, Àlex Fiestas va escriure: Tomorrow (If nobody objects) I will push some changes that require this commit in qtbase: 0ace3112137b78cf7d150e9974e69ccfe6838533 The changes I will push are: https://git.reviewboard.kde.org/r/109527/ https://git.reviewboard.kde.org/r/109526/ And then Aleix will move kglobalsettings to kdesupport :) Isn't the rule to just require stuff that is part of qt5.git ? Yes, but it just got in recently so we try to give a bit of time to people so they can catch up and upgrade their qt5 first. Please note that the previous build of Qt 5 failed on Jenkins, so it is even further behind (13 days atm). I have just initiated a fresh build - please don't push those changes until it has managed to make a successful build of Qt 5. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
