On Friday 23 August 2013 06:51:23 Martin Graesslin wrote:
Given that it's already lots of work to keep up with the constant breakage
due to changes in frameworks the outlook of also having breakage in cmake
is nothing I look forward to.
FWIW, I've been using cmake master for many years, and I
On Fri, Aug 23, 2013 at 7:14 PM, David Faure fa...@kde.org wrote:
On Friday 23 August 2013 06:51:23 Martin Graesslin wrote:
Given that it's already lots of work to keep up with the constant breakage
due to changes in frameworks the outlook of also having breakage in cmake
is nothing I look
On Friday 23 August 2013 09:14:05 David Faure wrote:
On Friday 23 August 2013 06:51:23 Martin Graesslin wrote:
Given that it's already lots of work to keep up with the constant breakage
due to changes in frameworks the outlook of also having breakage in cmake
is nothing I look forward to.
The paper that describes make_unique - and contains an implementation
- can be found here [1]. For reference, the full code to have
make_unique ready to paste in any file is here [2].
Make unique is only a method to create a std::unique_ptr, and it doesn't
provide (or, rather, inhibit) the
On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote:
staging/kguiaddons/src/util/qiconoverlay.cpp, line 33
http://git.reviewboard.kde.org/r/112079/diff/1/?file=179564#file179564line33
Should be const
The virtual engine method is not const (nor is QIcon::actualSize()), so that's
why
On Aug. 17, 2013, 8:39 p.m., Nicolás Alvarez wrote:
staging/kguiaddons/src/util/qiconoverlay.h, line 31
http://git.reviewboard.kde.org/r/112079/diff/1/?file=179563#file179563line31
What about calling this one AddOverlays, in plural?
Dunno, I never much liked different method names
#ifndef KFILEDIALOG_H
#define KFILEDIALOG_H
#include kio/kio_export.h
#include QDialog
#include kfile.h
#include qmimetype.h
#include QUrl
In file included from /opt/qt5/include/KDE/KFileDialog:1:0,
from
/var/git/kwin5/plasma/generic/wallpapers/image/image.cpp:27:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112079/
---
(Updated Aug. 23, 2013, 9:25 a.m.)
Review request for KDE Frameworks.
Hi,
2013/8/22 David Faure:
On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote:
Hi David,
2013/8/7 David Faure:
On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote:
OK, I see now that it uses pointers to be able to modify the actual
KFileItems in KDirListerCache (if it
Hey,
I've written a somewhat lengthy and detailed article about the changes to our
plugin system:
http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/
Thought it might be interesting for many people here. :)
Cheers,
--
sebas
http://www.kde.org | http://vizZzion.org | GPG
On 2013-08-23, Ivan Čukić ivan.cu...@kde.org wrote:
oh. and I think it also looks a bit like your d-ptr gets in the way when
you need a d-ptr hierachy.
As I said, this is for non-inherited privates.
That alone is - I think - a reason to not have it.
The few cases where I have needed
The few cases where I have needed d-ptr hierachies, I didn't know about
it in advance but was happy than I could extend my classes without having
to use a different smartpointer (with possibly a different size).
Exactly. The *few* cases.
Most of our higher-level code do not use and do not
P1, P2 are your preference. Why do you even need to care about access
to the raw pointer. The d_ptr/make_unique pointer is stored as private
class member anyway. I don't see the need for those but that might
also be because i just don't know enough in that area. If you could
explain that,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112225/
---
Review request for KDE Frameworks.
Description
---
Simple port of
See http://build.kde.org/job/kdelibs_frameworks_qt5/1068/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112229/
---
Review request for KDE Frameworks.
Description
---
Removes more of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112175/
---
(Updated Aug. 23, 2013, 11:27 p.m.)
Review request for KDE Frameworks.
17 matches
Mail list logo