Re: Review Request 112556: Move itemviews to tier2

2013-09-13 Thread David Faure
On Tuesday 10 September 2013 21:46:45 Christoph Feck wrote: So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it too late for that? I'd be fine with that. There are indeed other item models and item views than the ones provided by KF5, so a k makes sense. Stephen,

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39935 --- Ship it! ... after fixing the last two small issues.

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39936 --- See the docu inside

Re: Dependency specifications

2013-09-13 Thread David Faure
On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls. And I disagree. If you build the framework with unittests disabled (like

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39940 --- Ship it! Much simpler indeed - David Faure On Sept. 12,

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39942 --- staging/kcompletion/src/klineedit.cpp

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review39943 --- staging/kservice/autotests/pluginlocatortest.cpp

Templates for frameworks CMake files

2013-09-13 Thread Aurélien Gâteau
Hi, I have been playing around with itemviews CMake files and put together some templates for the top level CMakeLists.txt and *Config.cmake.in. You can find them attached there. Any one against me adding those to the repository? Auréliencmake_minimum_required(VERSION 2.8.11) project(FooBar)

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m.) Review request for Build System, KDE

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread Aleix Pol Gonzalez
On Sept. 13, 2013, 7:35 a.m., David Faure wrote: See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt. This is preparation for future splitting. The variables are necessary for that, for now, as I understand it. Let's finish moving everything into separate frameworks,

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 13, 2013, 11:01 a.m.) Review request for KDE Frameworks.

Re: Dependency specifications

2013-09-13 Thread Aleix Pol
On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls.

Re: Review Request 112700: Prepare KI18n to move to tier2

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/ --- (Updated Sept. 13, 2013, 11:05 a.m.) Status -- This change has been

Re: Review Request 112700: Prepare KI18n to move to tier2

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112700/#review39948 --- This review has been submitted with commit

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:03:29 Aleix Pol wrote: On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt.

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/ --- (Updated Sept. 13, 2013, 11:15 a.m.) Review request for KDE Frameworks

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-13 Thread Aleix Pol Gonzalez
On Sept. 12, 2013, 7:57 p.m., Stephen Kelly wrote: Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt. This should make it possible to move kdoctools to its own tier. Why is this necessary to move it to its own tier? That wouldn't be an existing

Re: Dependency specifications

2013-09-13 Thread Aleix Pol
On Fri, Sep 13, 2013 at 1:17 PM, David Faure fa...@kde.org wrote: On Friday 13 September 2013 13:03:29 Aleix Pol wrote: On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39951 --- Ship it! Looks good. Remember to adjust the commit log if it

Re: Review Request 112696: Moves KNotifications to tier2

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39952 --- Ship it! Ship It! - David Faure On Sept. 12, 2013, 4:25

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:17:47 Aleix Pol wrote: Well, but in that case you'll maybe want to find QtGui, QtWidgets or KF5::AwesomeTests. Ah yes, true, manual tests can have more deps sometimes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE

Review Request 112710: Move KIO::NetAccess to kde4support

2013-09-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- Review request for KDE Frameworks and David Faure. Description ---

Re: Review Request 112710: Move KIO::NetAccess to kde4support

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39953 --- Ship it! Ship It! - David Faure On Sept. 13, 2013, 11:21

Re: Review Request 112696: Moves KNotifications to tier2

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39954 --- This review has been submitted with commit

Build failed in Jenkins: kdelibs_frameworks_qt5 #1188

2013-09-13 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1188/changes Changes: [aleixpol] Move KNotifications to tier2 -- [...truncated 3959 lines...] [ 27%] Building CXX object tier2/kauth/src/CMakeFiles/KAuth.dir/kauthaction.cpp.o [ 27%] Building CXX object

Re: Review Request 112710: Move KIO::NetAccess to kde4support

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/ --- (Updated Sept. 13, 2013, 11:42 a.m.) Status -- This change has been

Re: Review Request 112710: Move KIO::NetAccess to kde4support

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39955 --- This review has been submitted with commit

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1189

2013-09-13 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1189/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #1191

2013-09-13 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1191/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112715: Move KI18n to tier2

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- Review request for KDE Frameworks and Chusslove Illich. Description

Re: Review Request 112685: Fix KWindowSystem::setMainWindow

2013-09-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/#review39966 --- Ship it! Looks good to me. - Martin Gräßlin On Sept. 12,

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39967 --- This review has been submitted with commit

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/ --- (Updated Sept. 13, 2013, 1:42 p.m.) Status -- This change has been

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1192

2013-09-13 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1192/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Templates for frameworks CMake files

2013-09-13 Thread Aurélien Gâteau
On Friday 13 September 2013 11:30:32 Aurélien Gâteau wrote: Hi, I have been playing around with itemviews CMake files and put together some templates for the top level CMakeLists.txt and *Config.cmake.in. You can find them attached there. Any one against me adding those to the repository?

Fwd: Binary incompatible change in dev branch.

2013-09-13 Thread Stephen Kelly
--- Forwarded message (begin) Subject: Binary incompatible change in dev branch. From: Stephen Kelly stephen.ke...@kdab.com Date: Fri, 13 Sep 2013 16:52:14 +0200 Newsgroup: gmane.comp.lib.qt.devel Hello, Two changes which are binary incompatible compared to the state before them

Re: Review Request 112556: Move itemviews to tier2

2013-09-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 13, 2013, 5:02 p.m.) Status -- This change has been

Review Request 112716: Prepare itemviews for moving

2013-09-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112716/ --- Review request for KDE Frameworks. Description --- - Use

Re: Review Request 112685: Fix KWindowSystem::setMainWindow

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/#review39978 --- This review has been submitted with commit

Re: Review Request 112685: Fix KWindowSystem::setMainWindow

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112685/ --- (Updated Sept. 13, 2013, 3:25 p.m.) Status -- This change has been

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 3:33 p.m.) Status -- This change has been

Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/ --- (Updated Sept. 13, 2013, 5:25 p.m.) Status -- This change has been

Review Request 112717: Start adopting QCollator

2013-09-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.

Re: Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/#review39985 --- This review has been submitted with commit

Re: Review Request 112717: Start adopting QCollator

2013-09-13 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review39986 --- That's a very impressive part on the porting side! Thank you

Re: Review Request 112715: Move KI18n to tier2

2013-09-13 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/#review39981 --- Ship it! Ship It! - Chusslove Illich On Sept. 13, 2013,

Re: Review Request 112717: Start adopting QCollator

2013-09-13 Thread Aleix Pol Gonzalez
On Sept. 13, 2013, 5:32 p.m., Mark Gaiser wrote: That's a very impressive part on the porting side! Thank you very much for taking care here. I have some experience in optimizing this function (understatement ^_^) and know very well that even a tiny change in performace (negative

Re: Review Request 112715: Move KI18n to tier2

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112715/ --- (Updated Sept. 13, 2013, 6:30 p.m.) Status -- This change has been

Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-13 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- Review request for KDE Frameworks and David Faure. Description ---

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-13 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- (Updated Sept. 13, 2013, 11:38 p.m.) Review request for KDE Frameworks