Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Sept. 17, 2013, 7:42 a.m.) Review request for KDE Frameworks. C

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Sept. 16, 2013, 2:16 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kxutils_p.h, line 49 > > > > > > This statement is no longer true. If the pixmap is not an ARGB32 > > pixmap, the function will cr

Re: Review Request 112547: avoid creating jobs on urls with double slashes

> On Sept. 8, 2013, 1:13 p.m., David Faure wrote: > > Please test https://codereview.qt-project.org/64926, it should make this > > fix unnecessary. Quietness suggests that this review can be closed probably. Is that the case? - Aleix -

Re: Review Request 112760: Add test program for KMessageBox methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112760/#review40187 --- Ship it! Tests are always good, aren't they? :) - Aleix Pol G

Re: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/#review40186 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 15

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40185 --- Bump! what's the status of this? - Aleix Pol Gonzalez On Sep

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40184 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 16

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 16, 2013, 11:45 p.m.) Review request for KDE Frameworks.

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review40183 --- This review has been submitted with commit 6a0cc8d254ec957eacc

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 16, 2013, 11:30 p.m.) Status -- This change has been m

Re: Review Request 112717: Start adopting QCollator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40174 --- QCollator is available for everyone to use now, if there's any

Re: Review Request 112759: sonnet - improve dependencies

> On Sept. 16, 2013, 5:21 p.m., Aleix Pol Gonzalez wrote: > > tier1/sonnet/autotests/CMakeLists.txt, line 5 > > > > > > Seems like you should use "${REQUIRED_QT_VERSION}" here too... no? I set it like this for cons

Re: Review Request 112759: sonnet - improve dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112759/#review40171 --- tier1/sonnet/autotests/CMakeLists.txt

Review Request 112759: sonnet - improve dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112759/ --- Review request for KDE Frameworks. Description --- Move QtTest out of

Re: Review Request 112759: sonnet - improve dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112759/ --- (Updated Sept. 16, 2013, 5:12 p.m.) Status -- This change has been ma

Re: Review Request 112759: sonnet - improve dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112759/#review40167 --- This review has been submitted with commit 500c5b665964ce7215b

Re: Review Request 112759: sonnet - improve dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112759/#review40163 --- Ship it! Ship It! - David Edmundson On Sept. 16, 2013, 4:42

Review Request 112760: Add test program for KMessageBox methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112760/ --- Review request for KDE Frameworks. Description --- Add a manual test

Re: Splitting out a KX11Extras frameworks from KWindowSystems

On Monday 16 September 2013 16:51:45 Aurélien Gâteau wrote: > On Monday 16 September 2013 15:07:37 Martin Graesslin wrote: > > Hi, > > > > KWindowSystems is a framework which looks to me like a KX11Extras > > framework. Most of the things inside this framework are X11 specific. > > Some API even h

Re: Splitting out a KX11Extras frameworks from KWindowSystems

On Monday 16 September 2013 15:07:37 Martin Graesslin wrote: > Hi, > > KWindowSystems is a framework which looks to me like a KX11Extras framework. > Most of the things inside this framework are X11 specific. Some API even > has XLib/XCB specific data types as arguments or return values (e.g. > ne

Review Request 112758: Move KCompletion to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758/ --- Review request for KDE Frameworks. Description --- Not much else. D

Jenkins build is back to normal : plasma-framework_master_qt5 #747

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112757: kwindowsystem - remove unused dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112757/ --- Review request for KDE Frameworks. Description --- Apart from a stray

Build failed in Jenkins: plasma-framework_master_qt5 #746

See Changes: [notmart] correctly restore popup size -- [...truncated 510 lines...] Generated

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/ --- (Updated Sept. 16, 2013, 1:42 p.m.) Status -- This change has been ma

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review40117 --- This review has been submitted with commit fb72740e2c9e950b913

KF5 Update Meeting 2013-w38 Reminder

Hi there ! Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Barcelona (CEST / UTC+2) time. If you want me to do any announcement tomorrow just when the meeting start either send it as a reply here, or contact me in any way. See you there. Cheers ! _

Splitting out a KX11Extras frameworks from KWindowSystems

Hi, KWindowSystems is a framework which looks to me like a KX11Extras framework. Most of the things inside this framework are X11 specific. Some API even has XLib/XCB specific data types as arguments or return values (e.g. netwm.h). The only class which has a non-X11 implementation is KWindowSy

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really familiar with most of the affected code, and

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review40111 --- tier1/kwindowsystem/src/kxutils.cpp

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really familiar with most of the affected code, and

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really familiar with most of the affected code, and

Build failed in Jenkins: plasma-framework_master_qt5 #745

See Changes: [notmart] correctly save DialogHeight/DialogWidth -- [...truncated 26 lines...] attica - Branch master kdelibs - Branch frameworks libstreams - Branch master ===

Re: Review Request 112745: karchive - remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112745/ --- (Updated Sept. 16, 2013, 10:25 a.m.) Status -- This change has been m

Re: Review Request 112745: karchive - remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112745/#review40098 --- This review has been submitted with commit 48f411882f97aa4c4ed

Re: Review Request 112681: Tests for KPluginTrader and friends

On Monday 16 September 2013 11:50:21 Sebastian Kügler wrote: > On Sunday, September 15, 2013 08:42:31 David Faure wrote: > > Data-driven tests *can* be run separately (and therefore qDebugs don't get > > confusing), using the "methodName:rowName" syntax as command-line > > argument. > > > > Data-d

Re: Review Request 112681: Tests for KPluginTrader and friends

On Sunday, September 15, 2013 08:42:31 David Faure wrote: > Data-driven tests *can* be run separately (and therefore qDebugs don't get > confusing), using the "methodName:rowName" syntax as command-line argument. > > Data-driven tests have the huge benefit that they reduce code duplication, > and

Re: Review Request 112716: Prepare itemviews for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112716/#review40096 --- This review has been submitted with commit c7badf800e8298df7db

Re: Review Request 112716: Prepare itemviews for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112716/ --- (Updated Sept. 16, 2013, 9:20 a.m.) Status -- This change has been ma

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Sept. 16, 2013, 8:05 a.m.) Status -- This change has been ma

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review40091 --- This review has been submitted with commit 5bd41f0bb007569af3e

Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- Review request for KDE Frameworks. Description --- Implements the cre