Re: Review Request 113112: Notify about palette changes

2013-10-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41293 --- Ship it! Ship It! - David Edmundson On Oct. 5, 2013, 12:14

Re: Review Request 113112: Notify about palette changes

2013-10-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41305 --- Can you adapt the autotest to check that this event is being

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: kdeui/colors/kcolorschemetoken.h, line 70 http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70 using int here loses the type-safety. Why no use the corresponding enums? It would also make the code more

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Oct. 6, 2013, 7:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 6, 2013, 8:56 p.m.) Review request for KDE Frameworks.

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 6, 2013, 9:02 p.m.) Review request for KDE Frameworks.

KF5 Update Meeting 2013-w41 Reminder

2013-10-06 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com

Re: Re: kio-related build error in plasma-framework

2013-10-06 Thread Martin Gräßlin
On Saturday 05 October 2013 13:00:24 David Faure wrote: On Friday 04 October 2013 19:55:52 Sebastian Kügler wrote: On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: Hi, I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure