Re: Projects adding dependencies without clear indication of requirements
The dependency is kactivities/frameworks branch which does not depend on nepomuk-core nor soprano. Deps for kactivities are: -- The following OPTIONAL packages have been found: * KDBusAddons * KWindowSystem * KCoreAddons * KConfig -- The following REQUIRED packages have been found: * ECM (required version = 0.0.8) * Qt5Sql * KF5 * Qt5Test * Qt5Core * Qt5DBus * Qt5 Cheers, Ivan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting 2013-w43 Reminder
Hello all, I forgot to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #828
See http://build.kde.org/job/plasma-framework_master_qt5/828/ -- Started by user Ben Cooksley Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6803713758000378232.sh + /home/jenkins/scripts/setup-env.sh The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to Branch jenkins set up to track remote branch master from origin. Success build forhudson.tasks.Shell@434d4f2b Checkout:plasma-framework_master_qt5 / http://build.kde.org/job/plasma-framework_master_qt5/ws/ - hudson.remoting.Channel@699d7f6d:LinuxSlave - 3 Using strategy: Default Last Built Revision: Revision af8a7bad7d7504caaa94f55a59fcb72db86ab45b (refs/heads/jenkins) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision af8a7bad7d7504caaa94f55a59fcb72db86ab45b (refs/heads/jenkins) Checking out Revision af8a7bad7d7504caaa94f55a59fcb72db86ab45b (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson349707655326296.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: extra-cmake-modules - Branch master kdelibs - Branch frameworks phonon - Branch master qt5 - Branch stable strigiutils - Branch master libstreamanalyzer - Branch master strigiclient - Branch master attica - Branch master kactivities - Branch frameworks strigidaemon - Branch master libstreams - Branch master == Cleaning Source Tree HEAD is now at af8a7ba Stop using Qt5Transitional in Plasma Frameworks Removing build/ == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.7.2 -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/find-modules/FindKF5.cmake:135 (message): KF5: requested unknown components KDeclarative Call Stack (most recent call first): CMakeLists.txt:42 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/plasma-framework_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project plasma-framework. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 #829
See http://build.kde.org/job/plasma-framework_master_qt5/829/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Projects adding dependencies without clear indication of requirements
On Tue, Oct 22, 2013 at 6:59 PM, Ivan Čukić ivan.cu...@kde.org wrote: The dependency is kactivities/frameworks branch which does not depend on nepomuk-core nor soprano. Deps for kactivities are: -- The following OPTIONAL packages have been found: * KDBusAddons * KWindowSystem * KCoreAddons * KConfig -- The following REQUIRED packages have been found: * ECM (required version = 0.0.8) * Qt5Sql * KF5 * Qt5Test * Qt5Core * Qt5DBus * Qt5 Cheers, Ivan Thanks for the clarification - this has now been resolved, and the build of plasma-framework has now been fixed. Cheers, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc
On Monday 21 October 2013 15:25:41 Michael Pyne wrote: On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: Any reason why this patch isn't committed yet? Please do so ASAP. Kevin Ottens wrote: Any news? I'll close it as discarded if I don't see any activity by next monday. I've integrated it, you don't have to worry about closing this out. Pity we haven't heard from Patrick though, I hope he's OK. Which Patrick? At least the Spendrin one is OK. I've seen him today :) Cheers -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #1465
See http://build.kde.org/job/kdelibs_frameworks_qt5/1465/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Include path issues in CMake
Hi all, It seems after the recent activation of KActivities that the usual issue of include/ and include/KDE/ has once again reared it's head. Do we have a proper solution for this which can be broadly applied across all frameworks, no matter if they are included in kdelibs[frameworks] or other seperate repositories? At this point, it is becoming quite unworkable - i've just had to disable CI support for kde-workspace[master] due to it. Regards, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #830
See http://build.kde.org/job/plasma-framework_master_qt5/830/changes Changes: [notmart] remove dead code -- [...truncated 327 lines...] Automoc for target fullmodelaccesstest Scanning dependencies of target plasmaextracomponentsplugin_automoc Scanning dependencies of target plasmacomponentsplugin_automoc [ 5%] [ 5%] Automoc for target plasmaextracomponentsplugin Automoc for target plasmacomponentsplugin Generating corebindingsplugin.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/corebindingsplugin.cpp:0: Note: No relevant classes found. No output generated. Generating columnproxymodel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/columnproxymodel.cpp:0: Note: No relevant classes found. No output generated. Generating fallbackcomponent.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp:0: Note: No relevant classes found. No output generated. Generating datasource.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/datasource.cpp:0: Note: No relevant classes found. No output generated. Generating mouseeventlistener.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/mouseeventlistener.cpp:0: Note: No relevant classes found. No output generated. Generating moc_storage_p.cpp Generating moc_storagethread_p.cpp Generating moc_storagetest.cpp [ 5%] Built target storagetest_automoc Scanning dependencies of target platformcomponentsplugin_automoc [ 6%] Generating qiconitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/qiconitem.cpp:0: Note: No relevant classes found. No output generated. Generating plasmaextracomponentsplugin.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp:0: Note: No relevant classes found. No output generated. Automoc for target platformcomponentsplugin Generating moc_modeltest.cpp Generating moc_columnproxymodel.cpp Generating moc_columnproxymodeltest.cpp [ 6%] Built target fullmodelaccesstest_automoc Generating moc_DeclarativeDragArea.cpp Generating moc_DeclarativeDragDropEvent.cpp Generating moc_DeclarativeDropArea.cpp Generating moc_DeclarativeMimeData.cpp Generating moc_draganddropplugin.cpp Generating datamodel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/datamodel.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target localebindingsplugin_automoc [ 6%] [ 6%] Built target draganddropplugin_automoc Generating moc_enums.cpp Generating moc_plasmacomponentsplugin.cpp Generating qmenu.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/plasmacomponents/qmenu.cpp:0: Note: No relevant classes found. No output generated. Automoc for target localebindingsplugin Generating sortfiltermodeltest.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/sortfiltermodeltest.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target calendarplugin_automoc [ 7%] Automoc for target calendarplugin Generating qimageitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/qimageitem.cpp:0: Note: No relevant classes found. No output generated. Generating moc_fallbackcomponent.cpp Generating moc_plasmaextracomponentsplugin.cpp [ 7%] Built target plasmaextracomponentsplugin_automoc Scanning dependencies of target plasmapkg_automoc [ 8%] Automoc for target plasmapkg Generating qmenuitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/plasmacomponents/qmenuitem.cpp:0: Note: No relevant classes found. No output generated. Generating moc_plasmapkg.cpp Generating datasource.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/datasource.cpp:0: Note: No relevant classes found. No output generated. Generating qpixmapitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/qpixmapitem.cpp:0: Note: No relevant classes found. No output generated. [ 8%] Generating localebindingsplugin.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/localebindingsplugin.cpp:0: Note: No relevant classes found. No output generated. Built target plasmapkg_automoc Scanning dependencies of target kded_platformstatus_automoc Generating qrangemodel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/plasmacomponents/qrangemodel.cpp:0: Note: No relevant classes found. No output generated. [ 8%] Generating platformextensionplugin.moc Generating moc_application.cpp
Re: Forward includes
The above is pretty much it on my side, but I'd like to add something: We should get those forwarding includes generated to not have to maintain Lets bring this topic back from the dead. I don't have a real preference between include/Module, include/KDE/Module and include/KF5/Module. Main benefit of include/KF5/Module is the fact that the users will be able to have different non-ABI/API-compatible versions of KF installed at the same time, if this is needed at all. As for pointing the cmake configs to that path, it might be tricky to achieve in all libraries. Namely those that rely on namespaces instead of prefixing the names of classes with K or KSomething. For example, while #includeKJob can work without collisions, it can not for libraries like Solid (classes named Camera, Video, Button - needs to be #includeSolid/Camera etc.) or KActivities (Controller, Info - #includeKActivities/Info etc.) Cheers, Ivan -- The problem with object-oriented languages is they’ve got all this implicit environment that they carry around with them. You wanted a banana but what you got was a gorilla holding the banana. -- Joe Armstrong ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 #831
See http://build.kde.org/job/plasma-framework_master_qt5/831/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113266: introduce KMessageBoxNotifyInterface to support notifications
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113266/ --- (Updated Oct. 22, 2013, 12:04 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- This is a 4-commit request which does the following: - moves plugin handling to kmessagebox_p.* - fixes loading of plugin (library name was wrong) - introduces KMessageBoxNotifyInterface - implements KMessageBoxNotifyInterface in the framework integration plugin. Individual patches are available here: http://agateau.com/tmp/kmessagebox-notification.patch.mbox (apply with `git am`) Diffs - staging/frameworkintegration/src/integrationplugin/CMakeLists.txt d8305bf staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.h ccf44d6 staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7 tier1/kwidgetsaddons/src/CMakeLists.txt 50c578a tier1/kwidgetsaddons/src/kmessagebox.h 9a76c23 tier1/kwidgetsaddons/src/kmessagebox.cpp b2345d0 tier1/kwidgetsaddons/src/kmessagebox_p.h PRE-CREATION tier1/kwidgetsaddons/src/kmessagebox_p.cpp PRE-CREATION tier1/kwidgetsaddons/src/kmessageboxnotifyinterface.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113266/diff/ Testing --- Ran kmessageboxtest, heard lots of beeps. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs_frameworks_qt5 #1466
See http://build.kde.org/job/kdelibs_frameworks_qt5/1466/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
DBusMenuQt cmake *Config
Hi Aurelien,
Let's try again to finally get this resolved. :)
Attached, the necessary cmake foo to have find_package(DBusMenuQt NO_MODULE)
work like other frameworks do.
The .diff should work, but someone had problems applying it during testing, so
I've attached the whole files as well. (Maybe I missed some bzr diff option.)
Could you get this merged? If you want to test: kde-
workspace/plasma/generic/dataengines/CMakeLists.txt uses this, builds fine in
both cases (with and without DBusMenuQt). I need this for the
statusnotifieritem portion of the systemtray.
Thanks,
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2012-05-21 20:16:56 +
+++ CMakeLists.txt 2013-09-18 00:49:32 +
@@ -44,22 +44,47 @@
)
add_dependencies(distcheck dist)
+
find_package(Qt5Widgets QUIET)
if (Qt5Widgets_FOUND)
find_package(Qt5DBus REQUIRED)
include_directories(${Qt5Widgets_INCLUDE_DIRS} ${Qt5DBus_INCLUDE_DIRS})
- find_package(extra-cmake-modules 0.0.2 REQUIRED)
- set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${EXTRA_CMAKE_MODULES_MODULE_PATH})
+ find_package(ECM 0.0.4 REQUIRED)
+ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})
find_package(Qt5Transitional REQUIRED Core)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTOMOC_RELAXED_MODE ON)
+
+include(ECMSetupVersion)
+ecm_setup_version(${dbusmenu_qt_VERSION_MAJOR} ${dbusmenu_qt_VERSION_MINOR} ${dbusmenu_qt_VERSION_PATCH} VARIABLE_PREFIX DBusMenuQt
+VERSION_HEADER ${CMAKE_CURRENT_BINARY_DIR}/dbusmenu_version.h
+PACKAGE_VERSION_FILE ${CMAKE_CURRENT_BINARY_DIR}/DBusMenuQtConfigVersion.cmake)
+
+find_package(KF5 5.0.0 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs)
+set(CMAKECONFIG_INSTALL_DIR ${SHARE_INSTALL_PREFIX}/cmake/DBusMenuQt)
+include(CMakePackageConfigHelpers)
+message( CMAKECONFIG_INSTALL_DIR ${CMAKECONFIG_INSTALL_DIR})
+set(INCLUDE_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/include)
+configure_package_config_file(${CMAKE_CURRENT_SOURCE_DIR}/DBusMenuQtConfig.cmake.in
+${CMAKE_CURRENT_BINARY_DIR}/DBusMenuQtConfig.cmake
+INSTALL_DESTINATION ${CMAKECONFIG_INSTALL_DIR}
+PATH_VARS INCLUDE_INSTALL_DIR CMAKE_INSTALL_PREFIX )
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/DBusMenuQtConfig.cmake
+${CMAKE_CURRENT_BINARY_DIR}/DBusMenuQtConfigVersion.cmake
+#${CMAKE_CURRENT_SOURCE_DIR}/DBusMenuQtMacros.cmake
+DESTINATION ${CMAKECONFIG_INSTALL_DIR}
+COMPONENT Devel )
+
+install(EXPORT DBusMenuQtTargets DESTINATION ${CMAKECONFIG_INSTALL_DIR}
+FILE DBusMenuQtTargets.cmake COMPONENT Devel)
+
else()
-find_package(Qt4 REQUIRED)
-include_directories(
-${QT_INCLUDE_DIR}
-${QT_QTCORE_INCLUDE_DIR}
-${QT_QTDBUS_INCLUDE_DIR}
-${QT_QTGUI_INCLUDE_DIR}
+find_package(Qt4 REQUIRED)
+include_directories(
+${QT_INCLUDE_DIR}
+${QT_QTCORE_INCLUDE_DIR}
+${QT_QTDBUS_INCLUDE_DIR}
+${QT_QTGUI_INCLUDE_DIR}
)
endif()
=== added file 'DBusMenuQtConfig.cmake.in'
--- DBusMenuQtConfig.cmake.in 1970-01-01 00:00:00 +
+++ DBusMenuQtConfig.cmake.in 2013-09-18 00:51:34 +
@@ -0,0 +1,24 @@
+@PACKAGE_INIT@
+
+# Any changes in this .cmake file will be overwritten by CMake, the source is the .cmake.in file.
+
+set(DBusMenuQt_INSTALL_PREFIX @PACKAGE_CMAKE_INSTALL_PREFIX@)
+set_and_check(DBusMenuQt_INCLUDE_DIR@PACKAGE_INCLUDE_INSTALL_DIR@)
+
+include(${CMAKE_CURRENT_LIST_DIR}/DBusMenuQtTargets.cmake)
+
+set(DBusMenuQt_INCLUDE_DIR${PACKAGE_PREFIX_DIR}/include/dbusmenu-qt/)
+
+
+set(DBusMenuQt_FOUND TRUE)
+set(DBusMenuQt_INCLUDE_DIRS ${DBusMenuQt_INCLUDE_DIR})
+
+set(DBusMenuQt_LIBRARY dbusmenu-qt)
+set(DBusMenuQt_LIBRARIES dbusmenu-qt)
+#set(DBusMenuQt_LIBRARIES DBusMenuQt)
+
+
+message( XX DBUSMENU --- ${DBusMenuQt_INCLUDE_DIR} ${DBusMenuQt_LIBRARIES})
+
+#get_target_property(KConfig_KCFGC_EXECUTABLE KF5::kconfig_compiler LOCATION)
+#include(${CMAKE_CURRENT_LIST_DIR}/KConfigMacros.cmake)
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2012-05-21 20:16:56 +
+++ src/CMakeLists.txt 2013-09-18 00:49:13 +
@@ -17,6 +17,7 @@
set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -Wall)
endif (__DBUSMENU_HAVE_W_ALL)
+remove_definitions(-DQT_NO_CAST_FROM_ASCII -DQT_STRICT_ITERATORS -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_KEYWORDS)
# Check whether QIcon::name() exists. It was added in late Qt 4.7 cycle, and is
# not present in betas.
set(CMAKE_REQUIRED_INCLUDES ${QT_INCLUDE_DIR})
@@ -75,9 +76,12 @@
)
install(TARGETS dbusmenu-qt
+EXPORT DBusMenuQtTargets
LIBRARY DESTINATION lib${LIB_SUFFIX}
RUNTIME DESTINATION bin)
+#install(TARGETS plasma EXPORT kdelibsLibraryTargets ${INSTALL_TARGETS_DEFAULT_ARGS})
+
install(DIRECTORY
Re: Porting away from KLocale
On Thursday 17 October 2013 23:47:40 Aleix Pol wrote: Well maybe I could help with this, but I'd need to know what do you think it would be the most appropriate solution. I'd say, split it out into a separate function for KF5, and later on, if you feel like it, contribute it to Qt for 5.3. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting 2013-w43 Reminder
You could make an announcement that people should look into using the categorized debugging when porting new stuff. It is now documented on the wiki [1] to get people started. :) [1] http://community.kde.org/index.php?title=Frameworks/Porting_To_qCDebug On Tue, Oct 22, 2013 at 8:08 AM, Kevin Ottens er...@kde.org wrote: Hello all, I forgot to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113378: Trivial warning fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42160 --- interfaces/kimproxy/library/kimproxy.cpp http://git.reviewboard.kde.org/r/113378/#comment30713 Not sure it is really useful to keep this line at all tier3/xmlgui/autotests/kactioncategorytest.cpp http://git.reviewboard.kde.org/r/113378/#comment30712 Maybe a better solution here would be to change the Q_ASSERT into QVERIFY or QCOMPARE - Aurélien Gâteau On Oct. 22, 2013, 1:38 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 22, 2013, 1:38 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Trivial warning fixes Fixes for warnings (almost entirely unused variables or parameters) where the correct fix was obvious. Diffs - interfaces/kimproxy/library/kimproxy.cpp e48545f0a7229d66d16901c492095ce70b755c7e khtml/src/css/css_ruleimpl.cpp e2b3a8ae82ec0f6f85c5949a08f1773b08510479 khtml/src/css/css_webfont.cpp 9c5bedd13a24a3d32f670d718e1ff761ec4a6724 khtml/src/css/cssstyleselector.cpp fa8f5f4049aec3c2738257215a74b2536981d89b khtml/src/ecma/kjs_clientrect.cpp 6d7138e7f15293d18406a90eacf214847d884c45 khtml/src/ecma/kjs_events.cpp d0c481f06ab0efab9457f699571fdd052a99a348 khtml/src/ecma/kjs_proxy.cpp afd661bd149eaaa2a8ad4940f2a7d61d1f892116 khtml/src/editing/htmlediting_impl.cpp 2ec91188e47748a19ce414cf5d740518b8cf5225 khtml/src/imload/decoders/pngloader.cpp 6d0f023e25cdd112173873bf26b13c2d86172cb8 khtml/src/rendering/RenderSVGRoot.cpp c1e96d23e12732294301d675b3603f3e86656e56 khtml/src/rendering/render_canvasimage.cpp 73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c khtml/src/svg/SVGLinearGradientElement.cpp 46059f78527b313e90111cfcc048fc64727fb265 khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp 11c768fc1f496a1cb365bd5fc2ed2e3cada66720 kioslave/file/file.cpp 692a77fe02c33d64ff38afccfd48e8dc3127e75d kioslave/file/file_unix.cpp c8781fef39cf3e842f9c9794d757154d8ae284ac kioslave/http/http.cpp b4fd4126dfb86a251d2b98cf587311b715be9979 knewstuff/src/ui/itemsgridviewdelegate.cpp a0abb7f0b359b06268e4c640be08bfd3ddae79b1 staging/frameworkintegration/src/platformtheme/main.cpp 45b487c739266e4108df8de38ae5e139ca603e5a staging/kde4support/autotests/kglobalstatictest.cpp db6473a572d47086e8db400d94c3bf62424f493f staging/kde4support/src/kdecore/kdebug.cpp 98baed423e2af32d5a6726d21d4d140854b94375 staging/kde4support/src/kdeui/kaction.cpp f5d2e201b84feea2e0ccba9b17298d3c5877e04d staging/kde4support/src/kdeui/kapplication.cpp dc2e120bc28fca5708c699e68ddea22915c46233 staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df231227cd058842b8f1b90b5901cbebadbb683 staging/kde4support/tests/kcmdlineargstest.cpp a72aa4d120baf2904addd238276e0b400e0d8850 staging/kio/src/core/klocalsocket.h 93b04d69f52ccc16a3dba817d0585835e7134821 staging/kio/src/core/tcpslavebase.cpp 5180ed952d29e995c78cae498f323e0f1a3e08d7 staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp 59c4b37709acd37e9a6d1b77ff233f9e83cdecc8 staging/kio/src/widgets/kdirmodel.cpp ea290d0369aea303657afb74000780610c135ddf staging/kio/src/widgets/kurlrequester.cpp 70c760589d460f705c8bb884a5c76e2f9d5dece8 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kplugintrader.h 823b8d5dd363642a4c11be971ee64bc3cac6a65f staging/kservice/tests/pluginlocator/plugintest.cpp 4cfc74ace9c10cccbd2651291e752b8275af036e tier1/itemmodels/src/kdescendantsproxymodel.cpp 3bdfd9ffed351b5bab24e7959730c29773cc0952 tier1/itemmodels/src/kselectionproxymodel.cpp ca97070b70996ab1320d252623a503172c9be041 tier1/itemviews/src/kwidgetitemdelegate.cpp 8d4d5cec85ee460fe2604c83fd49bf7536db990a tier1/itemviews/src/kwidgetitemdelegatepool.cpp ed94c8936e4db44dc180c5820619a0ca3fdeffa2 tier1/itemviews/tests/kwidgetitemdelegatetest.cpp 07c8bca052a3340322884ba84e8ecdf5386e10a6 tier1/karchive/src/karchive.cpp 375d717bd5030ff694e1586855f1e3f401ef tier1/kconfig/autotests/test_kconf_update.cpp 78b783042b03dd0a15f8ce91f85ec1415acfc12f tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 2b5570938f189d4891fa7baa9f9b74791c97f4ad tier1/kwidgetsaddons/src/kdatetable.cpp e5c6f5cbdafaa8ac2abd4f4eea1bb0ef9191b386 tier1/kwidgetsaddons/src/kdragwidgetdecorator.cpp 74fb8bbcf3c9836cfd88da1d017b61c4da4deb29 tier1/threadweaver/src/Weaver/DestructedState.cpp bcd613201234ca6db19d285d571c4b6fca350789
KF5 Update Meeting Minutes 2013-w43
Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, dfaure, dMaggot, jpwhiting, mck182, PovAddict, sebas, teo, vHanda and myself. Announcement: * All new code should use qCDebug and friends instead of qDebug: http://community.kde.org/index.php?title=Frameworks/Porting_To_qCDebug Topics discussed: * afiestas is finishing the kded/ksycoca move; * he's also replacing Solid::PowerManagement with newer API; * agateau brought back the notification support of KMessageBox; * he's fixing the standalone build of tier1 frameworks; * he's also cleaning up kcompletion, ki18n, kdoctools, knotifications and dbusmenu-qt; * dfaure is killing kio one stab at a time (which means among other things moving KFileDialog to kde4support); * only KImageIO and kdbusservicestarter are left; * dMaggot found only already done tasks in khtml; * he's planning to help agateau for ter2 standalone build fixes; * jpwhiting is removing the KImageIO dependency of knewstuff; * mck182 is working on the workspace (ksplash in particular); * PovAddict is working on getting things to build on windows (very important work! help needed!); * Effort tracking there: http://community.kde.org/Frameworks/Windows * sebas renamed KF5::plasma to KF5::Plasma * he's also working on build fixes; * he's also tackling the network and systray applets; * teo is done with KEncodingFileDialog; * he's still working on ksmserver; * vHanda found out kross and kjsembed as unmaintained; * he's also getting nepomuk ready for frameworks; * ervin emptying KDE4Attic, almost there. If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113378: Trivial warning fixes
On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: interfaces/kimproxy/library/kimproxy.cpp, line 578 http://git.reviewboard.kde.org/r/113378/diff/1/?file=204289#file204289line578 Not sure it is really useful to keep this line at all I left this commented because there is later commented code that uses the appStub variable. So it should either all be removed or all commented. On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: tier3/xmlgui/autotests/kactioncategorytest.cpp, line 92 http://git.reviewboard.kde.org/r/113378/diff/1/?file=204337#file204337line92 Maybe a better solution here would be to change the Q_ASSERT into QVERIFY or QCOMPARE Yeah, I think that's a better solution for the tests. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42160 --- On Oct. 21, 2013, 11:38 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 21, 2013, 11:38 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Trivial warning fixes Fixes for warnings (almost entirely unused variables or parameters) where the correct fix was obvious. Diffs - interfaces/kimproxy/library/kimproxy.cpp e48545f0a7229d66d16901c492095ce70b755c7e khtml/src/css/css_ruleimpl.cpp e2b3a8ae82ec0f6f85c5949a08f1773b08510479 khtml/src/css/css_webfont.cpp 9c5bedd13a24a3d32f670d718e1ff761ec4a6724 khtml/src/css/cssstyleselector.cpp fa8f5f4049aec3c2738257215a74b2536981d89b khtml/src/ecma/kjs_clientrect.cpp 6d7138e7f15293d18406a90eacf214847d884c45 khtml/src/ecma/kjs_events.cpp d0c481f06ab0efab9457f699571fdd052a99a348 khtml/src/ecma/kjs_proxy.cpp afd661bd149eaaa2a8ad4940f2a7d61d1f892116 khtml/src/editing/htmlediting_impl.cpp 2ec91188e47748a19ce414cf5d740518b8cf5225 khtml/src/imload/decoders/pngloader.cpp 6d0f023e25cdd112173873bf26b13c2d86172cb8 khtml/src/rendering/RenderSVGRoot.cpp c1e96d23e12732294301d675b3603f3e86656e56 khtml/src/rendering/render_canvasimage.cpp 73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c khtml/src/svg/SVGLinearGradientElement.cpp 46059f78527b313e90111cfcc048fc64727fb265 khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp 11c768fc1f496a1cb365bd5fc2ed2e3cada66720 kioslave/file/file.cpp 692a77fe02c33d64ff38afccfd48e8dc3127e75d kioslave/file/file_unix.cpp c8781fef39cf3e842f9c9794d757154d8ae284ac kioslave/http/http.cpp b4fd4126dfb86a251d2b98cf587311b715be9979 knewstuff/src/ui/itemsgridviewdelegate.cpp a0abb7f0b359b06268e4c640be08bfd3ddae79b1 staging/frameworkintegration/src/platformtheme/main.cpp 45b487c739266e4108df8de38ae5e139ca603e5a staging/kde4support/autotests/kglobalstatictest.cpp db6473a572d47086e8db400d94c3bf62424f493f staging/kde4support/src/kdecore/kdebug.cpp 98baed423e2af32d5a6726d21d4d140854b94375 staging/kde4support/src/kdeui/kaction.cpp f5d2e201b84feea2e0ccba9b17298d3c5877e04d staging/kde4support/src/kdeui/kapplication.cpp dc2e120bc28fca5708c699e68ddea22915c46233 staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df231227cd058842b8f1b90b5901cbebadbb683 staging/kde4support/tests/kcmdlineargstest.cpp a72aa4d120baf2904addd238276e0b400e0d8850 staging/kio/src/core/klocalsocket.h 93b04d69f52ccc16a3dba817d0585835e7134821 staging/kio/src/core/tcpslavebase.cpp 5180ed952d29e995c78cae498f323e0f1a3e08d7 staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp 59c4b37709acd37e9a6d1b77ff233f9e83cdecc8 staging/kio/src/widgets/kdirmodel.cpp ea290d0369aea303657afb74000780610c135ddf staging/kio/src/widgets/kurlrequester.cpp 70c760589d460f705c8bb884a5c76e2f9d5dece8 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kplugintrader.h 823b8d5dd363642a4c11be971ee64bc3cac6a65f staging/kservice/tests/pluginlocator/plugintest.cpp 4cfc74ace9c10cccbd2651291e752b8275af036e tier1/itemmodels/src/kdescendantsproxymodel.cpp 3bdfd9ffed351b5bab24e7959730c29773cc0952 tier1/itemmodels/src/kselectionproxymodel.cpp ca97070b70996ab1320d252623a503172c9be041 tier1/itemviews/src/kwidgetitemdelegate.cpp 8d4d5cec85ee460fe2604c83fd49bf7536db990a tier1/itemviews/src/kwidgetitemdelegatepool.cpp ed94c8936e4db44dc180c5820619a0ca3fdeffa2 tier1/itemviews/tests/kwidgetitemdelegatetest.cpp 07c8bca052a3340322884ba84e8ecdf5386e10a6 tier1/karchive/src/karchive.cpp 375d717bd5030ff694e1586855f1e3f401ef tier1/kconfig/autotests/test_kconf_update.cpp 78b783042b03dd0a15f8ce91f85ec1415acfc12f
Build failed in Jenkins: plasma-framework_master_qt5 #839
See http://build.kde.org/job/plasma-framework_master_qt5/839/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson8560491833644822724.sh + /home/jenkins/scripts/setup-env.sh fatal: Unable to look up anongit.kde.org (port 9418) (Name or service not known) Success build forhudson.tasks.Shell@434d4f2b Checkout:plasma-framework_master_qt5 / http://build.kde.org/job/plasma-framework_master_qt5/ws/ - hudson.remoting.Channel@699d7f6d:LinuxSlave - 3 Using strategy: Default Last Built Revision: Revision 8ee1cecd81dc3ce221b65fb794707163dd35bfba (refs/heads/jenkins) Fetching changes from 1 remote Git repository Fetching upstream changes from origin ERROR: Problem fetching from origin / origin - could be unavailable. Continuing anyway hudson.plugins.git.GitException: Command fetch -t origin +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: fatal: Unable to look up anongit.kde.org (port 9418) (System error) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:928) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:902) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.fetch(CliGitAPIImpl.java:187) at hudson.plugins.git.GitAPI.fetch(GitAPI.java:233) at hudson.plugins.git.GitAPI.fetch(GitAPI.java:237) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:791) at hudson.plugins.git.GitSCM.access$000(GitSCM.java:58) at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:983) at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:948) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2420) at hudson.remoting.UserRequest.perform(UserRequest.java:118) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:326) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) ERROR: Could not fetch from any repository hudson.util.IOException2: remote file operation failed: http://build.kde.org/job/plasma-framework_master_qt5/ws/ at hudson.remoting.Channel@699d7f6d:LinuxSlave - 3 at hudson.FilePath.act(FilePath.java:908) at hudson.FilePath.act(FilePath.java:885) at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:948) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1114) at hudson.model.AbstractProject.checkout(AbstractProject.java:1411) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:652) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:557) at hudson.model.Run.execute(Run.java:1665) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:246) Caused by: java.io.IOException: Could not fetch from any repository at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:992) at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:948) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2420) at hudson.remoting.UserRequest.perform(UserRequest.java:118) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:326) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113378: Trivial warning fixes
On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: tier3/xmlgui/autotests/kactioncategorytest.cpp, line 92 http://git.reviewboard.kde.org/r/113378/diff/1/?file=204337#file204337line92 Maybe a better solution here would be to change the Q_ASSERT into QVERIFY or QCOMPARE Alex Merry wrote: Yeah, I think that's a better solution for the tests. I rewrote the test to not use Q_ASSERT at all, only the QTest macros. I can't do the same in the other test files, due to how they are structured (one doesn't use QTest at all, the other has the relevant code in helper methods, not the methods invoked directly by QTest). - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42160 --- On Oct. 21, 2013, 11:38 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 21, 2013, 11:38 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Trivial warning fixes Fixes for warnings (almost entirely unused variables or parameters) where the correct fix was obvious. Diffs - interfaces/kimproxy/library/kimproxy.cpp e48545f0a7229d66d16901c492095ce70b755c7e khtml/src/css/css_ruleimpl.cpp e2b3a8ae82ec0f6f85c5949a08f1773b08510479 khtml/src/css/css_webfont.cpp 9c5bedd13a24a3d32f670d718e1ff761ec4a6724 khtml/src/css/cssstyleselector.cpp fa8f5f4049aec3c2738257215a74b2536981d89b khtml/src/ecma/kjs_clientrect.cpp 6d7138e7f15293d18406a90eacf214847d884c45 khtml/src/ecma/kjs_events.cpp d0c481f06ab0efab9457f699571fdd052a99a348 khtml/src/ecma/kjs_proxy.cpp afd661bd149eaaa2a8ad4940f2a7d61d1f892116 khtml/src/editing/htmlediting_impl.cpp 2ec91188e47748a19ce414cf5d740518b8cf5225 khtml/src/imload/decoders/pngloader.cpp 6d0f023e25cdd112173873bf26b13c2d86172cb8 khtml/src/rendering/RenderSVGRoot.cpp c1e96d23e12732294301d675b3603f3e86656e56 khtml/src/rendering/render_canvasimage.cpp 73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c khtml/src/svg/SVGLinearGradientElement.cpp 46059f78527b313e90111cfcc048fc64727fb265 khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp 11c768fc1f496a1cb365bd5fc2ed2e3cada66720 kioslave/file/file.cpp 692a77fe02c33d64ff38afccfd48e8dc3127e75d kioslave/file/file_unix.cpp c8781fef39cf3e842f9c9794d757154d8ae284ac kioslave/http/http.cpp b4fd4126dfb86a251d2b98cf587311b715be9979 knewstuff/src/ui/itemsgridviewdelegate.cpp a0abb7f0b359b06268e4c640be08bfd3ddae79b1 staging/frameworkintegration/src/platformtheme/main.cpp 45b487c739266e4108df8de38ae5e139ca603e5a staging/kde4support/autotests/kglobalstatictest.cpp db6473a572d47086e8db400d94c3bf62424f493f staging/kde4support/src/kdecore/kdebug.cpp 98baed423e2af32d5a6726d21d4d140854b94375 staging/kde4support/src/kdeui/kaction.cpp f5d2e201b84feea2e0ccba9b17298d3c5877e04d staging/kde4support/src/kdeui/kapplication.cpp dc2e120bc28fca5708c699e68ddea22915c46233 staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df231227cd058842b8f1b90b5901cbebadbb683 staging/kde4support/tests/kcmdlineargstest.cpp a72aa4d120baf2904addd238276e0b400e0d8850 staging/kio/src/core/klocalsocket.h 93b04d69f52ccc16a3dba817d0585835e7134821 staging/kio/src/core/tcpslavebase.cpp 5180ed952d29e995c78cae498f323e0f1a3e08d7 staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp 59c4b37709acd37e9a6d1b77ff233f9e83cdecc8 staging/kio/src/widgets/kdirmodel.cpp ea290d0369aea303657afb74000780610c135ddf staging/kio/src/widgets/kurlrequester.cpp 70c760589d460f705c8bb884a5c76e2f9d5dece8 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kplugintrader.h 823b8d5dd363642a4c11be971ee64bc3cac6a65f staging/kservice/tests/pluginlocator/plugintest.cpp 4cfc74ace9c10cccbd2651291e752b8275af036e tier1/itemmodels/src/kdescendantsproxymodel.cpp 3bdfd9ffed351b5bab24e7959730c29773cc0952 tier1/itemmodels/src/kselectionproxymodel.cpp ca97070b70996ab1320d252623a503172c9be041 tier1/itemviews/src/kwidgetitemdelegate.cpp 8d4d5cec85ee460fe2604c83fd49bf7536db990a tier1/itemviews/src/kwidgetitemdelegatepool.cpp ed94c8936e4db44dc180c5820619a0ca3fdeffa2 tier1/itemviews/tests/kwidgetitemdelegatetest.cpp 07c8bca052a3340322884ba84e8ecdf5386e10a6 tier1/karchive/src/karchive.cpp 375d717bd5030ff694e1586855f1e3f401ef tier1/kconfig/autotests/test_kconf_update.cpp 78b783042b03dd0a15f8ce91f85ec1415acfc12f tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 2b5570938f189d4891fa7baa9f9b74791c97f4ad
Re: Review Request 113378: Trivial warning fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 22, 2013, 4:01 p.m.) Review request for KDE Frameworks. Changes --- Use QVERIFY/QCOMPARE in kactioncategorytest.cpp, rather than Q_UNUSED to hack around Q_ASSERT Repository: kdelibs Description --- Trivial warning fixes Fixes for warnings (almost entirely unused variables or parameters) where the correct fix was obvious. Diffs (updated) - interfaces/kimproxy/library/kimproxy.cpp e48545f0a7229d66d16901c492095ce70b755c7e khtml/src/css/css_ruleimpl.cpp e2b3a8ae82ec0f6f85c5949a08f1773b08510479 khtml/src/css/css_webfont.cpp 9c5bedd13a24a3d32f670d718e1ff761ec4a6724 khtml/src/css/cssstyleselector.cpp fa8f5f4049aec3c2738257215a74b2536981d89b khtml/src/ecma/kjs_clientrect.cpp 6d7138e7f15293d18406a90eacf214847d884c45 khtml/src/ecma/kjs_events.cpp d0c481f06ab0efab9457f699571fdd052a99a348 khtml/src/ecma/kjs_proxy.cpp afd661bd149eaaa2a8ad4940f2a7d61d1f892116 khtml/src/editing/htmlediting_impl.cpp 2ec91188e47748a19ce414cf5d740518b8cf5225 khtml/src/imload/decoders/pngloader.cpp 6d0f023e25cdd112173873bf26b13c2d86172cb8 khtml/src/rendering/RenderSVGRoot.cpp c1e96d23e12732294301d675b3603f3e86656e56 khtml/src/rendering/render_canvasimage.cpp 73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c khtml/src/svg/SVGLinearGradientElement.cpp 46059f78527b313e90111cfcc048fc64727fb265 khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp 11c768fc1f496a1cb365bd5fc2ed2e3cada66720 kioslave/file/file.cpp 692a77fe02c33d64ff38afccfd48e8dc3127e75d kioslave/file/file_unix.cpp c8781fef39cf3e842f9c9794d757154d8ae284ac kioslave/http/http.cpp b4fd4126dfb86a251d2b98cf587311b715be9979 knewstuff/src/ui/itemsgridviewdelegate.cpp a0abb7f0b359b06268e4c640be08bfd3ddae79b1 staging/frameworkintegration/src/platformtheme/main.cpp 45b487c739266e4108df8de38ae5e139ca603e5a staging/kde4support/autotests/kglobalstatictest.cpp db6473a572d47086e8db400d94c3bf62424f493f staging/kde4support/src/kdecore/kdebug.cpp 98baed423e2af32d5a6726d21d4d140854b94375 staging/kde4support/src/kdeui/kaction.cpp f5d2e201b84feea2e0ccba9b17298d3c5877e04d staging/kde4support/src/kdeui/kapplication.cpp dc2e120bc28fca5708c699e68ddea22915c46233 staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df231227cd058842b8f1b90b5901cbebadbb683 staging/kde4support/tests/kcmdlineargstest.cpp a72aa4d120baf2904addd238276e0b400e0d8850 staging/kio/src/core/klocalsocket.h 93b04d69f52ccc16a3dba817d0585835e7134821 staging/kio/src/core/tcpslavebase.cpp 5180ed952d29e995c78cae498f323e0f1a3e08d7 staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp 59c4b37709acd37e9a6d1b77ff233f9e83cdecc8 staging/kio/src/widgets/kdirmodel.cpp ea290d0369aea303657afb74000780610c135ddf staging/kio/src/widgets/kurlrequester.cpp 70c760589d460f705c8bb884a5c76e2f9d5dece8 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kplugintrader.h 823b8d5dd363642a4c11be971ee64bc3cac6a65f staging/kservice/tests/pluginlocator/plugintest.cpp 4cfc74ace9c10cccbd2651291e752b8275af036e tier1/itemmodels/src/kdescendantsproxymodel.cpp 3bdfd9ffed351b5bab24e7959730c29773cc0952 tier1/itemmodels/src/kselectionproxymodel.cpp ca97070b70996ab1320d252623a503172c9be041 tier1/itemviews/src/kwidgetitemdelegate.cpp 8d4d5cec85ee460fe2604c83fd49bf7536db990a tier1/itemviews/src/kwidgetitemdelegatepool.cpp ed94c8936e4db44dc180c5820619a0ca3fdeffa2 tier1/itemviews/tests/kwidgetitemdelegatetest.cpp 07c8bca052a3340322884ba84e8ecdf5386e10a6 tier1/karchive/src/karchive.cpp 375d717bd5030ff694e1586855f1e3f401ef tier1/kconfig/autotests/test_kconf_update.cpp 78b783042b03dd0a15f8ce91f85ec1415acfc12f tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 2b5570938f189d4891fa7baa9f9b74791c97f4ad tier1/kwidgetsaddons/src/kdatetable.cpp e5c6f5cbdafaa8ac2abd4f4eea1bb0ef9191b386 tier1/kwidgetsaddons/src/kdragwidgetdecorator.cpp 74fb8bbcf3c9836cfd88da1d017b61c4da4deb29 tier1/threadweaver/src/Weaver/DestructedState.cpp bcd613201234ca6db19d285d571c4b6fca350789 tier1/threadweaver/src/Weaver/JobCollection.cpp bac3d22e25bc2a89cc72278f666fe6e1d0635079 tier1/threadweaver/src/Weaver/ShuttingDownState.cpp ff692a59a7f94c123fc225eea9d165ba28bf5d0b tier2/kwallet/src/kwallet.cpp 49098bf5832ff83b270c1934aaf0abf6c4c780a9 tier3/kdeclarative/src/bindings/icon.cpp 0d956c500d4a0492025310abad67254fd1a7776e tier3/kinit/src/klauncher/klauncher.cpp 83f98357bd692b13b2a4b812e536acc69372c541 tier3/xmlgui/autotests/kactioncategorytest.cpp 2e30b0c53374a2d5677f507550d24588c862af1e tier3/xmlgui/src/khelpmenu.cpp 2b88f406385e8ae8084f6f11ddf824243acfca5e Diff: http://git.reviewboard.kde.org/r/113378/diff/ Testing
Review Request 113388: Port knewstuff from KImageIO to QImageReader
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Ported knewstuff from KImageIO to QImageReader to get the qimage supported file formats to put in a filter for QFileDialog. Diffs - knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 Diff: http://git.reviewboard.kde.org/r/113388/diff/ Testing --- Builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #840
See http://build.kde.org/job/plasma-framework_master_qt5/840/changes Changes: [notmart] stub for activitySwitcher component [ervin] KLocale moved in KDE4Support [ervin] KDE4Attic is gone -- [...truncated 795 lines...] CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::setMonetaryThousandsSeparator(QString const)': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:430: undefined reference to `KLocale::setMonetaryThousandsSeparator(QString const)' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::setMonetaryDecimalSymbol(QString const)': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:436: undefined reference to `KLocale::setMonetaryDecimalSymbol(QString const)' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::setCurrencySymbol(QString const)': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:442: undefined reference to `KLocale::setCurrencySymbol(QString const)' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::pageSize() const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:448: undefined reference to `KLocale::pageSize() const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::setPageSize(int)': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:453: undefined reference to `KLocale::setPageSize(int)' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::measureSystem() const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:459: undefined reference to `KLocale::measureSystem() const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::setMeasureSystem(Locale::MeasureSystem)': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:464: undefined reference to `KLocale::setMeasureSystem(KLocale::MeasureSystem)' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::defaultLanguage()': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:470: undefined reference to `KLocale::defaultLanguage()' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::defaultCountry()': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:475: undefined reference to `KLocale::defaultCountry()' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::defaultCurrencyCode()': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:480: undefined reference to `KLocale::defaultCurrencyCode()' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::fileEncodingMib() const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:485: undefined reference to `KLocale::fileEncodingMib() const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::allLanguagesList() const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:490: undefined reference to `KLocale::allLanguagesList() const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::installedLanguages() const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:495: undefined reference to `KLocale::installedLanguages() const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::languageCodeToName(QString const) const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:500: undefined reference to `KLocale::languageCodeToName(QString const) const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::allCountriesList() const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:505: undefined reference to `KLocale::allCountriesList() const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::countryCodeToName(QString const) const': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:510: undefined reference to `KLocale::countryCodeToName(QString const) const' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::setCalendarSystem(Locale::CalendarSystem)': http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/locale/locale.cpp:515: undefined reference to `KLocale::setCalendarSystem(KLocale::CalendarSystem)' CMakeFiles/localebindingsplugin.dir/locale.cpp.o: In function `Locale::calendarSystem() const':
Review Request 113391: Remove unnecessary #includes for moc files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Remove unnecessary #includes for moc files These are all of the form #include foo.moc, which tells automoc to process foo.cpp, but where there is no class (Q_OBJECT-tagged) in the .cpp file for moc to process. This gets rid of nearly all the messages about appropriate files not being found to process (except in the kconfig_compiler tests, where the code is autogenerated). The ThreadWeaver cleanup is more extensive, because it had more qmake compatibility hacks (which I don't think are needed any more; they seem out of date, at least, and there are no .pro files). Diffs - khtml/src/java/kjavaappletcontext.cpp 7721cc3524d1e6fee3ffce89214a2620e5dfec8a khtml/src/khtml_iface.cpp cc60a58bbe199cc47c62502bdb227119b5f2647d kioslave/http/tests/httpobjecttest.cpp 37ea25d33e1866804a500ff640231d1e9e8c8b99 staging/kde4attic/autotests/kdatetimeformattertest.cpp 159ed7a735527c0078b8bee84dafe8f8ff3e490b staging/kde4attic/autotests/klocaletest.cpp a307e4896191b76549f052cc32acd4b83f0f39fc staging/kde4support/autotests/kasciitest.cpp fb1177ef675d093b8e5fca83d3a1719cf832e91d staging/kde4support/autotests/klibloadertest.cpp c1feb4fc7f59f33ef1ad0bf68c13ea3749403402 staging/kde4support/autotests/kmimetypetest.cpp 7466e565290663f8ac3b8c9c0b64132188c5d51d staging/kde4support/src/kdecore/k3bufferedsocket.cpp d90a371e142400386ba3b2ee04c04f85e0ca45af staging/kde4support/src/kdecore/k3clientsocketbase.cpp 96e99a2024f65aa3b834051d146a962504d83467 staging/kde4support/src/kdecore/k3resolver.cpp 539cf4085dcd949b89d154738d042c673d98a3e2 staging/kde4support/src/kdecore/k3reverseresolver.cpp 2e261135c210802e6a3a6f69252d48d6054323f0 staging/kde4support/src/kdecore/k3serversocket.cpp b6b29837ca35aeff24fae3560bfed3a746ce3d92 staging/kde4support/src/kdecore/k3socketbase.cpp 43651cb9e64a3135e2a40f5c75be73a0da0a84b7 staging/kde4support/src/kdecore/k3streamsocket.cpp 27ae4a93e3b0191439474d36bc16e61a03516b35 staging/kde4support/src/kdecore/klibloader.cpp 10fea2cdde619e2f8ba768c3820a1b0364a3238c staging/kio/autotests/clipboardupdatertest.cpp d7fcfd40bf09378d26f7e901848d488009a93d5e staging/kio/autotests/dataprotocoltest.cpp d73cc951dcb28edb4b469706a3b2a4ef0ee05067 staging/kio/autotests/fileundomanagertest.cpp dfdeaeb7bc3da7af4e4d4da06b5da5704c906c05 staging/kio/tests/previewtest.cpp bfc66bf33068731a5ad7f487bde950a08fa2b1e3 staging/kservice/src/kdeinit/ktoolinvocation.cpp ef047b3847de6cdb61f73d4fd6723541e9359644 staging/kservice/src/plugin/klibrary.cpp 845ff9d24d5f0884dfd57cefe16a190d5b783230 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kpluginloader.cpp 798a9766c92e172977f02720d7c338b8d36a5bc8 staging/kservice/src/services/kautostart.cpp f540e901a62819f4bd9fe9e3dc61560e30ef5ea1 staging/kservice/src/sycoca/ksycoca.cpp 2923172f985bbf744c9adfec3f23c514b7f20e46 tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp 7a7e4e65e312f0c5b7176d851c303c9df101ab08 tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp 75c91fc257c14a773fc22b405f84c8056b0880de tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp 6583a624a26cbaab4c58b262b4056d953cbb316e tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp 9bcd9ec79b140752255d06db8d15dc021ab3ce8b tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp b1a1407c97df7a82832b4af0e1f7bb6d4127d9c9 tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp 9ff7d4bfe7f16ef583420a45d9f26b5c310b7e2e tier1/itemmodels/src/kmodelindexproxymapper.cpp c806e8a8476bdd40e1379a799a6f5c3d7d607fe2 tier1/kconfig/src/core/kconfigbackend.cpp 9bccf420f16737a170273c495b0858b8cca31d67 tier1/kconfig/src/core/kcoreconfigskeleton.cpp ec2c9eedfbb515c97812b5bc78cf66653e9d6e2b tier1/kcoreaddons/autotests/kcompositejobtest.cpp d3d46276a2f8a4e799bda2211c7f0473903b5608 tier1/kcoreaddons/tests/kdirwatchtest.cpp 1ad3928e47b083c2ec21c2748a0e50e972be0d63 tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp edc4ce7e03d28e5b6963f2e4f7274ddf4a0ed41a tier1/kdbusaddons/src/kdedmodule.cpp bdd1ca1874d8255dda7ae828b6d9c1e14816e5b8 tier1/kguiaddons/autotests/kiconutilstest.cpp 3690c131c54bd328e3d135bbdd048e18597924a1 tier1/kjs/autotests/ecmatest.cpp 585516377dfc0cf63f4bb463bb1d27fd9031c3cb tier1/kplotting/examples/testplot_widget.cpp 95e1a42894bef6b131a97aaf0ce43b0b86eb0d99 tier1/solid/src/imports/devices.cpp 05e6618000b1b273ebfd1eae3eb6fd64e9e84b4f tier1/solid/src/imports/solidextensionplugin.cpp a019f7fbfdaeb7ba6b651fb69dd34458a91494b8
Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42163 --- knewstuff/src/uploaddialog.cpp http://git.reviewboard.kde.org/r/113388/#comment30717 Does this actually produce a list of the right form? It looks like it will generate something like png;;jpg;;jpeg;;gif;;[etc], while the QFileDialog docs (http://doc-snapshot.qt-project.org/qt5-stable/qfiledialog.html#getOpenFileName) suggest you want something like PNG image (*.png);;JPG image (*.jpg);;[etc]. The KImageIO code, incidentally, produced a different format again. It also added an All images thing to the start. - Alex Merry On Oct. 22, 2013, 4:06 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- (Updated Oct. 22, 2013, 4:06 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported knewstuff from KImageIO to QImageReader to get the qimage supported file formats to put in a filter for QFileDialog. Diffs - knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 Diff: http://git.reviewboard.kde.org/r/113388/diff/ Testing --- Builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Changes --- * Watch the whole timezone database dir * Rename signal to timeZoneDatabaseUpdated() * Windows support is to be added later by John (I have no way to test) * The Solaris support remains removed. Yes, Solaris still has its users, but they are using KDE4 and will keep so for some time. IF PlasmaWorkspaces2 will get Solaris support (so that it all builds and runs), I hereby commit to add proper Solaris support to ktimezoned at that time, otherwise there's no point in keeping old (now untested) code around to bitrot and add maintenance burden, especially since there is 0 effort to have other, more important components work on Solaris (including Frameworks). Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs (updated) - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader
On Oct. 22, 2013, 10:46 a.m., Alex Merry wrote: knewstuff/src/uploaddialog.cpp, lines 823-833 http://git.reviewboard.kde.org/r/113388/diff/1/?file=204524#file204524line823 Does this actually produce a list of the right form? It looks like it will generate something like png;;jpg;;jpeg;;gif;;[etc], while the QFileDialog docs (http://doc-snapshot.qt-project.org/qt5-stable/qfiledialog.html#getOpenFileName) suggest you want something like PNG image (*.png);;JPG image (*.jpg);;[etc]. The KImageIO code, incidentally, produced a different format again. It also added an All images thing to the start. Actually it probably doesn't generate the right string, and also after discussing with david on irc it's a better idea to use supportedMimeTypes() and give that to the QFileDialog instead, so I'll redo this patch that way. - Jeremy --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42163 --- On Oct. 22, 2013, 10:06 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- (Updated Oct. 22, 2013, 10:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported knewstuff from KImageIO to QImageReader to get the qimage supported file formats to put in a filter for QFileDialog. Diffs - knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 Diff: http://git.reviewboard.kde.org/r/113388/diff/ Testing --- Builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/#review42171 --- Ship it! Looks sane to me. - Alex Merry On Oct. 21, 2013, 11:23 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/ --- (Updated Oct. 21, 2013, 11:23 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Subject says it all. Diffs - find-modules/FindKF5.cmake 8f95469 Diff: http://git.reviewboard.kde.org/r/113377/diff/ Testing --- find_package(KF5 ... KDeclarative) works with this patch, it doesn't work without. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #841
See http://build.kde.org/job/plasma-framework_master_qt5/841/ -- Started by user ervin Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6808593348664168578.sh + /home/jenkins/scripts/setup-env.sh fatal: Unable to look up anongit.kde.org (port 9418) (Name or service not known) Success build forhudson.tasks.Shell@434d4f2b Checkout:plasma-framework_master_qt5 / http://build.kde.org/job/plasma-framework_master_qt5/ws/ - hudson.remoting.Channel@699d7f6d:LinuxSlave - 3 Using strategy: Default Last Built Revision: Revision ce00ca976e72c1ec3b8ffdef3f99798a0773302f (refs/heads/jenkins) Fetching changes from 1 remote Git repository Fetching upstream changes from origin ERROR: Problem fetching from origin / origin - could be unavailable. Continuing anyway hudson.plugins.git.GitException: Command fetch -t origin +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: fatal: Unable to look up anongit.kde.org (port 9418) (System error) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:928) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:902) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.fetch(CliGitAPIImpl.java:187) at hudson.plugins.git.GitAPI.fetch(GitAPI.java:233) at hudson.plugins.git.GitAPI.fetch(GitAPI.java:237) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:791) at hudson.plugins.git.GitSCM.access$000(GitSCM.java:58) at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:983) at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:948) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2420) at hudson.remoting.UserRequest.perform(UserRequest.java:118) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:326) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) ERROR: Could not fetch from any repository hudson.util.IOException2: remote file operation failed: http://build.kde.org/job/plasma-framework_master_qt5/ws/ at hudson.remoting.Channel@699d7f6d:LinuxSlave - 3 at hudson.FilePath.act(FilePath.java:908) at hudson.FilePath.act(FilePath.java:885) at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:948) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1114) at hudson.model.AbstractProject.checkout(AbstractProject.java:1411) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:652) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:557) at hudson.model.Run.execute(Run.java:1665) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:246) Caused by: java.io.IOException: Could not fetch from any repository at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:992) at hudson.plugins.git.GitSCM$2.invoke(GitSCM.java:948) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2420) at hudson.remoting.UserRequest.perform(UserRequest.java:118) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:326) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/#review42172 --- Ship it! Inspecting the code, you don't seem to have changed the logic on Unix systems, so it looks good to me. - Alex Merry On Oct. 21, 2013, 11:46 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/ --- (Updated Oct. 21, 2013, 11:46 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KDirWatch: don't check for symlinks on Windows. Windows doesn't have symbolic links, at least not in the same way as Unix, so it doesn't have functions like lstat. Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 Diff: http://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Still doesn't compile on Windows, but getting closer. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #842
See http://build.kde.org/job/plasma-framework_master_qt5/842/ -- [...truncated 538 lines...] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/applet.cpp:0: Note: No relevant classes found. No output generated. Built target Plasma_automoc [ 15%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragArea.cpp.o Generating configgroup.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/configgroup.cpp:0: Note: No relevant classes found. No output generated. Generating containment.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/containment.cpp:0: Note: No relevant classes found. No output generated. Generating desktopscriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/desktopscriptengine.cpp:0: Note: No relevant classes found. No output generated. [ 16%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragDropEvent.cpp.o Generating layouttemplatepackagestructure.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/layouttemplatepackagestructure.cpp:0: Note: No relevant classes found. No output generated. Generating panel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/panel.cpp:0: Note: No relevant classes found. No output generated. Generating moc_theme.cpp Generating moc_corebindingsplugin.cpp Generating moc_datamodel.cpp Generating moc_datasource.cpp Generating moc_dialog.cpp Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_tooltipdialog.cpp Generating moc_windowthumbnail.cpp [ 16%] [ 16%] Built target corebindingsplugin_automoc [ 16%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDropArea.cpp.o Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin.cpp.o Generating scriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/scriptengine.cpp:0: Note: No relevant classes found. No output generated. Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::nonDestructiveBasicTest()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:128:19: warning: variable ‘flags’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::hasIndex()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:208:9: warning: unused variable ‘columns’ [-Wunused-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::index()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:233:9: warning: unused variable ‘columns’ [-Wunused-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:243:17: warning: variable ‘a’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:244:17: warning: variable ‘b’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::parent()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:277:21: warning: variable ‘childIndex’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:286:21: warning: variable ‘childIndex’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:287:21: warning: variable ‘childIndex1’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::checkChildren(const QModelIndex, int)’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:354:25: warning: variable ‘modifiedIndex’ set but not used [-Wunused-but-set-variable]
Jenkins build is back to normal : plasma-framework_master_qt5 #843
See http://build.kde.org/job/plasma-framework_master_qt5/843/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Keep the Things You Forgot
hi :) (i stole the subject without shame. but it seemed appropriate given the topic) we’ve all gotten out of the habit of communicating with the outside world, with some notable exceptions. Martin, in particular, has become an outstanding blogger. the rest of us have been overly quiet. i’m working on getting my bloggerificness going again rather than just hiding on irc and g+ ... i’d like to invite all of you to blog at least once a week about the amazing work everyone is doing with Frameworks 5 and Plasma 2. there is SO MUCH ACTIVITY in the repositories and the progress is astounding. it is important that the rest of the KDE (and beyond!) community sees this movement too so they know what we’re up to and that we’re still running ahead at great speed. communicating is how we get more contributors, it’s how we get more users, it’s how we find more partners, it’s how we remind others to believe as much as we do in the things we’re doing. love ‘n hugs to you all ... -- Aaron J. Seigo ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113393: Get KPassivePopup positioning in a semi-working state
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Get KPassivePopup positioning in a semi-working state Since we cannot use the NETWM stuff from KWindowSystems, we are forced to either rely on what Qt can give us or hack in window-system-specific code. This does the former, using QDesktopWidget to calculate the default placement of the popup, QWidget to place the popup next to our own windows and QWindow for foreign windows. Caveats: * the docs claim the popup will be placed next to taskbar entries; this is not possible using only what Qt gives us * Qt does not provide foreign window geometry on X11, so if you pass a foreign window id you will just get the default placement Diffs - tier1/kwidgetsaddons/CMakeLists.txt ea6654d83acb265a87ed21c913a7f799b457ca71 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 Diff: http://git.reviewboard.kde.org/r/113393/diff/ Testing --- Builds. Test application seems to work as expected (on X11, at least). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review42187 --- This review has been submitted with commit 9d0d6b4b5fef67b2154bc137957a9dd3b7ce248f by David Gil to branch frameworks. - Commit Hook On Oct. 7, 2013, 10:08 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 7, 2013, 10:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: KEmoticonsProvider::save() -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save() and prefer saveTheme() instead. -Adjust plugins. -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(), which was empty. Now it's a pure virtual function. Therefore, I deprecate it and advice subclassing KEmoticonsProvider. Diffs - staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a635a300e0ed8e38b1d59a535d6ec15b99cb staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3fe4ba25c9d6a69634024b2c157235e674 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b194eee1543bf13f1177a0e4092f1a10943 staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267679919c968bbe4d12c35abb90cf1bcc9b staging/kemoticons/src/core/kemoticonstheme.cpp ed3407cdd45c84d91f2d0057e108b760ff696ff2 staging/kemoticons/src/core/kemoticonstheme.h b8b25f7607d3741dda78d6302c1ed81fbc9211a0 staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e87b118f5d45717b3b2ccd9dea47dc2526 staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d Diff: http://git.reviewboard.kde.org/r/112984/diff/ Testing --- It builds. It installs. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 22, 2013, 9:51 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: KEmoticonsProvider::save() -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save() and prefer saveTheme() instead. -Adjust plugins. -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(), which was empty. Now it's a pure virtual function. Therefore, I deprecate it and advice subclassing KEmoticonsProvider. Diffs - staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a635a300e0ed8e38b1d59a535d6ec15b99cb staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3fe4ba25c9d6a69634024b2c157235e674 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b194eee1543bf13f1177a0e4092f1a10943 staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267679919c968bbe4d12c35abb90cf1bcc9b staging/kemoticons/src/core/kemoticonstheme.cpp ed3407cdd45c84d91f2d0057e108b760ff696ff2 staging/kemoticons/src/core/kemoticonstheme.h b8b25f7607d3741dda78d6302c1ed81fbc9211a0 staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e87b118f5d45717b3b2ccd9dea47dc2526 staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d Diff: http://git.reviewboard.kde.org/r/112984/diff/ Testing --- It builds. It installs. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review42188 --- This review has been submitted with commit b2e2218bc7677ac8f3444d4088ca112beca88bdb by David Gil to branch frameworks. - Commit Hook On Oct. 6, 2013, 9:02 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 6, 2013, 9:02 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: map and index methods -Make map and index KEmoticons API slightly clearer and deprecate the methods that are confusing. -Use the new methods in the plugins. Diffs - staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e87b118f5d45717b3b2ccd9dea47dc2526 staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 Diff: http://git.reviewboard.kde.org/r/112985/diff/ Testing --- It builds. It installs. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 22, 2013, 10:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: map and index methods -Make map and index KEmoticons API slightly clearer and deprecate the methods that are confusing. -Use the new methods in the plugins. Diffs - staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e87b118f5d45717b3b2ccd9dea47dc2526 staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 Diff: http://git.reviewboard.kde.org/r/112985/diff/ Testing --- It builds. It installs. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113395: Enable KConfig on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113395: Enable KConfig on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42192 --- tier1/kconfig/src/core/kconfigini.cpp http://git.reviewboard.kde.org/r/113395/#comment30726 Not actually a TODO... fi.ownerId() will always return -2 on Windows (files have no owners on Win). Also kdewin's getuid would also return -2. tier1/kconfig/src/core/kconfigini.cpp http://git.reviewboard.kde.org/r/113395/#comment30727 Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would do kdewin's getuid, so here we probably should follow the if part, not the else one. - Andrius da Costa Ribas On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 23, 2013, 12:03 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113395: Enable KConfig on Windows
On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: tier1/kconfig/src/core/kconfigini.cpp, line 425 http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425 Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would do kdewin's getuid, so here we probably should follow the if part, not the else one. Oops. Double comment ... I thought the first one hadn't been saved ;) - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42192 --- On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 23, 2013, 12:03 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
