Google Code-In
Hello all, I got contacted by Lydia because the Google Code-In will soon start and we could maybe give out tasks to people. I think that's a good idea, and one area is port kdeexamples to KF5. If we split it per example in the repo, it makes for nice small tasks, is easy to have them in parallel, etc. The catch of course is that we need people to mentor and create the tasks. Anyone up for it? I can give a hand, but it's better to have a couple of people IMO. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113402: Fix KI18n standalone build
On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: I can only say that whatever is the proper fix here, it is fine with me. Since non-installed headers are being used, maybe ki18n is using KJS in a way which became deprecated somewhere along the way? If so, I've nothing against fixing that instead. Aleix Pol Gonzalez wrote: Well the thing is that ki18n was using private API (since it was in the same module, kdelibs). Aurélien: what about installing these headers in a private/ directory? Chusslove Illich wrote: If I recall, when implementing that I mimicked what khtml was doing. And apparently is still doing. Aleix Pol Gonzalez wrote: khtml is in kdelibs as well, nobody has tried to build it standalone just yet, I guess. Chusslove Illich wrote: Right, but, how is then KJS supposed to be used in a different way? Are these private headers really private, or actually necessary to use KJS as a JS interpreter in random client code? Aurélien Gâteau wrote: The ideal solution would be for ktranscript to only use public headers, but I assume there is no way to do so (I haven't taken the time to study ktranscript enough to understand what it does), Chusslove, it would be awesome if you could have a look at it. If it is definitely not possible, then I am going to update my changes to install to a private/ directory, like Aleix suggests. Aurélien Gâteau wrote: Actually, the even more ideal solution would be for ktranscript to use QtScript instead of KJS. In the future we will have more and more applications developed with QtQuick, so they will already link to QtScript, loading another JavaScript interpreter sounds wasteful to me. Do you think this is doable? I would be quite interested in helping making it happen. Aurélien Gâteau wrote: Mmm, actually I am wrong, QtScript is provided for Qt 4.x compatibility, QtQuick uses the QJS* classes from QtQML, so this is what we should be using. Kevin Ottens wrote: I would definitely welcome such a port... I remember asking ktranscript to be ported away from KJS. Would also make ki18n tier 1. Aurélien Gâteau wrote: I started diving into this today. No change for now, but I wrote some unit tests for ktranscript, so that a qjs port can be evaluated. Patchset is here: http://agateau.com/tmp/ki18n-qjs.patch but it's missing loads of tests for now. Chusslove: would you be interested in extending the test coverage? Chusslove Illich wrote: Yes, I most certainly would be interested in extending the test coverage. But I intended to do it full-range, that is starting from test PO files (which are already there), once I get to it. And first I need to document it better :) Currently all there is is this wiki page: http://techbase.kde.org/Localization/Concepts/Transcript As for the port away from KJS, I have to state again that I see no value in that. Having ki18n be tier 1 is of no use: if someone is so tight on dependencies that using a tier 2 framework is a problem, then ki18n is the first thing to dump in favor of built-in Qt translation system, tier 1 or not. Note that ki18n also brings into play all the Gettext tools, as opposed to self-contained Qt translation tools. The only possible advantage of ki18n in tier 1 is that it can be used by tier 2 frameworks, of which there is not much by my estimate (and between tier 1 and tier 3, I also fail to see the reason for existence of tier 2). Aurélien Gâteau wrote: There is value in both full-range tests and tests exercising smaller parts of the code as well IMO. Thanks for the link, I am going to look at it. Regarding the port to QJSEngine, I see the following advantages to it: - It solves the build issue I have been trying to fix with this request: no need for uninstalled headers anymore. - The code is going to be simpler: from what I read of QJSEngine and KJS, exposing an object using QJSEngine is simpler than with KJS: no need for lookup tables or things like that, just a QObject with slots. - I expect QJSEngine to be better maintained than KJS, given that it is the backbone of QtQuick. - Having ki18n in tier1 would make it more attractive to Qt developers since it brings superior translation support. Right now the cost of dragging in a separate JavaScript interpreter, can be perceived as a burden especially for QtQuick developers. Yes, it's not only about the tiers (it's just a nice side-effect). But it's clear that at that point ktranscript is built on top of something huge and unmaintained. It'd be safer built on top of something with proper maintenance if possible. - Kevin --- This is an automatically generated e-mail. To reply, visit:
Re: extra-cmake-modules: remove ECMPrintVariables.cmake
On Thursday 24 October 2013 22:29:51 Alexander Neundorf wrote: If somebody feels like it, I think it would be a good idea to remove ECMPrintVariables.cmake, now that there is a replacement in cmake. Makes sense IMO. Thanks for pointing it out. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDirWatch vs QFileSystemWatcher
On Thursday 24 October 2013 21:54:42 Sune Vuorela wrote:
Hi
If your KDirWatch backend is QFileSystemWatcher, one of the testcases
fails.
The last QVERIFY in testMoveTo never receives the signal dirty-signal it
is looking for.
Apparantly, the watch.removeFile apparantly somehow turns off the QFSW
to not do any further notifications for what happens in the directory
that it also is supposed to be watching.
I haven't yet fully understood what's going on here, but if someone is
up for it, fixing it would be nice. Among others, it is the only backend
available on windows.
This dirty patch seems to ensure that QFSW is used on your platform:
diff --git a/tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
b/tier1/kcoreaddons/src/lib/io/kdirwatch.cpp index 2a89372..8bc9d9b 100644
--- a/tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
+++ b/tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
@@ -103,12 +103,7 @@ static KDirWatch::Method methodFromString(const QString
method) { } else if (method == QLatin1String(QFSWatch)) {
return KDirWatch::QFSWatch;
} else {
-#ifdef Q_OS_LINUX
-// inotify supports delete+recreate+modify, which QFSWatch doesn't
support -return KDirWatch::INotify;
-#else
return KDirWatch::QFSWatch;
-#endif
}
}
Anyone looking into it would be nice.
Please add that as a task on the cleanups page of the wiki if you don't plan
to work on it. Here it'll likely be lost at some point.
Cheers!
--
Kévin Ottens, http://ervin.ipsquad.net
Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42333 --- Ship it! tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp http://git.reviewboard.kde.org/r/112443/#comment30787 Maybe add a comment that this is the same a QX11Info::display(), but we don't want to link to QtX11Extras here. tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp http://git.reviewboard.kde.org/r/112443/#comment30786 Using qApp would work too, after all the display() method already relies on a QGuiApp being used rather than a QCoreApp. - David Faure On Oct. 24, 2013, 5:19 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Oct. 24, 2013, 5:19 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt e4578aa tier1/kguiaddons/src/lib/CMakeLists.txt 4b9e4cd tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113395: Enable KConfig on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42335 --- Looks good to me (don't know about the ownerId() stuff. Maybe QFileInfo could gain a simpler method for doing that, like isOwnedByCurrentUser()?) - David Faure On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 23, 2013, 12:03 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113371: Kross: Remove the KJs backened
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/#review42338 --- Ship it! If he says so :) - David Faure On Oct. 21, 2013, 4:03 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/ --- (Updated Oct. 21, 2013, 4:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Kross: Remove the KJs backened The unit tests currently segfault, and according to the maintainer (Sebastian Sauer) the kjs backend never reached a quality state and should be removed. Diffs - staging/kross/Mainpage.dox c17e1a2 staging/kross/autotests/CMakeLists.txt c5b4a05 staging/kross/autotests/testkross.js e8e7729 staging/kross/autotests/unittest.js 0d7b141 staging/kross/src/CMakeLists.txt 0279846 staging/kross/src/core/action.h e818a51 staging/kross/src/core/interpreter.h d8b1168 staging/kross/src/core/interpreter.cpp 937ca60 staging/kross/src/core/krossconfig.h 0243a53 staging/kross/src/core/manager.h 982817b staging/kross/src/core/manager.cpp 88e312d staging/kross/src/kjs/CMakeLists.txt 32ba00b staging/kross/src/kjs/kjsinterpreter.h be2d61a staging/kross/src/kjs/kjsinterpreter.cpp d89e42b staging/kross/src/kjs/kjsscript.h f760327 staging/kross/src/kjs/kjsscript.cpp 541caf2 Diff: http://git.reviewboard.kde.org/r/113371/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113391: Remove unnecessary #includes for moc files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/#review42337 --- Ship it! Ship It! - David Faure On Oct. 22, 2013, 4:23 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- (Updated Oct. 22, 2013, 4:23 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Remove unnecessary #includes for moc files These are all of the form #include foo.moc, which tells automoc to process foo.cpp, but where there is no class (Q_OBJECT-tagged) in the .cpp file for moc to process. This gets rid of nearly all the messages about appropriate files not being found to process (except in the kconfig_compiler tests, where the code is autogenerated). The ThreadWeaver cleanup is more extensive, because it had more qmake compatibility hacks (which I don't think are needed any more; they seem out of date, at least, and there are no .pro files). Diffs - khtml/src/java/kjavaappletcontext.cpp 7721cc3524d1e6fee3ffce89214a2620e5dfec8a khtml/src/khtml_iface.cpp cc60a58bbe199cc47c62502bdb227119b5f2647d kioslave/http/tests/httpobjecttest.cpp 37ea25d33e1866804a500ff640231d1e9e8c8b99 staging/kde4attic/autotests/kdatetimeformattertest.cpp 159ed7a735527c0078b8bee84dafe8f8ff3e490b staging/kde4attic/autotests/klocaletest.cpp a307e4896191b76549f052cc32acd4b83f0f39fc staging/kde4support/autotests/kasciitest.cpp fb1177ef675d093b8e5fca83d3a1719cf832e91d staging/kde4support/autotests/klibloadertest.cpp c1feb4fc7f59f33ef1ad0bf68c13ea3749403402 staging/kde4support/autotests/kmimetypetest.cpp 7466e565290663f8ac3b8c9c0b64132188c5d51d staging/kde4support/src/kdecore/k3bufferedsocket.cpp d90a371e142400386ba3b2ee04c04f85e0ca45af staging/kde4support/src/kdecore/k3clientsocketbase.cpp 96e99a2024f65aa3b834051d146a962504d83467 staging/kde4support/src/kdecore/k3resolver.cpp 539cf4085dcd949b89d154738d042c673d98a3e2 staging/kde4support/src/kdecore/k3reverseresolver.cpp 2e261135c210802e6a3a6f69252d48d6054323f0 staging/kde4support/src/kdecore/k3serversocket.cpp b6b29837ca35aeff24fae3560bfed3a746ce3d92 staging/kde4support/src/kdecore/k3socketbase.cpp 43651cb9e64a3135e2a40f5c75be73a0da0a84b7 staging/kde4support/src/kdecore/k3streamsocket.cpp 27ae4a93e3b0191439474d36bc16e61a03516b35 staging/kde4support/src/kdecore/klibloader.cpp 10fea2cdde619e2f8ba768c3820a1b0364a3238c staging/kio/autotests/clipboardupdatertest.cpp d7fcfd40bf09378d26f7e901848d488009a93d5e staging/kio/autotests/dataprotocoltest.cpp d73cc951dcb28edb4b469706a3b2a4ef0ee05067 staging/kio/autotests/fileundomanagertest.cpp dfdeaeb7bc3da7af4e4d4da06b5da5704c906c05 staging/kio/tests/previewtest.cpp bfc66bf33068731a5ad7f487bde950a08fa2b1e3 staging/kservice/src/kdeinit/ktoolinvocation.cpp ef047b3847de6cdb61f73d4fd6723541e9359644 staging/kservice/src/plugin/klibrary.cpp 845ff9d24d5f0884dfd57cefe16a190d5b783230 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kpluginloader.cpp 798a9766c92e172977f02720d7c338b8d36a5bc8 staging/kservice/src/services/kautostart.cpp f540e901a62819f4bd9fe9e3dc61560e30ef5ea1 staging/kservice/src/sycoca/ksycoca.cpp 2923172f985bbf744c9adfec3f23c514b7f20e46 tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp 7a7e4e65e312f0c5b7176d851c303c9df101ab08 tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp 75c91fc257c14a773fc22b405f84c8056b0880de tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp 6583a624a26cbaab4c58b262b4056d953cbb316e tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp 9bcd9ec79b140752255d06db8d15dc021ab3ce8b tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp b1a1407c97df7a82832b4af0e1f7bb6d4127d9c9 tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp 9ff7d4bfe7f16ef583420a45d9f26b5c310b7e2e tier1/itemmodels/src/kmodelindexproxymapper.cpp c806e8a8476bdd40e1379a799a6f5c3d7d607fe2 tier1/kconfig/src/core/kconfigbackend.cpp 9bccf420f16737a170273c495b0858b8cca31d67 tier1/kconfig/src/core/kcoreconfigskeleton.cpp ec2c9eedfbb515c97812b5bc78cf66653e9d6e2b tier1/kcoreaddons/autotests/kcompositejobtest.cpp d3d46276a2f8a4e799bda2211c7f0473903b5608 tier1/kcoreaddons/tests/kdirwatchtest.cpp 1ad3928e47b083c2ec21c2748a0e50e972be0d63 tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp edc4ce7e03d28e5b6963f2e4f7274ddf4a0ed41a tier1/kdbusaddons/src/kdedmodule.cpp
Re: Google Code-In
On Friday 25 October 2013 08:59:27 Sune Vuorela wrote: On 2013-10-25, Kevin Ottens er...@kde.org wrote: I got contacted by Lydia because the Google Code-In will soon start and= we=20 could maybe give out tasks to people. I think that's a good idea, and o= ne area=20 is port kdeexamples to KF5. If we split it per example in the repo, i= t makes=20 for nice small tasks, is easy to have them in parallel, etc. The catch of course is that we need people to mentor and create the tas= ks.=20 Anyone up for it? I can give a hand, but it's better to have a couple o= f=20 people IMO. I'm in. I think google code-in is great and I'm up for mentoring some tasks. I'm just almost always out of ideas for what to suggest, so this fits me perfect Excellent! Could you get in touch with Lydia about it? I'd rather have a support role, but we need someone to keep track of things and you seem like a good candidate. :-) Cheers. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113373: Enable C++11 support by default.
Kevin Ottens wrote: Stephen Kelly wrote: It's not my decision either. It's just a recommendation. Aleix Pol Gonzalez wrote: I object. What's the big impediment of releasing ECM? If there's an impediment, let's fix it. I agree with Aleix here. I think it's important that the first frameworks we'll release are as close as possible to the final situation, ECM should be releasable by then. If something blocks that, we should try to solve it. ReviewBoard is not suited for non-patch discussion. One problem is that we have a CMakePackageConfigHelpers.cmake fork in ECM. That fork is no longer needed as of cmake master. Things like http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/7994/focus=6969 could also be solved by teaching CMake something more about tests (not done yet, but I see no reason why worthwhile improvements there would not be accepted). That could obsolete ecm_mark_as_test etc. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113373: Enable C++11 support by default.
On Friday 25 October 2013 11:22:26 Stephen Kelly wrote: Kevin Ottens wrote: Stephen Kelly wrote: It's not my decision either. It's just a recommendation. Aleix Pol Gonzalez wrote: I object. What's the big impediment of releasing ECM? If there's an impediment, let's fix it. I agree with Aleix here. I think it's important that the first frameworks we'll release are as close as possible to the final situation, ECM should be releasable by then. If something blocks that, we should try to solve it. ReviewBoard is not suited for non-patch discussion. One problem is that we have a CMakePackageConfigHelpers.cmake fork in ECM. That fork is no longer needed as of cmake master. Things like http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/7994/focus=6969 could also be solved by teaching CMake something more about tests (not done yet, but I see no reason why worthwhile improvements there would not be accepted). That could obsolete ecm_mark_as_test etc. Sure, I don't see how that's different from classes or methods we have in our libraries at the moment which will get obsoleted by some later Qt version. With that line of thinking we'd never release. Just mark modules which gets obsoleted as deprecated... Or I'm missing something? Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113373: Enable C++11 support by default.
Kevin Ottens wrote: That could obsolete ecm_mark_as_test etc. Sure, I don't see how that's different from classes or methods we have in our libraries at the moment which will get obsoleted by some later Qt version. With that line of thinking we'd never release. Just mark modules which gets obsoleted as deprecated... Or I'm missing something? /shrug/ It's your call. My opinion is that releasing a fork of something that's already in cmake master is not a good idea. Will the CMake version override the fork when it is released? That file will be in a CMake release early next year I guess. Sure, that's after you want to release karchive and threadweaver, but before everything else. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113373: Enable C++11 support by default.
On Friday 25 October 2013 11:38:40 Stephen Kelly wrote: Kevin Ottens wrote: That could obsolete ecm_mark_as_test etc. Sure, I don't see how that's different from classes or methods we have in our libraries at the moment which will get obsoleted by some later Qt version. With that line of thinking we'd never release. Just mark modules which gets obsoleted as deprecated... Or I'm missing something? /shrug/ It's your call. My opinion is that releasing a fork of something that's already in cmake master is not a good idea. Will the CMake version override the fork when it is released? That file will be in a CMake release early next year I guess. Well, yes, I agree exact forks are a problem... They should at least have a different name IMO. For instance ecm_mark_as_test is doing the right thing, there's no risk of clash later on. So if we have things which present this risk of clash, we probably need to rename them ASAP. Sure, that's after you want to release karchive and threadweaver, but before everything else. I think that we just disagree on the timing really, by its nature I think ECM should go first, even though at the last possible moment... so that'd be with the tp1 containing karchive and threadweaver. I've no problem with that particular release of ECM being marked as TP or Alpha if you want. That still leaves you free to change the interface until we get to release more of KF5... it could follow a similar cycle. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113391: Remove unnecessary #includes for moc files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- (Updated Oct. 25, 2013, 10:05 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Remove unnecessary #includes for moc files These are all of the form #include foo.moc, which tells automoc to process foo.cpp, but where there is no class (Q_OBJECT-tagged) in the .cpp file for moc to process. This gets rid of nearly all the messages about appropriate files not being found to process (except in the kconfig_compiler tests, where the code is autogenerated). The ThreadWeaver cleanup is more extensive, because it had more qmake compatibility hacks (which I don't think are needed any more; they seem out of date, at least, and there are no .pro files). Diffs - khtml/src/java/kjavaappletcontext.cpp 7721cc3524d1e6fee3ffce89214a2620e5dfec8a khtml/src/khtml_iface.cpp cc60a58bbe199cc47c62502bdb227119b5f2647d kioslave/http/tests/httpobjecttest.cpp 37ea25d33e1866804a500ff640231d1e9e8c8b99 staging/kde4attic/autotests/kdatetimeformattertest.cpp 159ed7a735527c0078b8bee84dafe8f8ff3e490b staging/kde4attic/autotests/klocaletest.cpp a307e4896191b76549f052cc32acd4b83f0f39fc staging/kde4support/autotests/kasciitest.cpp fb1177ef675d093b8e5fca83d3a1719cf832e91d staging/kde4support/autotests/klibloadertest.cpp c1feb4fc7f59f33ef1ad0bf68c13ea3749403402 staging/kde4support/autotests/kmimetypetest.cpp 7466e565290663f8ac3b8c9c0b64132188c5d51d staging/kde4support/src/kdecore/k3bufferedsocket.cpp d90a371e142400386ba3b2ee04c04f85e0ca45af staging/kde4support/src/kdecore/k3clientsocketbase.cpp 96e99a2024f65aa3b834051d146a962504d83467 staging/kde4support/src/kdecore/k3resolver.cpp 539cf4085dcd949b89d154738d042c673d98a3e2 staging/kde4support/src/kdecore/k3reverseresolver.cpp 2e261135c210802e6a3a6f69252d48d6054323f0 staging/kde4support/src/kdecore/k3serversocket.cpp b6b29837ca35aeff24fae3560bfed3a746ce3d92 staging/kde4support/src/kdecore/k3socketbase.cpp 43651cb9e64a3135e2a40f5c75be73a0da0a84b7 staging/kde4support/src/kdecore/k3streamsocket.cpp 27ae4a93e3b0191439474d36bc16e61a03516b35 staging/kde4support/src/kdecore/klibloader.cpp 10fea2cdde619e2f8ba768c3820a1b0364a3238c staging/kio/autotests/clipboardupdatertest.cpp d7fcfd40bf09378d26f7e901848d488009a93d5e staging/kio/autotests/dataprotocoltest.cpp d73cc951dcb28edb4b469706a3b2a4ef0ee05067 staging/kio/autotests/fileundomanagertest.cpp dfdeaeb7bc3da7af4e4d4da06b5da5704c906c05 staging/kio/tests/previewtest.cpp bfc66bf33068731a5ad7f487bde950a08fa2b1e3 staging/kservice/src/kdeinit/ktoolinvocation.cpp ef047b3847de6cdb61f73d4fd6723541e9359644 staging/kservice/src/plugin/klibrary.cpp 845ff9d24d5f0884dfd57cefe16a190d5b783230 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kpluginloader.cpp 798a9766c92e172977f02720d7c338b8d36a5bc8 staging/kservice/src/services/kautostart.cpp f540e901a62819f4bd9fe9e3dc61560e30ef5ea1 staging/kservice/src/sycoca/ksycoca.cpp 2923172f985bbf744c9adfec3f23c514b7f20e46 tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp 7a7e4e65e312f0c5b7176d851c303c9df101ab08 tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp 75c91fc257c14a773fc22b405f84c8056b0880de tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp 6583a624a26cbaab4c58b262b4056d953cbb316e tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp 9bcd9ec79b140752255d06db8d15dc021ab3ce8b tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp b1a1407c97df7a82832b4af0e1f7bb6d4127d9c9 tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp 9ff7d4bfe7f16ef583420a45d9f26b5c310b7e2e tier1/itemmodels/src/kmodelindexproxymapper.cpp c806e8a8476bdd40e1379a799a6f5c3d7d607fe2 tier1/kconfig/src/core/kconfigbackend.cpp 9bccf420f16737a170273c495b0858b8cca31d67 tier1/kconfig/src/core/kcoreconfigskeleton.cpp ec2c9eedfbb515c97812b5bc78cf66653e9d6e2b tier1/kcoreaddons/autotests/kcompositejobtest.cpp d3d46276a2f8a4e799bda2211c7f0473903b5608 tier1/kcoreaddons/tests/kdirwatchtest.cpp 1ad3928e47b083c2ec21c2748a0e50e972be0d63 tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp edc4ce7e03d28e5b6963f2e4f7274ddf4a0ed41a tier1/kdbusaddons/src/kdedmodule.cpp bdd1ca1874d8255dda7ae828b6d9c1e14816e5b8 tier1/kguiaddons/autotests/kiconutilstest.cpp 3690c131c54bd328e3d135bbdd048e18597924a1 tier1/kjs/autotests/ecmatest.cpp 585516377dfc0cf63f4bb463bb1d27fd9031c3cb tier1/kplotting/examples/testplot_widget.cpp 95e1a42894bef6b131a97aaf0ce43b0b86eb0d99 tier1/solid/src/imports/devices.cpp 05e6618000b1b273ebfd1eae3eb6fd64e9e84b4f
Re: Review Request 113378: Trivial warning fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42343 --- This review has been submitted with commit 139a09daf188129c470b6b3f49d7720e6a2b71b9 by Alex Merry to branch frameworks. - Commit Hook On Oct. 22, 2013, 4:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 22, 2013, 4:01 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Trivial warning fixes Fixes for warnings (almost entirely unused variables or parameters) where the correct fix was obvious. Diffs - interfaces/kimproxy/library/kimproxy.cpp e48545f0a7229d66d16901c492095ce70b755c7e khtml/src/css/css_ruleimpl.cpp e2b3a8ae82ec0f6f85c5949a08f1773b08510479 khtml/src/css/css_webfont.cpp 9c5bedd13a24a3d32f670d718e1ff761ec4a6724 khtml/src/css/cssstyleselector.cpp fa8f5f4049aec3c2738257215a74b2536981d89b khtml/src/ecma/kjs_clientrect.cpp 6d7138e7f15293d18406a90eacf214847d884c45 khtml/src/ecma/kjs_events.cpp d0c481f06ab0efab9457f699571fdd052a99a348 khtml/src/ecma/kjs_proxy.cpp afd661bd149eaaa2a8ad4940f2a7d61d1f892116 khtml/src/editing/htmlediting_impl.cpp 2ec91188e47748a19ce414cf5d740518b8cf5225 khtml/src/imload/decoders/pngloader.cpp 6d0f023e25cdd112173873bf26b13c2d86172cb8 khtml/src/rendering/RenderSVGRoot.cpp c1e96d23e12732294301d675b3603f3e86656e56 khtml/src/rendering/render_canvasimage.cpp 73eb2c6b95c1e1089204b062ef1dd0a6f3c40f6c khtml/src/svg/SVGLinearGradientElement.cpp 46059f78527b313e90111cfcc048fc64727fb265 khtml/src/svg/graphics/qt/SVGResourceClipperQt.cpp 11c768fc1f496a1cb365bd5fc2ed2e3cada66720 kioslave/file/file.cpp 692a77fe02c33d64ff38afccfd48e8dc3127e75d kioslave/file/file_unix.cpp c8781fef39cf3e842f9c9794d757154d8ae284ac kioslave/http/http.cpp b4fd4126dfb86a251d2b98cf587311b715be9979 knewstuff/src/ui/itemsgridviewdelegate.cpp a0abb7f0b359b06268e4c640be08bfd3ddae79b1 staging/frameworkintegration/src/platformtheme/main.cpp 45b487c739266e4108df8de38ae5e139ca603e5a staging/kde4support/autotests/kglobalstatictest.cpp db6473a572d47086e8db400d94c3bf62424f493f staging/kde4support/src/kdecore/kdebug.cpp 98baed423e2af32d5a6726d21d4d140854b94375 staging/kde4support/src/kdeui/kaction.cpp f5d2e201b84feea2e0ccba9b17298d3c5877e04d staging/kde4support/src/kdeui/kapplication.cpp dc2e120bc28fca5708c699e68ddea22915c46233 staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df231227cd058842b8f1b90b5901cbebadbb683 staging/kde4support/tests/kcmdlineargstest.cpp a72aa4d120baf2904addd238276e0b400e0d8850 staging/kio/src/core/klocalsocket.h 93b04d69f52ccc16a3dba817d0585835e7134821 staging/kio/src/core/tcpslavebase.cpp 5180ed952d29e995c78cae498f323e0f1a3e08d7 staging/kio/src/filewidgets/kdirsortfilterproxymodel.cpp 59c4b37709acd37e9a6d1b77ff233f9e83cdecc8 staging/kio/src/widgets/kdirmodel.cpp ea290d0369aea303657afb74000780610c135ddf staging/kio/src/widgets/kurlrequester.cpp 70c760589d460f705c8bb884a5c76e2f9d5dece8 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kplugintrader.h 823b8d5dd363642a4c11be971ee64bc3cac6a65f staging/kservice/tests/pluginlocator/plugintest.cpp 4cfc74ace9c10cccbd2651291e752b8275af036e tier1/itemmodels/src/kdescendantsproxymodel.cpp 3bdfd9ffed351b5bab24e7959730c29773cc0952 tier1/itemmodels/src/kselectionproxymodel.cpp ca97070b70996ab1320d252623a503172c9be041 tier1/itemviews/src/kwidgetitemdelegate.cpp 8d4d5cec85ee460fe2604c83fd49bf7536db990a tier1/itemviews/src/kwidgetitemdelegatepool.cpp ed94c8936e4db44dc180c5820619a0ca3fdeffa2 tier1/itemviews/tests/kwidgetitemdelegatetest.cpp 07c8bca052a3340322884ba84e8ecdf5386e10a6 tier1/karchive/src/karchive.cpp 375d717bd5030ff694e1586855f1e3f401ef tier1/kconfig/autotests/test_kconf_update.cpp 78b783042b03dd0a15f8ce91f85ec1415acfc12f tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 2b5570938f189d4891fa7baa9f9b74791c97f4ad tier1/kwidgetsaddons/src/kdatetable.cpp e5c6f5cbdafaa8ac2abd4f4eea1bb0ef9191b386 tier1/kwidgetsaddons/src/kdragwidgetdecorator.cpp 74fb8bbcf3c9836cfd88da1d017b61c4da4deb29 tier1/threadweaver/src/Weaver/DestructedState.cpp bcd613201234ca6db19d285d571c4b6fca350789 tier1/threadweaver/src/Weaver/JobCollection.cpp bac3d22e25bc2a89cc72278f666fe6e1d0635079 tier1/threadweaver/src/Weaver/ShuttingDownState.cpp ff692a59a7f94c123fc225eea9d165ba28bf5d0b tier2/kwallet/src/kwallet.cpp 49098bf5832ff83b270c1934aaf0abf6c4c780a9
Re: Review Request 113391: Remove unnecessary #includes for moc files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/#review42344 --- This review has been submitted with commit 8a86b081e66726ffc45e708ec327a85f686fb295 by Alex Merry to branch frameworks. - Commit Hook On Oct. 22, 2013, 4:23 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- (Updated Oct. 22, 2013, 4:23 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Remove unnecessary #includes for moc files These are all of the form #include foo.moc, which tells automoc to process foo.cpp, but where there is no class (Q_OBJECT-tagged) in the .cpp file for moc to process. This gets rid of nearly all the messages about appropriate files not being found to process (except in the kconfig_compiler tests, where the code is autogenerated). The ThreadWeaver cleanup is more extensive, because it had more qmake compatibility hacks (which I don't think are needed any more; they seem out of date, at least, and there are no .pro files). Diffs - khtml/src/java/kjavaappletcontext.cpp 7721cc3524d1e6fee3ffce89214a2620e5dfec8a khtml/src/khtml_iface.cpp cc60a58bbe199cc47c62502bdb227119b5f2647d kioslave/http/tests/httpobjecttest.cpp 37ea25d33e1866804a500ff640231d1e9e8c8b99 staging/kde4attic/autotests/kdatetimeformattertest.cpp 159ed7a735527c0078b8bee84dafe8f8ff3e490b staging/kde4attic/autotests/klocaletest.cpp a307e4896191b76549f052cc32acd4b83f0f39fc staging/kde4support/autotests/kasciitest.cpp fb1177ef675d093b8e5fca83d3a1719cf832e91d staging/kde4support/autotests/klibloadertest.cpp c1feb4fc7f59f33ef1ad0bf68c13ea3749403402 staging/kde4support/autotests/kmimetypetest.cpp 7466e565290663f8ac3b8c9c0b64132188c5d51d staging/kde4support/src/kdecore/k3bufferedsocket.cpp d90a371e142400386ba3b2ee04c04f85e0ca45af staging/kde4support/src/kdecore/k3clientsocketbase.cpp 96e99a2024f65aa3b834051d146a962504d83467 staging/kde4support/src/kdecore/k3resolver.cpp 539cf4085dcd949b89d154738d042c673d98a3e2 staging/kde4support/src/kdecore/k3reverseresolver.cpp 2e261135c210802e6a3a6f69252d48d6054323f0 staging/kde4support/src/kdecore/k3serversocket.cpp b6b29837ca35aeff24fae3560bfed3a746ce3d92 staging/kde4support/src/kdecore/k3socketbase.cpp 43651cb9e64a3135e2a40f5c75be73a0da0a84b7 staging/kde4support/src/kdecore/k3streamsocket.cpp 27ae4a93e3b0191439474d36bc16e61a03516b35 staging/kde4support/src/kdecore/klibloader.cpp 10fea2cdde619e2f8ba768c3820a1b0364a3238c staging/kio/autotests/clipboardupdatertest.cpp d7fcfd40bf09378d26f7e901848d488009a93d5e staging/kio/autotests/dataprotocoltest.cpp d73cc951dcb28edb4b469706a3b2a4ef0ee05067 staging/kio/autotests/fileundomanagertest.cpp dfdeaeb7bc3da7af4e4d4da06b5da5704c906c05 staging/kio/tests/previewtest.cpp bfc66bf33068731a5ad7f487bde950a08fa2b1e3 staging/kservice/src/kdeinit/ktoolinvocation.cpp ef047b3847de6cdb61f73d4fd6723541e9359644 staging/kservice/src/plugin/klibrary.cpp 845ff9d24d5f0884dfd57cefe16a190d5b783230 staging/kservice/src/plugin/kpluginfactory.cpp 405d41ed63f8bf4d54334d437f443160c569a82b staging/kservice/src/plugin/kpluginloader.cpp 798a9766c92e172977f02720d7c338b8d36a5bc8 staging/kservice/src/services/kautostart.cpp f540e901a62819f4bd9fe9e3dc61560e30ef5ea1 staging/kservice/src/sycoca/ksycoca.cpp 2923172f985bbf744c9adfec3f23c514b7f20e46 tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp 7a7e4e65e312f0c5b7176d851c303c9df101ab08 tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp 75c91fc257c14a773fc22b405f84c8056b0880de tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp 6583a624a26cbaab4c58b262b4056d953cbb316e tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp 9bcd9ec79b140752255d06db8d15dc021ab3ce8b tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp b1a1407c97df7a82832b4af0e1f7bb6d4127d9c9 tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp 9ff7d4bfe7f16ef583420a45d9f26b5c310b7e2e tier1/itemmodels/src/kmodelindexproxymapper.cpp c806e8a8476bdd40e1379a799a6f5c3d7d607fe2 tier1/kconfig/src/core/kconfigbackend.cpp 9bccf420f16737a170273c495b0858b8cca31d67 tier1/kconfig/src/core/kcoreconfigskeleton.cpp ec2c9eedfbb515c97812b5bc78cf66653e9d6e2b tier1/kcoreaddons/autotests/kcompositejobtest.cpp d3d46276a2f8a4e799bda2211c7f0473903b5608 tier1/kcoreaddons/tests/kdirwatchtest.cpp 1ad3928e47b083c2ec21c2748a0e50e972be0d63 tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp
Re: Review Request 113395: Enable KConfig on Windows
On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: tier1/kconfig/src/core/kconfigini.cpp, line 425 http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425 Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would do kdewin's getuid, so here we probably should follow the if part, not the else one. Andrius da Costa Ribas wrote: Oops. Double comment ... I thought the first one hadn't been saved ;) Alexander Richardson wrote: Looks like files do have owners: http://msdn.microsoft.com/en-us/library/windows/desktop/aa446629%28v=vs.85%29.aspx I guess the correct solution would be to get the owner SID using GetSecurityInfo and then GetTokenInformation to get the current SID and then compare that. Yes, the SID is the equivalent, however it won't match what Qt does on Windows: http://doc-snapshot.qt-project.org/qt5-nosubdir/qfileinfo.html#ownerId - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42192 --- On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 23, 2013, 12:03 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Dirty CMake master content in install directory
Hello, If you use CMake master, then you may have unused stuff in your install directory versioned by commit sha: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8433 The issue is resolved in the CMake next branch, and will be merged to master next week probably. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113430: More warnings fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- This is a series of commits: warnings--: parentheses around '' within '||' Fix a couple of warnings inadventently caused by 139a09da Use a better hack for dealing with gperf's unhelpful inlining gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which *only* generates inline versions. This causes linker errors if the compiler decides not to use inlining. Previously, there was a hack (claiming to prevent warnings) that disabled __inline keyword, which fixed the linking issue but caused another warning (about ignored attributes) to be emitted because the __gnu_inline__ attribute was still there, and that doesn't work without one of the normal inline keywords. This version leaves __inline alone, but prevents the use of __gnu_inline__. Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray Visibility attributes only work on declarations, not on definitions. Remove virtual modifier from signal A virtual signal makes no sense. Diffs - khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 khtml/src/rendering/render_canvasimage.cpp 346a65491e459c3d8f1c731340ff5a6ae33b35f1 khtml/src/rendering/render_inline.cpp 84e07eab5604e4882fd816826b6e59c317c53805 tier1/itemmodels/src/kselectionproxymodel.cpp c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a tier1/solid/src/solid/backends/udev/udevbutton.h 39eb6683fc611dfff5b6fef69e66ab709238e889 Diff: http://git.reviewboard.kde.org/r/113430/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113432: Install FindDBusMenuQt5.cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly. Repository: extra-cmake-modules Description --- Install FindDBusMenuQt5.cmake. This makes it possible to fix issues in kde-workspace and to remove kdelibs/tier2/knotifications/cmake Diffs - find-modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113432/diff/ Testing --- Module installs successfully, kde-workspace can use it after adaptation. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113432: Install FindDBusMenuQt5.cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/#review42361 --- Why does that library not install a Config.cmake file? - Stephen Kelly On Oct. 25, 2013, 3:16 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- (Updated Oct. 25, 2013, 3:16 p.m.) Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly. Repository: extra-cmake-modules Description --- Install FindDBusMenuQt5.cmake. This makes it possible to fix issues in kde-workspace and to remove kdelibs/tier2/knotifications/cmake Diffs - find-modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113432/diff/ Testing --- Module installs successfully, kde-workspace can use it after adaptation. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113432: Install FindDBusMenuQt5.cmake
On Oct. 25, 2013, 5:40 p.m., Stephen Kelly wrote: Why does that library not install a Config.cmake file? Sebas put together a patch to do so, but it needs to be refined because it currently does not work for Qt4 (dbusmenu-qt is Qt4 and Qt5). Furthermore, the upstream project needs to accept it, which is not guaranteed. Installing this Find module fixes the issue, potentially faster and without breaking working Qt4 setup. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/#review42361 --- On Oct. 25, 2013, 5:16 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- (Updated Oct. 25, 2013, 5:16 p.m.) Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly. Repository: extra-cmake-modules Description --- Install FindDBusMenuQt5.cmake. This makes it possible to fix issues in kde-workspace and to remove kdelibs/tier2/knotifications/cmake Diffs - find-modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113432/diff/ Testing --- Module installs successfully, kde-workspace can use it after adaptation. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Use of the WIN32 executable property
2013/10/25 David Faure fa...@kde.org: On Wednesday 02 October 2013 23:52:08 Nicolás Alvarez wrote: In fact, I wonder if we should make all tests console applications by default (in ecm_mark_as_test?)... All unittests, yes. But interactive test apps are really just normal test apps, there's no reason for them to behave differently from actual apps. Many interactive test apps communicate via console messages, or expect command-line arguments and show help on the console if you don't pass any. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: cyclic dependency kinit - kservice
On Friday 25 October 2013 12:21:28 David Narvaez wrote: On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens er...@kde.org wrote: Not that I know of, Alex never replied to that I think... What would be a proper fix for this? Separating kbuildsycoca and putting it on top of kinit? I'd lean more toward having kbuildsycoca not be a kdeinit module. David (Faure) knows more that area than me though... Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs_stable #867
See http://build.kde.org/job/kdelibs_stable/867/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_stable #868
See http://build.kde.org/job/kdelibs_stable/868/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113436: Deprecate KEmoticonsTheme methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Deprecate KEmoticonsTheme methods Before the initial cleanup, the loadTheme(), removeEmoticon() and addEmoticon methods of KEmoticonsTheme called the KEmoticonsProvider methods of the same name, which were either empty or useless. Now the KEmoticonsProvider methods are pure virtual and therefore those KEmoticonsTheme methods are deprecated and a subclassing of KEmoticonsProvider is advised. Diffs - KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 Diff: http://git.reviewboard.kde.org/r/113436/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
