Jenkins build is back to stable : kdelibs_frameworks_qt5 #1706
See http://build.kde.org/job/kdelibs_frameworks_qt5/1706/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113883/ --- (Updated Nov. 20, 2013, 11:10 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview Diffs - staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067 staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp 04efb24 staging/kmediaplayer/src/kfileaudiopreview/mediacontrols_p.h bb36ab1 Diff: http://git.reviewboard.kde.org/r/113883/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113970: KConfigDialog: Guard against editing buttons that do not exist.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113970/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- KConfigDialog: Guard against editing buttons that do not exist. ButtonBox is public inside KPageDialog which means any other class can call setButtons() on it. KConfigDialog can not reliably know that certain buttons exist, and should guard appropriately. This fixes a crash in systemsettings in Plasma2 Diffs - tier3/kconfigwidgets/src/kconfigdialog.cpp 23ed3ee Diff: http://git.reviewboard.kde.org/r/113970/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kded5 and kde-workspace
Hey there Today I have been porting powerdevil and while doing it found out that kded5 was not loading any modules and many kde-workspace projects were using org.kde.kded instead of the one ended with .kded5 Tomorrow I'd like to push a local commit that changes all org.kde.kded for org.kde.kded5 (which we will have to change again but more about that in a later email), and will effectively make kde-workspace and plasma-framework depend on kded5. In order to make kded5 load modules, you have to have KDE_SESSION_VERSION set to 5, so add that to your set kde5 environment script. So please, adapt your environment asap, I'd like to push this tomorrow so we can do testing of the kf5 KDEDModules instead of kded4. Cheers ! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113972: Add some autotests for KMediaPlayer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113972/ --- (Updated Nov. 21, 2013, midnight) Review request for KDE Frameworks. Changes --- Use QCOMPARE instead of QVERIFY, for better error messages. Repository: kdelibs Description --- Add some autotests for KMediaPlayer Diffs (updated) - staging/kmediaplayer/CMakeLists.txt c9f301ae961a0fd7f4ad71f1a7cec766493f3d14 staging/kmediaplayer/autotests/CMakeLists.txt PRE-CREATION staging/kmediaplayer/autotests/playertest.cpp PRE-CREATION staging/kmediaplayer/autotests/testplayer.h PRE-CREATION staging/kmediaplayer/autotests/testview.h PRE-CREATION staging/kmediaplayer/autotests/viewtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113972/diff/ Testing --- Builds, new tests run and pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113972: Add some autotests for KMediaPlayer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113972/#review44084 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 21, 2013, midnight, Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113972/ --- (Updated Nov. 21, 2013, midnight) Review request for KDE Frameworks. Repository: kdelibs Description --- Add some autotests for KMediaPlayer Diffs - staging/kmediaplayer/CMakeLists.txt c9f301ae961a0fd7f4ad71f1a7cec766493f3d14 staging/kmediaplayer/autotests/CMakeLists.txt PRE-CREATION staging/kmediaplayer/autotests/playertest.cpp PRE-CREATION staging/kmediaplayer/autotests/testplayer.h PRE-CREATION staging/kmediaplayer/autotests/testview.h PRE-CREATION staging/kmediaplayer/autotests/viewtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113972/diff/ Testing --- Builds, new tests run and pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
