Re: Optional QtGui dependency for KDBusAddons?

2013-11-22 Thread David Faure
On Wednesday 13 November 2013 11:16:24 Alex Merry wrote: On 13/11/13 05:38, Martin Gräßlin wrote: On Tuesday 12 November 2013 23:42:36 Alex Merry wrote: The latter is my personal preference (and I don't see any real issue with KDBusAddons optionally using something from Qt Essentials),

Re: Having a Tier 0 for cmake and git submodules

2013-11-22 Thread David Faure
On Tuesday 12 November 2013 22:56:47 Alexander Neundorf wrote: 4) find_package(KArchive) find_package(Solid) find_package(KConfig) find_package(ECM) include(KDECMakeSettings) include(KDEInstallDirs) include(KDECompilerSettings) If all it takes to avoid a tier0 (kf5umbrella) dependency in

Re: kdoctools

2013-11-22 Thread David Faure
On Friday 15 November 2013 10:12:23 Treeve Jelbert wrote: kdoctools installs files to /opt/qt5/share/ksgmltools2/customization whereas kdelibs4 uses /opt/qt4/share/apps/ksgmltools2/customization is the problem due to the extra apps directory? That would be a bug, then. apps got removed in

Re: Optional QtGui dependency for KDBusAddons?

2013-11-22 Thread Alex Merry
On 22/11/13 09:55, David Faure wrote: On Wednesday 13 November 2013 11:16:24 Alex Merry wrote: Alternatively, if the app implements D-Bus Activation, the client can pass the desktop startup notification ID via the D-Bus call. The application still has to remove it. I think most developer

Re: Accessing the private of KGlobalShortcut in kglobalaccel

2013-11-22 Thread David Faure
On Wednesday 13 November 2013 07:22:18 Martin Gräßlin wrote: Hi, I'm currently trying to port kglobalaccel in kde-runtime to frameworks. I'm facing an issue in the file globalshortcut.cpp: it tries to access the private header of KGlobalShortcutInfo to create a custom KGlobalShortcutInfo

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

2013-11-22 Thread David Faure
On Wednesday 13 November 2013 17:34:45 Alex Merry wrote: Of course, if we wanted to support Ryan's use cases (like text editor use by git), thing's get a little more complicated. He basically suggests the route of standardising application arguments, AFAICS, but even without that, I think

Re: Review Request 114004: Install kio/connection_p.h

2013-11-22 Thread David Faure
On Thursday 21 November 2013 16:51:12 Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114004/ (sorry, can't reply on RB from the train, it keeps losing my comments)

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

2013-11-22 Thread Alex Merry
On 22/11/13 10:32, David Faure wrote: On Wednesday 13 November 2013 17:34:45 Alex Merry wrote: Of course, if we wanted to support Ryan's use cases (like text editor use by git), thing's get a little more complicated. He basically suggests the route of standardising application arguments,

Build failed in Jenkins: kdelibs_frameworks_qt5 #1727

2013-11-22 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1727/changes Changes: [faure] Move IdleSlave from klauncher to KIO, so that KIO::Connection can remain internal. [faure] Move ConnectionServer into own header, and install it for klauncher. --

Build failed in Jenkins: plasma-framework_master_qt5 #912

2013-11-22 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/912/changes Changes: [aleixpol] KParts is a Kross dependency now -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: KMediaPlayer

2013-11-22 Thread Alex Merry
On Friday 22 Nov 2013 15:35:37 David Faure wrote: On Saturday 16 November 2013 09:47:02 Alex Merry wrote: * Decide whether it's a tier3 or tier4 framework (kfileaudiopreview is a KIO preview plugin; kmediaplayer is a skeleton/interface for a multimedia KPart) kfileaudiopreview: I

Re: KMediaPlayer

2013-11-22 Thread David Faure
On Friday 22 November 2013 14:56:43 Alex Merry wrote: On Friday 22 Nov 2013 15:35:37 David Faure wrote: On Saturday 16 November 2013 09:47:02 Alex Merry wrote: * Decide whether it's a tier3 or tier4 framework (kfileaudiopreview is a KIO preview plugin; kmediaplayer is a skeleton/interface

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-22 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44216 --- Ok, we checked with David. Solution is to simply remove

Re: Review Request 113975: Make some KSSL files public API

2013-11-22 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113975/#review44218 --- We're looking into moving the relevant bits in KHTML instead.

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

2013-11-22 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/#review44221 --- If we believe jenkins, the test you introduced fails. :-) -

Re: Review Request 113910: Add basic KArchive examples

2013-11-22 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44222 --- tier1/karchive/examples/helloworld/main.cpp

Re: Review Request 114010: [tier1/kcoreaddons] Rename mimetype xml

2013-11-22 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114010/ --- (Updated Nov. 22, 2013, 5:09 p.m.) Status -- This change has been

Re: Review Request 114012: Remove kfileaudiopreview

2013-11-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114012/ --- (Updated Nov. 22, 2013, 5:31 p.m.) Status -- This change has been

Re: Accessing the private of KGlobalShortcut in kglobalaccel

2013-11-22 Thread Nicolás Alvarez
2013/11/22 David Faure fa...@kde.org: On Wednesday 13 November 2013 07:22:18 Martin Gräßlin wrote: Hi, I'm currently trying to port kglobalaccel in kde-runtime to frameworks. I'm facing an issue in the file globalshortcut.cpp: it tries to access the private header of KGlobalShortcutInfo to

Review Request 114037: Split kfileaudiopreview out from kmediaplayer

2013-11-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 114038: Integrate KAboutData and QCommandLineParser

2013-11-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 22, 2013, 6:23 p.m.) Review request for KDE Frameworks.

Review Request 114043: [tier3/kunitconversion] Improve dependency specification

2013-11-22 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114043/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 114044: Remove unused dependencies in kcoreaddons

2013-11-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114044/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Accessing the private of KGlobalShortcut in kglobalaccel

2013-11-22 Thread Martin Graesslin
On Friday 22 November 2013 15:39:35 Nicolás Alvarez wrote: Why is the daemon needed? Why can't global shortcuts handling be done in-process by the library? a) not all window systems allow to read the keyboard. b) The daemon does handling like only one application can take a global shortcut. If

Re: Review Request 114003: Install private headers needed by kde4support

2013-11-22 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44238 --- Ship it! Ship It! - Kevin Ottens On Nov. 22, 2013, 6:23

Review Request 114050: Add manual test app for enableBlurBehind.

2013-11-22 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/ --- Review request for KDE Frameworks. Repository: kdelibs Description