Re: Forward includes

2013-12-27 Thread Àlex Fiestas
On Friday 27 December 2013 19:00:14 Aleix Pol wrote: > Hi, > I've been going through the kde4support forward includes, since I wanted to > start making the modules I decided we'd better make sure all of them are > working properly. > > After some research, I found that I don't have these available

KCoreAddons forward headers

2013-12-27 Thread Aleix Pol
Hi, Here's a patch adding CamelCase headers to KCoreAddons (attached). If we agree that it's the proper way of doing it, I'll proceed to do it on the rest of modules. Cheers! Aleix diff --git a/CMakeLists.txt b/CMakeLists.txt index 389245c..ba6644a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt

Re: What are the plans with CamelCase includes?

2013-12-27 Thread Friedrich W. H. Kossebau
Am Dienstag, 24. Dezember 2013, 18:17:48 schrieb Bhushan Shah: > Hello, > > On Tue, Dec 24, 2013 at 5:59 PM, Aleix Pol wrote: > > I'll try to take some time after the 26th to do it. If somebody wants to > > do > > it meanwhile, please do and I'll review it. > > I have some spare time and want to

Forward includes

2013-12-27 Thread Aleix Pol
Hi, I've been going through the kde4support forward includes, since I wanted to start making the modules I decided we'd better make sure all of them are working properly. After some research, I found that I don't have these available, can somebody please tell me if I'm missing some dependency or i

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

2013-12-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/ --- (Updated Dec. 27, 2013, 4:29 p.m.) Status -- This change has been ma

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

2013-12-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/#review46194 --- This review has been submitted with commit 778bf0ac0b057db190

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

2013-12-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/#review46193 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2013, 2

Re: Using KCompressionDevice with QSaveFile

2013-12-27 Thread Dominik Haumann
On Tuesday 10 December 2013 23:31:33 David Faure wrote: > On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote: > > It seems that the behavior for "None" is different. Interestingly, > > KSaveFile also behaved like this (KFilterDev did not change after all I > > guess). > I'm surprised, becau

Review Request 114683: Clean up target_link_libraries for KF5Plasma

2013-12-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/ --- Review request for Build System, KDE Frameworks and Plasma. Repository: p

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114478/#review46183 --- This review has been submitted with commit c48bce3c47a7c160aa

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114478/ --- (Updated Dec. 27, 2013, 12:13 p.m.) Status -- This change has been m

Re: Review Request 114478: Add kshareddatacache.h include

2013-12-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114478/#review46182 --- Ship it! As per discussion on kde-frameworks list. I'll have

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Alex Merry
On 27/12/13 11:30, Kevin Ottens wrote: > On Friday 27 December 2013 11:22:57 Alex Merry wrote: >> On 27/12/13 11:04, Kevin Ottens wrote: >>> On Monday 23 December 2013 14:51:19 Alex Merry wrote: Actually, I think we should just install application files directly in share/applications. (ie

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Kevin Ottens
On Friday 27 December 2013 11:22:57 Alex Merry wrote: > On 27/12/13 11:04, Kevin Ottens wrote: > > On Monday 23 December 2013 14:51:19 Alex Merry wrote: > >> Actually, I think we should just install application files directly in > >> share/applications. (ie: change the value of XDG_APPS_INSTALL_DIR

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Alex Merry
On 27/12/13 11:04, Kevin Ottens wrote: > On Monday 23 December 2013 14:51:19 Alex Merry wrote: >> Actually, I think we should just install application files directly in >> share/applications. (ie: change the value of XDG_APPS_INSTALL_DIR in >> KDEInstallDirs.cmake). It makes everyone's lives more

Re: kde4support: kstandarddirs_unittest fix

2013-12-27 Thread Kevin Ottens
Hello, Any news on that front? I see kde4support is still the one not green because of that test. I see that Alex is kind of waiting for someone to take a side on the possible solutions. See below for my own take but I don't know KStandardDirs enough to have a valuable opinion. /me looks at D

Re: pkg-config files

2013-12-27 Thread Alexander Neundorf
On Thursday 26 December 2013, Alex Merry wrote: > How much do we care about users of frameworks who don't use CMake? Do > we want to provide pkg-config files? How easy is it to do so? > > (My personal answers would be: enough to put in a little effort, but not > a huge one; yes, if it's easy; th

Re: Framework licenses

2013-12-27 Thread Martin Graesslin
On Monday 23 December 2013 19:45:36 Alex Merry wrote: > On 23/12/13 18:46, Aurélien Gâteau wrote: > > - plasma-framework: this framework uses multiple licenses, but majority is > > LGPL (this is the case for many other frameworks). Should we use a LGPL > > 2.1 > > COPYING.LIB file? > > A quick att