Review Request 115021: Fix build without X

2014-01-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/ --- Review request for KDE Frameworks. Repository: kdesu Description

Review Request 115022: Remove unused dependency

2014-01-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/ --- Review request for KDE Frameworks. Repository: kdesu Description

Re: Integrating kf5dot and kapidox

2014-01-15 Thread Aurélien Gâteau
On Tue, Jan 14, 2014, at 6:53, Alex Merry wrote: On 14/01/14 08:58, Aurélien Gâteau wrote: On Mon, Jan 13, 2014, at 14:34, Alex Merry wrote: On 13/01/14 21:36, Aurélien Gâteau wrote: Second, api.kde.org deployment. kf5dot-prepare needs to be able to run CMake on the source code. @Allen:

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-15 Thread Alex Merry
On 15/01/14 07:36, Valentin Rusu wrote: On 01/15/2014 07:16 AM, Ben Cooksley wrote: It seems you are relying on D-Bus auto-launching. Is this the case? Yes, the kwallet API uses DBus activation to get kwalletd up un running. If that's already in place, then I realize that we need another

Re: Review Request 115023: Remove unused dependency

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115023/#review47429 --- Ship it! CMakeLists.txt

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47437 --- This review has been submitted with commit

Re: Review Request 114962: Improve dependency specifications

2014-01-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- (Updated Jan. 15, 2014, 12:13 p.m.) Status -- This change has been

Review Request 115024: Remove check for X11

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/ --- Review request for KDE Frameworks and Andreas Hartmetz. Repository:

Re: Review Request 115024: Remove check for X11

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/ --- (Updated Jan. 15, 2014, 12:21 p.m.) Review request for KDE Frameworks

Re: Review Request 115016: Make KJob usable from QML

2014-01-15 Thread Alex Merry
On 15/01/14 12:43, Kevin Krammer wrote: On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: A NOTIFY signal is optional. If defined, it should specify one existing signal in that class that is emitted whenever the value of the property changes. NOTIFY signals for MEMBER variables must

Re: Review Request 115016: Make KJob usable from QML

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47440 --- Ship it! After Kevin Krammer's comment on the list, I

Ktextwidget module

2014-01-15 Thread laurent Montel
Hi, I will maintain this module. I spoke this morning with David Gil and he is ok with it. This is used a lot in kdepim/kmail and I worked on it (in kdelibs) before. So I am interesting to maintain it. I will change name in wiki. Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt

Review Request 115028: Allow the building of deprecated code to be disabled

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- (Updated Jan. 15, 2014, 2:08 p.m.) Review request for KDE Frameworks,

Re: Review Request 114969: Add common files required for documentation generation

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- (Updated Jan. 15, 2014, 2:08 p.m.) Review request for KDE Frameworks,

Re: Review Request 114979: Do not install licenses

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/ --- (Updated Jan. 15, 2014, 2:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 114972: Trim default settings from Doxyfile.global

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/ --- (Updated Jan. 15, 2014, 2:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 114973: Remove spurious image files

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/ --- (Updated Jan. 15, 2014, 2:10 p.m.) Review request for KDE Frameworks and

Review Request 115030: Install public headers for KJsEmbed

2014-01-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/ --- Review request for KDE Frameworks. Repository: kjsembed Description

Re: Review Request 114969: Add common files required for documentation generation

2014-01-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/#review47450 --- Makes sense to me , but I leave it up to Luigi to give the

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/#review47449 --- Ship it! Makes sense to me. - Aurélien Gâteau On Jan. 15,

Re: Review Request 114972: Trim default settings from Doxyfile.global

2014-01-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/#review47451 --- Ship it! Much nicer, indeed. - Aurélien Gâteau On Jan.

Re: Review Request 114979: Do not install licenses

2014-01-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/#review47453 --- Ship it! Makes sense, thanks! - Aurélien Gâteau On Jan.

Re: Review Request 114973: Remove spurious image files

2014-01-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/#review47452 --- Ship it! Those are left overs: the apidox folder used to

Re: Review Request 114972: Trim default settings from Doxyfile.global

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/ --- (Updated Jan. 15, 2014, 2:49 p.m.) Status -- This change has been

Re: Review Request 114973: Remove spurious image files

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/#review47455 --- This review has been submitted with commit

Re: Review Request 114972: Trim default settings from Doxyfile.global

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/#review47454 --- This review has been submitted with commit

Re: Review Request 114979: Do not install licenses

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/ --- (Updated Jan. 15, 2014, 2:54 p.m.) Status -- This change has been

Re: Review Request 114979: Do not install licenses

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/#review47456 --- This review has been submitted with commit

Re: Review Request 114973: Remove spurious image files

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/ --- (Updated Jan. 15, 2014, 2:49 p.m.) Status -- This change has been

Re: Review Request 115021: Fix build without X

2014-01-15 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/#review47457 --- Ship it! Ship It! - Nicolás Alvarez On Jan. 15, 2014,

Re: Review Request 115021: Fix build without X

2014-01-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/ --- (Updated Jan. 15, 2014, 3:15 p.m.) Status -- This change has been

Re: Review Request 115021: Fix build without X

2014-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/#review47458 --- This review has been submitted with commit

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-15 Thread Valentin Rusu
On 01/15/2014 12:15 PM, Alex Merry wrote: On 15/01/14 07:36, Valentin Rusu wrote: On 01/15/2014 07:16 AM, Ben Cooksley wrote: It seems you are relying on D-Bus auto-launching. Is this the case? Yes, the kwallet API uses DBus activation to get kwalletd up un running. If that's already in

Re: Review Request 114969: Add common files required for documentation generation

2014-01-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/#review47471 --- Ship it! I think there is no way to save the old history for

Re: Review Request 114971: Remove unused common files and do not install any of them

2014-01-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/#review47472 --- Ship it! I don't think we should be installing the licenses

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

2014-01-15 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- (Updated Jan. 15, 2014, 9:25 p.m.) Review request for KDE Frameworks and

Review Request 115047: Fix substitution order for some KUIT elements with attributes

2014-01-15 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: