---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115097/#review47626
---
Ship it!
Good work, thanks.
I agree with the small SC break
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115098/#review47627
---
Why does this remove some forwarding headers?
- David Faure
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115024/#review47628
---
Ship it!
Windows says Ctrl Alt too, so this seems correct to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115024/
---
(Updated Jan. 18, 2014, 9:40 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099/
---
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
KF5DocToolsMacros.cmake, lines 166-172
https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166
These should *not* be renamed, as they are compatibility macros.
However, they should probably be moved to
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
KF5DocToolsMacros.cmake, lines 166-172
https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166
These should *not* be renamed, as they are compatibility macros.
However, they should probably be moved to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115077/
---
(Updated Jan. 18, 2014, 1:16 p.m.)
Review request for Documentation, KDE
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
KF5DocToolsMacros.cmake, lines 166-172
https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166
These should *not* be renamed, as they are compatibility macros.
However, they should probably be moved to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099/#review47642
---
modules/ECMGeneratePriFile.cmake
On Jan. 18, 2014, 8:58 a.m., David Faure wrote:
Why does this remove some forwarding headers?
Because they are installed from the KParts module itself already, with the same
forwarding include path. So no need to duplicate them in KDE4Support, or?
(Only difference is those from KParts have
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115100/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/
---
Review request for KDE Frameworks, Albert Astals Cid and Aurélien Gâteau.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/
---
(Updated Jan. 18, 2014, 5:47 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115100/
---
(Updated Jan. 18, 2014, 5:48 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115100/
---
(Updated Jan. 18, 2014, 5:49 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/
---
(Updated Jan. 18, 2014, 6:13 p.m.)
Review request for KDE Frameworks,
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote:
this would break my workflow given that I install kde4 and kf5 to different
prefixes. I think this needs a different approach, but please don't ask me
for it. I'm lacking ideas how we could solve this upstream.
What about just renaming
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
KF5DocToolsMacros.cmake, lines 166-172
https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166
These should *not* be renamed, as they are compatibility macros.
However, they should probably be moved to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/#review47655
---
Hm, how does KMessageWidget behave, if you post the next
On Jan. 18, 2014, 7:46 p.m., Christoph Feck wrote:
Hm, how does KMessageWidget behave, if you post the next message without
waiting for the animation to finish? I somehow feel that the queuing should
be done inside KMessageWidget.
KMessageWidget has no post function at all. It is just
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/#review47660
---
The patch looks ago, I have two remarks:
- I think that
22 matches
Mail list logo
