Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-03-01 Thread David Faure
On Feb. 26, 2014, 9:12 a.m., David Gil Oliva wrote: src/kdecore/kurl.h, line 386 https://git.reviewboard.kde.org/r/116064/diff/1/?file=246155#file246155line386 I would say: @deprecated since 5.0, use Foo instead. Alex Merry wrote: I'm not sure how

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-03-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116064/#review51412 --- src/kdecore/kurl.h

Re: KDNSSD merge

2014-03-01 Thread David Faure
On Tuesday 25 February 2014 20:37:28 Alex Merry wrote: I've had a look at the kdnssd repositoy, and it contains two related bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify KIO about changes to available services. These two obviously belong together; the question is

Re: KDNSSD merge

2014-03-01 Thread David Faure
On Wednesday 26 February 2014 14:36:49 Nicolas Lécureuil wrote: Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : On 26/02/14 10:01, Alex Merry wrote: Actually, having slept on it, my suggestion is: - rename kdnssd to zeroconf-ioslave - rename kdnssd-framework to kdnssd

Re: Review Request 116124: Always compile static lib with -fPIC

2014-03-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116124/#review51413 --- Ship it! Looks correct. - David Faure On Feb. 27, 2014,

Re: KDNSSD merge

2014-03-01 Thread Alex Merry
On 01/03/14 09:55, David Faure wrote: On Tuesday 25 February 2014 20:37:28 Alex Merry wrote: I've had a look at the kdnssd repositoy, and it contains two related bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify KIO about changes to available services. These two

Re: KDNSSD merge

2014-03-01 Thread Alex Merry
On 01/03/14 09:57, David Faure wrote: On Wednesday 26 February 2014 14:36:49 Nicolas Lécureuil wrote: as there is already a kdnssd tarball for kde 4, i think this would be safer to keep the -framework in the name. I can't see how the name of the kde-sc-4 tarballs matter? This is version 5

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #95

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kde4support_master_qt5 #71

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kde4support_master_qt5/71/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116098: Use KDEInstallDirs

2014-03-01 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- (Updated March 1, 2014, 11:14 a.m.) Review request for KDE Frameworks,

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51415 --- The implementation all looks fine. The only concern I have

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #96

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/96/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : plasma-framework_master_qt5 » NoX11,LINBUILDER #96

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/96/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread David Faure
On March 1, 2014, 11:15 a.m., Alex Merry wrote: The implementation all looks fine. The only concern I have is that it's an odd location for it; I wouldn't expect to go looking for a method to invoke Help in KConfigWidgets. Although I'm not sure where it would go instead, given the

Jenkins build became unstable: kimageformats_master_qt5 #34

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kimageformats_master_qt5/34/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kjsembed_master_qt5 #27

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kjsembed_master_qt5/27/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-03-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116064/ --- (Updated March 1, 2014, 12:13 p.m.) Status -- This change has been

Build failed in Jenkins: kio_master_qt5 #87

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/87/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51426 --- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 11 a.m.,

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
On March 1, 2014, 11:15 a.m., Alex Merry wrote: The implementation all looks fine. The only concern I have is that it's an odd location for it; I wouldn't expect to go looking for a method to invoke Help in KConfigWidgets. Although I'm not sure where it would go instead, given the

Re: Review Request 116098: Use KDEInstallDirs

2014-03-01 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51427 --- CMakeLists.txt

Jenkins build is back to normal : kservice_master_qt5 #58

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kservice_master_qt5/58/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Kevin Krammer
On Saturday, 2014-03-01, 13:19:23, David Faure wrote: On Saturday 01 March 2014 12:12:37 KDE CI System wrote: CMake Error at CMakeLists.txt:30 (find_package): Could not find a configuration file for package KF5DocTools that is compatible with requested version 4.97.0. The

Jenkins build is back to normal : kemoticons_master_qt5 #28

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kemoticons_master_qt5/28/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread David Faure
On Saturday 01 March 2014 13:37:31 Kevin Krammer wrote: On Saturday, 2014-03-01, 13:19:23, David Faure wrote: On Saturday 01 March 2014 12:12:37 KDE CI System wrote: CMake Error at CMakeLists.txt:30 (find_package): Could not find a configuration file for package KF5DocTools that is

Build failed in Jenkins: kbookmarks_master_qt5 #32

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kbookmarks_master_qt5/32/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Build failed in Jenkins: kcmutils_master_qt5 #24

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kcmutils_master_qt5/24/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Kevin Krammer
On Saturday, 2014-03-01, 15:37:05, David Faure wrote: On Saturday 01 March 2014 13:37:31 Kevin Krammer wrote: On Saturday, 2014-03-01, 13:19:23, David Faure wrote: On Saturday 01 March 2014 12:12:37 KDE CI System wrote: CMake Error at CMakeLists.txt:30 (find_package): Could not

Jenkins build is back to normal : kjsembed_master_qt5 #28

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kjsembed_master_qt5/28/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktextwidgets_master_qt5 #30

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/ktextwidgets_master_qt5/30/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread David Faure
On Saturday 01 March 2014 15:37:05 David Faure wrote: I'll change the tier in kjsembed to 2. I meant 3 of course. Done. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel

Build failed in Jenkins: kxmlgui_master_qt5 #63

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kxmlgui_master_qt5/63/ -- Started by user dfaure Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/kxmlgui_master_qt5/ws/ Running Prebuild steps [kxmlgui_master_qt5] $ /bin/sh -xe

Jenkins build is back to normal : ktextwidgets_master_qt5 #31

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/ktextwidgets_master_qt5/31/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kxmlgui_master_qt5 #64

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kxmlgui_master_qt5/64/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Binary incompatible changes

2014-03-01 Thread David Faure
On Friday 28 February 2014 20:49:34 Ben Cooksley wrote: I suggest that any further BC or SC changes be rolled out more carefully, with pushes being separated by sufficient time for the CI system to complete builds of earlier modules. I just tried to do that, with the KF5 version number

Re: Review Request 116030: Extend tests to cover getConf... calls

2014-03-01 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/#review51435 --- I'm wondering why create the test config on the fly, and not

Jenkins build is back to normal : kcmutils_master_qt5 #25

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kcmutils_master_qt5/25/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kbookmarks_master_qt5 #33

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kbookmarks_master_qt5/33/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Binary incompatible changes

2014-03-01 Thread David Faure
On Saturday 01 March 2014 16:03:52 David Faure wrote: So yeah, it's doable, but quite painful. I wish we could script this, but wait for CI is hard to script... Oh, and if one doesn't have the rights for Build Now on build.kde.org, one cannot fix things after messing up the push order.

Jenkins build is back to normal : kio_master_qt5 #88

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/88/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdewebkit_master_qt5 #25

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kdewebkit_master_qt5/25/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: khtml_master_qt5 #50

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/khtml_master_qt5/50/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Jenkins build is back to normal : kdewebkit_master_qt5 #26

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kdewebkit_master_qt5/26/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : khtml_master_qt5 #51

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/khtml_master_qt5/51/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Binary incompatible changes

2014-03-01 Thread Albert Astals Cid
El Dissabte, 1 de març de 2014, a les 16:06:24, David Faure va escriure: On Saturday 01 March 2014 16:03:52 David Faure wrote: So yeah, it's doable, but quite painful. I wish we could script this, but wait for CI is hard to script... Oh, and if one doesn't have the rights for Build Now on

Build failed in Jenkins: kde4support_master_qt5 #73

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kde4support_master_qt5/73/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #97

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/97/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by upstream project plasma-framework_master_qt5 build number 97 originally

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #97

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/97/changes Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by upstream project plasma-framework_master_qt5 build number 97 originally

Re: qt5 polkit-qt-1 and kdesrc-build

2014-03-01 Thread David Faure
On Wednesday 26 February 2014 22:25:01 Milian Wolff wrote: module-set repository kde-projects branch qt5 use-modules polkit-qt-1 cmake-options -DCMAKE_BUILD_TYPE:STRING=debug end module-set Considering that all other people should hit the same issue - how did you resolve

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #98

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/98/ -- Started by upstream project plasma-framework_master_qt5 build number 98 originally caused by: Started by user dfaure Building remotely on LinuxSlave - 4 in

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #98

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/98/ -- Started by upstream project plasma-framework_master_qt5 build number 98 originally caused by: Started by user dfaure Building remotely on LinuxSlave - 1 in

Re: Build failed in Jenkins: plasma-framework_master_qt5 » NoX11, LINBUILDER #97

2014-03-01 Thread David Faure
On Saturday 01 March 2014 15:41:26 KDE CI System wrote: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/kdelibs/kactivities/in st/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake, version: 4.96.0 Urgh, kactivities didn't get rebuilt after I pushed to it. -- David Faure,

Re: Binary incompatible changes

2014-03-01 Thread David Faure
On Saturday 01 March 2014 16:39:56 Albert Astals Cid wrote: Every time someone commits to okular, which may a bit too much, no? This is not what I suggested. I suggested: if A and B are both marked as dirty because a commit was just pushed to them, then look at whether one depends on the

Re: Binary incompatible changes

2014-03-01 Thread Albert Astals Cid
El Dissabte, 1 de març de 2014, a les 16:53:28, David Faure va escriure: On Saturday 01 March 2014 16:39:56 Albert Astals Cid wrote: Every time someone commits to okular, which may a bit too much, no? This is not what I suggested. I suggested: if A and B are both marked as dirty because a

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review51440 --- Hmm, this might be equivalent, but all it means is that the

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #99

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/99/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #99

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/99/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: qt5 polkit-qt-1 and kdesrc-build

2014-03-01 Thread Milian Wolff
On Saturday 01 March 2014 16:42:31 David Faure wrote: On Wednesday 26 February 2014 22:25:01 Milian Wolff wrote: module-set repository kde-projects branch qt5 use-modules polkit-qt-1 cmake-options -DCMAKE_BUILD_TYPE:STRING=debug end module-set Considering

Cannot build with ccache clang - cmake issue?

2014-03-01 Thread Milian Wolff
Hey all, is anyone else using ccache in combination with clang to build KF5? A few days ago it worked for me, so maybe something in cmake git broke (we do use cmake git for KF5, right?). In order to use ccache with clang, I export the following: export CXX=ccache /usr/bin/clang++

Re: Review Request 116030: Extend tests to cover getConf... calls

2014-03-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/#review51451 --- This review has been submitted with commit

Re: Review Request 116030: Extend tests to cover getConf... calls

2014-03-01 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- (Updated March 1, 2014, 5:54 p.m.) Status -- This change has been

Re: Cannot build with ccache clang - cmake issue?

2014-03-01 Thread David Faure
On Saturday 01 March 2014 18:43:32 Milian Wolff wrote: Can someone tell me how to configure CMake git to use clang ccache in another way? Not sure this list will be able to help you. I would suggest at least kde- buildsystem, if not cmake-developers. It's not a KF5 problem. -- David Faure,

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Aurélien Gâteau
On Sat, Mar 1, 2014, at 6:37, David Faure wrote: On Saturday 01 March 2014 13:37:31 Kevin Krammer wrote: On Saturday, 2014-03-01, 13:19:23, David Faure wrote: On Saturday 01 March 2014 12:12:37 KDE CI System wrote: CMake Error at CMakeLists.txt:30 (find_package): Could not find a

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread David Faure
On Saturday 01 March 2014 12:49:02 Aurélien Gâteau wrote: On Sat, Mar 1, 2014, at 6:37, David Faure wrote: On Saturday 01 March 2014 13:37:31 Kevin Krammer wrote: On Saturday, 2014-03-01, 13:19:23, David Faure wrote: On Saturday 01 March 2014 12:12:37 KDE CI System wrote: CMake

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Luigi Toscano
David Faure wrote: On Saturday 01 March 2014 12:49:02 Aurélien Gâteau wrote: If I am not mistaken, KJSEmbed depends on KDocTools because it uses kdoctools_create_manpage. Would it be an option to generate the man page without KDocTools. It's a bit sad to bump it from tier 2 to tier 3 just

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread David Faure
On Saturday 01 March 2014 22:36:24 tsdg...@yahoo.es wrote: The script solution has a big problem with l10n, so let's not go there please. I don't understand this. While compiling kjsembed, the translations are not available, are they? I fail to see the difference between converting docbook to

Jenkins build became unstable: kdelibs_stable #1026

2014-03-01 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/1026/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel