Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52619 --- Ship it! I can reproduce the failure on ktexteditor with cmake 2.8.12.2. The patch fixes it, thanks! - Aurélien Gâteau On March 10, 2014, 3 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/ --- (Updated March 10, 2014, 3 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- execute_process won't translate the generation expression into a path, so it refuses to work. In this case using get_property(... LOCATION) it's fine because it's only used as an imported target. Diffs - KF5ServiceMacros.cmake fd835bd Diff: https://git.reviewboard.kde.org/r/116696/diff/ Testing --- Now I can build frameworks that use kservice_desktop_to_json. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Documentation policy moved to community.kde.org
Hi, As was discussed a few weeks ago, I moved the Frameworks Documentation Policy from techbase.kde.org to community.kde.org. You can find it here: https://community.kde.org/Frameworks/Frameworks_Documentation_Policy It is basically a slightly refreshed version of the KDE4 kdelibs policy, with framework-specific additions like README.md and $framework.yaml. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/ --- (Updated March 11, 2014, 10 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- execute_process won't translate the generation expression into a path, so it refuses to work. In this case using get_property(... LOCATION) it's fine because it's only used as an imported target. Diffs - KF5ServiceMacros.cmake fd835bd Diff: https://git.reviewboard.kde.org/r/116696/diff/ Testing --- Now I can build frameworks that use kservice_desktop_to_json. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52624 --- This review has been submitted with commit 8be89cb18293fce57b0e1e6ec7d639c9b42f0c29 by Aleix Pol to branch master. - Commit Hook On March 10, 2014, 2 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/ --- (Updated March 10, 2014, 2 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- execute_process won't translate the generation expression into a path, so it refuses to work. In this case using get_property(... LOCATION) it's fine because it's only used as an imported target. Diffs - KF5ServiceMacros.cmake fd835bd Diff: https://git.reviewboard.kde.org/r/116696/diff/ Testing --- Now I can build frameworks that use kservice_desktop_to_json. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/ --- (Updated March 11, 2014, 11:05 a.m.) Review request for Build System and KDE Frameworks. Changes --- Don't center the replace on /. Actually only allow alphanumeric characters on the target name and replace the rest with -. This should be more flexible. Repository: kdoctools Description --- While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename). I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something? Diffs (updated) - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116025: Add documentation about writing find modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated March 11, 2014, 11:41 a.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add documentation about writing find modules Diffs - README.md 85b97b7fa003282e1eeb1113c4668a9b73e3f731 docs/writing-find-modules.md PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116025/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116653: Create ECMFindModuleHelpers module for common find-module code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116653/ --- (Updated March 11, 2014, 12:32 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Changes --- Update writing-find-modules.md Change module_component_deps var to module_component_component_deps, leaving space for other potential dep types in future (such as target deps). Repository: extra-cmake-modules Description --- Create ECMFindModuleHelpers module for common find-module code This currently mostly contains macros for handling components; FindWayland and FindXCB are ported to use this module, which comes with various improvements for them. Diffs (updated) - docs/writing-find-modules.md 4f6a9cd68959e51b0c26a18c4c9d0633dd9f1c76 find-modules/FindWayland.cmake a121de9f8adda1e035b0f8e8401be26a45b61af4 find-modules/FindXCB.cmake eb3075885bc408fc4c213516a387dfcd0e75cb8b modules/ECMFindModuleHelpers.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116653/diff/ Testing --- Tested various configurations with a test CMakeLists.txt file, including with various include files missing. Configured and built kwindowsystem and kde-workspace. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kglobalaccel fixes
A quick heads-up: I'm looking into what's broken in our global shortcuts. Here's a quick run-down of my findings so far: kglobalaccel has some brokenness in it. It used to poke into the privates of KGlobalShortcutInfo in order to create its own object in a cast. This code is disabled right now since the kglobalaccel (from kde-runtime) can't see the privates of KGlobalShortcutInfo (in frameworks/kglobalaccel). This is a porting problem which can be worked around by copying the header in. I think that's fine as a solution right now, since it will go away again quickly, once kde-runtime is split up. This makes exporting shortcut info from kglobalaccel work for me. Editing shortcuts also has problems. We introduced a new parameter there, actionType, which tells whether the shortcut is an application shortcut, a widget shortcut, a global shortcut, and so on. Now there's one role in the model which doesn't know about this new API, and that's the role that allows to edit the shortcut -- the result: global shortcuts can't be edited. I have a patch fixing that, but need to test it a bit better. With that in place, I could add a global shortcut to kwin to trigger the desktop grid effect -- hooray! There's a bunch of other bugs in there, connected to storing and loading shortcuts which I'm also looking into. One thing is a bit puzzling, perhaps someone knows how to go about this: The meta key behaves different now, when I edit a shortcut, it's accepted as soon as I press the meta key, so it's not seen as a modifier, but as a key of its own. This means that one can effectively (through the GUI) only assign meta to an action, but not, for example meta+arrow_left. Any ideas how to best fix this? More hacking ensues... -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116713: Remove FindOpenEXR.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- The file has moved to the extra-cmake-modules repository. Diffs - CMakeLists.txt a667ed8 cmake/FindOpenEXR.cmake 00a2364 Diff: https://git.reviewboard.kde.org/r/116713/diff/ Testing --- Rebuilt from scratch, still finds the openexr library. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116713: Remove FindOpenEXR.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/#review52640 --- Ship it! Ship It! - Alex Merry On March 11, 2014, 1:55 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/ --- (Updated March 11, 2014, 1:55 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- The file has moved to the extra-cmake-modules repository. Diffs - CMakeLists.txt a667ed8 cmake/FindOpenEXR.cmake 00a2364 Diff: https://git.reviewboard.kde.org/r/116713/diff/ Testing --- Rebuilt from scratch, still finds the openexr library. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116713: Remove FindOpenEXR.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/#review52641 --- This review has been submitted with commit 2ded57d50ec0de3e972bf77f3427d03f75f746f6 by Aurélien Gâteau to branch master. - Commit Hook On March 11, 2014, 1:55 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/ --- (Updated March 11, 2014, 1:55 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- The file has moved to the extra-cmake-modules repository. Diffs - CMakeLists.txt a667ed8 cmake/FindOpenEXR.cmake 00a2364 Diff: https://git.reviewboard.kde.org/r/116713/diff/ Testing --- Rebuilt from scratch, still finds the openexr library. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116713: Remove FindOpenEXR.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/ --- (Updated March 11, 2014, 2:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- The file has moved to the extra-cmake-modules repository. Diffs - CMakeLists.txt a667ed8 cmake/FindOpenEXR.cmake 00a2364 Diff: https://git.reviewboard.kde.org/r/116713/diff/ Testing --- Rebuilt from scratch, still finds the openexr library. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Should we kill the broken Class Members links on api.kde.org?
Hi, All pages on api.kde.org have a sidebar with a few links in there. One of them is Class Members. If you look at it, you might be surprised to learn we only have methods which starts with an 'a' :) Example: http://api.kde.org/frameworks-api/frameworks5-apidocs/kconfig/html/functions.html This is because Doxygen normally adds to the top of the page links to go to methods starting with the other letters, but our custom templates do not. This is fixable, but I am wondering if it is worth the effort. Would you use this way to go through the API or should we simply remove Class Members from the sidebar? Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Should we kill the broken Class Members links on api.kde.org?
Hello, On Tuesday 11 March 2014 07:24:51 Aurélien Gâteau wrote: All pages on api.kde.org have a sidebar with a few links in there. One of them is Class Members. If you look at it, you might be surprised to learn we only have methods which starts with an 'a' :) Example: http://api.kde.org/frameworks-api/frameworks5-apidocs/kconfig/html/functions .html This is because Doxygen normally adds to the top of the page links to go to methods starting with the other letters, but our custom templates do not. This is fixable, but I am wondering if it is worth the effort. Would you use this way to go through the API or should we simply remove Class Members from the sidebar? I don't think I'd use that... I don't think I ever used it in fact. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2014-w11
Hello everyone, This is the minutes of the Week 10 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, dfaure, mgraesslin, notmart, sebas, teo, tosky and myself. Announcement: * Beta 1 will be tagged on March 28 instead of April 1st as planned earlier; * Two tasks up for adoption on http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation * Please nail them down before they turn into release blockers! * afiestas has been fixing things around; * he's also working with apol on the kde-runtime split; * agateau has been doing mainly build fixes downstream; * he's also been working on some of the cmake files and on api.kde.org; * he then fixed a bug in Doxygen waiting for review; * last but not least he moved the doc policy to community.kde.org; * alexmerry is waiting for the maintainers of kdnssd before proceeding with the rename, timeout on friday; * he's also tracking bugs in kimageformats showing up on non-x86_64 architectures; * he also proposed ECMFindModuleHelpers macros for ECM and investigates on how to generate docs; * dfaure is optimizing KConfig to minimize reparsing; * he also plans to improve the KUrl - QUrl porting scripts; * mgraesslin has two open review requests for KWindowSystem which will be merged after Plasma Next Alpha tagging; * notmart is also waiting for Plasma Next Alpha tagging to move QML imports in their respective frameworks; * sebas is working on kglobalaccel; * he also has a pending patch to make oxygen the default font; * teo ported kwalletmanager to KF5; * he still has to port away from kde4support; * tosky is fixing the fallout of doctools version bump; * he still has one pending review, still open because it waits on windows or mac savvy people feedback: https://git.reviewboard.kde.org/r/116670/ ; * he also plans to remove all htdig references from kdoctools and khelpcenter; * ervin has been in review frenzy mode; If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116723: Update cmake code in apidox to reflect new macro names
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/ --- Review request for KDE Frameworks. Repository: kauth Description --- These are based on the commit Reformat apidocs to be manageable, which just adjusts the line breaks of the apidocs without changing the content. Update cmake code in apidox to reflect new macro names Fix doxygen warnings about not being able to resolve link requests Diffs - README.md 0cc38fd90cd1a83bae754cf9724fc0c998d42075 src/kauthactionreply.h d1fefc0243ba62d1447eecfa3c9f0cd7846a04fa Diff: https://git.reviewboard.kde.org/r/116723/diff/ Testing --- Regenerated apidocs. Only warnings are for undocumented members. Docs seem correct by visual inspection. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116723: Update cmake code in apidox to reflect new macro names
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/#review52653 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 11, 2014, 4:10 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/ --- (Updated March 11, 2014, 4:10 p.m.) Review request for KDE Frameworks. Repository: kauth Description --- These are based on the commit Reformat apidocs to be manageable, which just adjusts the line breaks of the apidocs without changing the content. Update cmake code in apidox to reflect new macro names Fix doxygen warnings about not being able to resolve link requests Diffs - README.md 0cc38fd90cd1a83bae754cf9724fc0c998d42075 src/kauthactionreply.h d1fefc0243ba62d1447eecfa3c9f0cd7846a04fa Diff: https://git.reviewboard.kde.org/r/116723/diff/ Testing --- Regenerated apidocs. Only warnings are for undocumented members. Docs seem correct by visual inspection. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116723: Update cmake code in apidox to reflect new macro names
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/#review52656 --- This review has been submitted with commit 3af18449fd880fd9a8b9e2251c0d8cddeecd0930 by Alex Merry to branch master. - Commit Hook On March 11, 2014, 4:10 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/ --- (Updated March 11, 2014, 4:10 p.m.) Review request for KDE Frameworks. Repository: kauth Description --- These are based on the commit Reformat apidocs to be manageable, which just adjusts the line breaks of the apidocs without changing the content. Update cmake code in apidox to reflect new macro names Fix doxygen warnings about not being able to resolve link requests Diffs - README.md 0cc38fd90cd1a83bae754cf9724fc0c998d42075 src/kauthactionreply.h d1fefc0243ba62d1447eecfa3c9f0cd7846a04fa Diff: https://git.reviewboard.kde.org/r/116723/diff/ Testing --- Regenerated apidocs. Only warnings are for undocumented members. Docs seem correct by visual inspection. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116723: Update cmake code in apidox to reflect new macro names
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/#review52655 --- This review has been submitted with commit e0f7c5b06da59ceedc22a840ee52d13152634fd0 by Alex Merry to branch master. - Commit Hook On March 11, 2014, 4:10 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116723/ --- (Updated March 11, 2014, 4:10 p.m.) Review request for KDE Frameworks. Repository: kauth Description --- These are based on the commit Reformat apidocs to be manageable, which just adjusts the line breaks of the apidocs without changing the content. Update cmake code in apidox to reflect new macro names Fix doxygen warnings about not being able to resolve link requests Diffs - README.md 0cc38fd90cd1a83bae754cf9724fc0c998d42075 src/kauthactionreply.h d1fefc0243ba62d1447eecfa3c9f0cd7846a04fa Diff: https://git.reviewboard.kde.org/r/116723/diff/ Testing --- Regenerated apidocs. Only warnings are for undocumented members. Docs seem correct by visual inspection. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116724: Replace comment that refers to removed code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116724/ --- Review request for KDE Frameworks. Repository: kdeclarative Description --- Replace comment that refers to removed code Diffs - src/kdeclarative.cpp c074efb89a35f22cdc1ae7823749555623957755 Diff: https://git.reviewboard.kde.org/r/116724/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116725: Remove out-of-date README
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116725/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Description --- Remove out-of-date README All the information that is still applicable can be found in README.md. Diffs - src/README cbf079488d9961a718201373fd4bb3483b2f3bf8 Diff: https://git.reviewboard.kde.org/r/116725/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116726: Remove unused CMakeLists.txt file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116726/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Remove unused CMakeLists.txt file Diffs - tests/pics/CMakeLists.txt 3d2f8d5286205336f1ea6f31714c226b0d7a142f Diff: https://git.reviewboard.kde.org/r/116726/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116727: Remove obsolete code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116727/ --- Review request for KDE Frameworks. Repository: kinit Description --- Remove obsolete code This code had #if 0 around it through all of KDE 4, so it clearly wasn't that important. Diffs - src/kdeinit/kinit.cpp c1010dd7f8980ae8b4b456a41d9094a16aca62a6 Diff: https://git.reviewboard.kde.org/r/116727/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116728: Remove no-longer-needed magic variable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116728/ --- Review request for KDE Frameworks. Repository: kjs Description --- Remove no-longer-needed magic variable The manifest stuff is all gone for now, and won't return in the same form, so remove the variable with the special name and the comment about it. Diffs - src/kjs/CMakeLists.txt 491cf52ea7d3d8a6b138fb328fdfdeec61f6740a Diff: https://git.reviewboard.kde.org/r/116728/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116732: Use the new uic macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description --- Use the new uic macro This got missed because the line is never called currently (due to a lack of a ported QGpgMe). Diffs - tests/kwalletd/CMakeLists.txt 65e75234b1d52e519d34a47bb14521d3b1ed6482 Diff: https://git.reviewboard.kde.org/r/116732/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116732: Use the new uic macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/#review52663 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 11, 2014, 5:20 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/ --- (Updated March 11, 2014, 5:20 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description --- Use the new uic macro This got missed because the line is never called currently (due to a lack of a ported QGpgMe). Diffs - tests/kwalletd/CMakeLists.txt 65e75234b1d52e519d34a47bb14521d3b1ed6482 Diff: https://git.reviewboard.kde.org/r/116732/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116732: Use the new uic macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/#review52666 --- This review has been submitted with commit 431e9f57932bfb3fc42fbcdfbd17e1aec3cc76d3 by Alex Merry to branch master. - Commit Hook On March 11, 2014, 5:20 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/ --- (Updated March 11, 2014, 5:20 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description --- Use the new uic macro This got missed because the line is never called currently (due to a lack of a ported QGpgMe). Diffs - tests/kwalletd/CMakeLists.txt 65e75234b1d52e519d34a47bb14521d3b1ed6482 Diff: https://git.reviewboard.kde.org/r/116732/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116732: Use the new uic macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116732/ --- (Updated March 11, 2014, 5:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description --- Use the new uic macro This got missed because the line is never called currently (due to a lack of a ported QGpgMe). Diffs - tests/kwalletd/CMakeLists.txt 65e75234b1d52e519d34a47bb14521d3b1ed6482 Diff: https://git.reviewboard.kde.org/r/116732/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/#review52671 --- Ship it! Would it make sense to support both kde and kde4 names (if that's even possible)? - Christoph Feck On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 5 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116739: Update commented-out cmake code to new macros
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116739/ --- Review request for KDE Frameworks. Repository: solid Description --- Update commented-out cmake code to new macros This test is also disabled in kdelibs4; it appears to use a non-existant mock D-Bus service. At least this way the CMake code is ready to be re-enabled if and when the test is fixed up. Diffs - tests/CMakeLists.txt 59337085e005c9ad93f490e269dfcdcae8628d78 Diff: https://git.reviewboard.kde.org/r/116739/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116740: Fix kdeglobals location in apidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116740/ --- Review request for KDE Frameworks. Repository: kxmlgui Description --- Fix kdeglobals location in apidox Diffs - src/kcheckaccelerators.h 7ce96430b584543bf853a0595db93c1a0a569e59 Diff: https://git.reviewboard.kde.org/r/116740/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
On March 11, 2014, 7:21 p.m., Christoph Feck wrote: Would it make sense to support both kde and kde4 names (if that's even possible)? It should be possible to support them, yes. I would suggest application/x-kio-urilist, though, since that property is really for KIO URIs. Of course, that means duplicating the mime data all the time; the question is whether it is worth it. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/#review52671 --- On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 5 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/#review52673 --- This review has been submitted with commit a148143b772333d71b338e56b0d030b737ab74a8 by Alex Merry to branch master. - Commit Hook On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 5 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 7:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/#review52690 --- Ship it! Perfect, thanks! - Luigi Toscano On March 11, 2014, 12:05 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/ --- (Updated March 11, 2014, 12:05 p.m.) Review request for Build System and KDE Frameworks. Repository: kdoctools Description --- While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename). I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something? Diffs - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w11
Hi! 2014-03-11 16:33 GMT+01:00 Kevin Ottens er...@kde.org: Hello everyone, This is the minutes of the Week 10 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, dfaure, mgraesslin, notmart, sebas, teo, tosky and myself. Announcement: * Beta 1 will be tagged on March 28 instead of April 1st as planned earlier; Why is that? Are we in a hurry? Is the work in all the frameworks so advanced that we can advance the tagging? BTW, is it allowed to deprecate methods and add new methods from beta1 on? (please forgive my ignorance, I didn't find out what SIC change means). And, again BTW, the date here isn't updated: http://community.kde.org/Frameworks/Epics Cheers, David Gil * Two tasks up for adoption on http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation * Please nail them down before they turn into release blockers! * afiestas has been fixing things around; * he's also working with apol on the kde-runtime split; * agateau has been doing mainly build fixes downstream; * he's also been working on some of the cmake files and on api.kde.org; * he then fixed a bug in Doxygen waiting for review; * last but not least he moved the doc policy to community.kde.org; * alexmerry is waiting for the maintainers of kdnssd before proceeding with the rename, timeout on friday; * he's also tracking bugs in kimageformats showing up on non-x86_64 architectures; * he also proposed ECMFindModuleHelpers macros for ECM and investigates on how to generate docs; * dfaure is optimizing KConfig to minimize reparsing; * he also plans to improve the KUrl - QUrl porting scripts; * mgraesslin has two open review requests for KWindowSystem which will be merged after Plasma Next Alpha tagging; * notmart is also waiting for Plasma Next Alpha tagging to move QML imports in their respective frameworks; * sebas is working on kglobalaccel; * he also has a pending patch to make oxygen the default font; * teo ported kwalletmanager to KF5; * he still has to port away from kde4support; * tosky is fixing the fallout of doctools version bump; * he still has one pending review, still open because it waits on windows or mac savvy people feedback: https://git.reviewboard.kde.org/r/116670/ ; * he also plans to remove all htdig references from kdoctools and khelpcenter; * ervin has been in review frenzy mode; If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w11
On Tue, Mar 11, 2014 at 10:19 PM, David Gil Oliva davidgilol...@gmail.comwrote: Announcement: * Beta 1 will be tagged on March 28 instead of April 1st as planned earlier; Why is that? Are we in a hurry? Is the work in all the frameworks so advanced that we can advance the tagging? It's because David Faure, who will do the packages, is travelling on April 1 iirc, so it was moved before his travels. The actual release date should still be April 1st afaik. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116747: Clean up KCompletionBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Clean up KCompletionBox -canceled() - cancelled (private method) -Deprecate sizeAndPosition() -- resizeAndReposition() -Remove old comments and commented-out code -Move some slots to be normal methods, since they don't seem to be able to work as slots. Diffs - src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w11
El 11/03/2014 22:58, Martin Klapetek martin.klape...@gmail.com escribió: On Tue, Mar 11, 2014 at 10:19 PM, David Gil Oliva davidgilol...@gmail.com wrote: Announcement: * Beta 1 will be tagged on March 28 instead of April 1st as planned earlier; Why is that? Are we in a hurry? Is the work in all the frameworks so advanced that we can advance the tagging? It's because David Faure, who will do the packages, is travelling on April 1 iirc, so it was moved before his travels. The actual release date should still be April 1st afaik. Thanks! Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116740: Fix kdeglobals location in apidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116740/#review52701 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 11, 2014, 7:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116740/ --- (Updated March 11, 2014, 7:46 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Fix kdeglobals location in apidox Diffs - src/kcheckaccelerators.h 7ce96430b584543bf853a0595db93c1a0a569e59 Diff: https://git.reviewboard.kde.org/r/116740/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/ --- (Updated March 11, 2014, 11:14 p.m.) Status -- This change has been marked as submitted. Review request for Build System and KDE Frameworks. Repository: kdoctools Description --- While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename). I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something? Diffs - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/#review52702 --- This review has been submitted with commit 8aad0fb7aaa3bbb9da8801d2d12f3396f74569d5 by Aleix Pol to branch master. - Commit Hook On March 11, 2014, 11:05 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/ --- (Updated March 11, 2014, 11:05 a.m.) Review request for Build System and KDE Frameworks. Repository: kdoctools Description --- While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename). I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something? Diffs - KF5DocToolsMacros.cmake 6567b67 Diff: https://git.reviewboard.kde.org/r/116650/diff/ Testing --- Now kde-runtime documentation builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116747: Clean up KCompletionBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52703 --- src/kcompletionbox.h https://git.reviewboard.kde.org/r/116747/#comment37176 I wouldn't leave the implementation here. Move it to the .cpp file, this way it can be changed in the future, if it's required for some reason. Also there's a typo in the method name. Have you looked through the uses of the un-slotted methods? (lxr.kde.org). Maybe there's a reason for that... :/ - Aleix Pol Gonzalez On March 11, 2014, 10:32 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 11, 2014, 10:32 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Clean up KCompletionBox -canceled() - cancelled (private method) -Deprecate sizeAndPosition() -- resizeAndReposition() -Remove old comments and commented-out code -Move some slots to be normal methods, since they don't seem to be able to work as slots. Diffs - src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
