Re: Review Request 117695: change where dynamic replace tabs is performed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 8:49 a.m.) Review request for KDE Frameworks and Christoph Cullmann. Changes --- factor out the replace tabs functionality into a method. I was wrong btw, indent pasted text still works as intended. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs (updated) - src/document/katedocument.h 83cc0317e26ef077d5292763d0ba9864103bf454 src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Bugs: 332681 https://bugs.kde.org/show_bug.cgi?id=332681 Repository: kwindowsystem Description --- Fix crashers in KStartupInfo on remove while iterating This is similar to the change ... just for more cases. If the API was used with ::checkStartup it could happen that an item got removed from the startups while iterating the list of startups. Thus the data corrupted resulting in a crash when getting a similar crash. In this case the code now uses erase instead of remove to have a valid iterator. BUG: 332681 Diffs - autotests/kstartupinfo_unittest.cpp 29fa320bc2c82e7e04a7322111bcdba44b7078c6 src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117701/diff/ Testing --- See new unit tests which crash without the change. For people wanting to run the test: be warned it has the power to crash plasma-shell and kwin. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w17
On Tuesday 22 of April 2014 20:11:28 Nicolás Alvarez wrote: El martes, 22 de abril de 2014, Allen Winter win...@kde.org escribió: with Harald's help. Stuck in docbook hell at the moment (kdoctools/xslt.cpp says it can't find the customizations). Anyway, just thought I'd mention this. The same error happens on Windows. I have been commenting out add_subdirectory(docs) here and there to get things to build. So, this is an unresolved issue which depends on QStandardDirs. Here are few RR for Windows: https://git.reviewboard.kde.org/r/115210/ https://git.reviewboard.kde.org/r/117011/ It seems that, in both cases (Windows and MacOSX) QStandardDirs needs to be fixed to search also in some other common directories, or that the files are not installed in the place QStandardDirs expects it. The pending question is: which directory? I really need the help of domain experts here; I would really avoid to have final KF5.0 with docs removed. Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117695: change where dynamic replace tabs is performed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56264 --- src/document/katedocument.cpp https://git.reviewboard.kde.org/r/117695/#comment39333 Early-return? if (!replacetabs) return str; ... - Kevin Funk On April 23, 2014, 8:49 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 8:49 a.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs - src/document/katedocument.h 83cc0317e26ef077d5292763d0ba9864103bf454 src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117695: change where dynamic replace tabs is performed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 11:15 a.m.) Review request for KDE Frameworks and Christoph Cullmann. Changes --- Yes, makes sense. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs (updated) - src/document/katedocument.h 83cc0317e26ef077d5292763d0ba9864103bf454 src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117704: Deprecate obsolete KStartupInfo ctor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117704/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Deprecate obsolete KStartupInfo ctor Ctor had an @obsolete tag, so let's deprecate it to properly get rid of it with next ABI break. Diffs - autotests/kstartupinfo_unittest.cpp 29fa320bc2c82e7e04a7322111bcdba44b7078c6 src/kstartupinfo.h bcb7580b8588a4631ef8ff82671da0cf0158068e src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117704/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56269 --- src/kstartupinfo.cpp https://git.reviewboard.kde.org/r/117701/#comment39336 this function is so ugly that i wonder whether removal by value is actually required at all and in case it should try to find the iterator and use that in case of success - instead of the ugly ::operator[] ;-) src/kstartupinfo.cpp https://git.reviewboard.kde.org/r/117701/#comment39334 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go with a map pointer/reference to stress this (and as a matching map usage is required anyway) src/kstartupinfo.cpp https://git.reviewboard.kde.org/r/117701/#comment39335 ahhh... this one's the (semi-)obvious crasher =) (I had first only seen the other loops, which looked pretty harmless) Though i had assumed that the non-const iterator would have detached the list anyway. - Thomas Lübking On April 23, 2014, 9:35 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 23, 2014, 9:35 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Bugs: 332681 https://bugs.kde.org/show_bug.cgi?id=332681 Repository: kwindowsystem Description --- Fix crashers in KStartupInfo on remove while iterating This is similar to the change ... just for more cases. If the API was used with ::checkStartup it could happen that an item got removed from the startups while iterating the list of startups. Thus the data corrupted resulting in a crash when getting a similar crash. In this case the code now uses erase instead of remove to have a valid iterator. BUG: 332681 Diffs - autotests/kstartupinfo_unittest.cpp 29fa320bc2c82e7e04a7322111bcdba44b7078c6 src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117701/diff/ Testing --- See new unit tests which crash without the change. For people wanting to run the test: be warned it has the power to crash plasma-shell and kwin. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/ --- Review request for KDE Frameworks. Repository: kactivities Description --- to enable co-installability with kdelibs4 rename kactivitymanagerd to kactivitymanagerd5. also rename it in the .desktop file used to run the binary. Diffs - src/service/CMakeLists.txt 3436764 src/service/files/kactivitymanagerd.desktop 00ff557 Diff: https://git.reviewboard.kde.org/r/117705/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117706: remove unused kwallet upgrade script
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: kwallet Description --- Remove unused kwallet-4.13.upd from KDE Frameworks 5, it is needed for upgrades from 4.12 to 4.13 but KF5 installs have no previously set config settings. Diffs - src/runtime/kwalletd/CMakeLists.txt d9fb4b3 src/runtime/kwalletd/kwallet-4.13.upd beb51ba Diff: https://git.reviewboard.kde.org/r/117706/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
On April 23, 2014, 3:03 p.m., Thomas Lübking wrote: src/kstartupinfo.cpp, line 413 https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go with a map pointer/reference to stress this (and as a matching map usage is required anyway) my understand is that silent/unintended was dead code for these cases as it only iterated over the startups and that if it's in startups it's not in silent or unintended. I'll re-check that. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56269 --- On April 23, 2014, 11:35 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 23, 2014, 11:35 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Bugs: 332681 https://bugs.kde.org/show_bug.cgi?id=332681 Repository: kwindowsystem Description --- Fix crashers in KStartupInfo on remove while iterating This is similar to the change ... just for more cases. If the API was used with ::checkStartup it could happen that an item got removed from the startups while iterating the list of startups. Thus the data corrupted resulting in a crash when getting a similar crash. In this case the code now uses erase instead of remove to have a valid iterator. BUG: 332681 Diffs - autotests/kstartupinfo_unittest.cpp 29fa320bc2c82e7e04a7322111bcdba44b7078c6 src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117701/diff/ Testing --- See new unit tests which crash without the change. For people wanting to run the test: be warned it has the power to crash plasma-shell and kwin. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is QStandardPaths with QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I think %APPDATA%. KF5 based KDE software won't work otherwise since it can't find the data. I think the better way of fixing this is patching Qt, but for now this works. Patrick Spendrin wrote: Can you keep that patch locally for now and we try and come up with a patch for Qt instead? We cannot restrict ourselves at that point I think. Alexander Richardson wrote: Sure no problem. I'll drop this request David Faure wrote: So what do you recommend instead, for QStandardPaths? Checking some non-standard environment variable? or? Alexander Richardson wrote: I would go for the environment variable. Something like QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default dirs. Would also be useful for other cases: e.g. in the okteta unit tests I set XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there is QFINDTESTDATA, but that won't work in that case). It would also be nice if there were some cross-platform solution like QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString path) to inject (like KStandardDirs::addResourceDir). Patrick von Reth wrote: I don't like the idea of using the env var as this would require the user to setup the variables or a kde process to set them up. We also would get an undefined behaviour if the env var is not set. I think kde is not the only qt project ported to windows wich uses the bin/../share location on windows, so why not only add this path with a low priority to QStrandardpathes? David Faure wrote: I agree that the env var would be quite inconvenient, which is why I was dubious about that approach. A method to add paths wouldn't help either (how would all apps do it?) bin/../share means go up one level from the location of the executable and enter share? I thought Windows apps didn't use a bin/ dir actually, but were rather in the toplevel? Anyhow I'd be fine with that, especially if you can find any documentation of this outside of kde (to explain the reasoning in the Qt change request). Andrius da Costa Ribas wrote: As far as I can see: 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, $PREFIX/share etc... and PREFIX is not standard on windows (those apps normally don't use %PROGRAMFILES%) * Other autoconf-based apps and libs also follow this structure * even those using %PROGRAMFILES% also follow this structure (e.g. for GIMP 2, $PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside it) 2 - Most CMake-based apps also follow a similar pattern, relative to $CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a different directory structure * Cmake itself is distributed in this kind of structure (http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip) I think those can explain the reasoning needed for a Qt request. Yes, a single monolithic can somehow find out about its own PREFIX (e.g. by writing it into the registry at install time, right? Or indeed from the path where the .exe is being started, simply). But the issue here is what if you install several apps (and possibly several frameworks), and they need to find each other's stuff... - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/#review47983 --- On Jan. 22, 2014, 2:53 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/ --- (Updated Jan. 22, 2014, 2:53 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin. Repository: extra-cmake-modules Description --- Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows Otherwise QStandardPaths will always fail with e.g. GenericDataLocation Diffs - kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 Diff: https://git.reviewboard.kde.org/r/115210/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is QStandardPaths with QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I think %APPDATA%. KF5 based KDE software won't work otherwise since it can't find the data. I think the better way of fixing this is patching Qt, but for now this works. Patrick Spendrin wrote: Can you keep that patch locally for now and we try and come up with a patch for Qt instead? We cannot restrict ourselves at that point I think. Alexander Richardson wrote: Sure no problem. I'll drop this request David Faure wrote: So what do you recommend instead, for QStandardPaths? Checking some non-standard environment variable? or? Alexander Richardson wrote: I would go for the environment variable. Something like QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default dirs. Would also be useful for other cases: e.g. in the okteta unit tests I set XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there is QFINDTESTDATA, but that won't work in that case). It would also be nice if there were some cross-platform solution like QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString path) to inject (like KStandardDirs::addResourceDir). Patrick von Reth wrote: I don't like the idea of using the env var as this would require the user to setup the variables or a kde process to set them up. We also would get an undefined behaviour if the env var is not set. I think kde is not the only qt project ported to windows wich uses the bin/../share location on windows, so why not only add this path with a low priority to QStrandardpathes? David Faure wrote: I agree that the env var would be quite inconvenient, which is why I was dubious about that approach. A method to add paths wouldn't help either (how would all apps do it?) bin/../share means go up one level from the location of the executable and enter share? I thought Windows apps didn't use a bin/ dir actually, but were rather in the toplevel? Anyhow I'd be fine with that, especially if you can find any documentation of this outside of kde (to explain the reasoning in the Qt change request). Andrius da Costa Ribas wrote: As far as I can see: 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, $PREFIX/share etc... and PREFIX is not standard on windows (those apps normally don't use %PROGRAMFILES%) * Other autoconf-based apps and libs also follow this structure * even those using %PROGRAMFILES% also follow this structure (e.g. for GIMP 2, $PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside it) 2 - Most CMake-based apps also follow a similar pattern, relative to $CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a different directory structure * Cmake itself is distributed in this kind of structure (http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip) I think those can explain the reasoning needed for a Qt request. David Faure wrote: Yes, a single monolithic can somehow find out about its own PREFIX (e.g. by writing it into the registry at install time, right? Or indeed from the path where the .exe is being started, simply). But the issue here is what if you install several apps (and possibly several frameworks), and they need to find each other's stuff... That's the exact same situation of using XDG_DATA_DIRS on *nix. For KDE-Windows we install all packages into the same prefix for a given KDE set up. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/#review47983 --- On Jan. 22, 2014, 2:53 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115210/ --- (Updated Jan. 22, 2014, 2:53 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin. Repository: extra-cmake-modules Description --- Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows Otherwise QStandardPaths will always fail with e.g. GenericDataLocation Diffs - kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 Diff: https://git.reviewboard.kde.org/r/115210/diff/ Testing --- Thanks,
Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.
On Wednesday 05 March 2014 10:44:24 Kevin Ottens wrote: * kactivities moved under kde/kdelibs/kactivities (a very odd location in the frameworks world, but kde_projects.xml is global, not branch-dependent) Ideally should be under frameworks at some point. I'd rather have it odd in the kde4 world now. :-) I just moved kactivities to frameworks/. Anyone using kdesrc-build: you should delete kde/kdelibs/kactivities because kdesrc-build is now using frameworks/kactivities. Whichever branch you're hacking on ! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117708: move kioslave docs paths for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56293 --- I think after this change many documentation links (at least in khelpcenter) need to be fixed (I can't check now). - Luigi Toscano On April 23, 2014, 5:24 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/ --- (Updated April 23, 2014, 5:24 p.m.) Review request for KDE Frameworks. Repository: kio Description --- move kioslave docs path which currently clashes with equivalents from kdelibs4 land. Diffs - docs/kioslave/data/CMakeLists.txt 64ae620 docs/kioslave/file/CMakeLists.txt 42385fb docs/kioslave/ftp/CMakeLists.txt 935298b docs/kioslave/help/CMakeLists.txt cfb29f1 docs/kioslave/help/documentationnotfound/CMakeLists.txt f2bc0b5 docs/kioslave/http/CMakeLists.txt 2aae4fb docs/kioslave/mailto/CMakeLists.txt b0a405e docs/kioslave/telnet/CMakeLists.txt 07b2d33 docs/kioslave/webdav/CMakeLists.txt eb45ed5 src/ioslaves/file/file.protocol 07cd4c3 src/ioslaves/ftp/ftp.protocol 70ddcd0 src/ioslaves/help/help.protocol 1bb5801 src/ioslaves/http/http.protocol 2d97cd4 src/ioslaves/http/https.protocol 62a43ad src/ioslaves/http/webdav.protocol c0fbd11 src/ioslaves/http/webdavs.protocol 7017c24 src/ioslaves/mailto/kmailservice5.desktop 03838a5 src/ioslaves/protocols/data.protocol 2a57b2e src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3 Diff: https://git.reviewboard.kde.org/r/117708/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117708: move kioslave docs paths for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/ --- Review request for KDE Frameworks. Repository: kio Description --- move kioslave docs path which currently clashes with equivalents from kdelibs4 land. Diffs - docs/kioslave/data/CMakeLists.txt 64ae620 docs/kioslave/file/CMakeLists.txt 42385fb docs/kioslave/ftp/CMakeLists.txt 935298b docs/kioslave/help/CMakeLists.txt cfb29f1 docs/kioslave/help/documentationnotfound/CMakeLists.txt f2bc0b5 docs/kioslave/http/CMakeLists.txt 2aae4fb docs/kioslave/mailto/CMakeLists.txt b0a405e docs/kioslave/telnet/CMakeLists.txt 07b2d33 docs/kioslave/webdav/CMakeLists.txt eb45ed5 src/ioslaves/file/file.protocol 07cd4c3 src/ioslaves/ftp/ftp.protocol 70ddcd0 src/ioslaves/help/help.protocol 1bb5801 src/ioslaves/http/http.protocol 2d97cd4 src/ioslaves/http/https.protocol 62a43ad src/ioslaves/http/webdav.protocol c0fbd11 src/ioslaves/http/webdavs.protocol 7017c24 src/ioslaves/mailto/kmailservice5.desktop 03838a5 src/ioslaves/protocols/data.protocol 2a57b2e src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3 Diff: https://git.reviewboard.kde.org/r/117708/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w17
On Wednesday, April 23, 2014 12:40:09 PM Luigi Toscano wrote: On Tuesday 22 of April 2014 20:11:28 Nicolás Alvarez wrote: El martes, 22 de abril de 2014, Allen Winter win...@kde.org escribió: with Harald's help. Stuck in docbook hell at the moment (kdoctools/xslt.cpp says it can't find the customizations). Anyway, just thought I'd mention this. The same error happens on Windows. I have been commenting out add_subdirectory(docs) here and there to get things to build. So, this is an unresolved issue which depends on QStandardDirs. Here are few RR for Windows: https://git.reviewboard.kde.org/r/115210/ https://git.reviewboard.kde.org/r/117011/ It seems that, in both cases (Windows and MacOSX) QStandardDirs needs to be fixed to search also in some other common directories, or that the files are not installed in the place QStandardDirs expects it. The pending question is: which directory? I really need the help of domain experts here; I would really avoid to have final KF5.0 with docs removed. In the meantime, perhaps we can use ecm_optional_add_subdirectory(docs) so at least we don't need local modifications with add_subdirectory(docs) commented out This is how things were done in KDE4. I think then we just pass -DBUILD_DOCS=false to cmake (not tested) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 81 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line81 would QStringLiteral work here? Given the multiple implementations of QStringLiteral depending on compiler and C++11 support, I'd rather not risk it. IIRC it uses a lambda on msvc. sounds tricky. On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 82 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line82 Hmm. I think that looks weird. Can this be split in the type definition (struct something) and the constant defintion? I don't get that. If I make a list of type names, what do I do with it? All I need is a type-subdir lookup table (just like kstandarddirs has/had, btw) On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 97 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line97 Also maybe just a personal taste, but I find it better to explicitly use parentheses when mixing boolean and arithmetic operators, i.e. make it explicit which operator has precendence. In this case putting parentheses around the size calculation. Or even calculating the size as a const int before the loop (can it be done as a const_expr outside the function?). Kevin Krammer wrote: Or as a std:find_if()? Sorry, have just watched a Going Native talk about no raw loops :) std::find_if requires iterators, which I don't really have here. Plus it's not usual in KDE code (so it reduces maintainability/readability). I moved the size as a const int before the loop (which actually improves readability). On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 106 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line106 Do we have some logging categories for kdecoreaddons? No. Porting to categorized logging has to be done everywhere in frameworks - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review56172 --- On April 22, 2014, 9:32 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 22, 2014, 9:32 a.m.) Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 23, 2014, 4:26 p.m.) Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Changes --- move size calculation before loop Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs (updated) - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Plasma Next - Translations KCM - What Languages?
On Sunday 16 March 2014 15:49:02 Chusslove Illich wrote: The related problem for me is this: why are there still standalone language packages for some of KDE software (the SC)? Other than historical reasons, the only advantage I see is installation space. But I don't see anyone complaining about all the other Gettext-using software coming with all translations. In fact, for me installing the standalone language package is always one more thing to remember to do, or to explain to people that they should do. This vision isn't fully true, though. Large software packages do come with splitted out translations, at least the way some distros package them. OK, I actually have only one example: libreoffice-l10n-af | African Localization Files for LibreOffice | package libreoffice-l10n-am | Amharic Localization Files for LibreOffice | package libreoffice-l10n-ar | Arabic Localization Files for LibreOffice | package libreoffice-l10n-as | Assamese Localization Files for LibreOffice | package libreoffice-l10n-ast | Asturian Localization Files for LibreOffice | package libreoffice-l10n-be-BY| Belorussian Localization Files for LibreOffice | package libreoffice-l10n-bg | Bulgarian Localization Files for LibreOffice | package libreoffice-l10n-br | Breton French Localization Files for LibreOffice | package [...] I think that the only reasonable thing for Frameworks themselves is to ship with translations as part of each framework. Yes. Some packaging scripts will have to be adapted to make this easy on the release person. Yes please !!! :-) I would suggest using the same system for everything else that was so far covered by standalone language packages, and doing away with them. No opinion from me about workspace and apps. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review56306
---
The reason I did it this way was because existing application code uses
#include kjsembed/kjsembed.h
#include kjsembed/qobject_binding.h
etc.
See e.g.
http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4
So I picked the namespaced framework setup, where lowercase headers go to
include/KF5/FrameworkName/lower/lower.h and forwarding headers go to
include/KF5/FrameworkName/Camelcase/Camelcase. KParts does the same, for
instance, with e.g. include/KF5/KParts/kparts/event.h and
include/KF5/KParts/KParts/Event.
So why is this a problem for kjsembed and not for kparts? Ah, I see. The
forwarding header is supposed to go under a camelcase subdir (like it does in
kparts). KParts/KParts/Event looks confusing, but a better example where the
framework name differs from the namespace is KIOCore/KIO/Job.
So this should be the fix you need:
-install(FILES ${KJsEmbed_CamelCase_HEADERS} DESTINATION
${INCLUDE_INSTALL_DIR}/KJsEmbed COMPONENT Devel)
+install(FILES ${KJsEmbed_CamelCase_HEADERS} DESTINATION
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed COMPONENT Devel)
- David Faure
On April 21, 2014, 1:59 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
(Updated April 21, 2014, 1:59 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #282
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/282/changes Changes: [hein] Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5 build number 282 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson6387388786721102243.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 0ef526b..baff217 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 0ef526b remove deprecated elements Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision baff21787471ec17403ea630fd684a2881595955 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson5018373806630961996.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: extra-cmake-modules - Branch master attica - Branch master knotifications - Branch master phonon - Branch master kross - Branch master sonnet - Branch master kjobwidgets - Branch master ktextwidgets - Branch master kcodecs - Branch master kactivities - Branch master kdbusaddons - Branch master kcompletion - Branch master kcoreaddons - Branch master kconfigwidgets - Branch master cmake - Branch master kwallet - Branch master kauth - Branch master kio - Branch master ktexteditor - Branch master kdnssd - Branch master kwidgetsaddons - Branch master kcrash - Branch master kiconthemes - Branch master karchive - Branch master kitemviews - Branch master kbookmarks - Branch master kglobalaccel - Branch master qt5 - Branch stable kdoctools - Branch master kservice - Branch master kidletime - Branch master kguiaddons - Branch master solid - Branch master kparts - Branch master kjs - Branch master kwindowsystem - Branch master threadweaver - Branch master kitemmodels - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kunitconversion - Branch master kdeclarative - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #282
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/282/changes Changes: [hein] Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5 build number 282 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson2563876921378134936.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 47dfda7..baff217 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 47dfda7 introduce the signal Corona::startupCompleted() Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision baff21787471ec17403ea630fd684a2881595955 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson4728157003029348178.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master solid - Branch master kdnssd - Branch master kcompletion - Branch master threadweaver - Branch master kcodecs - Branch master kactivities - Branch master kparts - Branch master kdbusaddons - Branch master kitemmodels - Branch master kdeclarative - Branch master kwallet - Branch master ktextwidgets - Branch master kconfigwidgets - Branch master cmake - Branch master kio - Branch master ktexteditor - Branch master phonon - Branch master extra-cmake-modules - Branch master kcrash - Branch master kiconthemes - Branch master karchive - Branch master kwidgetsaddons - Branch master kitemviews - Branch master kbookmarks - Branch master kglobalaccel - Branch master qt5 - Branch stable kdoctools - Branch master kservice - Branch master kguiaddons - Branch master kidletime - Branch master kjobwidgets - Branch master kjs - Branch master kwindowsystem - Branch master sonnet - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kunitconversion - Branch master kcoreaddons - Branch master kconfig - Branch master kauth - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #283
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/283/changes Changes: [hein] Revert Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5 build number 283 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson2199700555864008951.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework baff217..1e55245 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at baff217 Install header for Dialog so it's publically subclassable as discussed. Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 1e5524525fb27be4cb2ca06904c6aaddbaaa42d6 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson6939785370100346503.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master sonnet - Branch master kjobwidgets - Branch master ktextwidgets - Branch master kcodecs - Branch master kauth - Branch master kdbusaddons - Branch master kcompletion - Branch master kwidgetsaddons - Branch master kcoreaddons - Branch master kconfigwidgets - Branch master cmake - Branch master kwallet - Branch master kactivities - Branch master kio - Branch master ktexteditor - Branch master kdnssd - Branch master extra-cmake-modules - Branch master kcrash - Branch master kiconthemes - Branch master karchive - Branch master kitemviews - Branch master kbookmarks - Branch master kglobalaccel - Branch master qt5 - Branch stable phonon - Branch master kdoctools - Branch master kservice - Branch master kidletime - Branch master kguiaddons - Branch master solid - Branch master kparts - Branch master kjs - Branch master kwindowsystem - Branch master threadweaver - Branch master kitemmodels - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kunitconversion - Branch master kdeclarative - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #283
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/283/changes Changes: [hein] Revert Install header for Dialog so it's publically subclassable as discussed. -- Started by upstream project plasma-framework_master_qt5 build number 283 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson7463664684910015700.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework baff217..1e55245 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at baff217 Install header for Dialog so it's publically subclassable as discussed. Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 1e5524525fb27be4cb2ca06904c6aaddbaaa42d6 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson2136167453656278130.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master sonnet - Branch master kparts - Branch master kjobwidgets - Branch master ktextwidgets - Branch master kcodecs - Branch master extra-cmake-modules - Branch master kactivities - Branch master kdbusaddons - Branch master kcrash - Branch master kdeclarative - Branch master kconfigwidgets - Branch master threadweaver - Branch master kwallet - Branch master kauth - Branch master kio - Branch master ktexteditor - Branch master kwidgetsaddons - Branch master kcompletion - Branch master kiconthemes - Branch master solid - Branch master kbookmarks - Branch master kitemviews - Branch master kitemmodels - Branch master karchive - Branch master kglobalaccel - Branch master qt5 - Branch stable phonon - Branch master kdoctools - Branch master cmake - Branch master kservice - Branch master kidletime - Branch master kguiaddons - Branch master kdnssd - Branch master kjs - Branch master kwindowsystem - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kunitconversion - Branch master kcoreaddons - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
On April 23, 2014, 3:03 p.m., Thomas Lübking wrote:
src/kstartupinfo.cpp, line 413
https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413
this is somehow not equivalent to the other variant (ignores
silent/uninited) - the iterator should perhaps go with a map
pointer/reference to stress this (and as a matching map usage is required
anyway)
Martin Gräßlin wrote:
my understand is that silent/unintended was dead code for these cases as
it only iterated over the startups and that if it's in startups it's not in
silent or unintended. I'll re-check that.
yep, unintended and ignored do not matter in that case as it's either in
startups or in silent_startups or in unintended_startups:
if (update_P) { // change: without any new: first
//qDebug() adding uninited;
uninited_startups.insert(id_P, data_P);
} else if (data_P.silent() != Data::Yes || flags AnnounceSilenceChanges) {
//qDebug() adding;
startups.insert(id_P, data_P);
emit q-gotNewStartup(id_P, data_P);
} else { // new silenced, and silent shouldn't be announced
//qDebug() adding silent;
silent_startups.insert(id_P, data_P);
}
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/#review56269
---
On April 23, 2014, 11:35 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/
---
(Updated April 23, 2014, 11:35 a.m.)
Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah.
Bugs: 332681
https://bugs.kde.org/show_bug.cgi?id=332681
Repository: kwindowsystem
Description
---
Fix crashers in KStartupInfo on remove while iterating
This is similar to the change ... just for more cases. If the API was
used with ::checkStartup it could happen that an item got removed from
the startups while iterating the list of startups. Thus the data
corrupted resulting in a crash when getting a similar crash.
In this case the code now uses erase instead of remove to have a valid
iterator.
BUG: 332681
Diffs
-
autotests/kstartupinfo_unittest.cpp
29fa320bc2c82e7e04a7322111bcdba44b7078c6
src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb
Diff: https://git.reviewboard.kde.org/r/117701/diff/
Testing
---
See new unit tests which crash without the change. For people wanting to run
the test: be warned it has the power to crash plasma-shell and kwin.
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
On April 23, 2014, 3:03 p.m., Thomas Lübking wrote:
src/kstartupinfo.cpp, line 413
https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413
this is somehow not equivalent to the other variant (ignores
silent/uninited) - the iterator should perhaps go with a map
pointer/reference to stress this (and as a matching map usage is required
anyway)
Martin Gräßlin wrote:
my understand is that silent/unintended was dead code for these cases as
it only iterated over the startups and that if it's in startups it's not in
silent or unintended. I'll re-check that.
Martin Gräßlin wrote:
yep, unintended and ignored do not matter in that case as it's either in
startups or in silent_startups or in unintended_startups:
if (update_P) { // change: without any new: first
//qDebug() adding uninited;
uninited_startups.insert(id_P, data_P);
} else if (data_P.silent() != Data::Yes || flags
AnnounceSilenceChanges) {
//qDebug() adding;
startups.insert(id_P, data_P);
emit q-gotNewStartup(id_P, data_P);
} else { // new silenced, and silent shouldn't be announced
//qDebug() adding silent;
silent_startups.insert(id_P, data_P);
}
But yes, it might be a good idea to either rename the new method or add the map
as a reference. Though I think rename is better.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/#review56269
---
On April 23, 2014, 11:35 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/
---
(Updated April 23, 2014, 11:35 a.m.)
Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah.
Bugs: 332681
https://bugs.kde.org/show_bug.cgi?id=332681
Repository: kwindowsystem
Description
---
Fix crashers in KStartupInfo on remove while iterating
This is similar to the change ... just for more cases. If the API was
used with ::checkStartup it could happen that an item got removed from
the startups while iterating the list of startups. Thus the data
corrupted resulting in a crash when getting a similar crash.
In this case the code now uses erase instead of remove to have a valid
iterator.
BUG: 332681
Diffs
-
autotests/kstartupinfo_unittest.cpp
29fa320bc2c82e7e04a7322111bcdba44b7078c6
src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb
Diff: https://git.reviewboard.kde.org/r/117701/diff/
Testing
---
See new unit tests which crash without the change. For people wanting to run
the test: be warned it has the power to crash plasma-shell and kwin.
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #284
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/284/changes Changes: [notmart] always use all the borders for floating dialogs -- Started by upstream project plasma-framework_master_qt5 build number 284 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson4955033036793325125.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 2e7d295..fc98e63 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 2e7d295 sync borders after adjusting geometry Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision fc98e6323b2c8a4480b95bb40ea0035b2b9fed67 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson8789795393311176382.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master cmake - Branch master phonon - Branch master kparts - Branch master kdnssd - Branch master threadweaver - Branch master kcodecs - Branch master kactivities - Branch master kdbusaddons - Branch master sonnet - Branch master kcrash - Branch master kcoreaddons - Branch master kconfigwidgets - Branch master ktextwidgets - Branch master kwallet - Branch master kauth - Branch master kio - Branch master ktexteditor - Branch master kwidgetsaddons - Branch master kcompletion - Branch master kiconthemes - Branch master solid - Branch master kbookmarks - Branch master kitemviews - Branch master kitemmodels - Branch master karchive - Branch master kglobalaccel - Branch master qt5 - Branch stable kdoctools - Branch master kservice - Branch master extra-cmake-modules - Branch master kidletime - Branch master kguiaddons - Branch master kjobwidgets - Branch master kjs - Branch master kwindowsystem - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kunitconversion - Branch master kdeclarative - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #284
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/284/changes Changes: [notmart] always use all the borders for floating dialogs -- Started by upstream project plasma-framework_master_qt5 build number 284 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson1025285531440240135.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 1e55245..fc98e63 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 1e55245 Revert Install header for Dialog so it's publically subclassable as discussed. Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision fc98e6323b2c8a4480b95bb40ea0035b2b9fed67 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson1035614352640336857.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master extra-cmake-modules - Branch master kjobwidgets - Branch master ktextwidgets - Branch master phonon - Branch master kcodecs - Branch master kactivities - Branch master kdbusaddons - Branch master kcompletion - Branch master kcoreaddons - Branch master kconfigwidgets - Branch master cmake - Branch master kwallet - Branch master kauth - Branch master kio - Branch master ktexteditor - Branch master kdnssd - Branch master kwidgetsaddons - Branch master sonnet - Branch master kcrash - Branch master kiconthemes - Branch master karchive - Branch master kitemviews - Branch master kbookmarks - Branch master kglobalaccel - Branch master qt5 - Branch stable kdoctools - Branch master kservice - Branch master kidletime - Branch master kguiaddons - Branch master solid - Branch master kparts - Branch master kjs - Branch master kwindowsystem - Branch master threadweaver - Branch master kitemmodels - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kunitconversion - Branch master kdeclarative - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #285
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/285/changes Changes: [notmart] correct the last commit -- Started by upstream project plasma-framework_master_qt5 build number 285 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson9184542512149478113.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework fc98e63..7ce31b6 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at fc98e63 always use all the borders for floating dialogs Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 7ce31b6b694fe20d10008c50cd46ca4504a0b770 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson20394200594859218.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master cmake - Branch master kdnssd - Branch master threadweaver - Branch master kcodecs - Branch master kactivities - Branch master kdoctools - Branch master kdbusaddons - Branch master kitemmodels - Branch master phonon - Branch master kcoreaddons - Branch master kwallet - Branch master ktextwidgets - Branch master kconfigwidgets - Branch master sonnet - Branch master kauth - Branch master kio - Branch master ktexteditor - Branch master extra-cmake-modules - Branch master solid - Branch master kcrash - Branch master kiconthemes - Branch master kbookmarks - Branch master kitemviews - Branch master karchive - Branch master kglobalaccel - Branch master qt5 - Branch stable kunitconversion - Branch master kservice - Branch master kguiaddons - Branch master kidletime - Branch master kparts - Branch master kjs - Branch master kwindowsystem - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 kwidgetsaddons - Branch master kjobwidgets - Branch master kcompletion - Branch master kdeclarative - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #285
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/285/changes Changes: [notmart] correct the last commit -- Started by upstream project plasma-framework_master_qt5 build number 285 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson2387140882829038334.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework fc98e63..7ce31b6 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at fc98e63 always use all the borders for floating dialogs Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 7ce31b6b694fe20d10008c50cd46ca4504a0b770 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson8340556644200563977.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master knotifications - Branch master kross - Branch master sonnet - Branch master kjobwidgets - Branch master ktextwidgets - Branch master kcodecs - Branch master kactivities - Branch master kdbusaddons - Branch master kcompletion - Branch master kdeclarative - Branch master kconfigwidgets - Branch master threadweaver - Branch master kwidgetsaddons - Branch master kwallet - Branch master kauth - Branch master kio - Branch master ktexteditor - Branch master kiconthemes - Branch master cmake - Branch master extra-cmake-modules - Branch master kcrash - Branch master kdnssd - Branch master karchive - Branch master kitemviews - Branch master solid - Branch master kbookmarks - Branch master kglobalaccel - Branch master qt5 - Branch stable kitemmodels - Branch master kdoctools - Branch master kservice - Branch master kidletime - Branch master kguiaddons - Branch master kparts - Branch master kjs - Branch master kwindowsystem - Branch master kxmlgui - Branch master ki18n - Branch master polkit-qt-1 - Branch qt5 phonon - Branch master kunitconversion - Branch master kcoreaddons - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kactivities/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Randa Meetings 2014: Registration Deadline and Fundraising
Good morning gals and guys You get this email because you're either: - Already registered on http://sprints.kde.org/sprint/212. - You're subscribed to a mailing list of a group that participates this year. - I already asked you in one way or another to come to Randa and you're not yet sure. - Or there is another good reason why you get this email ;-). This email is mainly to tell you the registration deadline for the Randa Meetings 2014: Deadline: Sunday, 4th of May 2014, 23:59 UTC. After this day we'll calculate the budget and will start a fundraising campaign as KDE e.V. can't give us enough money. We already did a campaign in 2012 [1] and it was a success but it needs some work and energy and you can be of valueable help: spread the fundraising campaign when we give you the link and go. But now, please do this: - If you're already registered on sprints.kde.org please check your data and verify that everything is correct (we can't try to sponsor you if you forget to add the data ;-). - Please check your group, who is yet missing on sprints.kde.org/sprint/212 of your group and ping and poke these people. - If you bring you family: did you already get in contact with me (about your preferred room, the number of persons, if they are vegetarians, etc.)? - Check if anything is unclear and you've question and send me an email or ping me (unormal) on IRC. Topics this year are: - KDE Books about KDE Frameworks - Gluon - KDE Edu/GCompris - KDE SDK - Porting apps to KF5 and porting KF5 to other platforms - Kdenlive - Amarok/Phonon/Multimedia And one last thing: Do not yet order any tickets! I'll tell when the right time for this will be. Best regards Mario [1] https://pledgie.com/campaigns/18045 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117078: Allow compiling kio on windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/#review56323 --- Ship it! A few comments, but none of them is a blocker. Well, the last one should be fixed, but you can push after fixing it. Nice work, thanks. autotests/kfileitemtest.cpp https://git.reviewboard.kde.org/r/117078/#comment39371 Could be replaced with a Windows-specific test for KFileItem::isReadable, though. src/core/kioglobal_p_win.cpp https://git.reviewboard.kde.org/r/117078/#comment39372 So this won't compile on XP at all? src/core/kioglobal_p_win.cpp https://git.reviewboard.kde.org/r/117078/#comment39373 Nice implementation :-) Quite a corner case though. Even on Unix this is almost never called: it requires running an app as root in the first place. src/ioslaves/file/file.cpp https://git.reviewboard.kde.org/r/117078/#comment39374 Should be QFile::decodeName() rather than QString::fromLocal8Bit(). - David Faure On April 4, 2014, 7:20 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/ --- (Updated April 4, 2014, 7:20 p.m.) Review request for KDE Frameworks. Repository: kio Description --- A series of commits (can submit separately if necessary): --- Add S_IXUSR, IRUSR, etc. definitions for Windows --- Add KIOPrivate::isProcessAlive() and KIOPrivate::sendTerminateSignal() kill() does not work on Windows, therefore a WIN32 implementation is needed in order to compile slave.cpp --- Add KIOPrivate::changeOwnership() to avoid directly calling chown() Additionally use KUserId/KGroupId instead of uid_t/gid_t. This allows compiling chmodjob.cpp on Windows. KIOPrivate::changeOwnership is a stub on Windows. However, it has always been like that with the kdewin chmod() implementation, so this is not a regression from kdelibs4. --- Add KIOPrivate::createSymlink() to avoid using symlink() directly --- Minor Windows compile fixes --- Use KUser in KPropertiesDialog This means no more need for getpwent(), etc - works on Windows --- Export the KIOPrivate functions --- Fix kio_http build on Windows --- No longer use uid_t/gid_t in kio_file --- Allow compiling kurlcompletion.cpp on windows --- Add a fake QT_LSTAT for Windows This just calls QT_STAT and adds QT_STAT_LNK flag to st_mode if it is a symlink --- Use KUser in kpropertiesdialog.cpp - no more getgrouplist Diffs - autotests/fileundomanagertest.cpp 3f209f89cc0e2ac48d8eaef7ee73ec18abca9a4c autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 autotests/kdirlistertest.cpp 10a970416b8874f1e136b460d05378f8f3a86810 autotests/kfileitemtest.h dc1808e726cf6af1605cfda520c7df3832225cc1 autotests/kfileitemtest.cpp 38bd87f4e9facd8e52e9e5fbd98b16011c866b5a autotests/kiotesthelper.h eb9f0f3019deb63506c2a173d700b78daa95ae10 src/core/CMakeLists.txt d897e370baedbe06b267934c123acee7a149adff src/core/chmodjob.cpp 271869bc2a643d715670560b7920efdbc948e560 src/core/job_error.cpp 1551959b6a3cf7060736bea361e840f82651a332 src/core/kfileitem.cpp 7364f87257b5d7dfb760b1c6e5b5d04e1d15a19d src/core/kioglobal_p.h PRE-CREATION src/core/kioglobal_p_unix.cpp PRE-CREATION src/core/kioglobal_p_win.cpp PRE-CREATION src/core/slave.cpp 787ffcf3cc97a73fb29c2172ed6b8df19ac016fc src/ioslaves/file/file.h 6477df7cf0d26bf4f581151e1ce8e6c1115a221c src/ioslaves/file/file.cpp a642a524c3022ce7f039f90d5bc1f577c88631dc src/ioslaves/file/file_win.cpp b0e433e5438e3c45f2f021bf073cb3cca8f4f923 src/ioslaves/ftp/ftp.cpp 79f6144264c03f506309037ed6e8ce429f6c30f0 src/ioslaves/http/http.cpp de1a1ddde544229689bd22cd69491a46b8c0dddb src/widgets/CMakeLists.txt 61e4db3566bad08baaa2e7e90b862ddfc8b957f7 src/widgets/config-getgrouplist.h.cmake 6847a19d60be4eb5c2b65fb86258f7368848e6ab src/widgets/getgrouplist-fake.c dbe77067371dcedb80cea684fb3cd5f42ed72805 src/widgets/kpropertiesdialog.cpp 8e0a9ba0a806fdb1c9e92de00dfb1c8a1449978c src/widgets/kurlcompletion.cpp 3f309257c187358de0fd66f9d67f09a712fdf7d6 Diff: https://git.reviewboard.kde.org/r/117078/diff/ Testing --- compiles, tests still the same as before (i.e. not passing) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 23, 2014, 9:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56327 --- This review has been submitted with commit b87a8701c3243bfb957d4dcaed60dbbbd177ea8e by David Jarvie to branch master. - Commit Hook On April 22, 2014, 10:03 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/#review56328 --- https://git.reviewboard.kde.org/r/115602/ - Jonathan Riddell On April 23, 2014, 1:22 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/ --- (Updated April 23, 2014, 1:22 p.m.) Review request for KDE Frameworks. Repository: kactivities Description --- to enable co-installability with kdelibs4 rename kactivitymanagerd to kactivitymanagerd5. also rename it in the .desktop file used to run the binary. Diffs - src/service/CMakeLists.txt 3436764 src/service/files/kactivitymanagerd.desktop 00ff557 Diff: https://git.reviewboard.kde.org/r/117705/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
On April 23, 2014, 1:03 p.m., Thomas Lübking wrote:
src/kstartupinfo.cpp, line 413
https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413
this is somehow not equivalent to the other variant (ignores
silent/uninited) - the iterator should perhaps go with a map
pointer/reference to stress this (and as a matching map usage is required
anyway)
Martin Gräßlin wrote:
my understand is that silent/unintended was dead code for these cases as
it only iterated over the startups and that if it's in startups it's not in
silent or unintended. I'll re-check that.
Martin Gräßlin wrote:
yep, unintended and ignored do not matter in that case as it's either in
startups or in silent_startups or in unintended_startups:
if (update_P) { // change: without any new: first
//qDebug() adding uninited;
uninited_startups.insert(id_P, data_P);
} else if (data_P.silent() != Data::Yes || flags
AnnounceSilenceChanges) {
//qDebug() adding;
startups.insert(id_P, data_P);
emit q-gotNewStartup(id_P, data_P);
} else { // new silenced, and silent shouldn't be announced
//qDebug() adding silent;
silent_startups.insert(id_P, data_P);
}
Martin Gräßlin wrote:
But yes, it might be a good idea to either rename the new method or add
the map as a reference. Though I think rename is better.
I actually meant, whether it's in actual use at all (yes, is) or could fully be
replaced by a variant taking an iterator and a map (no, can't) - there's no
ignored in my copy ;-)
I'd then suggest to rename it to removeAllStartupInfoInternal() and fix it (to
operate on iterators) in another patch.
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/#review56269
---
On April 23, 2014, 9:35 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117701/
---
(Updated April 23, 2014, 9:35 a.m.)
Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah.
Bugs: 332681
https://bugs.kde.org/show_bug.cgi?id=332681
Repository: kwindowsystem
Description
---
Fix crashers in KStartupInfo on remove while iterating
This is similar to the change ... just for more cases. If the API was
used with ::checkStartup it could happen that an item got removed from
the startups while iterating the list of startups. Thus the data
corrupted resulting in a crash when getting a similar crash.
In this case the code now uses erase instead of remove to have a valid
iterator.
BUG: 332681
Diffs
-
autotests/kstartupinfo_unittest.cpp
29fa320bc2c82e7e04a7322111bcdba44b7078c6
src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb
Diff: https://git.reviewboard.kde.org/r/117701/diff/
Testing
---
See new unit tests which crash without the change. For people wanting to run
the test: be warned it has the power to crash plasma-shell and kwin.
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56333 --- Ship it! Ship It! - Thomas Lübking On April 23, 2014, 9:35 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 23, 2014, 9:35 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Bugs: 332681 https://bugs.kde.org/show_bug.cgi?id=332681 Repository: kwindowsystem Description --- Fix crashers in KStartupInfo on remove while iterating This is similar to the change ... just for more cases. If the API was used with ::checkStartup it could happen that an item got removed from the startups while iterating the list of startups. Thus the data corrupted resulting in a crash when getting a similar crash. In this case the code now uses erase instead of remove to have a valid iterator. BUG: 332681 Diffs - autotests/kstartupinfo_unittest.cpp 29fa320bc2c82e7e04a7322111bcdba44b7078c6 src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117701/diff/ Testing --- See new unit tests which crash without the change. For people wanting to run the test: be warned it has the power to crash plasma-shell and kwin. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: knewstuff_master_qt5 #46
See http://build.kde.org/job/knewstuff_master_qt5/46/changes Changes: [jpwhiting] Move khotnewstuff and khotnewstuff_upload to knewstuff from kde-runtime. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/knewstuff_master_qt5/ws/ Running Prebuild steps [knewstuff_master_qt5] $ /bin/sh -xe /tmp/hudson4613576504551187792.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/knewstuff * [new branch] khotnewstuff - origin/khotnewstuff a79a102..4195bc6 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at a79a102 Add src/Messages.sh Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@3c7d8964 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/knewstuff Checking out Revision 4195bc64c667f9108557ef47d57e5238f9109a58 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [knewstuff_master_qt5] $ /bin/sh -xe /tmp/hudson6860433778233771302.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: knewstuff - Branch master == Build Dependencies: ktextwidgets - Branch master extra-cmake-modules - Branch master kwindowsystem - Branch master sonnet - Branch master cmake - Branch master kdoctools - Branch master karchive - Branch master kwallet - Branch master kjobwidgets - Branch master knotifications - Branch master kio - Branch master qt5 - Branch stable kcodecs - Branch master kdbusaddons - Branch master kcrash - Branch master kglobalaccel - Branch master kcoreaddons - Branch master kconfigwidgets - Branch master attica - Branch master kbookmarks - Branch master kxmlgui - Branch master kwidgetsaddons - Branch master solid - Branch master kguiaddons - Branch master kcompletion - Branch master kiconthemes - Branch master polkit-qt-1 - Branch qt5 kitemviews - Branch master ki18n - Branch master kconfig - Branch master kauth - Branch master kservice - Branch master phonon - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Warning (dev) at src/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- -- The following REQUIRED packages have been found: * Qt5Core (required version = 5.2.0) * ECM (required version = 0.0.12) * Qt5Gui (required version = 5.3.0) * Qt5Widgets * Qt5Xml * KF5Archive (required version = 4.98.0) * KF5Completion (required version = 4.98.0) * KF5Config (required version = 4.98.0) * KF5CoreAddons (required version = 4.98.0) * KF5I18n (required version = 4.98.0) * KF5IconThemes (required version = 4.98.0) * KF5KIO (required version = 4.98.0) * KF5ItemViews (required version = 4.98.0) * KF5TextWidgets (required version = 4.98.0) * KF5WidgetsAddons (required version = 4.98.0) * KF5XmlGui (required version = 4.98.0) * KF5Attica (required version = 4.98.0) , A Qt library that implements the Open Collaboration Services API , https://projects.kde.org/attica Support for Get Hot New Stuff in KNewStuff * Qt5Test Required for unit tests * Qt5 (required version = 5.2.0) -- Configuring done --
Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 24, 2014, 7:27 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Bhushan Shah. Changes --- Changed the method name to removeStartupInfoInternal and added a small documentation to what it does. Will now change the other one in another review request. Bugs: 332681 https://bugs.kde.org/show_bug.cgi?id=332681 Repository: kwindowsystem Description --- Fix crashers in KStartupInfo on remove while iterating This is similar to the change ... just for more cases. If the API was used with ::checkStartup it could happen that an item got removed from the startups while iterating the list of startups. Thus the data corrupted resulting in a crash when getting a similar crash. In this case the code now uses erase instead of remove to have a valid iterator. BUG: 332681 Diffs (updated) - autotests/kstartupinfo_unittest.cpp 29fa320bc2c82e7e04a7322111bcdba44b7078c6 src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117701/diff/ Testing --- See new unit tests which crash without the change. For people wanting to run the test: be warned it has the power to crash plasma-shell and kwin. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/ --- Review request for KDE Frameworks and Thomas Lübking. Repository: kwindowsystem Description --- Improve KStartupInfo::Private::remove_startup_info_internal Uses iterators to check whether startups, silent_startups or unintended_startups contains the id and erases the element. Method is renamed to removeAllStartupInfoInternal to point out the difference to the method which just removes from startups. Diffs - src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117731/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
