Re: Review Request 117080: cleanup KDirModelTest
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/#review56346 --- Ship it! I wonder why this was discarded -- other than the fact that I took too much time to get to it. It looks good to me. - David Faure On April 16, 2014, 4:47 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/ --- (Updated April 16, 2014, 4:47 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Use Qt5 new signal slot syntax for KDirModelTest This allows removing #define connect(...) QVERIFY(QObject::connect(...)), since now the connections are checked at compile time. Also removed all disconnect calls at the end of a test, now this is done in cleanup() which is automatically called after each test case Always use QTestEventLoop (as is the case now already) This merely removes the #define and #ifdefs for it Diffs - autotests/kdirmodeltest.h b8b41ec52a61a083c6c76e9184a556835551443e autotests/kdirmodeltest.cpp 5d59eba45495de30db5e70da2e80bb3d5cba424c Diff: https://git.reviewboard.kde.org/r/117080/diff/ Testing --- Test still passes (except for testFontUrlWithHost, but that has always timed out for me) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : knewstuff_master_qt5 #47
See http://build.kde.org/job/knewstuff_master_qt5/47/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #286
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/286/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #286
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/286/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56349 --- Ship it! Ship It! - Thomas Lübking On April 24, 2014, 5:46 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/ --- (Updated April 24, 2014, 5:46 a.m.) Review request for KDE Frameworks and Thomas Lübking. Repository: kwindowsystem Description --- Improve KStartupInfo::Private::remove_startup_info_internal Uses iterators to check whether startups, silent_startups or unintended_startups contains the id and erases the element. Method is renamed to removeAllStartupInfoInternal to point out the difference to the method which just removes from startups. Diffs - src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117731/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117733: Fully port KXMessages to XCB
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Fully port KXMessages to XCB * use xcb to resolve the intern atoms * use xcb event structure for sending the client message * add xcb overload for KXMessages::broadcastMessageX * deprecate XLib variant * extend test to verify all three variants of sending messages Diffs - autotests/kxmessages_unittest.cpp 90900f23961184e6bd35475e2cc43e0caa9099e9 src/kxmessages.h e6534964e82bddae46a7b09976e9b7c9e3138a2a src/kxmessages.cpp c76de22f5537e8a265d4dce53ce07e90234caeef Diff: https://git.reviewboard.kde.org/r/117733/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is QStandardPaths with QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I think %APPDATA%. KF5 based KDE software won't work otherwise since it can't find the data. I think the better way of fixing this is patching Qt, but for now this works. Patrick Spendrin wrote: Can you keep that patch locally for now and we try and come up with a patch for Qt instead? We cannot restrict ourselves at that point I think. Alexander Richardson wrote: Sure no problem. I'll drop this request David Faure wrote: So what do you recommend instead, for QStandardPaths? Checking some non-standard environment variable? or? Alexander Richardson wrote: I would go for the environment variable. Something like QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default dirs. Would also be useful for other cases: e.g. in the okteta unit tests I set XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there is QFINDTESTDATA, but that won't work in that case). It would also be nice if there were some cross-platform solution like QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString path) to inject (like KStandardDirs::addResourceDir). Patrick von Reth wrote: I don't like the idea of using the env var as this would require the user to setup the variables or a kde process to set them up. We also would get an undefined behaviour if the env var is not set. I think kde is not the only qt project ported to windows wich uses the bin/../share location on windows, so why not only add this path with a low priority to QStrandardpathes? David Faure wrote: I agree that the env var would be quite inconvenient, which is why I was dubious about that approach. A method to add paths wouldn't help either (how would all apps do it?) bin/../share means go up one level from the location of the executable and enter share? I thought Windows apps didn't use a bin/ dir actually, but were rather in the toplevel? Anyhow I'd be fine with that, especially if you can find any documentation of this outside of kde (to explain the reasoning in the Qt change request). Andrius da Costa Ribas wrote: As far as I can see: 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, $PREFIX/share etc... and PREFIX is not standard on windows (those apps normally don't use %PROGRAMFILES%) * Other autoconf-based apps and libs also follow this structure * even those using %PROGRAMFILES% also follow this structure (e.g. for GIMP 2, $PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside it) 2 - Most CMake-based apps also follow a similar pattern, relative to $CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a different directory structure * Cmake itself is distributed in this kind of structure (http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip) I think those can explain the reasoning needed for a Qt request. David Faure wrote: Yes, a single monolithic can somehow find out about its own PREFIX (e.g. by writing it into the registry at install time, right? Or indeed from the path where the .exe is being started, simply). But the issue here is what if you install several apps (and possibly several frameworks), and they need to find each other's stuff... Andrius da Costa Ribas wrote: That's the exact same situation of using XDG_DATA_DIRS on *nix. For KDE-Windows we install all packages into the same prefix for a given KDE set up. We had these arguments already when thinking about how to install KDE on Windows, a thing where we do have almost all possible control. - One argument why this doesn't work is that there are multiple (incompatible) compilers on windows. Since e.g. plugins etc. are incompatible, you can either enforce one single compiler (that is virtually impossible for pure Qt applications, but it would be possible to some extend for KDE apps). - Since shared data is very likely also version dependent, you'll have to invent versioned folders (e.g. %ALLUSERSPROFILE%\kde-share-5.4.0-123deadbeef vs. %ALLUSERSPROFILE%\kde-share-5.4.0-123cafecafe). This actually moves the problem of finding compatible versions to another location and messes up ALLUSERSPROFILE. - What about security issues? If I install an application as a single user in a separate partition (so to hide it from cops... ;-)), you'd leave an unwanted trace in that case. Similar problems can occur with portable apps where you might not even have access to that
Re: Re: Re: Writing a Frameworks book at Randa
On Sun, Apr 13, 2014 at 10:38 PM, Martin Gräßlin mgraess...@kde.org wrote: On Friday 11 April 2014 00:23:26 David Narvaez wrote: On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin mgraess...@kde.org wrote: we might have here a chicken-egg problem. Good API documentation would significantly help for writing the book. That is if the API documentation is good someone without deep domain knowledge will be able to write a book about it. But if the API documentation is not good enough it needs domain knowledge to write those. Now what I read out of the thread is that developers think that the time of the domain experts would be better spent writing the API documentation than writing a book. The question now is whether our API documentation is already good enough to write a book without domain experts or if we need to improve the documentation first, whether we could do this at the sprint instead of (or in addition) to writing a book. I have been thinking these are two orthogonal things. These are thoughts I had when this idea was first posted and may be relevant to this current discussion: O'Reilly media has these series of cookbooks. So you have * Programming in Perl[0]: Programming Perl, hit the shelves in 1990, and was quickly adopted as the undisputed bible of the language * Perl Cookbook[1]: The Perl Cookbook is a comprehensive collection of problems, solutions, and practical examples for anyone programming in Perl. I would presonally like us to have a Frameworks Cookbook after Randa, not a Frameworks Bible. Fully agree and that's what I hoped the book would be about. But it's something which requires domain knowledge. E.g. examples for KWindowSystems need someone to really know what the framework is doing to just come up with a good idea for such a recipe. I wouldn't mind to collect ideas and solutions over the time, but it's too late to do it at the sprint. Cheers Martin I was excited to hear David Narvaez' ideas about what the book should be. It sounds like the focus is happening. However, not many people have committed to come to Randa and get this book started. Right now there is one person on https://sprints.kde.org/sprint/212 listing kdebooks as their task. I can ask other people to come to Randa to help shape the text, but we *must* have Frameworks people committed to this project to make it happen. The deadline for signing up is approaching. Please sign up now if you intend to come to write. The e.V. and other funders will support us if we step up; but I will not waste their money by flying to Switzerland without a committed group of writers. Valorie -- http://about.me/valoriez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review request: kdeebugdialog5 co-installability
Reviewboard does not like this patch and even my usual goto man for git help agateau can't work out why. So here's a manual review request kdelibs4support: http://starsky.19inch.net/~jr/tmp/DIFF rename kdebugdialog to kdeebugdialog5 internally and move documentation to allow for co-installability this stops the documentation files clashing with kdelibs4 equivalents. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117080: cleanup KDirModelTest
On April 24, 2014, 8:44 a.m., David Faure wrote: I wonder why this was discarded -- other than the fact that I took too much time to get to it. It looks good to me. Okay, I'll reopen and fix the issues. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/#review56346 --- On April 16, 2014, 6:47 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/ --- (Updated April 16, 2014, 6:47 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Use Qt5 new signal slot syntax for KDirModelTest This allows removing #define connect(...) QVERIFY(QObject::connect(...)), since now the connections are checked at compile time. Also removed all disconnect calls at the end of a test, now this is done in cleanup() which is automatically called after each test case Always use QTestEventLoop (as is the case now already) This merely removes the #define and #ifdefs for it Diffs - autotests/kdirmodeltest.h b8b41ec52a61a083c6c76e9184a556835551443e autotests/kdirmodeltest.cpp 5d59eba45495de30db5e70da2e80bb3d5cba424c Diff: https://git.reviewboard.kde.org/r/117080/diff/ Testing --- Test still passes (except for testFontUrlWithHost, but that has always timed out for me) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117749: Allow kmimeassociationstest to be run alone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Allow kmimeassociationstest to be run alone Previously, it tried to create a KServiceFactory without ensuring the sycoca database had been created, which caused an assert if it had not. It was not caught previously, because make test runs other tests first that generate the sycoca database. Diffs - autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117749/diff/ Testing --- rm -rf ~/.qttest Ran kmimeassociationstest directly. It passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 24, 2014, 6:54 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Making the review request depend on itself doesn't make sense... Repository: kservice Description --- kmimeassociationstest: do not use KDE apps in test Looking for applications with a kde4- prefix will not be useful in the long term, as those applications will disappear as people move away from kdelibs4. However, simply stripping the kde4- prefix also does not work because you can set a mime type assocation for kwrite.desktop, and if the KF5-based KWrite (which has the desktop ID kwrite.desktop) is not installed but the kdelibs4-based one (which has the desktop ID kde4-kwrite.desktop) is installed, the mime type will be associated with kde4-kwrite.desktop, and the test will fail. To avoid this issue, we avoid using KDE applications in the tests. The prefixing stuff is explicitly tested with some fake application desktop files. We still try adding and removing associations for real applications (that may or may not be installed) to test cascading. Diffs - autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117475/diff/ Testing --- Test still passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Android integration in KConfig framework
Hi,
I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js)
and for storing persistent data, i'm using KConfig (from
https://projects.kde.org/projects/frameworks/kconfig/repository).
It works fine on Desktop (tested on linux) and with a slight
modification (I attached a potential patch which fix my problem) it
works also on Android.
I have a problem when compiling KConfig libraries because it appends the
soname at the end of library (meaning libGCompris.so will look for a
libKF5ConfigCore.so.5) and I deploy only libKF5ConfigCore.so (it looks
like Android does not support soname).
About the patch, in the toolchain I specifiy to compile with, ANDROID is
defined. This way, It only creates a libKF5ConfigCore.so.
If it is good for you, is it possible to integrate it on KConfig ?Or if
you have an other way to not have the soname, I take it :)
Regards,
Johnny
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt
index 0b1136b..7e07c63 100644
--- a/src/core/CMakeLists.txt
+++ b/src/core/CMakeLists.txt
@@ -31,10 +31,12 @@ if(WIN32)
target_link_libraries(KF5ConfigCore PRIVATE ${KDEWIN_LIBRARIES})
endif()
+if(NOT ANDROID)
set_target_properties(KF5ConfigCore PROPERTIES VERSION ${KCONFIG_VERSION_STRI
SOVERSION ${KCONFIG_SOVERSION}
EXPORT_NAME ConfigCore
)
+endif(NOT ANDROID)
ecm_generate_headers(KConfigCore_HEADERS
HEADER_NAMES
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Android integration in KConfig framework
On Thu, Apr 24, 2014 at 9:11 PM, JAZEIX Johnny jaz...@gmail.com wrote: Hi, I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) and for storing persistent data, i'm using KConfig (from https://projects.kde.org/projects/frameworks/kconfig/repository). It works fine on Desktop (tested on linux) and with a slight modification (I attached a potential patch which fix my problem) it works also on Android. I have a problem when compiling KConfig libraries because it appends the soname at the end of library (meaning libGCompris.so will look for a libKF5ConfigCore.so.5) and I deploy only libKF5ConfigCore.so (it looks like Android does not support soname). About the patch, in the toolchain I specifiy to compile with, ANDROID is defined. This way, It only creates a libKF5ConfigCore.so. If it is good for you, is it possible to integrate it on KConfig ?Or if you have an other way to not have the soname, I take it :) Regards, Johnny ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel You need to set the system name to Android (set(CMAKE_SYSTEM_NAME Android)), note you will need cmake 3.0 for that to work, this sets the cmake project to drop the soname for libraries. FWIW, I've been working on improving the cmake situation on Android [1], maybe that can help you, although it's far from a usable state. Aleix [1] http://quickgit.kde.org/?p=scratch%2Fapol%2Fkalgebraandroid.gita=blobh=9bd96cc3463a0675fd67aeca6cb1a47460f1dd8dhb=e75f946e87690db2c4b509baac9c1ff4e51bc130f=AndroidToolchain.cmake ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117758: Update install-compile.docbook translations to not reference KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated. Spanish was supplied by afiestas. Korean was grabbed from the Korean translation of techbase. The remaining ones I just replaced KDE4 with KDE Software (capitalized like that so it is like a coherent term). Translators can touch up the text later if they wish. Diffs - src/customization/es/entities/install-compile.docbook 4f4d2ae58ea8d5eebdfa3264cb3ebee47448cb18 src/customization/ja/entities/install-compile.docbook 4c48271567cea769d680c0306bb61f971059776d src/customization/ko/entities/install-compile.docbook af0546759cddcac69317e56bc375a792c47edd63 src/customization/lt/entities/install-compile.docbook b5ab6962064776c6d34426c0b767bb6a5f97814a src/customization/nds/entities/install-compile.docbook 61b915bd7f8775a4fad9716f68a25b2d2009e866 src/customization/sq/entities/install-compile.docbook 307c30230a3325221322e5462669b6cbb14b2c42 src/customization/sv/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 9:46 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Get the right name... Repository: kdoctools Description (updated) --- Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated. Spanish was supplied by apol. Korean was grabbed from the Korean translation of techbase. The remaining ones I just replaced KDE4 with KDE Software (capitalized like that so it is like a coherent term). Translators can touch up the text later if they wish. Diffs - src/customization/es/entities/install-compile.docbook 4f4d2ae58ea8d5eebdfa3264cb3ebee47448cb18 src/customization/ja/entities/install-compile.docbook 4c48271567cea769d680c0306bb61f971059776d src/customization/ko/entities/install-compile.docbook af0546759cddcac69317e56bc375a792c47edd63 src/customization/lt/entities/install-compile.docbook b5ab6962064776c6d34426c0b767bb6a5f97814a src/customization/nds/entities/install-compile.docbook 61b915bd7f8775a4fad9716f68a25b2d2009e866 src/customization/sq/entities/install-compile.docbook 307c30230a3325221322e5462669b6cbb14b2c42 src/customization/sv/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated April 24, 2014, 9:57 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Android integration in KConfig framework
On Thu, Apr 24, 2014 at 10:55 PM, Aleix Pol aleix...@kde.org wrote: On Thu, Apr 24, 2014 at 9:11 PM, JAZEIX Johnny jaz...@gmail.com wrote: Hi, I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) and for storing persistent data, i'm using KConfig (from https://projects.kde.org/projects/frameworks/kconfig/repository). It works fine on Desktop (tested on linux) and with a slight modification (I attached a potential patch which fix my problem) it works also on Android. I have a problem when compiling KConfig libraries because it appends the soname at the end of library (meaning libGCompris.so will look for a libKF5ConfigCore.so.5) and I deploy only libKF5ConfigCore.so (it looks like Android does not support soname). About the patch, in the toolchain I specifiy to compile with, ANDROID is defined. This way, It only creates a libKF5ConfigCore.so. If it is good for you, is it possible to integrate it on KConfig ?Or if you have an other way to not have the soname, I take it :) Regards, Johnny ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel You need to set the system name to Android (set(CMAKE_SYSTEM_NAME Android)), note you will need cmake 3.0 for that to work, this sets the cmake project to drop the soname for libraries. FWIW, I've been working on improving the cmake situation on Android [1], maybe that can help you, although it's far from a usable state. Aleix [1] http://quickgit.kde.org/?p=scratch%2Fapol%2Fkalgebraandroid.gita=blobh=9bd96cc3463a0675fd67aeca6cb1a47460f1dd8dhb=e75f946e87690db2c4b509baac9c1ff4e51bc130f=AndroidToolchain.cmake Adding JAZEIX, in case he's not subscribed. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56422 --- Ship it! I was hoping in other answers from translators :( Thanks for the fixes; fine by me, if Burkhard does not object in one day or two please commit. - Luigi Toscano On April 24, 2014, 11:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 11:46 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated. Spanish was supplied by apol. Korean was grabbed from the Korean translation of techbase. The remaining ones I just replaced KDE4 with KDE Software (capitalized like that so it is like a coherent term). Translators can touch up the text later if they wish. Diffs - src/customization/es/entities/install-compile.docbook 4f4d2ae58ea8d5eebdfa3264cb3ebee47448cb18 src/customization/ja/entities/install-compile.docbook 4c48271567cea769d680c0306bb61f971059776d src/customization/ko/entities/install-compile.docbook af0546759cddcac69317e56bc375a792c47edd63 src/customization/lt/entities/install-compile.docbook b5ab6962064776c6d34426c0b767bb6a5f97814a src/customization/nds/entities/install-compile.docbook 61b915bd7f8775a4fad9716f68a25b2d2009e866 src/customization/sq/entities/install-compile.docbook 307c30230a3325221322e5462669b6cbb14b2c42 src/customization/sv/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56423 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 8:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:32 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117491: Rework FindX11_XCB.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56424 --- This review has been submitted with commit a92b1da58ea317a3a6d2e9c0d68fbf1b77518717 by Alex Merry to branch master. - Commit Hook On April 11, 2014, 8:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 11, 2014, 8:32 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin. Repository: extra-cmake-modules Description --- Rework FindX11_XCB.cmake Imported target, version handling, package description etc. Diffs - find-modules/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review56425 --- Ship it! Ship It! - Kevin Ottens On April 14, 2014, 4:04 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 14, 2014, 4:04 p.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Repository: kcoreaddons Description --- Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Note that we cannot provide a constructor overload that is identical other than omitting the catalog name argument, as that would be ambiguous (if 4 strings are passed, it could be either the new constructor or the old one). So instead, we provide two new constructors: one requiring at least 4 strings and the license type, and one only taking 3 strings. Diffs - autotests/kaboutdatatest.cpp 22b013c0626ebea94f371474048c670b3d50dad6 src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/#review56427 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 1:14 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/ --- (Updated April 16, 2014, 1:14 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- ECMFindModuleHelpers: set traditional variables The traditional *_LIBRARIES, *_INCLUDE_DIRS and *_DEFINITIONS do have some uses - they make it easier to create package config files that use found libraries in their link interface. So this makes sure these variables are set by ecm_find_package_handle_library_components() (and hence by FindWayland.cmake and FindXCB.cmake). Diffs - modules/ECMFindModuleHelpers.cmake 15df9ef05f8367df3ebf60dd3f3c9bfe937d2547 find-modules/FindXCB.cmake dd876b214edd35993b8e8d3582536a24776a2e64 find-modules/FindWayland.cmake b7790e750e8ae9b1c6d5be81b7683b489d60a5a7 Diff: https://git.reviewboard.kde.org/r/117585/diff/ Testing --- Configured, built and installed KWindowSystem and KWin. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 10:17 p.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Burkhard Lück. Changes --- Add Burkhard Repository: kdoctools Description --- Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated. Spanish was supplied by apol. Korean was grabbed from the Korean translation of techbase. The remaining ones I just replaced KDE4 with KDE Software (capitalized like that so it is like a coherent term). Translators can touch up the text later if they wish. Diffs - src/customization/es/entities/install-compile.docbook 4f4d2ae58ea8d5eebdfa3264cb3ebee47448cb18 src/customization/ja/entities/install-compile.docbook 4c48271567cea769d680c0306bb61f971059776d src/customization/ko/entities/install-compile.docbook af0546759cddcac69317e56bc375a792c47edd63 src/customization/lt/entities/install-compile.docbook b5ab6962064776c6d34426c0b767bb6a5f97814a src/customization/nds/entities/install-compile.docbook 61b915bd7f8775a4fad9716f68a25b2d2009e866 src/customization/sq/entities/install-compile.docbook 307c30230a3325221322e5462669b6cbb14b2c42 src/customization/sv/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117602: Remove more UPnP stuff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/#review56430 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 7:46 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/ --- (Updated April 16, 2014, 7:46 p.m.) Review request for KDE Frameworks and Àlex Fiestas. Repository: solid Description --- Since the UPnP backend was removed, it looks like this other UPnP stuff can go too. Diffs - KF5SolidConfig.cmake.in a767f1963816a1f706ee6a4871f0ba95745b7151 cmake/FindHUpnp.cmake 8b34c2e8279c0cf21f2703e1cd5b22c3c35891dc src/solid/backends/fstab/fstabdevice.h cd8d92622ae35230cf9e90422a68260c1bab1bdb src/solid/config-solid.h.cmake 84d12604e0177d5af7108daf11b9b99be33468d5 src/solid/managerbase.cpp 66338125df7eb58fefb31c423b37258b9b96f1da src/solid/networkshare.h 6d8ab1e914d0f2fc570a48b4959aed99f3859c15 Diff: https://git.reviewboard.kde.org/r/117602/diff/ Testing --- Builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117617: New syntax for ecm_install_icons()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/#review56432 --- Ship it! Ship It! - Kevin Ottens On April 17, 2014, 7:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/ --- (Updated April 17, 2014, 7:40 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Apologies for the slightly ridiculous changeset. The unit tests involve lots of (mostly identical) files. New syntax for ecm_install_icons() This requires the icon files to be specified (which is better than globbing, because the build system will then be able to tell when files are added or removed and re-run CMake). It also removes the theme name from the filename pattern: the old code used a shorthand theme name for a small number of themes, and didn't allow any other themes. Extending this to arbitrary themes could cause problems with themes that have numbers or hyphens (or whatever other delimiter character was used) in their names. Most users are likely to just want to install to a single theme anyway (based on a random sampling of users of kde4_install_icons), so that is what the new syntax requires. The old syntax still works and behaves as before. ecm_update_iconcache is renamed to _ecm_update_iconcache - it was never documented as public API anyway. Diffs - modules/ECMInstallIcons.cmake d83003bac633d14ec538af539c3b414992c5f8e4 tests/CMakeLists.txt e464a0305bd71364463c3132103ffe02dcb94eb6 tests/ECMInstallIconsTest/128-devices-drive-removable-media-usb-pendrive.png PRE-CREATION tests/ECMInstallIconsTest/128-emblems-emblem-mounted.png PRE-CREATION tests/ECMInstallIconsTest/128-places-home.mng PRE-CREATION tests/ECMInstallIconsTest/16-actions-badext.txt PRE-CREATION tests/ECMInstallIconsTest/16-actions-computer.png PRE-CREATION tests/ECMInstallIconsTest/16-animations-loading.mng PRE-CREATION tests/ECMInstallIconsTest/16-apps-cmake.png PRE-CREATION tests/ECMInstallIconsTest/16-categories-system-help.mng PRE-CREATION tests/ECMInstallIconsTest/16-emotes-face-smile.png PRE-CREATION tests/ECMInstallIconsTest/16-intl-something.png PRE-CREATION tests/ECMInstallIconsTest/16-status-user-online.png PRE-CREATION tests/ECMInstallIconsTest/CMakeLists.txt PRE-CREATION tests/ECMInstallIconsTest/aa-actions-badsize.png PRE-CREATION tests/ECMInstallIconsTest/badlynamedfile.png PRE-CREATION tests/ECMInstallIconsTest/check_tree.cmake.in PRE-CREATION tests/ECMInstallIconsTest/expected-tree/badly-named-files-test/hicolor/16x16/actions/badext.txt PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/128x128/devices/l10n/en_US/drive-removable-media-usb-pendrive.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/128x128/emblems/l10n/en_US/emblem-mounted.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/128x128/places/l10n/en_US/home.mng PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/actions/l10n/en_US/computer.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/animations/l10n/en_US/loading.mng PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/apps/l10n/en_US/cmake.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/categories/l10n/en_US/system-help.mng PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/emotes/l10n/en_US/face-smile.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/intl/l10n/en_US/something.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/status/l10n/en_US/user-online.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/scalable/mimetypes/l10n/en_US/fonts-package.svgz PRE-CREATION tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/128x128/devices/drive-removable-media-usb-pendrive.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/128x128/emblems/emblem-mounted.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/128x128/places/home.mng PRE-CREATION tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/actions/computer.png PRE-CREATION tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/animations/loading.mng PRE-CREATION
Re: Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117658/#review56434
---
Ship it!
Ship It!
- Kevin Ottens
On April 20, 2014, 3 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117658/
---
(Updated April 20, 2014, 3 p.m.)
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Repository: extra-cmake-modules
Description
---
Split up module execution tests
Find module tests now use find_package(), and there is a version for
when CMAKE_MODULE_PATH is set and a version for when
ecm_use_find_modules() is used.
KDE modules are also now tested.
Add a stub for ECMFindModuleHelpers to the find-modules dir
ECMUseFindModules allows find modules to be copied to a local directory.
These find modules may use ECMFindModuleHelpers, but they will not be in
the same relative location to ECMFindModuleHelpers.cmake and there is no
guarantee that ECMFindModulesHelpers.cmake will be in the CMake module
path.
To solve this, we make sure there is always a stub file in the same
directory as the find modules that includes the real
ECMFindModuleHelpers.cmake. The one installed with ECM just includes
../modules/ECMFindModuleHelpers.cmake, while ecm_use_find_modules
generates a stub that uses an absolute path.
Diffs
-
find-modules/FindWayland.cmake b7790e750e8ae9b1c6d5be81b7683b489d60a5a7
find-modules/ECMFindModuleHelpersStub.cmake PRE-CREATION
find-modules/FindXCB.cmake dd876b214edd35993b8e8d3582536a24776a2e64
modules/ECMUseFindModules.cmake 25f42666ceaecdac4034caf43c31f3f219f9070b
tests/CMakeLists.txt e464a0305bd71364463c3132103ffe02dcb94eb6
tests/ExecuteAllModules/CMakeLists.txt
12e86c15d209ff38340af0dd0a5900091ce4cadb
tests/ExecuteAllModules/main.c
tests/ExecuteCoreModules/CMakeLists.txt PRE-CREATION
tests/ExecuteKDEModules/CMakeLists.txt PRE-CREATION
tests/ExecuteKDEModules/main.c PRE-CREATION
tests/FindModules/CMakeLists.txt PRE-CREATION
tests/FindModules/main.c PRE-CREATION
tests/UseFindModules/CMakeLists.txt PRE-CREATION
tests/UseFindModules/main.c PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117658/diff/
Testing
---
Tests pass. Also made a little test that called find_package(Wayland), both
using set(CMAKE_MODULE_PATH ${ECM_FIND_MODULE_DIR}) and using
ecm_use_find_modules(), and Wayland was found both times.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117581: Remove ECMDBusAddActivationService module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/#review56435 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ --- (Updated April 21, 2014, 9:47 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove ECMDBusAddActivationService module ecm_dbus_add_activation_service() requires suffient knowledge of its internals to use that replacing two lines with one seems silly. In order to use it you have to know it behaves like configure_file() (because you have to construct the file yourself), except that it also installs it somewhere (for which you have to make sure DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is certainly not a given for non-KDE projects). By this point, why not just use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR provided by KDEInstallDirs is all the magic you actually need, and if that's explicit in the CMakeLists.txt file, it's a lot more obvious that you should have it defined somewhere. Diffs - docs/module/ECMDBusAddActivationService.rst 2052faebb01ee7085279fe812aa6f7e100830a3c modules/ECMDBusAddActivationService.cmake 128482e35f9f15025868f3e283db839556a0ce82 Diff: https://git.reviewboard.kde.org/r/117581/diff/ Testing --- Built docs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56436 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:49 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- (Updated April 21, 2014, 9:49 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Make ecm_setup_version interact well with CMP0048 When CMake policy CMP0048 (CMake 3.0) is set to NEW, the project() command is meant to manage the project's version variables. We therefore do not set the PROJECT_VERSION variables in this case. To make sure projects do not have to specify their version in multiple places, this also allows the keyword PROJECT to be passed to ecm_setup_version instead of an actual version number. In this case, the version passed to project() will be used. Diffs - modules/ECMSetupVersion.cmake 3ae6fa8f73357f5958de9f54adf083bf6de03df0 modules/ECMVersionHeader.h.in 19eb96c53d3b518df6b364e249707f12892b6893 tests/CMakeLists.txt e464a0305bd71364463c3132103ffe02dcb94eb6 tests/ECMSetupVersionTest/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_header/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_header/main.c PRE-CREATION tests/ECMSetupVersionTest/new_explicit_header_abspath/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_header_abspath/main.c PRE-CREATION tests/ECMSetupVersionTest/new_explicit_simple/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_simple/main.c PRE-CREATION tests/ECMSetupVersionTest/new_explicit_soversion/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_soversion/main.c PRE-CREATION tests/ECMSetupVersionTest/new_explicit_version_file/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_version_file/main.c PRE-CREATION tests/ECMSetupVersionTest/new_explicit_version_file_abspath/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_explicit_version_file_abspath/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_header/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_header/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_header_abspath/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_header_abspath/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_header_prefix/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_header_prefix/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_simple/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_simple/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_simple_prefix/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_simple_prefix/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_soversion/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_soversion/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_soversion_prefix/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_soversion_prefix/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_version_file/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_version_file/main.c PRE-CREATION tests/ECMSetupVersionTest/new_project_version_file_abspath/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/new_project_version_file_abspath/main.c PRE-CREATION tests/ECMSetupVersionTest/old_header/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/old_header/main.c PRE-CREATION tests/ECMSetupVersionTest/old_header_abspath/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/old_header_abspath/main.c PRE-CREATION tests/ECMSetupVersionTest/old_simple/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/old_simple/main.c PRE-CREATION tests/ECMSetupVersionTest/old_soversion/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/old_soversion/main.c PRE-CREATION tests/ECMSetupVersionTest/old_version_file/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/old_version_file/main.c PRE-CREATION tests/ECMSetupVersionTest/old_version_file_abspath/CMakeLists.txt PRE-CREATION tests/ECMSetupVersionTest/old_version_file_abspath/main.c PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117619/diff/ Testing --- Bundled autotests pass. Freshly configured, built and installed KArchive - version header file and KF5ArchiveConfigVersion.cmake correct by
Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/#review56438 --- Same here, looks fine to me, but I'd like Harald to have a bit of time to react. - Kevin Ottens On April 22, 2014, 11:51 p.m., Allen Winter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/ --- (Updated April 22, 2014, 11:51 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald Fernengel. Repository: extra-cmake-modules Description --- Must define _DARWIN_C_SOURCE on the Mac in order to get the declarations for readlink(), setegid(), seteuid(), etc i.e for Single Unix Standard v3 (SUSv3) conformance Diffs - kde-modules/KDECompilerSettings.cmake 229e4f5 Diff: https://git.reviewboard.kde.org/r/117682/diff/ Testing --- works on the Mac didn't break the build on Linux Thanks, Allen Winter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117695: change where dynamic replace tabs is performed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 --- Any chance to have some unit tests? - Kevin Ottens On April 23, 2014, 11:15 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 11:15 a.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs - src/document/katedocument.h 83cc0317e26ef077d5292763d0ba9864103bf454 src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117749: Allow kmimeassociationstest to be run alone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56440 --- Looks fine to me. Let's wait for David though. - Kevin Ottens On April 24, 2014, 5:37 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/ --- (Updated April 24, 2014, 5:37 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Allow kmimeassociationstest to be run alone Previously, it tried to create a KServiceFactory without ensuring the sycoca database had been created, which caused an assert if it had not. It was not caught previously, because make test runs other tests first that generate the sycoca database. Diffs - autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117749/diff/ Testing --- rm -rf ~/.qttest Ran kmimeassociationstest directly. It passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56441 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 10:17 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 10:17 p.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Burkhard Lück. Repository: kdoctools Description --- Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated. Spanish was supplied by apol. Korean was grabbed from the Korean translation of techbase. The remaining ones I just replaced KDE4 with KDE Software (capitalized like that so it is like a coherent term). Translators can touch up the text later if they wish. Diffs - src/customization/es/entities/install-compile.docbook 4f4d2ae58ea8d5eebdfa3264cb3ebee47448cb18 src/customization/ja/entities/install-compile.docbook 4c48271567cea769d680c0306bb61f971059776d src/customization/ko/entities/install-compile.docbook af0546759cddcac69317e56bc375a792c47edd63 src/customization/lt/entities/install-compile.docbook b5ab6962064776c6d34426c0b767bb6a5f97814a src/customization/nds/entities/install-compile.docbook 61b915bd7f8775a4fad9716f68a25b2d2009e866 src/customization/sq/entities/install-compile.docbook 307c30230a3325221322e5462669b6cbb14b2c42 src/customization/sv/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/#review56442 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 11:58 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/ --- (Updated April 23, 2014, 11:58 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Use NETWinInfo instead of custom XLib code in KStartupInfo KStartupInfo had quite a lot of XLib code to read/write properties which are also abstracted by NETWinInfo. This makes the code less dependend on XLib and hopefully easier to read. Diffs - src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117703/diff/ Testing --- Run the unit tests. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117706: remove unused kwallet upgrade script
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/#review56444 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 1:37 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/ --- (Updated April 23, 2014, 1:37 p.m.) Review request for KDE Frameworks and Àlex Fiestas. Repository: kwallet Description --- Remove unused kwallet-4.13.upd from KDE Frameworks 5, it is needed for upgrades from 4.12 to 4.13 but KF5 installs have no previously set config settings. Diffs - src/runtime/kwalletd/CMakeLists.txt d9fb4b3 src/runtime/kwalletd/kwallet-4.13.upd beb51ba Diff: https://git.reviewboard.kde.org/r/117706/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117708: move kioslave docs paths for co-installability
On April 23, 2014, 3:30 p.m., Luigi Toscano wrote: I think after this change many documentation links (at least in khelpcenter) need to be fixed (I can't check now). That'd need to be confirmed before letting this patch in or not. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56293 --- On April 23, 2014, 3:24 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/ --- (Updated April 23, 2014, 3:24 p.m.) Review request for KDE Frameworks. Repository: kio Description --- move kioslave docs path which currently clashes with equivalents from kdelibs4 land. Diffs - docs/kioslave/data/CMakeLists.txt 64ae620 docs/kioslave/file/CMakeLists.txt 42385fb docs/kioslave/ftp/CMakeLists.txt 935298b docs/kioslave/help/CMakeLists.txt cfb29f1 docs/kioslave/help/documentationnotfound/CMakeLists.txt f2bc0b5 docs/kioslave/http/CMakeLists.txt 2aae4fb docs/kioslave/mailto/CMakeLists.txt b0a405e docs/kioslave/telnet/CMakeLists.txt 07b2d33 docs/kioslave/webdav/CMakeLists.txt eb45ed5 src/ioslaves/file/file.protocol 07cd4c3 src/ioslaves/ftp/ftp.protocol 70ddcd0 src/ioslaves/help/help.protocol 1bb5801 src/ioslaves/http/http.protocol 2d97cd4 src/ioslaves/http/https.protocol 62a43ad src/ioslaves/http/webdav.protocol c0fbd11 src/ioslaves/http/webdavs.protocol 7017c24 src/ioslaves/mailto/kmailservice5.desktop 03838a5 src/ioslaves/protocols/data.protocol 2a57b2e src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3 Diff: https://git.reviewboard.kde.org/r/117708/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117749: Allow kmimeassociationstest to be run alone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56447 --- Ship it! Ship It! - David Faure On April 24, 2014, 5:37 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/ --- (Updated April 24, 2014, 5:37 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Allow kmimeassociationstest to be run alone Previously, it tried to create a KServiceFactory without ensuring the sycoca database had been created, which caused an assert if it had not. It was not caught previously, because make test runs other tests first that generate the sycoca database. Diffs - autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117749/diff/ Testing --- rm -rf ~/.qttest Ran kmimeassociationstest directly. It passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56448 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:46 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/ --- (Updated April 24, 2014, 5:46 a.m.) Review request for KDE Frameworks and Thomas Lübking. Repository: kwindowsystem Description --- Improve KStartupInfo::Private::remove_startup_info_internal Uses iterators to check whether startups, silent_startups or unintended_startups contains the id and erases the element. Method is renamed to removeAllStartupInfoInternal to point out the difference to the method which just removes from startups. Diffs - src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb Diff: https://git.reviewboard.kde.org/r/117731/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117708: move kioslave docs paths for co-installability
On April 23, 2014, 5:30 p.m., Luigi Toscano wrote:
I think after this change many documentation links (at least in
khelpcenter) need to be fixed (I can't check now).
Kevin Ottens wrote:
That'd need to be confirmed before letting this patch in or not.
Right: I checked, and all doc/kioslave/foo/CMakeLists.txt have something like:
kdoctools_create_handbook(index.docbook INSTALL_DESTINATION
${HTML_INSTALL_DIR}/en SUBDIR kioslave/ftp)
Similar lines are in other kioslave which will be available in
kioslaves[-extra].
In addition, I think that also the lines like
X-DocPath=kioslave/ioslave/index.html
from src/ioslaves/ioslave/ioslaveprotocol1.protocol
should be fixed as well (Burkhard?).
There are two kioslave references in khelpcenter which could be affected too
(khelpcenter/plugintraverser.cpp khelpcenter/plugins/kioslaves.desktop) but I'm
not sure now.
- Luigi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117708/#review56293
---
On April 23, 2014, 5:24 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117708/
---
(Updated April 23, 2014, 5:24 p.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
move kioslave docs path which currently clashes with equivalents from
kdelibs4 land.
Diffs
-
docs/kioslave/data/CMakeLists.txt 64ae620
docs/kioslave/file/CMakeLists.txt 42385fb
docs/kioslave/ftp/CMakeLists.txt 935298b
docs/kioslave/help/CMakeLists.txt cfb29f1
docs/kioslave/help/documentationnotfound/CMakeLists.txt f2bc0b5
docs/kioslave/http/CMakeLists.txt 2aae4fb
docs/kioslave/mailto/CMakeLists.txt b0a405e
docs/kioslave/telnet/CMakeLists.txt 07b2d33
docs/kioslave/webdav/CMakeLists.txt eb45ed5
src/ioslaves/file/file.protocol 07cd4c3
src/ioslaves/ftp/ftp.protocol 70ddcd0
src/ioslaves/help/help.protocol 1bb5801
src/ioslaves/http/http.protocol 2d97cd4
src/ioslaves/http/https.protocol 62a43ad
src/ioslaves/http/webdav.protocol c0fbd11
src/ioslaves/http/webdavs.protocol 7017c24
src/ioslaves/mailto/kmailservice5.desktop 03838a5
src/ioslaves/protocols/data.protocol 2a57b2e
src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3
Diff: https://git.reviewboard.kde.org/r/117708/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117695: change where dynamic replace tabs is performed
On April 24, 2014, 10:31 p.m., Kevin Ottens wrote: Any chance to have some unit tests? Sure, I'll add some shortly. - Sven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 --- On April 23, 2014, 11:15 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 23, 2014, 11:15 a.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs - src/document/katedocument.h 83cc0317e26ef077d5292763d0ba9864103bf454 src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56458 --- Ship it! OK for me, thanks - Burkhard Lück On April 24, 2014, 10:17 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 10:17 p.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Burkhard Lück. Repository: kdoctools Description --- Update install-compile.docbook translations to not reference KDE4 These are links to techbase. Link text that was already English was just updated. Spanish was supplied by apol. Korean was grabbed from the Korean translation of techbase. The remaining ones I just replaced KDE4 with KDE Software (capitalized like that so it is like a coherent term). Translators can touch up the text later if they wish. Diffs - src/customization/es/entities/install-compile.docbook 4f4d2ae58ea8d5eebdfa3264cb3ebee47448cb18 src/customization/ja/entities/install-compile.docbook 4c48271567cea769d680c0306bb61f971059776d src/customization/ko/entities/install-compile.docbook af0546759cddcac69317e56bc375a792c47edd63 src/customization/lt/entities/install-compile.docbook b5ab6962064776c6d34426c0b767bb6a5f97814a src/customization/nds/entities/install-compile.docbook 61b915bd7f8775a4fad9716f68a25b2d2009e866 src/customization/sq/entities/install-compile.docbook 307c30230a3325221322e5462669b6cbb14b2c42 src/customization/sv/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
