Re: RFC: Do we want the entire commit history to be pushed if code is moved to another repository?
On Sat, Apr 26, 2014 at 7:20 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi everyone, when kdelibs was split into the different frameworks repositories, the git history was dropped. I think that this was a good idea - splitting the history properly would have been an extremely complex task, and everyone who wants to do source code archaelogy can just look at the kdelibs history after all. However, it seems that people follow a different approach now when code is moved to a different repository - the entire history of the code is being re-pushed to the new repository. Examples of this are the move of the about kioslave to kde-baseapps (I noticed it this morning because of all the commit emails I got, many of which are 1-line changes from 2006), and the recent move of kpasswdserver to kio [1]. Just as a quick note, people performing such moves should always talk to sysadmin, irregardless of whether the hooks would allow such moves or not. We can disable those notifications temporarily, which can avoid trauma such as this - be aware that such pushes can also disrupt Bugzilla, Reviewboard, etc. This is inconsistent with the kdelibs approach, and I see several reasons not to do it: 1. It makes using tools like git log, qgit or gitk for browsing the recent history extremely painful if lots of 10-year old commits are shown on top. 2. People who receive commit notification e-mails for a repository get lots of noise in their inbox. OTOH, the only reason to push all those old commits to the new repository would be to make browsing the history easier, but as the kdelibs splitting approach shows, this can also be done in another way. I would like to suggest the following approach for situations like this in the future: If code is moved to a new repository, then the current state of the corresponding directory from repo A is pushed to repo B in a single commit. The commit message should indicate how one can find out about the history of the code, i.e., which repository it is from, and what the commit hash is. Opinions? Thanks and best regards, Frank Thanks, Ben [1] I already asked about this in http://lists.kde.org/?l=kfm-develm=139601591605309w=2 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117781: Install again the content of common/, prepare for other languages too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56593 --- Ship it! Lokks good to me, thanks - Burkhard Lück On April 26, 2014, 1:08 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:08 a.m.) Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Install again common/, but: - under a different prefix - change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/lang/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here. This is the combination of four commits which can be checked here: http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.gita=logh=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7 Commit logs (older first): --- Move the definition of language list to the parent CMakeLists.txt The list can be then reused (namely by common/) --- Move en common doc files to own directory --- Install common doc files for all the languages common/CMakeLists.txt has been completely rewritten; it now supports a set of language directories and all the files included there. Right now only en/ is defined, other common files will be added using the corresponding files from trunk/l10n-kde4/lang/docs/common/ (SVN). --- Enable common/ for a different prefix, adapt kde-chunk.xsl Common files are installed again as it was in kdelibs4, but under a different prefix (kdoctools5-common) to avoid conflicts with the old common directory from kdelibs4. kde-chunk.xsl has been adapted to use this new prefix. Diffs - common/artistic-license.html 2069b4e CMakeLists.txt 3e41a26 common/CMakeLists.txt 4228625 common/block_title_bottom.png c0c0af5 common/block_title_mid.png f1ce933 common/block_title_top.png 2344376 common/bsd-license.html 422bb33 common/en/artistic-license.html PRE-CREATION common/en/block_title_bottom.png PRE-CREATION common/en/block_title_mid.png PRE-CREATION common/en/block_title_top.png PRE-CREATION common/en/bsd-license.html PRE-CREATION common/en/fdl-license.html PRE-CREATION common/en/fdl-notice.html PRE-CREATION common/en/gpl-license.html PRE-CREATION common/en/kde-default.css PRE-CREATION common/en/kde-docs.css PRE-CREATION common/en/kde_logo.png PRE-CREATION common/en/kde_logo_bg.png PRE-CREATION common/en/kmenu.png PRE-CREATION common/en/lgpl-license.html PRE-CREATION common/en/qpl-license.html PRE-CREATION common/en/top-kde.jpg PRE-CREATION common/en/top-left.jpg PRE-CREATION common/en/top-right.jpg PRE-CREATION common/en/top.jpg PRE-CREATION common/en/x11-license.html PRE-CREATION common/en/xml.dcl PRE-CREATION common/fdl-license.html 9ce378a common/fdl-notice.html 862f09e common/gpl-license.html 26ae3af common/kde-default.css 24ef928 common/kde-docs.css 12291a4 common/kde_logo.png 336bfd8 common/kde_logo_bg.png 6cf47f1 common/kmenu.png ff077c2 common/lgpl-license.html 343576d common/qpl-license.html 19a863b common/top-kde.jpg 48967d3 common/top-left.jpg 23c31c7 common/top-right.jpg 22d2a29 common/top.jpg 8be8caa common/x11-license.html 444a27b common/xml.dcl fed2103 src/CMakeLists.txt a2bb02b src/customization/kde-chunk.xsl eda3d38 Diff: https://git.reviewboard.kde.org/r/117781/diff/ Testing --- - The files are installed under the common doc prefix - `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix - `kioclient cat help:/kdoctools5-common/gpl-license.html` works Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Update your copy of extra-cmake-modules
Alex Merry wrote: On 21/04/14 16:26, šumski wrote: On Friday 18 of April 2014 10:37:50 Aurélien Gâteau wrote: ... I made it that way intentionally because I consider it bad to have different code generated depending on whether you have the framework is built from a release tarball or from git. I understand this means more build dependencies for packagers, but I don't see any other way. Understood. Wrt the packaging, that can be more or less bypassed (and i've done so already with openSUSE Qt5 packages), but i was also curious about additional dependencies in general. E.g. with KArchive, previously only QtCore was needed to get it built. Now people will need to build e.g. qtdeclarative and qtwebkit to get qttools, which is now hard requirement for KArchive (note that i haven't checked is ECMCreateQmFromPoFiles added specifically to KArchive, but this is applied to any such Framework). I guess the ideal solution would be to integrate the po-ts conversion into the translation workflow (ie: a job for scripty). That way, qttools is not needed at build time. The build/install process for the l10n modules should still do the conversion, of course, otherwise translators couldn't do their testing properly. But we should ship .ts files with frameworks instead of .po files. Sorry, I am a bit late on this thread. Alex and I discussed this during the KF5 sprint. Shipping .ts would not be good enough since we need to turn them into .qm, and doing so requires lrelease which comes with linguist. For me the short-term fix is for packagers to split the linguist package so that command line tools (lconvert, lupdate, lrelease and Qt5LinguistTools* cmake files) and linguist are in separate packages. The command line tools could then be used as a build dependency without bringing too much with them. The long-term fix would be to get this split upstream in Qt, but that requires some refactoring because linguist and the tools share some code statically. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117777: Make the KSelectionProxyModel unit test pass
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56594 --- Would it be a good idea to start by reverting https://git.reviewboard.kde.org/r/116096/ ? - Stephen Kelly On April 25, 2014, 7:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 25, 2014, 7:18 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs - autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117780: Add a FindKF5.cmake module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/#review56596 --- This review has been submitted with commit 12e3e7e2d6685aa29a487914cb45b27b183866ec by Alex Merry to branch master. - Commit Hook On April 25, 2014, 11:14 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/ --- (Updated April 25, 2014, 11:14 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add a FindKF5.cmake module This allows us to ditch KF5Umbrella. Note that find_package(KF5) calls must not use CONFIG or NO_MODULE (in contrast to previous advice) in order to use this find module. Diffs - docs/find-module/FindKF5.rst PRE-CREATION find-modules/FindKF5.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117780/diff/ Testing --- Built, ran autotests, installed. Removed PREFIX/lib64/cmake/KF5 (ie: KF5Umbrella). Altered KWin to use a single large find_package(KF5) with COMPONENTS and OPTIONAL_COMPONENTS. Tried with everything present, after removing the (optional) KF5Activities cmake config files (from PREFIX/lib64/cmake) and after removing the (required) KF5KIO and KF5XmlGui cmake config files. Behaviour was as expected in all cases, including the feature summary output. Visually inspected generated documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117780: Add a FindKF5.cmake module
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/ --- (Updated April 26, 2014, 9:07 a.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add a FindKF5.cmake module This allows us to ditch KF5Umbrella. Note that find_package(KF5) calls must not use CONFIG or NO_MODULE (in contrast to previous advice) in order to use this find module. Diffs - docs/find-module/FindKF5.rst PRE-CREATION find-modules/FindKF5.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117780/diff/ Testing --- Built, ran autotests, installed. Removed PREFIX/lib64/cmake/KF5 (ie: KF5Umbrella). Altered KWin to use a single large find_package(KF5) with COMPONENTS and OPTIONAL_COMPONENTS. Tried with everything present, after removing the (optional) KF5Activities cmake config files (from PREFIX/lib64/cmake) and after removing the (required) KF5KIO and KF5XmlGui cmake config files. Behaviour was as expected in all cases, including the feature summary output. Visually inspected generated documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
On Saturday 26 April 2014 10:56:00 Kevin Ottens wrote: Hello, On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken as the rest of frameworks ;-)) Thanks for looking into it. I checked with Burkhard Lück too and he said it was fine on the doc side as well. We just ended a clean up pass with Aurélien to make sure it was compliant with all the active policies, so it's now OK on our side as well. As far as I'm concerned it's ready to move in frameworks now. So you know, I got the OK from Ben for an early move as the main stakeholders did their duty of reviewing and we got a sprint going on. David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid hacking in an outdated checkout :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: RFC: Do we want the entire commit history to be pushed if code is moved to another repository?
On Saturday 26 April 2014 09:20:08 Frank Reininghaus wrote: Hi everyone, when kdelibs was split into the different frameworks repositories, the git history was dropped. I think that this was a good idea - splitting the history properly would have been an extremely complex task, and everyone who wants to do source code archaelogy can just look at the kdelibs history after all. ... or they can set up git graft in the framework repos, as documented in the initial commit. Examples of this are the move of the about kioslave to kde-baseapps (I noticed it this morning because of all the commit emails I got, many of which are 1-line changes from 2006), and the recent move of kpasswdserver to kio [1]. This is inconsistent with the kdelibs approach No it's not. This is a different issue: how to *merge* code (with the history) from a module to another. The kdelibs (and qt) splitting is an easier case: making a brand new git module, with history pointing back to the initial module after git graft. , and I see several reasons not to do it: 1. It makes using tools like git log, qgit or gitk for browsing the recent history extremely painful if lots of 10-year old commits are shown on top. It will do the same in any framework if you set up git graft. But yes, at least that is optional, while the history brought over when moving subdirs is not. 2. People who receive commit notification e-mails for a repository get lots of noise in their inbox. Yeah there's a bug somewhere, I'm not sure why I got some emails in my inbox (as opposed to properly filtered). OTOH, the only reason to push all those old commits to the new repository would be to make browsing the history easier, but as the kdelibs splitting approach shows, this can also be done in another way. Finding the old module will be kind of hard in the far future, unless it's very well documented in the initial commit, as you suggest below. I would like to suggest the following approach for situations like this in the future: If code is moved to a new repository, then the current state of the corresponding directory from repo A is pushed to repo B in a single commit. The commit message should indicate how one can find out about the history of the code, i.e., which repository it is from, and what the commit hash is. I would be OK with that, I guess. But I'll let those who do the work (e.g. Alex Merry) have the final word. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117777: Make the KSelectionProxyModel unit test pass
On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: Would it be a good idea to start by reverting https://git.reviewboard.kde.org/r/116096/ ? Alex Merry wrote: So we have no unit tests? I don't really see how that would help (except in the strict sense of no unit tests = no failing unit tests). Stephen Kelly wrote: I meant considering the problem again as it was before that patch - namely doing a proper merge of the two versions. Is that what this patch does? Is it a full merge? Yes, the first two commits merge the two versions (by reapplying all the changes you made on top of the new one). The third commit alters KSelectionProxyModel. Would it be less confusing as two reviews? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56594 --- On April 25, 2014, 7:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 25, 2014, 7:18 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs - autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $
On April 23, 2014, 5:09 p.m., David Faure wrote:
The reason I did it this way was because existing application code uses
#include kjsembed/kjsembed.h
#include kjsembed/qobject_binding.h
etc.
See e.g.
http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4
So I picked the namespaced framework setup, where lowercase headers go to
include/KF5/FrameworkName/lower/lower.h and forwarding headers go to
include/KF5/FrameworkName/Camelcase/Camelcase. KParts does the same, for
instance, with e.g. include/KF5/KParts/kparts/event.h and
include/KF5/KParts/KParts/Event.
So why is this a problem for kjsembed and not for kparts? Ah, I see. The
forwarding header is supposed to go under a camelcase subdir (like it does
in kparts). KParts/KParts/Event looks confusing, but a better example where
the framework name differs from the namespace is KIOCore/KIO/Job.
So this should be the fix you need:
-install(FILES ${KJsEmbed_CamelCase_HEADERS} DESTINATION
${INCLUDE_INSTALL_DIR}/KJsEmbed COMPONENT Devel)
+install(FILES ${KJsEmbed_CamelCase_HEADERS} DESTINATION
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed COMPONENT Devel)
+1, this would make it work the same as KParts.
Resulting in include/KF5/KJsEmbed/KJsEmbed/KJsEmbed. Do we have projects
including only KJsEmbed? In this case we'd have to introduce an interface for
KJsEmbed/KJsEmbed.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review56306
---
On April 21, 2014, 1:59 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
(Updated April 21, 2014, 1:59 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $
On April 23, 2014, 5:09 p.m., David Faure wrote:
The reason I did it this way was because existing application code uses
#include kjsembed/kjsembed.h
#include kjsembed/qobject_binding.h
etc.
See e.g.
http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4
So I picked the namespaced framework setup, where lowercase headers go to
include/KF5/FrameworkName/lower/lower.h and forwarding headers go to
include/KF5/FrameworkName/Camelcase/Camelcase. KParts does the same, for
instance, with e.g. include/KF5/KParts/kparts/event.h and
include/KF5/KParts/KParts/Event.
So why is this a problem for kjsembed and not for kparts? Ah, I see. The
forwarding header is supposed to go under a camelcase subdir (like it does
in kparts). KParts/KParts/Event looks confusing, but a better example where
the framework name differs from the namespace is KIOCore/KIO/Job.
So this should be the fix you need:
-install(FILES ${KJsEmbed_CamelCase_HEADERS} DESTINATION
${INCLUDE_INSTALL_DIR}/KJsEmbed COMPONENT Devel)
+install(FILES ${KJsEmbed_CamelCase_HEADERS} DESTINATION
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed COMPONENT Devel)
Aleix Pol Gonzalez wrote:
+1, this would make it work the same as KParts.
Resulting in include/KF5/KJsEmbed/KJsEmbed/KJsEmbed. Do we have projects
including only KJsEmbed? In this case we'd have to introduce an interface
for KJsEmbed/KJsEmbed.
I checked, and I couldn't see any such #include statement.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review56306
---
On April 26, 2014, 10:41 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
(Updated April 26, 2014, 10:41 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
(Updated April 26, 2014, 10:41 a.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review56610 --- This review has been submitted with commit 669a089e8cbb3c15a0d3b7fac1dcb11d1531bb25 by David Faure to branch master. - Commit Hook On April 23, 2014, 4:26 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 23, 2014, 4:26 p.m.) Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 26, 2014, 11:21 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: ktexteditor_master_qt5 #371
See http://build.kde.org/job/ktexteditor_master_qt5/371/changes Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [faure] cleanup after non-idempotent script -- [...truncated 416 lines...] Removing autotests/input/indent/ruby/basic3/actual Removing autotests/input/indent/ruby/basic4/actual Removing autotests/input/indent/ruby/block-comment1/actual Removing autotests/input/indent/ruby/block-comment2/actual Removing autotests/input/indent/ruby/block-comment3/actual Removing autotests/input/indent/ruby/block-comment4/actual Removing autotests/input/indent/ruby/block-comment5/actual Removing autotests/input/indent/ruby/block-comment6/actual Removing autotests/input/indent/ruby/block-comment7/actual Removing autotests/input/indent/ruby/block-comment8/actual Removing autotests/input/indent/ruby/block01/actual Removing autotests/input/indent/ruby/block02/actual Removing autotests/input/indent/ruby/comment1/actual Removing autotests/input/indent/ruby/comment2/actual Removing autotests/input/indent/ruby/comment3/actual Removing autotests/input/indent/ruby/comment4/actual Removing autotests/input/indent/ruby/comment5/actual Removing autotests/input/indent/ruby/comment6/actual Removing autotests/input/indent/ruby/do1/actual Removing autotests/input/indent/ruby/do2/actual Removing autotests/input/indent/ruby/do3/actual Removing autotests/input/indent/ruby/do4/actual Removing autotests/input/indent/ruby/do5/actual Removing autotests/input/indent/ruby/do6/actual Removing autotests/input/indent/ruby/do7/actual Removing autotests/input/indent/ruby/empty-file1/actual Removing autotests/input/indent/ruby/hash1/actual Removing autotests/input/indent/ruby/hash10/actual Removing autotests/input/indent/ruby/hash11/actual Removing autotests/input/indent/ruby/hash12/actual Removing autotests/input/indent/ruby/hash16/actual Removing autotests/input/indent/ruby/hash17/actual Removing autotests/input/indent/ruby/hash18/actual Removing autotests/input/indent/ruby/hash19/actual Removing autotests/input/indent/ruby/hash2/actual Removing autotests/input/indent/ruby/hash20/actual Removing autotests/input/indent/ruby/hash21/actual Removing autotests/input/indent/ruby/hash22/actual Removing autotests/input/indent/ruby/hash3/actual Removing autotests/input/indent/ruby/hash4/actual Removing autotests/input/indent/ruby/hash5/actual Removing autotests/input/indent/ruby/hash6/actual Removing autotests/input/indent/ruby/hash7/actual Removing autotests/input/indent/ruby/hash8/actual Removing autotests/input/indent/ruby/hash9/actual Removing autotests/input/indent/ruby/heredoc1/actual Removing autotests/input/indent/ruby/heredoc2/actual Removing autotests/input/indent/ruby/heredoc3/actual Removing autotests/input/indent/ruby/heredoc4/actual Removing autotests/input/indent/ruby/heredoc5/actual Removing autotests/input/indent/ruby/heredoc6/actual Removing autotests/input/indent/ruby/if10/actual Removing autotests/input/indent/ruby/if11/actual Removing autotests/input/indent/ruby/if20/actual Removing autotests/input/indent/ruby/if21/actual Removing autotests/input/indent/ruby/if22/actual Removing autotests/input/indent/ruby/if30/actual Removing autotests/input/indent/ruby/if31/actual Removing autotests/input/indent/ruby/multiline1/actual Removing autotests/input/indent/ruby/multiline10/actual Removing autotests/input/indent/ruby/multiline2/actual Removing autotests/input/indent/ruby/multiline3/actual Removing autotests/input/indent/ruby/multiline4/actual Removing autotests/input/indent/ruby/multiline5/actual Removing autotests/input/indent/ruby/multiline6/actual Removing autotests/input/indent/ruby/multiline7/actual Removing autotests/input/indent/ruby/multiline8/actual Removing autotests/input/indent/ruby/multiline9/actual Removing autotests/input/indent/ruby/no-do1/actual Removing autotests/input/indent/ruby/no-do2/actual Removing autotests/input/indent/ruby/no-do3/actual Removing autotests/input/indent/ruby/no-do4/actual Removing autotests/input/indent/ruby/ops1/actual Removing autotests/input/indent/ruby/ops11/actual Removing autotests/input/indent/ruby/ops12/actual Removing autotests/input/indent/ruby/ops13/actual Removing autotests/input/indent/ruby/ops14/actual Removing autotests/input/indent/ruby/ops15/actual Removing autotests/input/indent/ruby/ops16/actual Removing autotests/input/indent/ruby/ops17/actual Removing autotests/input/indent/ruby/ops18/actual Removing autotests/input/indent/ruby/ops2/actual Removing autotests/input/indent/ruby/ops21/actual Removing autotests/input/indent/ruby/ops22/actual Removing autotests/input/indent/ruby/ops23/actual Removing autotests/input/indent/ruby/ops24/actual Removing autotests/input/indent/ruby/ops25/actual Removing autotests/input/indent/ruby/ops26/actual Removing
Build failed in Jenkins: kwallet_master_qt5 #95
See http://build.kde.org/job/kwallet_master_qt5/95/changes Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/kwallet_master_qt5/ws/ Running Prebuild steps [kwallet_master_qt5] $ /bin/sh -xe /tmp/hudson8100827494708825352.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/kwallet 67665f3..e03d367 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 67665f3 Move include(ECMSetupVersion) to top-level CMakeLists.txt Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@7914622b Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/kwallet Checking out Revision e03d367bce33ced6a012c2fde522b2da4f19faa1 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [kwallet_master_qt5] $ /bin/sh -xe /tmp/hudson6399731197696657411.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: kwallet - Branch master == Build Dependencies: cmake - Branch master kcodecs - Branch master kwindowsystem - Branch master kdbusaddons - Branch master kcoreaddons - Branch master kiconthemes - Branch master kconfigwidgets - Branch master kwidgetsaddons - Branch master qt5 - Branch stable extra-cmake-modules - Branch master karchive - Branch master kitemviews - Branch master kdoctools - Branch master knotifications - Branch master polkit-qt-1 - Branch qt5 kguiaddons - Branch master kservice - Branch master kauth - Branch master kcrash - Branch master ki18n - Branch master phonon - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Error at src/runtime/kwalletd/CMakeLists.txt:8 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.98.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.97.0 -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/kwallet_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project kwallet. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #50
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #308
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/308/changes Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS -- Started by upstream project plasma-framework_master_qt5 build number 308 originally caused by: Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson4903323055679360033.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework abee1e2..e673128 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at abee1e2 Rename the yaml file per new policy Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@6682f59 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 2ef3b32dcdb71563072e8cd6a88838257f013808 (refs/heads/jenkins) [LINBUILDER] $ /bin/sh -xe /tmp/hudson3260001265431151044.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master kjs - Branch master kross - Branch master sonnet - Branch master kdnssd - Branch master ktextwidgets - Branch master threadweaver - Branch master kcodecs - Branch master kwindowsystem - Branch master kdbusaddons - Branch master kwallet - Branch master kcoreaddons - Branch master kactivities - Branch master kiconthemes - Branch master kitemviews - Branch master kcompletion - Branch master kconfigwidgets - Branch master kio - Branch master ktexteditor - Branch master kwidgetsaddons - Branch master kparts - Branch master solid - Branch master kdeclarative - Branch master kitemmodels - Branch master qt5 - Branch stable extra-cmake-modules - Branch master karchive - Branch master kauth - Branch master kdoctools - Branch master kglobalaccel - Branch master knotifications - Branch master kidletime - Branch master phonon - Branch master kunitconversion - Branch master polkit-qt-1 - Branch qt5 kguiaddons - Branch master kservice - Branch master kjobwidgets - Branch master kcrash - Branch master cmake - Branch master kxmlgui - Branch master ki18n - Branch master kbookmarks - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found XCB_XCB: /usr/lib64/libxcb.so (found version 1.9) -- Found XCB_RENDER: /usr/lib64/libxcb-render.so (found version 1.9) -- Found XCB_SHAPE: /usr/lib64/libxcb-shape.so (found version 1.9) -- Found XCB_XFIXES: /usr/lib64/libxcb-xfixes.so (found version 1.9) -- Found XCB_COMPOSITE: /usr/lib64/libxcb-composite.so (found version 1.9) -- Found XCB_DAMAGE: /usr/lib64/libxcb-damage.so (found version 1.9) -- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-render.so;/usr/lib64/libxcb-shape.so;/usr/lib64/libxcb-xfixes.so;/usr/lib64/libxcb-composite.so;/usr/lib64/libxcb-damage.so (found version 1.9) found components: XCB COMPOSITE DAMAGE SHAPE XFIXES RENDER -- Found OpenGL: /usr/lib64/libGL.so -- Found EGL: /usr/lib64/libEGL.so (found version 1.4) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success --
Build failed in Jenkins: frameworkintegration_master_qt5 #64
See http://build.kde.org/job/frameworkintegration_master_qt5/64/changes Changes: [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/frameworkintegration_master_qt5/ws/ Running Prebuild steps [frameworkintegration_master_qt5] $ /bin/sh -xe /tmp/hudson794061573243012.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/frameworkintegration 0a1feb1..1338aaf master - origin/master * [new tag] v4.98.0- v4.98.0 Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 0a1feb1 Upgrade ECM version requirement and KF5 version. Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@7aa0ebdf Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/frameworkintegration Checking out Revision 1338aaf3aac39b2da974238ab5108ac8cf1c9af9 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [frameworkintegration_master_qt5] $ /bin/sh -xe /tmp/hudson4265960848907465447.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: frameworkintegration - Branch master == Build Dependencies: kiconthemes - Branch master kbookmarks - Branch master kcrash - Branch master attica - Branch master ktextwidgets - Branch master kwindowsystem - Branch master kwallet - Branch master qt5 - Branch stable kservice - Branch master kdoctools - Branch master kcompletion - Branch master kjobwidgets - Branch master kio - Branch master kcodecs - Branch master extra-cmake-modules - Branch master kdbusaddons - Branch master knotifications - Branch master kcoreaddons - Branch master polkit-qt-1 - Branch qt5 kwidgetsaddons - Branch master sonnet - Branch master kconfigwidgets - Branch master kglobalaccel - Branch master karchive - Branch master kconfig - Branch master phonon - Branch master solid - Branch master kguiaddons - Branch master cmake - Branch master kauth - Branch master ki18n - Branch master kitemviews - Branch master kxmlgui - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at CMakeLists.txt:35 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.98.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.97.0 -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/frameworkintegration_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project frameworkintegration. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs4support_master_qt5 #146
See http://build.kde.org/job/kdelibs4support_master_qt5/146/changes Changes: [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [aleixpol] Add l10n to be installed [aleixpol] Cannot rename 2 things in 1 call [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/kdelibs4support_master_qt5/ws/ Running Prebuild steps [kdelibs4support_master_qt5] $ /bin/sh -xe /tmp/hudson2259395103493941681.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/kdelibs4support c249f5b..1a811f8 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at c249f5b Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@66dd122d Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/kdelibs4support Checking out Revision 1a811f8dd576fd658018199c82716e37956330a9 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [kdelibs4support_master_qt5] $ /bin/sh -xe /tmp/hudson957618561027515806.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: kdelibs4support - Branch master == Build Dependencies: kconfig - Branch master kinit - Branch master sonnet - Branch master kcrash - Branch master cmake - Branch master kiconthemes - Branch master kbookmarks - Branch master ktextwidgets - Branch master kwallet - Branch master qt5 - Branch stable kdewebkit - Branch master kservice - Branch master kdoctools - Branch master kcompletion - Branch master kjobwidgets - Branch master kio - Branch master kcodecs - Branch master kwidgetsaddons - Branch master kdbusaddons - Branch master attica - Branch master kcoreaddons - Branch master polkit-qt-1 - Branch qt5 knotifications - Branch master kconfigwidgets - Branch master kglobalaccel - Branch master karchive - Branch master phonon - Branch master kxmlgui - Branch master kwindowsystem - Branch master solid - Branch master kguiaddons - Branch master extra-cmake-modules - Branch master kauth - Branch master kitemviews - Branch master ki18n - Branch master kparts - Branch master kplotting - Branch master kdesignerplugin - Branch master kunitconversion - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at CMakeLists.txt:32 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.98.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.97.0 -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/kdelibs4support_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project kdelibs4support. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org
Build failed in Jenkins: khtml_master_qt5 #76
See http://build.kde.org/job/khtml_master_qt5/76/changes Changes: [aleixpol] flag.png was renamed to kf5_flag.png [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/khtml_master_qt5/ws/ Running Prebuild steps [khtml_master_qt5] $ /bin/sh -xe /tmp/hudson6339061985231626337.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/khtml d17ea2c..043e353 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at d17ea2c separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@7e618d41 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/khtml Checking out Revision 043e3536a445ecd7cf09fb70d63c4eea652e62df (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [khtml_master_qt5] $ /bin/sh -xe /tmp/hudson2452450995742837008.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: khtml - Branch master == Build Dependencies: kcodecs - Branch master kiconthemes - Branch master kcoreaddons - Branch master ktextwidgets - Branch master kconfig - Branch master kjobwidgets - Branch master kauth - Branch master cmake - Branch master kparts - Branch master kdbusaddons - Branch master polkit-qt-1 - Branch qt5 kwidgetsaddons - Branch master kwallet - Branch master qt5 - Branch stable extra-cmake-modules - Branch master kjs - Branch master karchive - Branch master kconfigwidgets - Branch master solid - Branch master kio - Branch master kdoctools - Branch master attica - Branch master sonnet - Branch master phonon - Branch master knotifications - Branch master kitemviews - Branch master kcrash - Branch master kglobalaccel - Branch master kwindowsystem - Branch master kxmlgui - Branch master kservice - Branch master kguiaddons - Branch master kinit - Branch master kbookmarks - Branch master kcompletion - Branch master ki18n - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at CMakeLists.txt:28 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.98.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.97.0 -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/khtml_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project khtml. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kmediaplayer_master_qt5 #42
See http://build.kde.org/job/kmediaplayer_master_qt5/42/changes Changes: [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/kmediaplayer_master_qt5/ws/ Running Prebuild steps [kmediaplayer_master_qt5] $ /bin/sh -xe /tmp/hudson699880103194183484.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/kmediaplayer 1c3f27c..6467553 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 1c3f27c separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@4346e138 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/kmediaplayer Checking out Revision 64675539df32da42cd577fcfc6be461a512f97b3 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [kmediaplayer_master_qt5] $ /bin/sh -xe /tmp/hudson5938433479406492722.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: kmediaplayer - Branch master == Build Dependencies: ktextwidgets - Branch master sonnet - Branch master kcompletion - Branch master cmake - Branch master kiconthemes - Branch master knotifications - Branch master kparts - Branch master kwallet - Branch master qt5 - Branch stable kservice - Branch master kdoctools - Branch master kcrash - Branch master kjobwidgets - Branch master kio - Branch master kcodecs - Branch master extra-cmake-modules - Branch master kdbusaddons - Branch master attica - Branch master kcoreaddons - Branch master polkit-qt-1 - Branch qt5 kconfigwidgets - Branch master kglobalaccel - Branch master karchive - Branch master kxmlgui - Branch master kwindowsystem - Branch master solid - Branch master kguiaddons - Branch master kwidgetsaddons - Branch master kbookmarks - Branch master phonon - Branch master kauth - Branch master kitemviews - Branch master ki18n - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible with requested version 4.98.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 4.97.0 Call Stack (most recent call first): /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kparts/inst/lib64/cmake/KF5Parts/KF5PartsConfig.cmake:69 (find_dependency) CMakeLists.txt:46 (find_package) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/kmediaplayer_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project kmediaplayer. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #51
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kio_master_qt5 #168
See http://build.kde.org/job/kio_master_qt5/168/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #309
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/309/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : frameworkintegration_master_qt5 #65
See http://build.kde.org/job/frameworkintegration_master_qt5/65/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Infopage in frameworkintegration
FrameworkIntegration installs a bunch of images and css files to
${DATA_INSTALL_DIR}/kf5/infopage. LXR suggests nothing ever references
an infopage directory (either in kf5-qt5 or in qt4-latest), except for
the CMakeLists.txt files in frameworkintegration, and the README.md
(which suggests the images are for info pages for applications).
Are these for GNU Info documentation? Are they actually used anywhere?
Does anyone know whether they have any use?
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Why is plasma-framework using /usr/share/kde5?
On Tuesday 22 April 2014 10:40:45 Daniel Vrátil wrote: On Monday 21 of April 2014 17:32:10 you wrote: On Tuesday 15 April 2014 18:14:36 Daniel Vrátil wrote: Hi, I'm wondering why Plasma Framework installs it's .desktop files to /usr/share/kde5 by default? It causes some confusion for packagers: No other framework is using a namespace in /usr/share, they all install into /usr/share/$FrameworkName. I don't see that here. $ find /d/kde/inst/kde_frameworks -name services /d/kde/inst/kde_frameworks/share/plasma/services /d/kde/inst/kde_frameworks/share/kde5/services /d/kde/inst/kde_frameworks/share/dbus-1/services /d/kde/inst/kde_frameworks/share/konqsidebartng/virtual_folders/services The first one, plasma/services, only has some *.operations files. The second one, share/kde5/services/, has all the Type=Service .desktop files from many places (khtml, plasma, kate, baloo, kdevelop, kcm). So this seems consistent to me (unlike your description). I find the inconsistency in some Framework(s?) using a kde5 (or kf5, does not matter) directory namespace, while others don't. Either all frameworks should install to /usr/share/kf5/$framework, or none should. OK. Alex Merry, Aleix Pol and I just had a long discussion about install directories, and we have plans for a number of changes. We included your concern in the discussion, and to make it easier to co- install frameworks (5 and 6), we'll have a KF5_DATA_INSTALL_DIR pointing to share/kf5. The alternative would have been sonnet5, khtml5, kxmlgui5 subdirs, it's easier to just have a kf5 parent. Note however that this is only for frameworks. Apps don't need co-installation, so e.g. share/kate is fine. Sort of. If you want to develop an application that depends on KService only, why should it use /usr/share/kde5/services if it has nothing to do with KDE? We'll rename it to kservices5. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
On Saturday, April 26, 2014, David Faure fa...@kde.org wrote: David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid hacking in an outdated checkout :) Awesome, thanks :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review request: kdeebugdialog5 co-installability
On Thursday 24 April 2014 14:49:00 Jonathan Riddell wrote: Reviewboard does not like this patch and even my usual goto man for git help agateau can't work out why. So here's a manual review request kdelibs4support: http://starsky.19inch.net/~jr/tmp/DIFF This seems to be about oxygen rather than kdebugdialog. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117781: Install again the content of common/, prepare for other languages too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Install again common/, but: - under a different prefix - change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/lang/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here. This is the combination of four commits which can be checked here: http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.gita=logh=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7 Commit logs (older first): --- Move the definition of language list to the parent CMakeLists.txt The list can be then reused (namely by common/) --- Move en common doc files to own directory --- Install common doc files for all the languages common/CMakeLists.txt has been completely rewritten; it now supports a set of language directories and all the files included there. Right now only en/ is defined, other common files will be added using the corresponding files from trunk/l10n-kde4/lang/docs/common/ (SVN). --- Enable common/ for a different prefix, adapt kde-chunk.xsl Common files are installed again as it was in kdelibs4, but under a different prefix (kdoctools5-common) to avoid conflicts with the old common directory from kdelibs4. kde-chunk.xsl has been adapted to use this new prefix. Diffs - common/artistic-license.html 2069b4e CMakeLists.txt 3e41a26 common/CMakeLists.txt 4228625 common/block_title_bottom.png c0c0af5 common/block_title_mid.png f1ce933 common/block_title_top.png 2344376 common/bsd-license.html 422bb33 common/en/artistic-license.html PRE-CREATION common/en/block_title_bottom.png PRE-CREATION common/en/block_title_mid.png PRE-CREATION common/en/block_title_top.png PRE-CREATION common/en/bsd-license.html PRE-CREATION common/en/fdl-license.html PRE-CREATION common/en/fdl-notice.html PRE-CREATION common/en/gpl-license.html PRE-CREATION common/en/kde-default.css PRE-CREATION common/en/kde-docs.css PRE-CREATION common/en/kde_logo.png PRE-CREATION common/en/kde_logo_bg.png PRE-CREATION common/en/kmenu.png PRE-CREATION common/en/lgpl-license.html PRE-CREATION common/en/qpl-license.html PRE-CREATION common/en/top-kde.jpg PRE-CREATION common/en/top-left.jpg PRE-CREATION common/en/top-right.jpg PRE-CREATION common/en/top.jpg PRE-CREATION common/en/x11-license.html PRE-CREATION common/en/xml.dcl PRE-CREATION common/fdl-license.html 9ce378a common/fdl-notice.html 862f09e common/gpl-license.html 26ae3af common/kde-default.css 24ef928 common/kde-docs.css 12291a4 common/kde_logo.png 336bfd8 common/kde_logo_bg.png 6cf47f1 common/kmenu.png ff077c2 common/lgpl-license.html 343576d common/qpl-license.html 19a863b common/top-kde.jpg 48967d3 common/top-left.jpg 23c31c7 common/top-right.jpg 22d2a29 common/top.jpg 8be8caa common/x11-license.html 444a27b common/xml.dcl fed2103 src/CMakeLists.txt a2bb02b src/customization/kde-chunk.xsl eda3d38 Diff: https://git.reviewboard.kde.org/r/117781/diff/ Testing --- - The files are installed under the common doc prefix - `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix - `kioclient cat help:/kdoctools5-common/gpl-license.html` works Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117781: Install again the content of common/, prepare for other languages too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56620 --- This review has been submitted with commit fd96fa5b175d965bbe9655ef36bbd9728f946ab2 by Luigi Toscano to branch master. - Commit Hook On April 26, 2014, 1:08 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:08 a.m.) Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Install again common/, but: - under a different prefix - change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/lang/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here. This is the combination of four commits which can be checked here: http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.gita=logh=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7 Commit logs (older first): --- Move the definition of language list to the parent CMakeLists.txt The list can be then reused (namely by common/) --- Move en common doc files to own directory --- Install common doc files for all the languages common/CMakeLists.txt has been completely rewritten; it now supports a set of language directories and all the files included there. Right now only en/ is defined, other common files will be added using the corresponding files from trunk/l10n-kde4/lang/docs/common/ (SVN). --- Enable common/ for a different prefix, adapt kde-chunk.xsl Common files are installed again as it was in kdelibs4, but under a different prefix (kdoctools5-common) to avoid conflicts with the old common directory from kdelibs4. kde-chunk.xsl has been adapted to use this new prefix. Diffs - common/artistic-license.html 2069b4e CMakeLists.txt 3e41a26 common/CMakeLists.txt 4228625 common/block_title_bottom.png c0c0af5 common/block_title_mid.png f1ce933 common/block_title_top.png 2344376 common/bsd-license.html 422bb33 common/en/artistic-license.html PRE-CREATION common/en/block_title_bottom.png PRE-CREATION common/en/block_title_mid.png PRE-CREATION common/en/block_title_top.png PRE-CREATION common/en/bsd-license.html PRE-CREATION common/en/fdl-license.html PRE-CREATION common/en/fdl-notice.html PRE-CREATION common/en/gpl-license.html PRE-CREATION common/en/kde-default.css PRE-CREATION common/en/kde-docs.css PRE-CREATION common/en/kde_logo.png PRE-CREATION common/en/kde_logo_bg.png PRE-CREATION common/en/kmenu.png PRE-CREATION common/en/lgpl-license.html PRE-CREATION common/en/qpl-license.html PRE-CREATION common/en/top-kde.jpg PRE-CREATION common/en/top-left.jpg PRE-CREATION common/en/top-right.jpg PRE-CREATION common/en/top.jpg PRE-CREATION common/en/x11-license.html PRE-CREATION common/en/xml.dcl PRE-CREATION common/fdl-license.html 9ce378a common/fdl-notice.html 862f09e common/gpl-license.html 26ae3af common/kde-default.css 24ef928 common/kde-docs.css 12291a4 common/kde_logo.png 336bfd8 common/kde_logo_bg.png 6cf47f1 common/kmenu.png ff077c2 common/lgpl-license.html 343576d common/qpl-license.html 19a863b common/top-kde.jpg 48967d3 common/top-left.jpg 23c31c7 common/top-right.jpg 22d2a29 common/top.jpg 8be8caa common/x11-license.html 444a27b common/xml.dcl fed2103 src/CMakeLists.txt a2bb02b src/customization/kde-chunk.xsl eda3d38 Diff: https://git.reviewboard.kde.org/r/117781/diff/ Testing --- - The files are installed under the common doc prefix - `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix - `kioclient cat help:/kdoctools5-common/gpl-license.html` works Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117781: Install again the content of common/, prepare for other languages too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56619 --- This review has been submitted with commit 75ba2ae6c1f35056cbb03de008c3605e10b9990e by Luigi Toscano to branch master. - Commit Hook On April 26, 2014, 1:08 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:08 a.m.) Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Install again common/, but: - under a different prefix - change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/lang/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here. This is the combination of four commits which can be checked here: http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.gita=logh=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7 Commit logs (older first): --- Move the definition of language list to the parent CMakeLists.txt The list can be then reused (namely by common/) --- Move en common doc files to own directory --- Install common doc files for all the languages common/CMakeLists.txt has been completely rewritten; it now supports a set of language directories and all the files included there. Right now only en/ is defined, other common files will be added using the corresponding files from trunk/l10n-kde4/lang/docs/common/ (SVN). --- Enable common/ for a different prefix, adapt kde-chunk.xsl Common files are installed again as it was in kdelibs4, but under a different prefix (kdoctools5-common) to avoid conflicts with the old common directory from kdelibs4. kde-chunk.xsl has been adapted to use this new prefix. Diffs - common/artistic-license.html 2069b4e CMakeLists.txt 3e41a26 common/CMakeLists.txt 4228625 common/block_title_bottom.png c0c0af5 common/block_title_mid.png f1ce933 common/block_title_top.png 2344376 common/bsd-license.html 422bb33 common/en/artistic-license.html PRE-CREATION common/en/block_title_bottom.png PRE-CREATION common/en/block_title_mid.png PRE-CREATION common/en/block_title_top.png PRE-CREATION common/en/bsd-license.html PRE-CREATION common/en/fdl-license.html PRE-CREATION common/en/fdl-notice.html PRE-CREATION common/en/gpl-license.html PRE-CREATION common/en/kde-default.css PRE-CREATION common/en/kde-docs.css PRE-CREATION common/en/kde_logo.png PRE-CREATION common/en/kde_logo_bg.png PRE-CREATION common/en/kmenu.png PRE-CREATION common/en/lgpl-license.html PRE-CREATION common/en/qpl-license.html PRE-CREATION common/en/top-kde.jpg PRE-CREATION common/en/top-left.jpg PRE-CREATION common/en/top-right.jpg PRE-CREATION common/en/top.jpg PRE-CREATION common/en/x11-license.html PRE-CREATION common/en/xml.dcl PRE-CREATION common/fdl-license.html 9ce378a common/fdl-notice.html 862f09e common/gpl-license.html 26ae3af common/kde-default.css 24ef928 common/kde-docs.css 12291a4 common/kde_logo.png 336bfd8 common/kde_logo_bg.png 6cf47f1 common/kmenu.png ff077c2 common/lgpl-license.html 343576d common/qpl-license.html 19a863b common/top-kde.jpg 48967d3 common/top-left.jpg 23c31c7 common/top-right.jpg 22d2a29 common/top.jpg 8be8caa common/x11-license.html 444a27b common/xml.dcl fed2103 src/CMakeLists.txt a2bb02b src/customization/kde-chunk.xsl eda3d38 Diff: https://git.reviewboard.kde.org/r/117781/diff/ Testing --- - The files are installed under the common doc prefix - `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix - `kioclient cat help:/kdoctools5-common/gpl-license.html` works Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117781: Install again the content of common/, prepare for other languages too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56622 --- This review has been submitted with commit 1cd33b3cad5c9a38d39655a39aac911ed7b334f8 by Luigi Toscano to branch master. - Commit Hook On April 26, 2014, 1:08 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:08 a.m.) Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Install again common/, but: - under a different prefix - change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/lang/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here. This is the combination of four commits which can be checked here: http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.gita=logh=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7 Commit logs (older first): --- Move the definition of language list to the parent CMakeLists.txt The list can be then reused (namely by common/) --- Move en common doc files to own directory --- Install common doc files for all the languages common/CMakeLists.txt has been completely rewritten; it now supports a set of language directories and all the files included there. Right now only en/ is defined, other common files will be added using the corresponding files from trunk/l10n-kde4/lang/docs/common/ (SVN). --- Enable common/ for a different prefix, adapt kde-chunk.xsl Common files are installed again as it was in kdelibs4, but under a different prefix (kdoctools5-common) to avoid conflicts with the old common directory from kdelibs4. kde-chunk.xsl has been adapted to use this new prefix. Diffs - common/artistic-license.html 2069b4e CMakeLists.txt 3e41a26 common/CMakeLists.txt 4228625 common/block_title_bottom.png c0c0af5 common/block_title_mid.png f1ce933 common/block_title_top.png 2344376 common/bsd-license.html 422bb33 common/en/artistic-license.html PRE-CREATION common/en/block_title_bottom.png PRE-CREATION common/en/block_title_mid.png PRE-CREATION common/en/block_title_top.png PRE-CREATION common/en/bsd-license.html PRE-CREATION common/en/fdl-license.html PRE-CREATION common/en/fdl-notice.html PRE-CREATION common/en/gpl-license.html PRE-CREATION common/en/kde-default.css PRE-CREATION common/en/kde-docs.css PRE-CREATION common/en/kde_logo.png PRE-CREATION common/en/kde_logo_bg.png PRE-CREATION common/en/kmenu.png PRE-CREATION common/en/lgpl-license.html PRE-CREATION common/en/qpl-license.html PRE-CREATION common/en/top-kde.jpg PRE-CREATION common/en/top-left.jpg PRE-CREATION common/en/top-right.jpg PRE-CREATION common/en/top.jpg PRE-CREATION common/en/x11-license.html PRE-CREATION common/en/xml.dcl PRE-CREATION common/fdl-license.html 9ce378a common/fdl-notice.html 862f09e common/gpl-license.html 26ae3af common/kde-default.css 24ef928 common/kde-docs.css 12291a4 common/kde_logo.png 336bfd8 common/kde_logo_bg.png 6cf47f1 common/kmenu.png ff077c2 common/lgpl-license.html 343576d common/qpl-license.html 19a863b common/top-kde.jpg 48967d3 common/top-left.jpg 23c31c7 common/top-right.jpg 22d2a29 common/top.jpg 8be8caa common/x11-license.html 444a27b common/xml.dcl fed2103 src/CMakeLists.txt a2bb02b src/customization/kde-chunk.xsl eda3d38 Diff: https://git.reviewboard.kde.org/r/117781/diff/ Testing --- - The files are installed under the common doc prefix - `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix - `kioclient cat help:/kdoctools5-common/gpl-license.html` works Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117781: Install again the content of common/, prepare for other languages too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56621 --- This review has been submitted with commit 184882c4c5418a9fc929b91c751c43a4234549af by Luigi Toscano to branch master. - Commit Hook On April 26, 2014, 1:08 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:08 a.m.) Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Install again common/, but: - under a different prefix - change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/lang/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here. This is the combination of four commits which can be checked here: http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.gita=logh=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7 Commit logs (older first): --- Move the definition of language list to the parent CMakeLists.txt The list can be then reused (namely by common/) --- Move en common doc files to own directory --- Install common doc files for all the languages common/CMakeLists.txt has been completely rewritten; it now supports a set of language directories and all the files included there. Right now only en/ is defined, other common files will be added using the corresponding files from trunk/l10n-kde4/lang/docs/common/ (SVN). --- Enable common/ for a different prefix, adapt kde-chunk.xsl Common files are installed again as it was in kdelibs4, but under a different prefix (kdoctools5-common) to avoid conflicts with the old common directory from kdelibs4. kde-chunk.xsl has been adapted to use this new prefix. Diffs - common/artistic-license.html 2069b4e CMakeLists.txt 3e41a26 common/CMakeLists.txt 4228625 common/block_title_bottom.png c0c0af5 common/block_title_mid.png f1ce933 common/block_title_top.png 2344376 common/bsd-license.html 422bb33 common/en/artistic-license.html PRE-CREATION common/en/block_title_bottom.png PRE-CREATION common/en/block_title_mid.png PRE-CREATION common/en/block_title_top.png PRE-CREATION common/en/bsd-license.html PRE-CREATION common/en/fdl-license.html PRE-CREATION common/en/fdl-notice.html PRE-CREATION common/en/gpl-license.html PRE-CREATION common/en/kde-default.css PRE-CREATION common/en/kde-docs.css PRE-CREATION common/en/kde_logo.png PRE-CREATION common/en/kde_logo_bg.png PRE-CREATION common/en/kmenu.png PRE-CREATION common/en/lgpl-license.html PRE-CREATION common/en/qpl-license.html PRE-CREATION common/en/top-kde.jpg PRE-CREATION common/en/top-left.jpg PRE-CREATION common/en/top-right.jpg PRE-CREATION common/en/top.jpg PRE-CREATION common/en/x11-license.html PRE-CREATION common/en/xml.dcl PRE-CREATION common/fdl-license.html 9ce378a common/fdl-notice.html 862f09e common/gpl-license.html 26ae3af common/kde-default.css 24ef928 common/kde-docs.css 12291a4 common/kde_logo.png 336bfd8 common/kde_logo_bg.png 6cf47f1 common/kmenu.png ff077c2 common/lgpl-license.html 343576d common/qpl-license.html 19a863b common/top-kde.jpg 48967d3 common/top-left.jpg 23c31c7 common/top-right.jpg 22d2a29 common/top.jpg 8be8caa common/x11-license.html 444a27b common/xml.dcl fed2103 src/CMakeLists.txt a2bb02b src/customization/kde-chunk.xsl eda3d38 Diff: https://git.reviewboard.kde.org/r/117781/diff/ Testing --- - The files are installed under the common doc prefix - `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix - `kioclient cat help:/kdoctools5-common/gpl-license.html` works Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Infopage in frameworkintegration
El Dissabte, 26 d'abril de 2014, a les 13:26:31, Alex Merry va escriure:
FrameworkIntegration installs a bunch of images and css files to
${DATA_INSTALL_DIR}/kf5/infopage. LXR suggests nothing ever references
an infopage directory (either in kf5-qt5 or in qt4-latest), except for
the CMakeLists.txt files in frameworkintegration, and the README.md
(which suggests the images are for info pages for applications).
Are these for GNU Info documentation? Are they actually used anywhere?
Does anyone know whether they have any use?
./src/infopage/usage-example.html:12:@import %1; /* kde_infopage.css */
./src/infopage/usage-example.html:13:%1 /* maybe @import
kde_infopage_rtl.css; */
./src/infopage/CMakeLists.txt:25:kde_infopage.css
./src/infopage/CMakeLists.txt:26:kde_infopage_rtl.css
./src/infopage/CMakeLists.txt:27:DESTINATION
${DATA_INSTALL_DIR}/kf5/infopage)
It's user there, no?
Cheers,
Albert
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdewebkit_master_qt5 #35
See http://build.kde.org/job/kdewebkit_master_qt5/35/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : khtml_master_qt5 #77
See http://build.kde.org/job/khtml_master_qt5/77/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kmediaplayer_master_qt5 #43
See http://build.kde.org/job/kmediaplayer_master_qt5/43/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kross_master_qt5 #46
See http://build.kde.org/job/kross_master_qt5/46/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kpty_master_qt5 #30
See http://build.kde.org/job/kpty_master_qt5/30/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : ktexteditor_master_qt5 #372
See http://build.kde.org/job/ktexteditor_master_qt5/372/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117777: Make the KSelectionProxyModel unit test pass
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56629 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 7:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 25, 2014, 7:18 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs - autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117777: Make the KSelectionProxyModel unit test pass
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56633 --- This review has been submitted with commit 2fc7aeab836b0e40360024bf57630fe2cfb66145 by Alex Merry to branch master. - Commit Hook On April 25, 2014, 7:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 25, 2014, 7:18 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs - autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117777: Make the KSelectionProxyModel unit test pass
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56632 --- This review has been submitted with commit 7cd8252d2c662c6db4a90788a64fec8297c6c378 by Alex Merry on behalf of Stephen Kelly to branch master. - Commit Hook On April 25, 2014, 7:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 25, 2014, 7:18 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs - autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117777: Make the KSelectionProxyModel unit test pass
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56631 --- This review has been submitted with commit fd6d554d8af7fe74d6c2e911a19c95a3b39268ee by Alex Merry to branch master. - Commit Hook On April 25, 2014, 7:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 25, 2014, 7:18 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs - autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- Review request for KDE Frameworks. Repository: kconfig Description --- Rename kreadconfig and kwriteconfig for coinstallability with kde-runtime4. There seems to be usage in only plasma-workspace that will require updating. Diffs - src/kreadconfig/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117708: move kioslave docs paths for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/ --- (Updated April 26, 2014, 5:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- move kioslave docs path which currently clashes with equivalents from kdelibs4 land. Diffs - docs/kioslave/data/CMakeLists.txt 64ae620 docs/kioslave/file/CMakeLists.txt 42385fb docs/kioslave/ftp/CMakeLists.txt 935298b docs/kioslave/help/CMakeLists.txt cfb29f1 docs/kioslave/help/documentationnotfound/CMakeLists.txt f2bc0b5 docs/kioslave/http/CMakeLists.txt 2aae4fb docs/kioslave/mailto/CMakeLists.txt b0a405e docs/kioslave/telnet/CMakeLists.txt 07b2d33 docs/kioslave/webdav/CMakeLists.txt eb45ed5 src/ioslaves/file/file.protocol 07cd4c3 src/ioslaves/ftp/ftp.protocol 70ddcd0 src/ioslaves/help/help.protocol 1bb5801 src/ioslaves/http/http.protocol 2d97cd4 src/ioslaves/http/https.protocol 62a43ad src/ioslaves/http/webdav.protocol c0fbd11 src/ioslaves/http/webdavs.protocol 7017c24 src/ioslaves/mailto/kmailservice5.desktop 03838a5 src/ioslaves/protocols/data.protocol 2a57b2e src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3 Diff: https://git.reviewboard.kde.org/r/117708/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/#review56637 --- Ship it! Ship It! - Kevin Ottens On April 26, 2014, 4:48 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- (Updated April 26, 2014, 4:48 p.m.) Review request for KDE Frameworks. Repository: kconfig Description --- Rename kreadconfig and kwriteconfig for coinstallability with kde-runtime4. There seems to be usage in only plasma-workspace that will require updating. Diffs - src/kreadconfig/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- (Updated April 26, 2014, 5:39 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kconfig Description --- Rename kreadconfig and kwriteconfig for coinstallability with kde-runtime4. There seems to be usage in only plasma-workspace that will require updating. Diffs - src/kreadconfig/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/#review56638 --- This review has been submitted with commit b7887433d5dd44a4414674c6b3147edff30a0f4b by Michael Palimaka to branch master. - Commit Hook On April 26, 2014, 4:48 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- (Updated April 26, 2014, 4:48 p.m.) Review request for KDE Frameworks. Repository: kconfig Description --- Rename kreadconfig and kwriteconfig for coinstallability with kde-runtime4. There seems to be usage in only plasma-workspace that will require updating. Diffs - src/kreadconfig/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #53
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs4support_master_qt5 #152
See http://build.kde.org/job/kdelibs4support_master_qt5/152/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117795: Adapt to yaml file renaming ($framework.yaml = metainfo.yaml)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117795/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- The dependency diagram code used to extract the framework name from the name of the yaml file, but that is not possible anymore. We can't use the name of the directory containing the code because build.kde.org stores the framework code under different names. Therefore I decided to use the name of the project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info from the CMakeLists.txt instead of README.md for consistency. That patch is unfortunately quite large as the changes cascaded quite a lot. Diffs - src/depdiagram-prepare 320502f src/kapidox/__init__.py 61e6a13 src/kapidox/data/dependencies.md.mustache 5d34042 src/kgenapidox 8fbffb1 src/kgenframeworksapidox 101f9b3 Diff: https://git.reviewboard.kde.org/r/117795/diff/ Testing --- - Regenerated all the diagrams. - Ran kgenframeworksapidox on all the frameworks. - Ran kgenapidox on one framework. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml = metainfo.yaml)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117795/#review56646 --- src/depdiagram-prepare https://git.reviewboard.kde.org/r/117795/#comment39499 This will break when we start putting VERSION arguments into project() calls (after we depend on CMake 3.0). src/kapidox/__init__.py https://git.reviewboard.kde.org/r/117795/#comment39502 As before, this will break with a VERSION argument (or, indeed, any languages). src/kgenframeworksapidox https://git.reviewboard.kde.org/r/117795/#comment39500 Not needed any more src/kgenframeworksapidox https://git.reviewboard.kde.org/r/117795/#comment39501 don't bother checking for README.md any more (this script doesn't care about it). - Alex Merry On April 26, 2014, 7:01 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117795/ --- (Updated April 26, 2014, 7:01 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- The dependency diagram code used to extract the framework name from the name of the yaml file, but that is not possible anymore. We can't use the name of the directory containing the code because build.kde.org stores the framework code under different names. Therefore I decided to use the name of the project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info from the CMakeLists.txt instead of README.md for consistency. That patch is unfortunately quite large as the changes cascaded quite a lot. Diffs - src/depdiagram-prepare 320502f src/kapidox/__init__.py 61e6a13 src/kapidox/data/dependencies.md.mustache 5d34042 src/kgenapidox 8fbffb1 src/kgenframeworksapidox 101f9b3 Diff: https://git.reviewboard.kde.org/r/117795/diff/ Testing --- - Regenerated all the diagrams. - Ran kgenframeworksapidox on all the frameworks. - Ran kgenapidox on one framework. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117799: Clean up private slots in KCompletion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117799/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Clean up private slots Some private slots didn't have the _k_* form and some methods with the _k_* form weren't even used as slots. Diffs - src/kcombobox.h 752db2c src/kcombobox.cpp da31394 src/kcompletionbox.h 3295c24 src/kcompletionbox.cpp 7d03d64 src/khistorycombobox.h ea56358 src/khistorycombobox.cpp 9e2f0be src/klineedit.h 705147d src/klineedit.cpp 9d02c12 src/klineedit_p.h e544224 Diff: https://git.reviewboard.kde.org/r/117799/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kinit_master_qt5 #65
See http://build.kde.org/job/kinit_master_qt5/65/changes Changes: [aleixpol] KF5 libexec files are now located in lib/libexec/kf5 -- [...truncated 12 lines...] == Cleaning Source Tree HEAD is now at 3cf90b5 Add framework information in metainfo.yaml files Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@23dc98ba Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/kinit Checking out Revision b695f0b747ebe1dabd08e5c915b8f0563ea1e4a0 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [kinit_master_qt5] $ /bin/sh -xe /tmp/hudson7387349185502761863.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: kinit - Branch master == Build Dependencies: knotifications - Branch master kcodecs - Branch master ktextwidgets - Branch master kcoreaddons - Branch master kiconthemes - Branch master kjobwidgets - Branch master kitemviews - Branch master cmake - Branch master kdbusaddons - Branch master polkit-qt-1 - Branch qt5 extra-cmake-modules - Branch master kwallet - Branch master qt5 - Branch stable kxmlgui - Branch master kwidgetsaddons - Branch master attica - Branch master karchive - Branch master kconfigwidgets - Branch master solid - Branch master kio - Branch master kdoctools - Branch master sonnet - Branch master kbookmarks - Branch master phonon - Branch master kauth - Branch master kcompletion - Branch master kglobalaccel - Branch master kwindowsystem - Branch master kservice - Branch master kconfig - Branch master kguiaddons - Branch master kcrash - Branch master ki18n - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for __progname -- Looking for __progname - found -- Looking for __progname_full -- Looking for __progname_full - found -- Looking for include file sys/pstat.h -- Looking for include file sys/pstat.h - not found -- Looking for include file sys/types.h -- Looking for include file sys/types.h - found -- Looking for include file unistd.h -- Looking for include file unistd.h - found -- Looking for include file sys/select.h -- Looking for include file sys/select.h - found -- Looking for include file sys/exec.h -- Looking for include file sys/exec.h - not found -- Looking for pstat -- Looking for pstat - not found -- Looking for setproctitle -- Looking for setproctitle - not found -- Looking for connect in socket -- Looking for connect in socket - not found -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Using setuid root kdeinit wrapper in order to protect it from bad Linux OOM-killer -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/kinit_master_qt5/ws/build == Commencing the Build Scanning dependencies of target kdeinit5_wrapper_automoc Scanning dependencies of target kdeinit5_automoc Scanning dependencies of target kdeinit5_shutdown_automoc Scanning dependencies of target kdeinit_klauncher_automoc Scanning dependencies of target kwrapper5_automoc Scanning dependencies of target start_kdeinit_wrapper_automoc Scanning dependencies of target klauncher_automoc [ 2%] Scanning dependencies of target kshell5_automoc Scanning dependencies of target start_kdeinit_automoc [ 5%] [ 7%] [ 10%] [ 13%] Automatic moc for target kdeinit5_wrapper [ 18%] Automatic moc for target kdeinit5_shutdown Automatic moc for target kdeinit_klauncher Automatic moc for
Jenkins build is back to normal : kinit_master_qt5 #66
See http://build.kde.org/job/kinit_master_qt5/66/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs4support_master_qt5 #156
See http://build.kde.org/job/kdelibs4support_master_qt5/156/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
