Re: Review Request 117961: remove several warnings on mingw

> On May 3, 2014, 4:25 a.m., Nicolás Alvarez wrote: > > src/lib/util/kuser_win.cpp, line 849 > > > > > > What's the warning here? Is it about signed vs unsigned? If so, change > > the format specifier to %u inst

Re: Review Request 117961: remove several warnings on mingw

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/#review57173 --- src/lib/util/kuser_win.cpp

Re: Review Request 117695: change where dynamic replace tabs is performed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated May 3, 2014, 12:57 a.m.) Review request for KDE Frameworks and C

Review Request 117967: use different syntax to run the target in question instead of an executable in the path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117967/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Review Request 117964: Fix references to translation of licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117964/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117963/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Review Request 117962: forward declare specialisation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117962/ --- Review request for KDE Frameworks, kdewin and Alexander Richardson. Repos

Review Request 117961: remove several warnings on mingw

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/ --- Review request for KDE Frameworks, kdewin and Alexander Richardson. Repos

Re: Review Request 117911: ECMGeneratePriFile: prefer KF5_INCLUDE_INSTALL_DIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117911/ --- (Updated May 2, 2014, 9:15 p.m.) Status -- This change has been disc

Re: Review Request 117805: Introduce kdoctools_install()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/ --- (Updated May 2, 2014, 8:01 p.m.) Status -- This change has been mark

Re: Review Request 117805: Introduce kdoctools_install()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review57159 --- This review has been submitted with commit 8930b2fd3336101336

Jenkins build is back to stable : kpty_master_qt5 #32

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/ --- (Updated May 2, 2014, 4:30 p.m.) Status -- This change has been mark

Re: Hitting assertion in kio-trash (KF5KIOCore)

On Wednesday 16 April 2014 21:31:01 Kevin Funk wrote: > Hey, > > While running unit tests from kdevplatform I hit the following assert in > trash/trashimpl.cpp (from workspace/kio-extras) > > Output of the unit test (which attempts to trash some folders): > trying to create "/home/krf/.local/sha

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951/#review57152 --- This review has been submitted with commit 800b2bda194eeb0433

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951/ --- (Updated May 2, 2014, 4:24 p.m.) Status -- This change has been mark

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

> On May 2, 2014, 4:14 p.m., David Faure wrote: > > I assume the test failed before the fix, right? ;-) Yep. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951/#review57148 -

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/#review57150 --- Ship it! LGTM - Kevin Funk On May 2, 2014, 4:12 p.m., Davi

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951/#review57148 --- Ship it! I assume the test failed before the fix, right? ;-)

Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/ --- Review request for KDE Frameworks and Kevin Funk. Repository: kio Descr

Review Request 117951: trash: Fix KUrl->QUrl porting bug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117951/ --- Review request for KDE Frameworks and David Faure. Repository: kio-extras

Re: Review Request 117946: Track screen changes in the containment when the containment is inside an applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117946/#review57143 --- Ship it! Looks good to me - Martin Klapetek On May 2, 2014

Review Request 117946: Track screen changes in the containment when the containment is inside an applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117946/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 117944: Rewrite the PIC image format handler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117944/ --- Review request for KDE Frameworks. Repository: kimageformats Descriptio

Re: Review Request 117842: Add/fix message extraction for repo frameworks/kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117842/#review57135 --- This review has been submitted with commit 42930de3abb945f456

Re: Review Request 117842: Add/fix message extraction for repo frameworks/kconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117842/ --- (Updated May 2, 2014, 1:59 p.m.) Status -- This change has been mark

Re: Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117935/ --- (Updated May 2, 2014, 1:17 p.m.) Status -- This change has been mark

Re: Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117935/#review57130 --- This review has been submitted with commit f8b5cf4773c8f86089

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117940/ --- (Updated May 2, 2014, 1:04 p.m.) Status -- This change has been mark

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117940/#review57127 --- This review has been submitted with commit e26337f1b1ef0e378d

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117940/#review57125 --- Ship it! Yay for non-confusing filenames :-) - David Faure

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117940/ --- (Updated May 2, 2014, 12:50 p.m.) Review request for KDE Frameworks and J

Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117940/ --- Review request for KDE Frameworks and John Layt. Repository: kdelibs4supp

Re: Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117935/#review57105 --- Ship it! Ship It! - Alex Merry On May 1, 2014, 9:16 p.m.,

Re: Review Request 117799: Clean up private slots in KCompletion

Hi! El 02/05/2014 10:19, "Luca Beltrame" escribió: > > Commit Hook wrote: > > > 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch > > clean_up_private_slots. > > Was this the right branch, or a mistake? Oops! Did I create a branch? :-O I did something wrong. I will fix it on Monday

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

> On May 1, 2014, 11:58 a.m., Alex Merry wrote: > > modules/ECMPoQmTools.cmake, lines 25-27 > > > > > > I wonder if it would be better to actually just have this as an extra > > argument. I mean, it's easy enough

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117823/ --- (Updated May 2, 2014, 10:55 a.m.) Review request for Build System, Extra

Re: Review Request 117799: Clean up private slots in KCompletion

Commit Hook wrote: > 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch > clean_up_private_slots. Was this the right branch, or a mistake? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-d