On May 3, 2014, 4:25 a.m., Nicolás Alvarez wrote:
src/lib/util/kuser_win.cpp, line 849
https://git.reviewboard.kde.org/r/117961/diff/1/?file=271202#file271202line849
What's the warning here? Is it about signed vs unsigned? If so, change
the format specifier to %u instead of
On Thu, Apr 10, 2014 at 9:23 PM, David Narvaez
david.narv...@computer.org wrote:
On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin mgraess...@kde.org wrote:
we might have here a chicken-egg problem. Good API documentation would
significantly help for writing the book. That is if the API
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57180
---
kde-modules/KDECMakeSettings.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117967/#review57181
---
Ship it!
Ship It!
- Alex Merry
On May 2, 2014, 11:32
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117682/#review57182
---
Ship it!
Since there's been no response from Harald, and I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/#review57183
---
Ship it!
Ship It!
- Patrick von Reth
On May 2, 2014, 9:16
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117962/#review57184
---
Ship it!
Ship It!
- Patrick von Reth
On May 2, 2014, 9:17
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117962/#review57188
---
Ship it!
Ship It!
- Alexander Richardson
On May 2, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/#review57190
---
Ship it!
Ship It!
- Alexander Richardson
On May 2, 2014,
On May 3, 2014, 10:10 a.m., Alex Merry wrote:
kde-modules/KDECMakeSettings.cmake, lines 170-176
https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
Now the comment doesn't match the code - which is correct?
The fix here is that RUNTIME_OUTPUT_DIRECTORY -
On May 3, 2014, 10:10 a.m., Alex Merry wrote:
kde-modules/KDECMakeSettings.cmake, lines 170-176
https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
Now the comment doesn't match the code - which is correct?
Patrick Spendrin wrote:
The fix here is
On May 3, 2014, 10:10 a.m., Alex Merry wrote:
kde-modules/KDECMakeSettings.cmake, lines 170-176
https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
Now the comment doesn't match the code - which is correct?
Patrick Spendrin wrote:
The fix here is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57201
---
Ship it!
Ship It!
- Patrick von Reth
On May 2, 2014,
Am Dienstag, 29. April 2014, 21:15:31 schrieb Burkhard Lück:
Hi,
forwarding this to get a more authoritative answer.
Even with kf5 and kdelibs4 coinstability we have already these clashes:
kdelibs4support
/docs/kcm_ssl/index.docbook
Using install subdir kcontrol5 instead of kcontrol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/#review57202
---
common/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117974/
---
Review request for KDE Frameworks.
Repository: karchive
Description
On May 3, 2014, 10:10 a.m., Alex Merry wrote:
kde-modules/KDECMakeSettings.cmake, lines 170-176
https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
Now the comment doesn't match the code - which is correct?
Patrick Spendrin wrote:
The fix here is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117976/
---
Review request for KDE Frameworks.
Repository: frameworkintegration
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---
(Updated May 3, 2014, 3:35 p.m.)
Review request for Build System, Extra
On May 3, 2014, 10:10 a.m., Alex Merry wrote:
kde-modules/KDECMakeSettings.cmake, lines 170-176
https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
Now the comment doesn't match the code - which is correct?
Patrick Spendrin wrote:
The fix here is
On May 3, 2014, 10:10 a.m., Alex Merry wrote:
kde-modules/KDECMakeSettings.cmake, lines 170-176
https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
Now the comment doesn't match the code - which is correct?
Patrick Spendrin wrote:
The fix here is
On May 3, 2014, 4:51 p.m., Alex Merry wrote:
common/CMakeLists.txt, lines 14-18
https://git.reviewboard.kde.org/r/117963/diff/1/?file=271204#file271204line14
Is there any reason why those files wouldn't exist? If not, why the
if(EXISTS)?
Also, the indentation is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/
---
(Updated May 3, 2014, 5:47 p.m.)
Review request for Documentation and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/
---
(Updated May 3, 2014, 5:47 p.m.)
Review request for Documentation and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117976/#review57207
---
src/platformtheme/kdeplatformfiledialoghelper.cpp
Currently all KF5/Workspaces configuration files end up in ~/.config.
Looking at my personal ~/.config, it seems that nearly all other
applications and desktop-environments make use of a subdirectory to
prevent spamming the toplevel directory and isolate the related config
files nicely.
Compared
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117976/
---
(Updated May 3, 2014, 4:38 p.m.)
Review request for KDE Frameworks.
On May 3, 2014, 4:23 p.m., Mark Gaiser wrote:
src/platformtheme/kdeplatformfiledialoghelper.cpp, line 157
https://git.reviewboard.kde.org/r/117976/diff/1/?file=271407#file271407line157
No default?
The Qt docs say that AnyFile is the default.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/#review57209
---
Ship it!
Ship It!
- Alex Merry
On May 3, 2014, 3:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/#review57211
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/#review57210
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117967/
---
(Updated May 3, 2014, 9:58 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---
(Updated May 3, 2014, 10:45 p.m.)
Review request for Build System, Extra
33 matches
Mail list logo
