Re: Review Request 118217: Deprecate the animation argument for KWindowSystem::minimizeWindow and unminimize
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118217/ --- (Updated May 22, 2014, 6:51 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- Deprecate the animation argument for KWindowSystem::minimizeWindow and unminimize If the animation argument was set to false a KWin specific client message was used. But the implementation was incomplete as it's not part of _NET_SUPPORTED and by that the implementation does not check whether the window manager does support this or not. According to lxr this was only used by SuperKaramba and korgac. Diffs - src/kwindowsystem.h 9acf537240967f41f92ce4caa163a380bc2bf945 src/kwindowsystem.cpp e93b4c38b485160656d932b326b9416efa484a6f src/kwindowsystem_p.h 925a722a1b5f1736bbbf400983843a2c6f3a3b9c src/kwindowsystem_p_x11.h 6d05775f1f1a5b7ec577533100d39b14eb9f2818 src/kwindowsystem_x11.cpp ea11d10b7a3de05464c4066018ca2c96673f6b0d Diff: https://git.reviewboard.kde.org/r/118217/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/ --- Review request for KDE Frameworks, kwin and Eike Hein. Repository: kwindowsystem Description --- Port KWindowSystem::minimizeWindow and unminizeWindow to XCB Unit test added to verify that the functionality works correctly. Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the create_atoms() function is not yet ported to xcb. Diffs - autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 Diff: https://git.reviewboard.kde.org/r/118252/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #67
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/67/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118253: Port KWindowSystem::raiseWindow and ::lowerWindow to XCB
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118253/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- Port KWindowSystem::raiseWindow and ::lowerWindow to XCB No unit test as that is extremely difficult to test as it depends on what the window manager running in the test environment supports. The code supports two variants for whether the WM supports the feature or not, thus the test would need to change the WM during execution and this would affect other running tests. Diffs - src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 Diff: https://git.reviewboard.kde.org/r/118253/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
How to properly encode the supported platforms on api.kde.org?
Hi, I wanted to ask how the platforms on the overview of http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be read. E.g. for kwindowsystem it looks like: * Linux supported * Windows not supported * MacOS X not supported This is only half of the story, though. The framework can be compiled and used on all platforms. It just uses a fallback on Windows and MacOS. The same is also the case for Linux on non-X11. Even with a working backend on non-X11 some parts of the API will only be available on X11. What should I use in the metadata file to encode this correctly? I would prefer to have Windows and MacOS X not being crossed out, as that could be read like cannot use and would limit the possible usage of the framework. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review58274 --- autotests/kwindowsystemx11test.cpp https://git.reviewboard.kde.org/r/118252/#comment40541 found no spec, but from tronche: Window managers *may* elect to receive this message and if the window is in its normal state, *may* treat it as a request to change the window's state from normal to iconic. Also WMs can of course place windows minimized (first test fails) or ignore un/minimize requests altogether (virtual desktop implementation etc.) Also this will likely fail if there's just no WM during the test... src/kwindowsystem_x11.cpp https://git.reviewboard.kde.org/r/118252/#comment40538 Do we have a strategy on this? - Thomas Lübking On May 22, 2014, 6:53 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/ --- (Updated May 22, 2014, 6:53 a.m.) Review request for KDE Frameworks, kwin and Eike Hein. Repository: kwindowsystem Description --- Port KWindowSystem::minimizeWindow and unminizeWindow to XCB Unit test added to verify that the functionality works correctly. Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the create_atoms() function is not yet ported to xcb. Diffs - autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 Diff: https://git.reviewboard.kde.org/r/118252/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB
On May 22, 2014, 10:18 a.m., Thomas Lübking wrote: autotests/kwindowsystemx11test.cpp, line 347 https://git.reviewboard.kde.org/r/118252/diff/1/?file=274045#file274045line347 found no spec, but from tronche: Window managers *may* elect to receive this message and if the window is in its normal state, *may* treat it as a request to change the window's state from normal to iconic. Also WMs can of course place windows minimized (first test fails) or ignore un/minimize requests altogether (virtual desktop implementation etc.) Also this will likely fail if there's just no WM during the test... I tested with openbox (being used on the ci system) and kwin. I can of course add a QSKIP in case it's neither kwin or openbox with a message that it might not work On May 22, 2014, 10:18 a.m., Thomas Lübking wrote: src/kwindowsystem_x11.cpp, line 809 https://git.reviewboard.kde.org/r/118252/diff/1/?file=274046#file274046line809 Do we have a strategy on this? not really. I included it to make sure it works. Once https://git.reviewboard.kde.org/r/118234/ is merged, it can be removed. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review58274 --- On May 22, 2014, 8:53 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/ --- (Updated May 22, 2014, 8:53 a.m.) Review request for KDE Frameworks, kwin and Eike Hein. Repository: kwindowsystem Description --- Port KWindowSystem::minimizeWindow and unminizeWindow to XCB Unit test added to verify that the functionality works correctly. Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the create_atoms() function is not yet ported to xcb. Diffs - autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 Diff: https://git.reviewboard.kde.org/r/118252/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118216: Skip non-directory files inside the po/ directory
On May 20, 2014, 4:15 p.m., Alex Merry wrote: Perhaps put some files in the test directories to make sure they are ignored? Interestingly, I did put files in the test directories, but they were not added to this request.Maybe post-review decided it was not worth its time since the files were empty? :) Anyway, complete patch is here: http://agateau.com/tmp/0001-Skip-non-directory-files-inside-the-po-directory.patch - Aurélien --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216/#review58198 --- On May 20, 2014, 3:05 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216/ --- (Updated May 20, 2014, 3:05 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- I had a build failure today because I generated the catalog template (.pot file) in the kwidgetsaddons repository and so had a po/kwidgetsaddons_qt5.pot file. Build failed because it tried to find .po files in po/kwidgetsaddons_qt5.pot/ Diffs - modules/ECMPoQmTools.cmake e217dd3 tests/ECMPoQmToolsTest/CMakeLists.txt 3dcb351 Diff: https://git.reviewboard.kde.org/r/118216/diff/ Testing --- kwidgetsaddons now build even if I have a .pot file in there. Added a file to be ignored to the po/ dir of the unit test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118216: Skip non-directory files inside the po/ directory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216/#review58282 --- Ship it! Ship It! - Alex Merry On May 20, 2014, 1:05 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216/ --- (Updated May 20, 2014, 1:05 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- I had a build failure today because I generated the catalog template (.pot file) in the kwidgetsaddons repository and so had a po/kwidgetsaddons_qt5.pot file. Build failed because it tried to find .po files in po/kwidgetsaddons_qt5.pot/ Diffs - modules/ECMPoQmTools.cmake e217dd3 tests/ECMPoQmToolsTest/CMakeLists.txt 3dcb351 Diff: https://git.reviewboard.kde.org/r/118216/diff/ Testing --- kwidgetsaddons now build even if I have a .pot file in there. Added a file to be ignored to the po/ dir of the unit test. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: How to properly encode the supported platforms on api.kde.org?
On 22/05/14 08:21, Martin Gräßlin wrote: Hi, I wanted to ask how the platforms on the overview of http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be read. E.g. for kwindowsystem it looks like: * Linux supported * Windows not supported * MacOS X not supported This is only half of the story, though. The framework can be compiled and used on all platforms. It just uses a fallback on Windows and MacOS. The same is also the case for Linux on non-X11. Even with a working backend on non-X11 some parts of the API will only be available on X11. What should I use in the metadata file to encode this correctly? I would prefer to have Windows and MacOS X not being crossed out, as that could be read like cannot use and would limit the possible usage of the framework. Something like: platforms: - name: Linux - name: MacOSX note: Not all features supported - name: Windows note: Not all features supported Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118116: Rename DBus interfaces to use new namespaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/#review58298 --- Ship it! Ship It! - David Edmundson On May 19, 2014, 1:27 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/ --- (Updated May 19, 2014, 1:27 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Rename DBus interfaces to use the new Qt namespace. Diffs - src/core/org.kde.KPasswdServer.xml fbb590e src/kpasswdserver/org.kde.KPasswdServer.xml fbb590e src/widgets/org.kde.kuiserver.xml 75ad12f Diff: https://git.reviewboard.kde.org/r/118116/diff/ Testing --- Everything still compiles, tests still pass Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/#review58299 --- Ship it! Ship It! - David Edmundson On May 19, 2014, 1:26 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/ --- (Updated May 19, 2014, 1:26 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Instead of just using the first value of a attribute, use all entries, seperated by a ',' Also drop KSslInfoDialog::launchConfig since it's not used internally anywhere ( atleast as far as I can tell ), not to mention that the slot won't work anyway since it calls a bogus KCM Diffs - src/widgets/ksslcertificatebox.cpp 576acd0 src/widgets/ksslinfodialog.h 5280242 src/widgets/ksslinfodialog.cpp 33001f4 Diff: https://git.reviewboard.kde.org/r/118102/diff/ Testing --- KCM SSL still works Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118104: Fix tests in kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/#review58307 --- This review has been submitted with commit 211861c8223fee5cc420f96be6769ddbfb994da9 by Rohan Garg to branch master. - Commit Hook On May 12, 2014, 4:45 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/ --- (Updated May 12, 2014, 4:45 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Fixed a couple of tests in KIO so that they pass. Diffs - src/core/kprotocolinfofactory.cpp d7aabae autotests/fileundomanagertest.cpp 2671bc2 Diff: https://git.reviewboard.kde.org/r/118104/diff/ Testing --- The fixed tests pass, however kiocore-listdirtest seems to be going on forever, not sure why ( it keeps going on forever regardless of this patch on my machine though ). Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/#review58309 --- This review has been submitted with commit a250df5c5f5f1b7706ac5130929c677972167f93 by Rohan Garg to branch master. - Commit Hook On May 19, 2014, 1:26 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/ --- (Updated May 19, 2014, 1:26 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Instead of just using the first value of a attribute, use all entries, seperated by a ',' Also drop KSslInfoDialog::launchConfig since it's not used internally anywhere ( atleast as far as I can tell ), not to mention that the slot won't work anyway since it calls a bogus KCM Diffs - src/widgets/ksslcertificatebox.cpp 576acd0 src/widgets/ksslinfodialog.h 5280242 src/widgets/ksslinfodialog.cpp 33001f4 Diff: https://git.reviewboard.kde.org/r/118102/diff/ Testing --- KCM SSL still works Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118104: Fix tests in kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/ --- (Updated May 22, 2014, 1:32 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- Fixed a couple of tests in KIO so that they pass. Diffs - src/core/kprotocolinfofactory.cpp d7aabae autotests/fileundomanagertest.cpp 2671bc2 Diff: https://git.reviewboard.kde.org/r/118104/diff/ Testing --- The fixed tests pass, however kiocore-listdirtest seems to be going on forever, not sure why ( it keeps going on forever regardless of this patch on my machine though ). Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118116: Rename DBus interfaces to use new namespaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/ --- (Updated May 22, 2014, 1:32 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- Rename DBus interfaces to use the new Qt namespace. Diffs - src/core/org.kde.KPasswdServer.xml fbb590e src/kpasswdserver/org.kde.KPasswdServer.xml fbb590e src/widgets/org.kde.kuiserver.xml 75ad12f Diff: https://git.reviewboard.kde.org/r/118116/diff/ Testing --- Everything still compiles, tests still pass Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/ --- (Updated May 22, 2014, 1:32 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- Instead of just using the first value of a attribute, use all entries, seperated by a ',' Also drop KSslInfoDialog::launchConfig since it's not used internally anywhere ( atleast as far as I can tell ), not to mention that the slot won't work anyway since it calls a bogus KCM Diffs - src/widgets/ksslcertificatebox.cpp 576acd0 src/widgets/ksslinfodialog.h 5280242 src/widgets/ksslinfodialog.cpp 33001f4 Diff: https://git.reviewboard.kde.org/r/118102/diff/ Testing --- KCM SSL still works Thanks, Rohan Garg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KUnitConversion apidox
Hi, I've just noticed that the KUnitConversion api dox at http://api.kde.org/frameworks-api/frameworks5-apidocs/kunitconversion/html/index.html does not have a class list available not the individual classes. Have I missed something? Cheers! John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review58320 --- Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the create_atoms() function is not yet ported to xcb. I actually have a port of that function that I forgot to push. I should see if I can find that patch. - Fredrik Höglund On May 22, 2014, 6:53 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/ --- (Updated May 22, 2014, 6:53 a.m.) Review request for KDE Frameworks, kwin and Eike Hein. Repository: kwindowsystem Description --- Port KWindowSystem::minimizeWindow and unminizeWindow to XCB Unit test added to verify that the functionality works correctly. Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the create_atoms() function is not yet ported to xcb. Diffs - autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 Diff: https://git.reviewboard.kde.org/r/118252/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118264: Switch to PolkitQt5-1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- Review request for KDE Frameworks. Repository: kauth Description --- since now master of polkit-qt-1 is able to exist w/o issues with Qt4 variant, KAuth should switch to that, instead of building either w/ no backend, or with the branch... Diffs - cmake/KF5AuthMacros.cmake 4cdf3ab src/ConfigureChecks.cmake aff05ed Diff: https://git.reviewboard.kde.org/r/118264/diff/ Testing --- Got CMake message: Building PolkitQt5-1 KAuth backend and kauth-policy-gen also built KAuth macros generate correct polkit-1 rules (e.g. date kcm in plasma-desktop, etc) Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KUnitConversion apidox
On Thursday 22 May 2014 15:19:50 John Layt wrote: Hi, I've just noticed that the KUnitConversion api dox at http://api.kde.org/frameworks-api/frameworks5-apidocs/kunitconversion/html/i ndex.html does not have a class list available not the individual classes. Have I missed something? You need to document the classes (eg: in unit.h, the Unit class members have doxygen comments, but the Unit class itself does not, and so doxygen will ignore it). Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Keeping CI green
There are currently four frameworks that are yellow (for between 6 hours and 8 days). kdelibs4support has had 3 commits (not counting those by scripty) since it broke that have done nothing to fix the issue. If we claim that our release schedule means more stability because of our review process and CI system, we need to enforce it. How are we going to do this? Because I don't think our current system is working very well. 8 days is a long time for breakage to stick around when we release every month. I don't think Jenkins currently sends emails directly to people who appear to have broken something - can we make it do so? Do we want to? Do we want to have a fix it or have it reverted policy? How would that interact with failures that can only be reproduced on Jenkins (which does have an unusual setup)? Alex (PS: I would try to fix things, but I don't have access to my development machine this weekend) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Keeping CI green
On Fri, May 23, 2014 at 8:08 AM, Alex Merry alex.me...@kde.org wrote: There are currently four frameworks that are yellow (for between 6 hours and 8 days). kdelibs4support has had 3 commits (not counting those by scripty) since it broke that have done nothing to fix the issue. If we claim that our release schedule means more stability because of our review process and CI system, we need to enforce it. How are we going to do this? Because I don't think our current system is working very well. 8 days is a long time for breakage to stick around when we release every month. I don't think Jenkins currently sends emails directly to people who appear to have broken something - can we make it do so? Do we want to? I'd prefer we not enable this option, as otherwise sysadmin will receive emails for every unstable build once scripty has committed to the repository. The Jenkins option for this emails *everyone* who has committed to the repository since the test breakage has occurred. Do we want to have a fix it or have it reverted policy? How would that interact with failures that can only be reproduced on Jenkins (which does have an unusual setup)? Alex Thanks, Ben (PS: I would try to fix things, but I don't have access to my development machine this weekend) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118269/ --- Review request for KDE Frameworks and David Faure. Bugs: 334648 https://bugs.kde.org/show_bug.cgi?id=334648 Repository: kjobwidgets Description --- Currently Dolphin (and probably anything else that can delete files using KIO) crashes when it's supposed to show the confirmation dialog. The problem is that KonqOperations::askDeleteConfirmation() sets up a KIO::JobUiDelegate object which has no associated job, and calls its setWindow(QWidget*) method before calling the actual askDeleteConfirmation() function. KIO::JobUiDelegate::setWindow(QWidget*) then calls the setWindow function of the base class, KDialogJobUiDelegate::setWindow(QWidget*), which then crashes because it contains the line Q_ASSERT(job()) and there is no job. The problem does not exist in KDE SC 4.x - the code went through a big refactoring in https://git.reviewboard.kde.org/r/111081/ which added the assert. Just removing the assert won't help because the function then calls KJobWidgets::setWindow(KJob *job, QWidget *widget) which dereferences the job, i.e., we get a segfault instead. This patch removes the assert and wraps the function in an if (job()) block instead. I'm not entirely sure if that is the correct solution though - any feedback is welcome. Alternatively, one could move the if-check to the child class, i.e., to KIO::JobUiDelegate::setWindow(QWidget*), if this is the only valid use of a KDialogJobUiDelegate without a job. Or maybe it does not make much sense at all to have the askDeleteConfirmation function, which is probably always called before any job is set up, in a KDialogJobUiDelegate subclass? Changing that would probably require more intrusive changes though. Diffs - src/kdialogjobuidelegate.cpp fb4c99a Diff: https://git.reviewboard.kde.org/r/118269/diff/ Testing --- Fixes the crash for me, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- Review request for KDE Frameworks, kdelibs, Rohan Garg, Jonathan Riddell, and Rex Dieter. Bugs: 335001 http://bugs.kde.org/show_bug.cgi?id=335001 Repository: kdelibs Description --- Use the more modern API function for XML loading and enable the flags which load the external entities, so that meinproc4 can work again after the security changes implemented for CVE-2014-0191. Without this change meinproc4 complains (see the referenced bug) The fix (half of the patch, the other half is on code which was removed) applies to KF5 too, hence the group. My tests shows that the documentation cache is properly generated as before, and the patch should work even on the old Packagers (Ubuntu packagers in CC, as Ubuntu is one of the few distributions where libxml2 has been already patched) could you please test it with a fixed libxml and without, and if possible with KF5 as well? Diffs - kdoctools/meinproc.cpp 0894d63 kdoctools/xslt.cpp a7265ca Diff: https://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
