Re: Review Request 118425: Improve deprecated notes in KSessionManager

2014-06-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118425/ --- (Updated June 2, 2014, 6:06 a.m.) Status -- This change has been mar

Re: Review Request 118425: Improve deprecated notes in KSessionManager

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118425/#review58919 --- This review has been submitted with commit 7fb79329f71c44a17e

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-01 Thread Ben Cooksley
On 31 May 2014 11:37, Marko Käning wrote: > So, I have figured that kdoctools has found docbook and docbook-xsl just fine > when installing it via MacPorts: > --- > -- Performing Test _OFFT_IS_64BIT - Success > -- Found LibXslt: /opt/local/lib/libxslt.dylib (found version "1.1.28") > -- Found LibX

Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-01 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- Review request for KDE Frameworks. Bugs: 329802 https://bugs.kde.org/

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

2014-06-01 Thread David Faure
> On June 1, 2014, 3:01 p.m., David Faure wrote: > > That makes the setWindow call (as called by konq_operations.cpp) useless, > > though. > > > > This is related to the line in jobuidelegate.cpp which says > >QWidget *widget = job() ? window() : NULL; // ### job is NULL here, most > > of

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

2014-06-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118269/#review58902 --- That makes the setWindow call (as called by konq_operations.cp

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-06-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review58901 --- A very big +1 from me! Your change is going to - heavily - co

Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-06-01 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 118449: Also set organization domain from KAboutData

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118449/#review58895 --- This review has been submitted with commit e27c330ea823511b49

Re: Review Request 118449: Also set organization domain from KAboutData

2014-06-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118449/ --- (Updated June 1, 2014, 1:43 p.m.) Status -- This change has been mar

Jenkins build is back to stable : kpty_master_qt5 #41

2014-06-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Maintainers: Please get ready for release

2014-06-01 Thread Alex Merry
On 26/04/14 23:32, Kevin Ottens wrote: > Please get back to us when you're done checking your framework, if you get > any > issue or if something is unclear. > Alex Merry: > - kdesignerplugin > - kimageformats > - kmediaplayer (porting aid) All checked. Alex ___

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/#review58893 --- This review has been submitted with commit 73294b2e0d562b79f1

Re: Review Request 118193: Use the macros provided by KDesignerPlugin

2014-06-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/ --- (Updated June 1, 2014, 12:55 p.m.) Status -- This change has been ma

Re: Review Request 118449: Also set organization domain from KAboutData

2014-06-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118449/#review58885 --- Ship it! Ship It! - David Edmundson On June 1, 2014, 12:14

Review Request 118449: Also set organization domain from KAboutData

2014-06-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118449/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: kioclient5 crashes on exit due to ~QDBusConnectionManager

2014-06-01 Thread David Faure
On Monday 12 May 2014 09:18:11 David Faure wrote: > Does Qt really unload plugins? That would be the problem, right? > We have an alive object in an unloaded plugin, and we're trying to call a > method on it. So the issue is that the widget style (QApplicationPrivate::app_style) doesn't get delet

Jenkins build became unstable: kpty_master_qt5 #40

2014-06-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #413

2014-06-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #412

2014-06-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : knotifyconfig_master_qt5 #57

2014-06-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118211: Add autotests for designer plugin generation

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118211/#review58881 --- This review has been submitted with commit 6387c82a483c1bb4ae

Re: Review Request 118211: Add autotests for designer plugin generation

2014-06-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118211/ --- (Updated June 1, 2014, 10:16 a.m.) Status -- This change has been ma

Re: Review Request 118384: Improve the kgendesignerplugin man page

2014-06-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118384/ --- (Updated June 1, 2014, 10:14 a.m.) Status -- This change has been ma

Re: Review Request 118384: Improve the kgendesignerplugin man page

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118384/#review58880 --- This review has been submitted with commit 06639fdb89820bc628

Build failed in Jenkins: knotifyconfig_master_qt5 #56

2014-06-01 Thread KDE CI System
See Changes: [faure] Upgrade KF5 version. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace <

Re: KIO directory listing - CPU slows down SSD

2014-06-01 Thread David Faure
On Thursday 29 May 2014 00:21:56 Aaron J. Seigo wrote: > .. you'll also find some perhaps useful cleanups and optimizations in the > aseigo/cleanups branch in kio. feel free to cherry-pick. Merged and fixed, many thanks :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE

Re: problems in http kioslave, where to debug?

2014-06-01 Thread David Faure
On Sunday 01 June 2014 09:58:09 David Faure wrote: > OK, writing this email gave me an idea for a workaround, at least. Can you > test it? (attached). I pushed this fix to kio so it becomes part of beta3, tagged today. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Framew

Jenkins build is back to stable : kdelibs4support_master_qt5 #210

2014-06-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118385: Remove name prefix from autotests

2014-06-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118385/ --- (Updated June 1, 2014, 9:30 a.m.) Status -- This change has been mar

Re: Review Request 118385: Remove name prefix from autotests

2014-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118385/#review58879 --- This review has been submitted with commit 92af1aa27c84541f37

Re: How to port KIntSpinBox::setSuffix

2014-06-01 Thread laurent Montel
On dimanche 1 juin 2014 10:34:07 David Faure wrote: > On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: > > Hi all, > > > > while trying to get rid of kdelibs4support I stumbled [1] over > > KIntSpinBox::setSuffix which allows to set a plural aware suffix. The > > recommendation is to port to Q

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-01 Thread Marko Käning
So, I have figured that kdoctools has found docbook and docbook-xsl just fine when installing it via MacPorts: --- -- Performing Test _OFFT_IS_64BIT - Success -- Found LibXslt: /opt/local/lib/libxslt.dylib (found version "1.1.28") -- Found LibXml2: /opt/local/lib/libxml2.dylib (found version "2.9.

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-01 Thread Marko Käning
Hi, I’ve given the first part of the patch from [1] a quick try: On 29 May 2014, at 15:17 , Marko Käning wrote: > as well as a patch for > > KF5DocToolsConfig.cmake.in > > but I haven’t tried anything of it yet, because I’ve got no clue as to how > much of it is specific for a Homebrew s

Re: How to port KIntSpinBox::setSuffix

2014-06-01 Thread David Faure
On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: > Hi all, > > while trying to get rid of kdelibs4support I stumbled [1] over > KIntSpinBox::setSuffix which allows to set a plural aware suffix. The > recommendation is to port to QSpinBox, but as far as I can see there is > suitable replacement

Re: Review Request 118385: Remove name prefix from autotests

2014-06-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118385/#review58878 --- Ship it! Ship It! - David Faure On May 28, 2014, 4:16 p.m.

Re: Review Request 118384: Improve the kgendesignerplugin man page

2014-06-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118384/#review58877 --- Ship it! docs/kgendesignerplugin/man-kgendesignerplugin.1.do

Re: problems in http kioslave, where to debug?

2014-06-01 Thread David Faure
On Wednesday 21 May 2014 18:19:57 Marco Martin wrote: > Hi all, > I'm writing here too since I'm kinda out of ideas ;) > I was indagating about this bug in Plasma Next: > https://bugs.kde.org/show_bug.cgi?id=332499 > > i tought it was probably a problem in ghns, but seems that instead, a copy > pr

Re: Review Request 118425: Improve deprecated notes in KSessionManager

2014-06-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118425/#review58874 --- Ship it! Ship It! - David Faure On May 30, 2014, 1:19 p.m.

Re: Review Request 118211: Add autotests for designer plugin generation

2014-06-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118211/#review58872 --- Ship it! Nice! autotests/testplugin.widgets

Re: CMake package files location

2014-06-01 Thread David Faure
On Sunday 18 May 2014 15:36:38 Alex Merry wrote: > I'm reviewing the frameworks I maintain, and one of things listed that I > should check is the directory structure: > http://community.kde.org/Frameworks/Policies#Framework_directory_structure > > This has the line "CMake modules (FindFoo.cmake et