On Tuesday 03 June 2014 17:59:18 David Faure wrote:
PS: Martin: meanwhile Laurent committed the class (which I reviewed) to
ktextwidgets, you can use that.
Laurent CC-ed me on the commit and I already adjusted the code to use it.
Thanks a lot for the fast fix.
Cheers
Martin
signature.asc
On Tue, Jun 3, 2014, at 17:04, Marko Käning wrote:
I was wondering why I couldn't find plasma-framework in tier 3 on
api.kde.org not below frameworks [1] although it is actually shown as
part of tier 3 in the dependency graph in [2] ...
The name on the landing page are based on the CMake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118458/#review59123
---
Very good to see that it brings the FAM backend to be more in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118474/#review59125
---
Ship it!
Ship It!
- David Faure
On June 2, 2014, 4:20
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118476/#review59126
---
Ship it!
Ship It!
- David Faure
On June 2, 2014, 4:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118486/#review59127
---
Ship it!
Ship It!
- David Faure
On June 2, 2014, 10:03
Hi Aurélien,
On 04 Jun 2014, at 09:15 , Aurélien Gâteau agat...@kde.org wrote:
The name on the landing page are based on the CMake project name: this
cause plasma-framework to be listed as Plasma there.
but why does plasma and plasma-framework appear as separate frameworks in the
dependency
It turns out that there are indeed a few more KF5 framework trying to install
their files in “/Library/Application Support”, here’s the full list of kf5
folders
found in the install environment:
---
On Wed, Jun 4, 2014, at 1:11, Marko Käning wrote:
Hi Aurélien,
On 04 Jun 2014, at 09:15 , Aurélien Gâteau agat...@kde.org wrote:
The name on the landing page are based on the CMake project name: this
cause plasma-framework to be listed as Plasma there.
but why does plasma and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118269/
---
(Updated June 4, 2014, 8:58 a.m.)
Status
--
This change has been
On June 1, 2014, 3:01 p.m., David Faure wrote:
That makes the setWindow call (as called by konq_operations.cpp) useless,
though.
This is related to the line in jobuidelegate.cpp which says
QWidget *widget = job() ? window() : NULL; // ### job is NULL here, most
of the time,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118474/#review59136
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118474/
---
(Updated June 4, 2014, 9:15 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118476/#review59137
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118476/
---
(Updated June 4, 2014, 9:16 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118486/
---
(Updated June 4, 2014, 9:18 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118486/#review59138
---
This review has been submitted with commit
On June 3, 2014, 10:16 a.m., Alex Merry wrote:
src/mdnsd-servicetypebrowser.cpp, line 51
https://git.reviewboard.kde.org/r/118490/diff/1/?file=277690#file277690line51
Interesting... any idea which monday?
Matthew Dawson wrote:
I'm assuming that is any Monday, as that used to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/
---
Review request for KDE Frameworks and Christoph Feck.
Repository:
On June 3, 2014, 10:12 a.m., Alex Merry wrote:
Changing the macro name is a no-brainer. Comments below; a lot of them are
about binary compatibility issues, and these depend on how we expect this
macro to be used. I believe that Qt5 makes all its deprecated functions
header-only so
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/
---
(Updated June 4, 2014, 11:52 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59145
---
+++
src/kcolumnresizer.h
See http://build.kde.org/job/ktexteditor_master_qt5/416/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59170
---
What about adding something like this to Qt ?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59163
---
Regarding remove type functions, I agree we need them.
On June 4, 2014, 11:41 a.m., Dominik Haumann wrote:
What about adding something like this to Qt ?
First, I was thinking the same. The efforts with KF5 work was to get as much
features as possible into Qt, and only keep the stuff that isn't accepted in
our libraries.
But here, I am not
On June 4, 2014, 1:52 p.m., Christoph Feck wrote:
src/kcolumnresizer.cpp, line 182
https://git.reviewboard.kde.org/r/118514/diff/2/?file=278585#file278585line182
What would be nice is if the widget you add is actually a GroupBox
containing a supported layout, then it would
On June 4, 2014, 11:41 a.m., Dominik Haumann wrote:
What about adding something like this to Qt ?
Christoph Feck wrote:
First, I was thinking the same. The efforts with KF5 work was to get as
much features as possible into Qt, and only keep the stuff that isn't
accepted in our
On June 4, 2014, 12:01 p.m., David Edmundson wrote:
src/kcolumnresizer.cpp, line 214
https://git.reviewboard.kde.org/r/118514/diff/2/?file=278585#file278585line214
Do we really want it to be critical?
Sometimes widgets are loaded dynamically, we probably don't want to
On June 4, 2014, 1:41 p.m., Dominik Haumann wrote:
src/kcolumnresizer.cpp, line 200
https://git.reviewboard.kde.org/r/118514/diff/2/?file=278585#file278585line200
You can use auto here, if wanted (you can use auto much more often in
your patch, btw.):
if (auto
On June 4, 2014, 1:52 p.m., Christoph Feck wrote:
src/kcolumnresizer.h, line 93
https://git.reviewboard.kde.org/r/118514/diff/2/?file=278584#file278584line93
Does it make sense to make = 0 the default value for the column?
Sounds good to me. Just did so.
- Aurélien
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/
---
(Updated June 4, 2014, 2:43 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118526/
---
Review request for KDE Frameworks, Plasma and Marco Martin.
Repository:
See http://build.kde.org/job/ktexteditor_master_qt5/417/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On June 4, 2014, 3:38 a.m., David Faure wrote:
autotests/kdirwatch_unittest.cpp, line 523
https://git.reviewboard.kde.org/r/118458/diff/1/?file=277318#file277318line523
The commit log doesn't mention any changes related to
QFileSystemWatcher, only to the FAM backend. Are you sure
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118458/
---
(Updated June 4, 2014, 1:05 p.m.)
Review request for KDE Frameworks.
See http://build.kde.org/job/kdelibs_stable/1102/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118538/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118538/#review59234
---
what is a valid use case where qml needs to know where the
On June 4, 2014, 7:30 p.m., Marco Martin wrote:
what is a valid use case where qml needs to know where the dialog actually
is?(not hypothetical please)
doing the animation on the proper direction can be tracked completely
internally
also, plasmoids should never ever do a screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118270/#review59243
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118270/
---
(Updated June 4, 2014, 8:40 p.m.)
Status
--
This change has been
On June 4, 2014, 7:30 p.m., Marco Martin wrote:
what is a valid use case where qml needs to know where the dialog actually
is?(not hypothetical please)
doing the animation on the proper direction can be tracked completely
internally
also, plasmoids should never ever do a screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118546/
---
Review request for Documentation and KDE Frameworks.
Repository:
On June 4, 2014, 7:30 p.m., Marco Martin wrote:
what is a valid use case where qml needs to know where the dialog actually
is?(not hypothetical please)
doing the animation on the proper direction can be tracked completely
internally
also, plasmoids should never ever do a screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118538/
---
(Updated June 4, 2014, 10:43 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118547/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118547/#review59256
---
Ship it!
Makes sense and looks nice!
- Mark Gaiser
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118547/#review59261
---
src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118490/
---
(Updated June 4, 2014, 11:56 p.m.)
Review request for KDE Frameworks and
50 matches
Mail list logo
