Re: Review Request 118547: Expose Formats as singleton

On June 5, 2014, 3:44 a.m., Bhushan Shah wrote: src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 40 https://git.reviewboard.kde.org/r/118547/diff/1/?file=278948#file278948line40 Err no, this will fail when using formatRelativeDate and formatRelativeDateTime good catch.

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- (Updated June 5, 2014, 8:23 a.m.) Review request for KDE Frameworks.

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59257 --- +1 from me. The i18nd is definitely useful. The

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

On June 5, 2014, 8:29 a.m., David Edmundson wrote: +1 from me. The i18nd is definitely useful. The setTranslationDomain isn't ideal, but there's no 100% nice solution to it. Brainstorming: There is one other possible way we could have i18n automatically select the right

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

On June 5, 2014, 10:29 a.m., David Edmundson wrote: +1 from me. The i18nd is definitely useful. The setTranslationDomain isn't ideal, but there's no 100% nice solution to it. David Edmundson wrote: Brainstorming: There is one other possible way we could have

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

On June 5, 2014, 10:29 a.m., David Edmundson wrote: src/kdeclarative/kdeclarative.cpp, line 120 https://git.reviewboard.kde.org/r/118526/diff/1/?file=278657#file278657line120 Can we warn if this is already set to something else. If two QML files try to do it to

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59284 --- Ship it! Great! I'll try to make plasmoids and shells

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59285 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 8:23

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59287 --- src/kdeclarative/private/rootcontext.cpp

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59288 --- This review has been submitted with commit

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- (Updated June 5, 2014, 9 a.m.) Status -- This change has been

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

On June 5, 2014, 8:29 a.m., David Edmundson wrote: src/kdeclarative/kdeclarative.cpp, line 120 https://git.reviewboard.kde.org/r/118526/diff/1/?file=278657#file278657line120 Can we warn if this is already set to something else. If two QML files try to do it to different

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

On June 5, 2014, 8:29 a.m., David Edmundson wrote: src/kdeclarative/kdeclarative.cpp, line 120 https://git.reviewboard.kde.org/r/118526/diff/1/?file=278657#file278657line120 Can we warn if this is already set to something else. If two QML files try to do it to different

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

On June 5, 2014, 8:58 a.m., Chusslove Illich wrote: src/kdeclarative/private/rootcontext.cpp, line 48 https://git.reviewboard.kde.org/r/118526/diff/1/?file=278659#file278659line48 (And at other places like this.) If I understand, any of the parameters can be not given

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59299 --- Ship it! Ship It! - Alex Merry On June 5, 2014, 3:56

Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/#review59301 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 10:12

Review Request 118561: Allow passing custom theme base path together with custom app themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59313 --- This review has been submitted with commit

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/ --- (Updated June 5, 2014, 10:59 a.m.) Status -- This change has been

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/#review59317 --- This review has been submitted with commit

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/ --- (Updated June 5, 2014, 11:20 a.m.) Status -- This change has been

Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- Review request for KDE Frameworks and John Layt. Repository: kconfig

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 5, 2014, 2:38 p.m.) Review request for KDE Frameworks and

Review Request 118565: Mark kdelibs4support widgets as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118565/ --- Review request for KDE Frameworks. Repository: kdelibs4support

Re: Review Request 118565: Mark kdelibs4support widgets as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118565/#review59331 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 5, 2014,

Review Request 118566: KAcceleratorManager: ignore Designer text fields

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118566/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 118565: Mark kdelibs4support widgets as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118565/ --- (Updated June 5, 2014, 1:59 p.m.) Status -- This change has been

Re: Review Request 118565: Mark kdelibs4support widgets as deprecated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118565/#review59334 --- This review has been submitted with commit

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59337 --- This review has been submitted with commit

Re: Review Request 118490: Properly mark ServiceBrowser::isRunning as deprecated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/ --- (Updated June 5, 2014, 2:52 p.m.) Status -- This change has been

Re: Review Request 118566: KAcceleratorManager: ignore Designer text fields

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118566/#review59357 --- Ship it! Ship It! - Christoph Feck On June 5, 2014, 1:54

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/#review59358 --- Thanks Martin for looking at the issue. Just one question:

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: What about adding something like this to Qt ? Christoph Feck wrote: First, I was thinking the same. The efforts with KF5 work was to get as much features as possible into Qt, and only keep the stuff that isn't accepted in our

What to do regarding OPTIONAL packages during KDE/CI builds?

The Qt5/KF5/KDE/CI system on OSX/MacPorts - which I am trying to set up - is eventually able to build and install (almost) all KF5 frameworks just fine. But during the builds I spotted every now and then that configure scripts mentioned a few OPTIONAL packages which could not be found... ...but

Review Request 118581: Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/ --- Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs: