Re: Review Request 118690: Introduce a KLocalizedTranslator

> On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > What's the use case? well as explained in the comment for translating dynamically loaded UI files. Where is that used? In KWin for the configuration

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 13, 2014, 2:31 a.m.) Review request for KDE Frameworks, Pla

Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- Review request for KDE Frameworks, Plasma, Chusslove Illich, and John Layt.

Re: Loading Qt 5 translations

El Dimarts, 10 de juny de 2014, a les 05:02:16, Aurélien Gâteau va escriure: > On Sun, Jun 8, 2014, at 15:04, Albert Astals Cid wrote: > > El Dimarts, 27 de maig de 2014, a les 07:08:45, Aurélien Gâteau va > > > > escriure: > > > On Mon, May 26, 2014, at 9:41, Alexander Potashev wrote: > > > > 201

Re: Review Request 118690: Introduce a KLocalizedTranslator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review59925 --- What's the use case? Didn't we have a different way for transl

Re: Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/ --- (Updated June 12, 2014, 10:56 p.m.) Status -- This change has been m

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59924 --- This review has been submitted with commit 69c203156d21385a8c

Re: Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/#review59923 --- This review has been submitted with commit ac6703215ba5e15237

Re: Review Request 118680: Reorder Tests

> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote: > > autotests/CMakeLists.txt, line 53 > > > > > > Why did you need to create a separate call to ecm_add_test? > > > > If it's for the target_inclu

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/#review59889 --- Would it make sense to backport that change to kdelibs4? - Al

Review Request 118698: Use correct type for QDBusReply when calling Activate.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118698/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/#review59886 --- Ship it! Good catch! I can confirm that this makes saving th

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 12, 2014, 4:17 p.m.) Review request for KDE Frameworks, Dav

Re: Plasma 5 Beta 2 tars

On Thursday 12 of June 2014 14:53:57 Marco Martin wrote: > On Wednesday 11 June 2014, šumski wrote: > > Unfortunately, we cannot touch the buildhost, only sources which are > > built (and i'm running x86_64 OS). > > You might be right about kde_file, though seems to be a namespace > > clash/mixup.

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 12:54 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfigini.cpp, line 79 > > > > > > Is it really like that? > > > > I think the catalan locale is es_CA, and the short representation

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review59880 --- src/core/kconfigini.cpp

Re: Plasma 5 Beta 2 tars

On Wednesday 11 June 2014, šumski wrote: > Unfortunately, we cannot touch the buildhost, only sources which are built > (and i'm running x86_64 OS). > You might be right about kde_file, though seems to be a namespace > clash/mixup. The attached patch resolves the failure here (basically > renaming

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 11:58 a.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), bu

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 12, 2014, 1:58 p.m., David Faure wrote: > > Looks good; but I'm surprised that it works :) the code for using fallbacks > > must be in there somewhere already then? (if de_DE not present then use > > de). > > This patch is only about not skipping these two entries (de and de_CH), but

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review59869 --- Looks good; but I'm surprised that it works :) the code for us

Re: Review Request 118666: Simple Cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/#review59858 --- Ship it! Looks good to me, I see you're the maintainer, so go

Re: Review Request 118666: Simple Cleanups

> On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfiggroup.cpp, line 205 > > > > > > shouldn't this be translated? > > Thomas Braxton wrote: > It's an error string, should it? I gues

Re: Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/#review59855 --- autotests/CMakeLists.txt

Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- Review request for KDE Frameworks, David Faure and John Layt. Repository:

Review Request 118690: Introduce a KLocalizedTranslator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/ --- Review request for KDE Frameworks, Aurélien Gâteau and Chusslove Illich.

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j