Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119152/#review61876 --- Ah. QT_DISABLE_DEPRECATED_BEFORE defaults to

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread Marco Martin
On July 7, 2014, 10:37 p.m., David Edmundson wrote: src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 99 https://git.reviewboard.kde.org/r/119165/diff/1/?file=288560#file288560line99 If the containment is removed before the containmentInterface (the cause of this

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119165/ --- (Updated July 8, 2014, 8:36 a.m.) Review request for KDE Frameworks,

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread David Edmundson
On July 7, 2014, 10:37 p.m., David Edmundson wrote: src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 99 https://git.reviewboard.kde.org/r/119165/diff/1/?file=288560#file288560line99 If the containment is removed before the containmentInterface (the cause of this

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119165/#review61879 --- Ship it! Ship It! - David Edmundson On July 8, 2014, 8:36

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119165/ --- (Updated July 8, 2014, 9:03 a.m.) Review request for KDE Frameworks,

Re: [OSX/Qt5/KF5/KDE CI system] - libksysguard currently broken on master branch

2014-07-08 Thread Aleix Pol
On Tue, Jul 8, 2014 at 6:57 AM, Marko Käning mk-li...@email.de wrote: On 08 Jul 2014, at 01:15 , Aleix Pol aleix...@kde.org wrote: Well, you'd get an application for managing processes, it's cool, but then you need to provide a backend for it. yep IMHO, you have projects much more

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-07-08 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 8, 2014, 1:51 nachm.) Review request for KDE Frameworks.

KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 28 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: agateau, apol, d_ed, dfaure, fregl, mgraesslin, notmart, PovAddict, Riddell, sandsmark, tosky, unormal, vHanda and myself. Announcements: * KF 5.0 got

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Mario Fux
Am Dienstag, 08. Juli 2014, 17.30:19 schrieb Kevin Ottens: Hello everyone, Morning This is the minutes of the Week 28 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. [snip] * unormal is looking forward to more mac CI results; * the windows CI is a bit stuck; *

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Jonathan Riddell
* he's not sold on the no branches policy, actually plasma-framework seeing heavy work he pushed feature branches already (said policy isn't written anywhere BTW); I've quite confused on this. Whyever would you not want feature branches? Jonathan

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread John Layt
On 8 July 2014 16:30, Kevin Ottens er...@kde.org wrote: * he'd like our documentation to improve, we're really behind alternatives in that regard; Seconded, especially from the point-of-view of external devs. For example, someone today was asking about KArchive and whether it was fully

Re: Deprecation Defines

2014-07-08 Thread Matthew Dawson
On July 8, 2014 11:20:37 AM David Faure wrote: I have a patch sitting in review for kconfig. What's the RR number? I can't see it in my k-f-d folder. 118489. It already has comments on it, with the decision that policy needs to be figured out before it is pushed. I'm waiting on a

online kanban/todo list

2014-07-08 Thread Marco Martin
Hi all, since it's time to schedule what we want to do in the next release, and the postit boards are so useful during sprints.. I was brought to attention of this thing (thanks Kevin, Aaron;): http://kanboard.net/ it's very simple, very similar to trello, free software and could be ran on KDE

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Alex Merry
On Tuesday 08 July 2014 17:30:19 Kevin Ottens wrote: * he's also like to see the android port progress, in particular he got no answer about getting a file in ECM to that effect; Sorry, life's a bit crazy at the mo. Will try to look at soon. Although I'd appreciate the input of anyone else

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-07-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61923 --- Build is failing now when BUILD_EXAMPLES is turned on. -

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Kevin Ottens
On Tuesday 08 July 2014 18:27:52 John Layt wrote: Here's a bit of bike-shedding for you: when creating completely new Frameworks in Tier 1, do we name them with a Q or with a K or with something completely neutral? Not really a bike-shedding topic hopefully... We had the case already and we

Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread laurent Montel
Hi, In qt4 it was a KDialog so okClicked() and applyClicked() existed. Now it’s a KPageDialog = a QDialog so we must to connect to QDialogButtonBox. This patch fixes bad signal. Can I commit it ? Thanks -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Boudewijn Rempt
On Tue, 8 Jul 2014, John Layt wrote: We already have a link to the donations page buried deep in the About KDE dialog under the Support KDE tab where no-one ever sees it. A Help menu item for Donate to KDE... that pops up a dialog explaining why would be far more visible, but easily disabled

Re: Deprecation Defines

2014-07-08 Thread David Faure
(moving this to kde-buildsystem) On Tuesday 08 July 2014 10:47:21 Matthew Dawson wrote: On July 8, 2014 11:20:37 AM David Faure wrote: I have a patch sitting in review for kconfig. What's the RR number? I can't see it in my k-f-d folder. 118489. It already has comments on it, with

Re: Deprecation Defines

2014-07-08 Thread Matthew Dawson
On July 8, 2014 10:50:18 PM David Faure wrote: I agree. I figured the first step was to come up with a draft policy and post to the list for comments, and as I said I'm trying to get a new contributer to help (they have lots of experience writing documents, and have a strong technical

Review Request 119186: Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119186/ --- Review request for KDE Frameworks. Repository: kemoticons Description

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Mario Fux
Am Dienstag, 08. Juli 2014, 19.27:52 schrieb John Layt: Morning John [snip] * he'd like to see a donation button in KDE apps based on KF5 (developers could opt-out); We already have a link to the donations page buried deep in the About KDE dialog under the Support KDE tab where

Re: Deprecation Defines

2014-07-08 Thread David Gil Oliva
Hi! 2014-07-07 23:39 GMT+02:00 David Faure fa...@kde.org: On Monday 05 May 2014 13:14:07 Alex Merry wrote: On 05/05/14 07:27, Matthew Dawson wrote: Hi all, I was looking into my frameworks, to prepare them for the 5.0. One thing was looking into was the deprecation defines. In

Re: Translations in frameworks released tarballs

2014-07-08 Thread Christoph Feck
On Tuesday 08 July 2014 07:56:17 Alexander Potashev wrote: 2014-07-08 3:01 GMT+04:00 Christoph Feck christ...@maxiom.de: Is there a way to detect and strip unused strings in the release tarballs? Hi Christoph, Quick googling gives this:

Re: Deprecation Defines

2014-07-08 Thread David Faure
On Tuesday 08 July 2014 23:14:54 David Gil Oliva wrote: AFAICS, KCompletion is already clean. ./src/ksortablelist.h:136:#ifndef KDE_NO_DEPRECATED -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61935 --- I know i'm late, but if CMake provides one, can't we just

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Ben Cooksley
On 9 July 2014 04:05, Mario Fux kde...@unormal.org wrote: Am Dienstag, 08. Juli 2014, 17.30:19 schrieb Kevin Ottens: Hello everyone, Morning Hi Mario, This is the minutes of the Week 28 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. [snip] * unormal is

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Ben Cooksley
On 9 July 2014 03:30, Kevin Ottens er...@kde.org wrote: Hello everyone, Hi Kevin, This is the minutes of the Week 28 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: agateau, apol, d_ed, dfaure, fregl, mgraesslin, notmart, PovAddict, Riddell,

Review Request 119189: Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119189/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 119189: Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED

2014-07-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119189/#review61943 --- Ship it! Ship It! - David Faure On July 8, 2014, 10:09

Re: Review Request 119189: Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED

2014-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119189/#review61944 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 8, 2014,

Re: Review Request 119186: Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED

2014-07-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119186/#review61945 --- Ship it! - David Faure On July 8, 2014, 9:10 p.m., David

Re: Review Request 119186: Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED

2014-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119186/#review61946 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 8, 2014,

Re: Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread Aleix Pol
On Tuesday 08 July 2014 22:10:10 laurent Montel wrote: Hi, In qt4 it was a KDialog so okClicked() and applyClicked() existed. Now it’s a KPageDialog = a QDialog so we must to connect to QDialogButtonBox. This patch fixes bad signal. Can I commit it ? Thanks Ship it! I'd say that if

Re: Translations in frameworks released tarballs

2014-07-08 Thread David Faure
On Tuesday 08 July 2014 23:24:36 Christoph Feck wrote: On Tuesday 08 July 2014 07:56:17 Alexander Potashev wrote: 2014-07-08 3:01 GMT+04:00 Christoph Feck christ...@maxiom.de: Is there a way to detect and strip unused strings in the release tarballs? Hi Christoph, Quick googling

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-08 Thread Aleix Pol
On Tuesday 08 July 2014 21:51:15 Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61935 ---

Re: Review Request 119189: Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119189/ --- (Updated July 8, 2014, 10:51 p.m.) Status -- This change has been

Re: Review Request 119186: Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119186/ --- (Updated July 8, 2014, 10:54 p.m.) Status -- This change has been

Re: Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread David Faure
On Wednesday 09 July 2014 00:36:27 Aleix Pol wrote: On Tuesday 08 July 2014 22:10:10 laurent Montel wrote: Hi, In qt4 it was a KDialog so okClicked() and applyClicked() existed. Now it’s a KPageDialog = a QDialog so we must to connect to QDialogButtonBox. This patch fixes bad signal.

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Kevin Ottens
Hello, On Wednesday 09 July 2014 09:57:27 Ben Cooksley wrote: On 9 July 2014 03:30, Kevin Ottens er...@kde.org wrote: * ervin hopes to see kdepimlibs bits getting in sooner rather than later; Hmm? Sysadmin has already received a request to get the frameworks branch of kdepimlibs building

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread Ben Cooksley
On 9 July 2014 17:14, Kevin Ottens er...@kde.org wrote: Hello, Hi Kevin, On Wednesday 09 July 2014 09:57:27 Ben Cooksley wrote: On 9 July 2014 03:30, Kevin Ottens er...@kde.org wrote: * ervin hopes to see kdepimlibs bits getting in sooner rather than later; Hmm? Sysadmin has already