Re: Web Shortcuts KCM

2014-07-15 Thread Kevin Ottens
Hello, On Monday 14 July 2014 12:46:15 David Faure wrote: On Monday 14 July 2014 12:34:44 Eike Hein wrote: I'd like to port the ebrowsing KCM and move it to plasma-desktop or -workspace, since it has plenty of users outside of Konq (e.g. Konvi, Konsole and Okular, the first two of which

Re: Web Shortcuts KCM

2014-07-15 Thread Kevin Ottens
On Monday 14 July 2014 13:15:32 John Layt wrote: Over on the Windows list we've been discussing about KCM's for configuring common services/frameworks like this when running apps under non-Plasma desktops, including Gnome, Windows, Mac, etc. General gist is that we don't want to have

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62372 --- Note that as mentioned in the Web Shortcuts KCM thread, I'm

Re: Web Shortcuts KCM

2014-07-15 Thread David Faure
On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: Honestly to me it looks like a wrong move. A better move would be to have the framework (e.g. KIO) read the settings from the platform for its settings (e.g. proxies). OK about proxies, but web shortcuts is a KIO-specific thing, you won't

Re: KConfig build fails

2014-07-15 Thread David Faure
On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: Hi! 2014-07-15 0:19 GMT+02:00 Frank Reininghaus frank7...@googlemail.com: Hi, 2014-07-14 23:21 GMT+02:00 David Gil Oliva: Hi! KConfig build fails with this messages, all of them related to QBasicAtomicInt. Are they KF5

Re: Web Shortcuts KCM

2014-07-15 Thread Kevin Ottens
Hello, On Tuesday 15 July 2014 10:01:50 David Faure wrote: On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: Honestly to me it looks like a wrong move. A better move would be to have the framework (e.g. KIO) read the settings from the platform for its settings (e.g. proxies). OK

Review Request 119291: Use an input type=search for the search box.

2014-07-15 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119291/ --- Review request for KDE Frameworks, Alex Merry and Aurélien Gâteau.

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-15 Thread Cristian Oneț
On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first

Re: Web Shortcuts KCM

2014-07-15 Thread Eike Hein
On 07/15/2014 10:24 AM, Kevin Ottens wrote: Which applications? I experience that mostly in krunner and the browsers. As a user I don't think I get to type those anywhere else. It's not just typing. Konversation, Okular and Konsole let you select text, right-click it and search it using one

Re: Web Shortcuts KCM

2014-07-15 Thread Kevin Ottens
On Tuesday 15 July 2014 14:59:43 Eike Hein wrote: On 07/15/2014 10:24 AM, Kevin Ottens wrote: Which applications? I experience that mostly in krunner and the browsers. As a user I don't think I get to type those anywhere else. It's not just typing. Konversation, Okular and Konsole let you

Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-15 Thread Andreas Xavier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/ --- Review request for KDE Frameworks, Alex Merry and Michael Pyne.

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119242/#review62402 --- Ship it! Ship It! - Milian Wolff On July 12, 2014, 9:43

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62401 --- Ship it! Ship It! - Milian Wolff On July 12, 2014, 9:41

Re: Web Shortcuts KCM

2014-07-15 Thread Eike Hein
On 07/15/2014 03:16 PM, Kevin Ottens wrote: Well, for a single entry menu, really? :-) Yeah, I do care about every single menu entry not being broken, no matter where users use my app :). Of course admittedly the situ- ation in KDE 4 wasn't good either since it actually meant a runtime dep on

Re: KConfig build fails

2014-07-15 Thread Daniel Vrátil
On Tuesday 15 of July 2014 12:09:43 David Gil Oliva wrote: El 15/07/2014 10:02, David Faure fa...@kde.org escribió: On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: Hi! 2014-07-15 0:19 GMT+02:00 Frank Reininghaus frank7...@googlemail.com: Hi, 2014-07-14 23:21

Re: KConfig build fails

2014-07-15 Thread David Gil Oliva
Hi! 2014-07-15 17:16 GMT+02:00 Daniel Vrátil dvra...@redhat.com: On Tuesday 15 of July 2014 12:09:43 David Gil Oliva wrote: El 15/07/2014 10:02, David Faure fa...@kde.org escribió: On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: Hi! 2014-07-15 0:19 GMT+02:00 Frank

Re: Review Request 119291: Use an input type=search for the search box.

2014-07-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119291/#review62407 --- Ship it! Ship It! - Alex Merry On July 15, 2014, 8:29

Re: Review Request 119291: Use an input type=search for the search box.

2014-07-15 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119291/ --- (Updated July 15, 2014, 6:20 p.m.) Status -- This change has been

Re: Review Request 119289: Remove api_searchbox.html.

2014-07-15 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/ --- (Updated July 15, 2014, 9:21 p.m.) Review request for KDE Frameworks,

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-15 Thread Alex Merry
On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/#review62408 --- I don't think this should be necessary. Let's keep discussion

Re: Review Request 119289: Remove api_searchbox.html.

2014-07-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/#review62414 --- Ship it! Huh, guess I missed that :-) - Alex Merry On

Re: Review Request 119289: Remove api_searchbox.html.

2014-07-15 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/ --- (Updated July 15, 2014, 7:20 p.m.) Status -- This change has been

Re: Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.

2014-07-15 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119257/#review62436 --- This patch fixes the build. Why did you discard it? - David

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-15 Thread Andreas Xavier
On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

2014-07-15 Thread Andreas Xavier
On July 15, 2014, 6:27 p.m., Alex Merry wrote: modules/ECMGenerateHeaders.cmake, line 150 https://git.reviewboard.kde.org/r/119300/diff/1/?file=290331#file290331line150 This test doesn't do what you think it does. Rather than comparing ${camelcase_headers_var} with

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-15 Thread Andreas Xavier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119275/ --- (Updated July 15, 2014, 9:36 p.m.) Status -- This change has been

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July 15, 2014, 10:21 p.m.) Status -- This change has been

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119242/ --- (Updated July 15, 2014, 10:22 p.m.) Status -- This change has been

Jenkins build is back to stable : kio_master_qt5 #299

2014-07-15 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/299/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[kwindowsystem] src: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-15 Thread Marko Käning
Git commit 10398255165afda1a0ecddd1671bbb599846bb35 by Marko Käning. Committed on 15/07/2014 at 22:51. Pushed by kaning into branch 'master'. Preventing a crash in the KWindowInfo::Private destructor on OSX René J.V. Bertin found that Apple's developer documentation for CFRelease mentions that

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-15 Thread Michael Pyne
On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-15 Thread Cristian Oneț
On Iulie 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my