---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119321/
---
(Updated July 17, 2014, 10:15 a.m.)
Status
--
This change has been
On July 16, 2014, 8:21 p.m., Alexander Richardson wrote:
The kioslaves part seems to be more or less like my patch here:
https://git.reviewboard.kde.org/r/119081/ , just without the renaming of
the output file.
OOoops, sorry, I didn't check for previous reviews. And also assigned a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119325/#review62556
---
Ship it!
Looks good to me. Please grep for more uses of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119300/
---
(Updated July 17, 2014, 9:40 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119329/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119329/#review62561
---
Ship it!
The reasoning is that it makes it easier for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119325/
---
(Updated July 17, 2014, 10:25 a.m.)
Status
--
This change has been
On July 17, 2014, 10:42 a.m., David Faure wrote:
Looks good to me. Please grep for more uses of LIBEXEC_INSTALL_DIR in other
frameworks though, they might have the same issue?
looks like there are a few more frameworks with this case. will be opening
reviews for them during the day.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119331/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119335/
---
Review request for KDE Frameworks.
Repository: kcrash
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119323/
---
(Updated July 17, 2014, 11:23 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119336/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119336/
---
(Updated July 17, 2014, 12:13 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119336/
---
(Updated July 17, 2014, 12:47 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119337/
---
Review request for KDE Frameworks.
Repository: kxmlgui
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119337/#review62576
---
would it be possible to add a unit test for it? I know it's
On July 17, 2014, 3:42 p.m., Martin Gräßlin wrote:
would it be possible to add a unit test for it? I know it's not easy as it
depends on the window manager, but Openbox which is used on the CI system
is quite decent.
I may try
- Martin
On July 17, 2014, 1:42 p.m., David Edmundson wrote:
the important differences are two, that are imo 100% necessary to maintain
a pixel perfect rendering (sacrificing that is a regression simply not
acceptable in any case, even for non default themes, ever). At the same
time avoids
On July 17, 2014, 1:42 p.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 434
https://git.reviewboard.kde.org/r/119336/diff/2/?file=290831#file290831line434
How is this whole branch simpler ?
We end up doing widths and sizes twice.
if you
On July 17, 2014, 1:42 p.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 434
https://git.reviewboard.kde.org/r/119336/diff/2/?file=290831#file290831line434
How is this whole branch simpler ?
We end up doing widths and sizes twice.
Marco
On July 17, 2014, 1:42 p.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 204
https://git.reviewboard.kde.org/r/119336/diff/2/?file=290831#file290831line204
Just no.
to me, or that or stays as is in master now.
Again, the timer can be disabled in cases
On July 17, 2014, 1:42 p.m., David Edmundson wrote:
src/declarativeimports/core/framesvgitem.cpp, line 434
https://git.reviewboard.kde.org/r/119336/diff/2/?file=290831#file290831line434
How is this whole branch simpler ?
We end up doing widths and sizes twice.
Marco
On July 17, 2014, 1:42 p.m., Martin Gräßlin wrote:
would it be possible to add a unit test for it? I know it's not easy as it
depends on the window manager, but Openbox which is used on the CI system
is quite decent.
Martin Klapetek wrote:
I may try
Please add/close bug 337353.
On July 17, 2014, 3:42 p.m., Martin Gräßlin wrote:
would it be possible to add a unit test for it? I know it's not easy as it
depends on the window manager, but Openbox which is used on the CI system
is quite decent.
Martin Klapetek wrote:
I may try
Christoph Feck wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119341/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119343/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119343/#review62602
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 17, 2014,
On July 17, 2014, 4:54 p.m., Eike Hein wrote:
Unless I'm missing something, this approach seems to defeat the purpose of
the exercise: The goal of the original change is to use actually use
smaller textures that fit the QSG's this can use the atlas heuristic on
most platforms. You
On July 17, 2014, 4:54 p.m., Eike Hein wrote:
Unless I'm missing something, this approach seems to defeat the purpose of
the exercise: The goal of the original change is to use actually use
smaller textures that fit the QSG's this can use the atlas heuristic on
most platforms. You
On July 17, 2014, 4:54 p.m., Eike Hein wrote:
Unless I'm missing something, this approach seems to defeat the purpose of
the exercise: The goal of the original change is to use actually use
smaller textures that fit the QSG's this can use the atlas heuristic on
most platforms. You
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119345/
---
Review request for KDE Frameworks.
Repository: attica
Description
On July 17, 2014, 4:54 p.m., Eike Hein wrote:
Unless I'm missing something, this approach seems to defeat the purpose of
the exercise: The goal of the original change is to use actually use
smaller textures that fit the QSG's this can use the atlas heuristic on
most platforms. You
On July 17, 2014, 4:54 p.m., Eike Hein wrote:
Unless I'm missing something, this approach seems to defeat the purpose of
the exercise: The goal of the original change is to use actually use
smaller textures that fit the QSG's this can use the atlas heuristic on
most platforms. You
See http://build.kde.org/job/kdelibs_stable/1152/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Is there any pre-build environment for this?
Or its too complicated to install the dependence apps and libs
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119345/#review62618
---
Ship it!
Ship It!
- Jeremy Whiting
On July 17, 2014,
See http://build.kde.org/job/kdelibs_stable/1153/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119336/
---
(Updated July 17, 2014, 8:17 p.m.)
Review request for KDE Frameworks and
Hello,
while testing out Yakuake (frameworks) I noticed that it would not display
the context menu.
Konsole had a similar issue, but that was fixed by adjusting the calls that
loaded the XML file (this occurred after the port to KXMLGUI_INSTALL_DIR).
However this did not occur with Yakuake,
Luca Beltrame wrote:
- Or instead the code loading the KPart needs to be adjusted?
Just FYI: the issue was in Konsole, which did not set a component name. This
was fixed in g88ffcc8 in Konsole (frameworks branch).
--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: 6E1A4E79
While trying to build kdepimlibs' dependency prison on OSX I got tons of error
messages like this:
---
...
Scanning dependencies of target prison
[ 25%] [ 31%] [ 37%] [ 43%] [ 50%] [ 56%] Building CXX object
lib/prison/CMakeFiles/prison.dir/abstractbarcode.cpp.o
Building CXX object
On Friday 18 July 2014 00:37:02 Kevin Ottens wrote:
On Thursday 17 July 2014 10:37:45 David Faure wrote:
On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote:
On Wednesday 16 July 2014 10:33:43 David Faure wrote:
On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote:
(ie at most a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/
---
(Updated July 18, 2014, 8:31 a.m.)
Review request for KDE Frameworks and
43 matches
Mail list logo
