Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/#review62680 --- src/lib/plugin/kpluginloader.h https://git.reviewboard.kde.org/r/119079/#comment43448 What about plugins that do not have metadata? src/lib/plugin/kpluginmetadata.h https://git.reviewboard.kde.org/r/119079/#comment43449 If you don't put at least minimal documentation in, Doxygen will warn about undocumented methods. src/lib/plugin/kpluginmetadata.cpp https://git.reviewboard.kde.org/r/119079/#comment43450 I think this would be clearer as passing QFileInfo an empty string gives the CWD, which is not what we want. And put the comment one line up, so it applies to the if() statement, rather than the assignment. I see you haven't changed the KPluginLoader methods - have you looked to see if they are the ones that are likely to be useful? - Alex Merry On July 18, 2014, 1:34 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated July 18, 2014, 1:34 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- This class simplifies reading the metadata from a qt plugin by providing type safe accessor functions for the standard plugininfo keys that are also used by the .desktop file based KPluginInfo KPluginMetaData: Read the translated value for name and description The Name and Comment fields of the metadata should be translated since they will be shown to the user (e.g. in the plugin selection dialog) Add a unit test for KPluginMetaData Add KPluginMetaData::findPlugins() Add a unit test for KPluginMetaData::findPlugins() Introduce KPluginLoader::instantiatePlugins() and add a unit test This method allows easily instantiating all plugins in a given directory KPluginMetaData::pluginName() was changed to return the base name of the plugin file if no plugin name was set in the JSON metadata Diffs - autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd autotests/jsonplugin.json d86fad49e5d074762d70282b3ace4bf3e6db58df autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 autotests/kpluginmetadatatest.cpp PRE-CREATION src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 src/lib/plugin/kpluginmetadata.h PRE-CREATION src/lib/plugin/kpluginmetadata.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: ktexteditor_master_qt5 #481
See http://build.kde.org/job/ktexteditor_master_qt5/481/changes Changes: [mikisabate] vimode: cleaning up the KateViRange class. -- [...truncated 1499 lines...] ViRange r; ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevinormalmode.cpp:2700:13: note: candidates are: In file included from http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevimodebase.h:31:0, from http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/kateviinsertmode.h:26, from http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevinormalmode.cpp:37: http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:53:14: note: KateVi::ViRange::ViRange(const KTextEditor::Cursor, KTextEditor::Cursor, MotionType) explicit ViRange(const KTextEditor::Cursor c1, const KTextEditor::Cursor c2, MotionType mt); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:53:14: note: candidate expects 3 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:52:14: note: KateVi::ViRange::ViRange(const KTextEditor::Cursor, MotionType) explicit ViRange(const KTextEditor::Cursor c, MotionType mt); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:52:14: note: candidate expects 2 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:51:14: note: KateVi::ViRange::ViRange(int, int, int, int, MotionType) explicit ViRange(int slin, int scol, int elin, int ecol, MotionType mt); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:51:14: note: candidate expects 5 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:49:14: note: KateVi::ViRange::ViRange(int, int, MotionType) explicit ViRange(int elin, int ecol, MotionType inc); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:49:14: note: candidate expects 3 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:40:26: note: constexpr KateVi::ViRange::ViRange(const KateVi::ViRange) class KTEXTEDITOR_EXPORT ViRange ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:40:26: note: candidate expects 1 argument, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:40:26: note: constexpr KateVi::ViRange::ViRange(KateVi::ViRange) http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:40:26: note: candidate expects 1 argument, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevinormalmode.cpp: In member function ‘KateVi::ViRange KateViNormalMode::motionToPreviousBraceBlockStart()’: http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevinormalmode.cpp:2729:13: error: no matching function for call to ‘KateVi::ViRange::ViRange()’ ViRange r; ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevinormalmode.cpp:2729:13: note: candidates are: In file included from http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevimodebase.h:31:0, from http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/kateviinsertmode.h:26, from http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/katevinormalmode.cpp:37: http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:53:14: note: KateVi::ViRange::ViRange(const KTextEditor::Cursor, KTextEditor::Cursor, MotionType) explicit ViRange(const KTextEditor::Cursor c1, const KTextEditor::Cursor c2, MotionType mt); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:53:14: note: candidate expects 3 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:52:14: note: KateVi::ViRange::ViRange(const KTextEditor::Cursor, MotionType) explicit ViRange(const KTextEditor::Cursor c, MotionType mt); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:52:14: note: candidate expects 2 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:51:14: note: KateVi::ViRange::ViRange(int, int, int, int, MotionType) explicit ViRange(int slin, int scol, int elin, int ecol, MotionType mt); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:51:14: note: candidate expects 5 arguments, 0 provided http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:49:14: note: KateVi::ViRange::ViRange(int, int, MotionType) explicit ViRange(int elin, int ecol, MotionType inc); ^ http://build.kde.org/job/ktexteditor_master_qt5/ws/src/vimode/range.h:49:14: note: candidate expects 3
Jenkins build is back to normal : ktexteditor_master_qt5 #482
See http://build.kde.org/job/ktexteditor_master_qt5/482/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/ --- Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- This patch addresses these build issues: 1. Some Qt5::X11Extras were not properly guarded. 2. KDEWin is needed on Windows for 'unistd.h' and others. 3. 'fmod' migth be a macro which will screw up calls to std::fmod Diffs - CMakeLists.txt de34f3c8d7479811d536fbce2114f29a96693087 src/CMakeLists.txt bc7534667d6a39b334d038d55391e784c6527b1c src/html/html_canvasimpl.cpp 18990eaa7ab00316471ecec0e9aa30b394aa4e02 tests/CMakeLists.txt d672fb56feb52da7308e844e0c86460e11778c07 Diff: https://git.reviewboard.kde.org/r/119365/diff/ Testing --- Build run on Windows and Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/#review62689 --- Interesting to see this happening on Windows, as I have similar problems on OSX for these two projects - libkscreen - kde-runtime which are obviously also not properly guarded in this respect. - Marko Käning On July 19, 2014, 1:58 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/ --- (Updated July 19, 2014, 1:58 p.m.) Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- This patch addresses these build issues: 1. Some Qt5::X11Extras were not properly guarded. 2. KDEWin is needed on Windows for 'unistd.h' and others. 3. 'fmod' migth be a macro which will screw up calls to std::fmod Diffs - CMakeLists.txt de34f3c8d7479811d536fbce2114f29a96693087 src/CMakeLists.txt bc7534667d6a39b334d038d55391e784c6527b1c src/html/html_canvasimpl.cpp 18990eaa7ab00316471ecec0e9aa30b394aa4e02 tests/CMakeLists.txt d672fb56feb52da7308e844e0c86460e11778c07 Diff: https://git.reviewboard.kde.org/r/119365/diff/ Testing --- Build run on Windows and Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata
On Juli 19, 2014, 11:27 vorm., Alexander Richardson wrote: I see you haven't changed the KPluginLoader methods - have you looked to see if they are the ones that are likely to be useful? I looked at KDevelop and Kate, and it seems there the version return a list of KPluginMetaData objects is sufficient. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/#review62680 --- On Juli 18, 2014, 3:34 nachm., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 18, 2014, 3:34 nachm.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- This class simplifies reading the metadata from a qt plugin by providing type safe accessor functions for the standard plugininfo keys that are also used by the .desktop file based KPluginInfo KPluginMetaData: Read the translated value for name and description The Name and Comment fields of the metadata should be translated since they will be shown to the user (e.g. in the plugin selection dialog) Add a unit test for KPluginMetaData Add KPluginMetaData::findPlugins() Add a unit test for KPluginMetaData::findPlugins() Introduce KPluginLoader::instantiatePlugins() and add a unit test This method allows easily instantiating all plugins in a given directory KPluginMetaData::pluginName() was changed to return the base name of the plugin file if no plugin name was set in the JSON metadata Diffs - autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd autotests/jsonplugin.json d86fad49e5d074762d70282b3ace4bf3e6db58df autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 autotests/kpluginmetadatatest.cpp PRE-CREATION src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 src/lib/plugin/kpluginmetadata.h PRE-CREATION src/lib/plugin/kpluginmetadata.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 19, 2014, 3:15 nachm.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- This class simplifies reading the metadata from a qt plugin by providing type safe accessor functions for the standard plugininfo keys that are also used by the .desktop file based KPluginInfo KPluginMetaData: Read the translated value for name and description The Name and Comment fields of the metadata should be translated since they will be shown to the user (e.g. in the plugin selection dialog) Add a unit test for KPluginMetaData Add KPluginMetaData::findPlugins() Add a unit test for KPluginMetaData::findPlugins() Introduce KPluginLoader::instantiatePlugins() and add a unit test This method allows easily instantiating all plugins in a given directory KPluginMetaData::pluginName() was changed to return the base name of the plugin file if no plugin name was set in the JSON metadata Diffs (updated) - src/lib/plugin/kpluginmetadata.cpp PRE-CREATION autotests/kpluginmetadatatest.cpp PRE-CREATION src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 src/lib/plugin/kpluginmetadata.h PRE-CREATION autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd autotests/jsonplugin.json d86fad49e5d074762d70282b3ace4bf3e6db58df autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/#review62699 --- Ship it! One more thing then I, at least, am happy for it to go in. src/lib/plugin/kpluginloader.h https://git.reviewboard.kde.org/r/119079/#comment43454 I think it's worth explicitly saying that the plugins will not necessarily have JSON metadata, and in fact are not even necessarily loadable via QPluginLoader (although they will generally be loadable by QLibrary). - Alex Merry On July 19, 2014, 1:15 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated July 19, 2014, 1:15 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- This class simplifies reading the metadata from a qt plugin by providing type safe accessor functions for the standard plugininfo keys that are also used by the .desktop file based KPluginInfo KPluginMetaData: Read the translated value for name and description The Name and Comment fields of the metadata should be translated since they will be shown to the user (e.g. in the plugin selection dialog) Add a unit test for KPluginMetaData Add KPluginMetaData::findPlugins() Add a unit test for KPluginMetaData::findPlugins() Introduce KPluginLoader::instantiatePlugins() and add a unit test This method allows easily instantiating all plugins in a given directory KPluginMetaData::pluginName() was changed to return the base name of the plugin file if no plugin name was set in the JSON metadata Diffs - src/lib/plugin/kpluginmetadata.cpp PRE-CREATION autotests/kpluginmetadatatest.cpp PRE-CREATION src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 src/lib/plugin/kpluginmetadata.h PRE-CREATION autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd autotests/jsonplugin.json d86fad49e5d074762d70282b3ace4bf3e6db58df autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI system: kgeography build broken on branch frameworks
Hi Luigi, I have copied now kdoctools' as well as kdelibs4support's files into /Library/Application Support/kf5/ That gave unfortunately only partial success: --- Scanning dependencies of target -Users-marko-WC-KDECI-builds-kde-baseapps-build-dolphin-docs-index-cache-bz2 [ 4%] Generating index.cache.bz2 Generating kstandarditemmodeltest.moc Generating moc_kitemmodelbase.cpp Generating moc_kstandarditemmodel.cpp Generating viewpropertiestest.moc [ 4%] [ 4%] Built target kstandarditemmodeltest_automoc Built target viewpropertiestest_automoc file:///Library/Application%20Support/kf5/kdoctools/customization/dtd/kdex.dtd:71: parser error : Invalid URI: /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kdoctools/inst/Library/Application Support/kf5/kdoctools/customization/dtd/rdbpool.elements st/Library/Application Support/kf5/kdoctools/customization/dtd/rdbpool.elements ^ file:///Library/Application%20Support/kf5/kdoctools/customization/dtd/kdex.dtd:80: parsScanning dependencies of target kdialog_automoc Scanning dependencies of target kdepasswd_automoc Generating kfileitemlistviewtest.moc Generating moc_kfileitemlistview.cpp --- As you can see the parser complains about an invalid URI! I wonder what could be the reason for that. Perhaps the white space in “Application Support”? ---[ kdex.dtd ]--- ... 69: !ENTITY % rdbpool PUBLIC 70: -//KDE//ELEMENTS DocBook XML Pool Redeclarations V1.1//EN 71: /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kdoctools/inst/Library/Application Support/kf5/kdoctools/customization/dtd/rdbpool.elements 72: 73: !ENTITY % dbpool.redecl.module INCLUDE ... --- Well, could this in fact be caused by me, as I didn’t use a backslash in my local configurePlatformArgs definition by using -DDATA_INSTALL_DIR=Library/Application Support”? Greets, Marko kde-baseapps.log.gz Description: GNU Zip compressed data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI system: kip build failure on branch frameworks
I suddenly can’t build kio anymore: 21%] Built target udsentrybenchmark_automoc [ 22%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_automoc.cpp.o Scanning dependencies of target kmailservice5 Scanning dependencies of target ktelnetservice5 Cannot process input: '/Users/marko/WC/KDECI-builds/kio/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop. make[2]: *** [src/ioslaves/http/kcookiejar/kcookieserverinterface.cpp] Error 1 make[1]: *** [src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs What’s going on here? kio.log.gz Description: GNU Zip compressed data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 19, 2014, 5:41 nachm.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- This class simplifies reading the metadata from a qt plugin by providing type safe accessor functions for the standard plugininfo keys that are also used by the .desktop file based KPluginInfo KPluginMetaData: Read the translated value for name and description The Name and Comment fields of the metadata should be translated since they will be shown to the user (e.g. in the plugin selection dialog) Add a unit test for KPluginMetaData Add KPluginMetaData::findPlugins() Add a unit test for KPluginMetaData::findPlugins() Introduce KPluginLoader::instantiatePlugins() and add a unit test This method allows easily instantiating all plugins in a given directory KPluginMetaData::pluginName() was changed to return the base name of the plugin file if no plugin name was set in the JSON metadata Diffs (updated) - autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd autotests/jsonplugin.json d86fad49e5d074762d70282b3ace4bf3e6db58df autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 autotests/kpluginmetadatatest.cpp PRE-CREATION src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 src/lib/plugin/kpluginmetadata.h PRE-CREATION src/lib/plugin/kpluginmetadata.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing --- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI system: kgeography build broken on branch frameworks
Marko Käning ha scritto: Hi Luigi, I have copied now kdoctools' as well as kdelibs4support's files into /Library/Application Support/kf5/ Yes, but please consider that it should work even if kdoctools and kdelibs4support documentation DTD's and other files are in separate directories (provided that QStandardPaths returns both locations). That gave unfortunately only partial success: --- Scanning dependencies of target -Users-marko-WC-KDECI-builds-kde-baseapps-build-dolphin-docs-index-cache-bz2 [ 4%] Generating index.cache.bz2 Generating kstandarditemmodeltest.moc Generating moc_kitemmodelbase.cpp Generating moc_kstandarditemmodel.cpp Generating viewpropertiestest.moc [ 4%] [ 4%] Built target kstandarditemmodeltest_automoc Built target viewpropertiestest_automoc file:///Library/Application%20Support/kf5/kdoctools/customization/dtd/kdex.dtd:71: parser error : Invalid URI: /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kdoctools/inst/Library/Application Support/kf5/kdoctools/customization/dtd/rdbpool.elements st/Library/Application Support/kf5/kdoctools/customization/dtd/rdbpool.elements ^ file:///Library/Application%20Support/kf5/kdoctools/customization/dtd/kdex.dtd:80: parsScanning dependencies of target kdialog_automoc Scanning dependencies of target kdepasswd_automoc Generating kfileitemlistviewtest.moc Generating moc_kfileitemlistview.cpp --- As you can see the parser complains about an invalid URI! I wonder what could be the reason for that. Perhaps the white space in “Application Support”? That could explain the issue. Could you please try to manually fix it by encoding the space (%20) ? Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI system: kgeography build broken on branch frameworks
Hi Luigi, On 19 Jul 2014, at 19:15 , Luigi Toscano luigi.tosc...@tiscali.it wrote: Yes, but please consider that it should work even if kdoctools and kdelibs4support documentation DTD's and other files are in separate directories (provided that QStandardPaths returns both locations). yes. Perhaps the white space in “Application Support”? That could explain the issue. Could you please try to manually fix it by encoding the space (%20) ? I had to replace it 5 times in kdex.dtd. Now the project can be build successfully. This means the project’s code which creates the dtd file needs to take care of it, or the CMake code which perhaps might do the replacement of the configuration directory. Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KAction Warning
Hi, perhaps that is a stupid question, but last time I read up in the docs, they didn't help me: KatePart spits out a lot of: kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for KAction smart_newline Insert Smart Newline set with QShortcut::setShortcut()! See KAction documentation. kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for KAction tools_indent Indent set with QShortcut::setShortcut()! See KAction documentation. ... How to fix that? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
