Re: Review Request 119567: Also find catalog files that are symlinks

2014-08-01 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119567/#review63656 --- src/docbookl10nhelper.cpp

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Review Request 119567: Also find catalog files that are symlinks

2014-08-01 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119567/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-01 Thread Axel Rasmussen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119564/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Harald Sitter
> On Aug. 1, 2014, 2:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Martin Klapetek
> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Aleix Pol Gonzalez
> On Aug. 1, 2014, 2:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. > > Martin Klapetek wrote: > Well the mess

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Martin Klapetek
> On Aug. 1, 2014, 4:31 p.m., Aleix Pol Gonzalez wrote: > > Well, you only get the frameworks integration when you're running Plasma > > 5... > > > > Actually, frameworksintegration should move to kde/workspace at least. It's > > not a framework. Well the message boxes won't do any sounds wit

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-08-01 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/ --- (Updated Aug. 1, 2014, 2:35 p.m.) Status -- This change has been mar

Re: Review Request 119562: Load polkit backends from installed location.

2014-08-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119562/ --- (Updated Aug. 1, 2014, 2:32 p.m.) Status -- This change has been mar

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/#review63634 --- Well, you only get the frameworks integration when you're runn

Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/ --- Review request for KDE Frameworks and Harald Sitter. Repository: framewor

Re: Review Request 119562: Load polkit backends from installed location.

2014-08-01 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119562/#review63631 --- Ship it! Ship It! - Lukáš Tinkl On Srp. 1, 2014, 3:59 odp.

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-08-01 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/#review63630 --- Ship it! Ship It! - Lukáš Tinkl On Čec. 30, 2014, 2:32 dop

Review Request 119562: Load polkit backends from installed location.

2014-08-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119562/ --- Review request for KDE Frameworks. Repository: kauth Description --

Re: Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread Marco Martin
> On Aug. 1, 2014, 1:16 p.m., David Edmundson wrote: > > probably needs the BUG n comments that the other two places have. Either > > that or wrap all the other code in an else {} rather than using a return. added BUG comments - Marco

Re: Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread Marco Martin
> On Aug. 1, 2014, 12:55 p.m., Aleix Pol Gonzalez wrote: > > What happened here? Is it actually submitted? yes, was told to do so in #kde, forgot the tag in the commit message - Marco --- This is an automatically generated e-mail. To re

Re: Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119560/#review63624 --- Ship it! probably needs the BUG n comments that the other two

Re: Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119560/#review63620 --- What happened here? Is it actually submitted? - Aleix Pol Gon

Re: Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119560/#review63619 --- What happened here? Is it actually submitted? - Aleix Pol Gon

Re: Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119560/ --- (Updated Aug. 1, 2014, 11:56 a.m.) Status -- This change has been ma

Review Request 119560: Avoid disappearing scrollbars

2014-08-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119560/ --- Review request for KDE Frameworks. Repository: kitemviews Description -

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Minimum translation percentage for frameworks release

2014-08-01 Thread Alexander Potashev
2014-08-01 13:07 GMT+04:00 Māris Nartišs : > As a head of another inactive, barely passing current criteria language > team, I would also vote for partially translated strings over no translation > at all. If the user doesn't like partially translated dialogs, he can always > join the translation t

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #80

2014-08-01 Thread KDE CI System
See Changes: [faure] Fix make install; remove deprecated and unused KonqFileItemCapabilities [lbeltrame] Try to fix the build (one more file to remove from CMakeLists.txt) -- [...truncated

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #79

2014-08-01 Thread KDE CI System
See -- [...truncated 2646 lines...] [ 76%] Building CXX object dolphin/src/tests/CMakeFiles/kitemsettest.dir/kitemsettest_automoc.cpp.o [ 76%] Building CXX object dolphin/src/tests/CMakeFiles/kfile

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #78

2014-08-01 Thread KDE CI System
See Changes: [faure] Remove KonqPopupMenuInformation and KonqMenuActions, deprecated, replacements in KIO since 4.3 -- [...truncated 2649 lines...] Linking CXX executable kitemlistselection

Re: Frameworks Cookbook book sprint

2014-08-01 Thread Mirko Boehm
Hi Valorie, On 07/31/2014 10:50 AM, Valorie Zimmerman wrote: > It would be good to decide on what writing platform we'll use. Rohan > and I are both familiar with Booki at Flossmanuals. I found a book > (available as an epub too) about Booki itself: > http://www.flossmanuals.net/booki-user-guide/